Issue 13632048: code review 13632048: test: add test of panic on division by zero

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13632048: code review 13632048: test: add test of panic on division by zero

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
10 years, 10 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

test: add test of panic on division by zero This tests the bug reported in issue 5805. I suspect it is fixed by the cleanup of the stack walk that I submitted over the summer. If not, the arm builders will tell us. Update issue 5805

Patch Set 1 #

Patch Set 2 : diff -r ef73acc06701 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ef73acc06701 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a74e4a7820d0 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -4 lines)			Patch
M	src/pkg/runtime/signal_arm.c	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/vlop_arm.s	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	test/divide.go	View	1 2	4 chunks	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/13632048 is best) in the description in your new CL. Thanks very much.

Expand All Messages | Collapse All Messages