Issue 134550043: net/http: add method constants from RFC 2616.
| Created: 11 years, 2 months ago by Andrew Bonventre Modified: 10 years, 11 months ago CC: golang-codereviews Visibility: Public. | Descriptionnet/http: add method constants from RFC 2616. As defined in http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html Patch Set 1 #Patch Set 2 : diff -r 9a36c3ea70155c017710096513c8733356c31fbb https://code.google.com/p/go/ #MessagesTotal messages: 7
Sign in to reply to this message.
Sorry, I missed this CL earlier. The tree is closed in any case. Please ping this thread after Go 1.4 is out (and copy golang-dev@ in this case), around December 1st, and we can discuss. I could go either on this. Others may have opinions. On Wed, Oct 1, 2014 at 2:32 AM, <andybons@chromium.org> wrote: > Reviewers: bradfitz, > > Description: > net/http: add method constants from RFC 2616. > > As defined in http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html > > Please review this at https://codereview.appspot.com/134550043/ > > Affected files (+18, -0 lines): > A src/pkg/net/http/methods.go > > > Index: src/pkg/net/http/methods.go > =================================================================== > new file mode 100644 > --- /dev/null > +++ b/src/pkg/net/http/methods.go > @@ -0,0 +1,18 @@ > +// Copyright 2014 The Go Authors. All rights reserved. > +// Use of this source code is governed by a BSD-style > +// license that can be found in the LICENSE file. > + > +package http > + > +// HTTP methods, defined in RFC 2616. > +const ( > + MethodHead = "HEAD" > + MethodGet = "GET" > + MethodPut = "PUT" > + MethodPost = "POST" > + MethodDelete = "DELETE" > + > + MethodConnect = "CONNECT" > + MethodOptions = "OPTIONS" > + MethodTrace = "TRACE" > +) > > > Sign in to reply to this message.
Sounds good. Will ping around Dec 1 assuming the tree is back open. Thanks for taking a look, Brad. On Wed Nov 12 2014 at 1:00:35 PM Brad Fitzpatrick <bradfitz@golang.org> wrote: > Sorry, I missed this CL earlier. The tree is closed in any case. > > Please ping this thread after Go 1.4 is out (and copy golang-dev@ in this > case), around December 1st, and we can discuss. I could go either on this. > Others may have opinions. > > > On Wed, Oct 1, 2014 at 2:32 AM, <andybons@chromium.org> wrote: > >> Reviewers: bradfitz, >> >> Description: >> net/http: add method constants from RFC 2616. >> >> As defined in http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html >> >> Please review this at https://codereview.appspot.com/134550043/ >> >> Affected files (+18, -0 lines): >> A src/pkg/net/http/methods.go >> >> >> Index: src/pkg/net/http/methods.go >> =================================================================== >> new file mode 100644 >> --- /dev/null >> +++ b/src/pkg/net/http/methods.go >> @@ -0,0 +1,18 @@ >> +// Copyright 2014 The Go Authors. All rights reserved. >> +// Use of this source code is governed by a BSD-style >> +// license that can be found in the LICENSE file. >> + >> +package http >> + >> +// HTTP methods, defined in RFC 2616. >> +const ( >> + MethodHead = "HEAD" >> + MethodGet = "GET" >> + MethodPut = "PUT" >> + MethodPost = "POST" >> + MethodDelete = "DELETE" >> + >> + MethodConnect = "CONNECT" >> + MethodOptions = "OPTIONS" >> + MethodTrace = "TRACE" >> +) >> >> >> > Sign in to reply to this message.
Following up on this. On Wed, Nov 12, 2014 at 1:01 PM Andy Bonventre <andybons@gmail.com> wrote: > Sounds good. Will ping around Dec 1 assuming the tree is back open. Thanks > for taking a look, Brad. > > On Wed Nov 12 2014 at 1:00:35 PM Brad Fitzpatrick <bradfitz@golang.org> > wrote: > >> Sorry, I missed this CL earlier. The tree is closed in any case. >> >> Please ping this thread after Go 1.4 is out (and copy golang-dev@ in >> this case), around December 1st, and we can discuss. I could go either on >> this. Others may have opinions. >> >> >> On Wed, Oct 1, 2014 at 2:32 AM, <andybons@chromium.org> wrote: >> >>> Reviewers: bradfitz, >>> >>> Description: >>> net/http: add method constants from RFC 2616. >>> >>> As defined in http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html >>> >>> Please review this at https://codereview.appspot.com/134550043/ >>> >>> Affected files (+18, -0 lines): >>> A src/pkg/net/http/methods.go >>> >>> >>> Index: src/pkg/net/http/methods.go >>> =================================================================== >>> new file mode 100644 >>> --- /dev/null >>> +++ b/src/pkg/net/http/methods.go >>> @@ -0,0 +1,18 @@ >>> +// Copyright 2014 The Go Authors. All rights reserved. >>> +// Use of this source code is governed by a BSD-style >>> +// license that can be found in the LICENSE file. >>> + >>> +package http >>> + >>> +// HTTP methods, defined in RFC 2616. >>> +const ( >>> + MethodHead = "HEAD" >>> + MethodGet = "GET" >>> + MethodPut = "PUT" >>> + MethodPost = "POST" >>> + MethodDelete = "DELETE" >>> + >>> + MethodConnect = "CONNECT" >>> + MethodOptions = "OPTIONS" >>> + MethodTrace = "TRACE" >>> +) >>> >>> >>> >> Sign in to reply to this message.
Let's wait until things have moved to Github. On Mon, Dec 1, 2014 at 6:49 AM, Andy Bonventre <andybons@gmail.com> wrote: > Following up on this. > > On Wed, Nov 12, 2014 at 1:01 PM Andy Bonventre <andybons@gmail.com> wrote: > >> Sounds good. Will ping around Dec 1 assuming the tree is back open. >> Thanks for taking a look, Brad. >> >> On Wed Nov 12 2014 at 1:00:35 PM Brad Fitzpatrick <bradfitz@golang.org> >> wrote: >> >>> Sorry, I missed this CL earlier. The tree is closed in any case. >>> >>> Please ping this thread after Go 1.4 is out (and copy golang-dev@ in >>> this case), around December 1st, and we can discuss. I could go either on >>> this. Others may have opinions. >>> >>> >>> On Wed, Oct 1, 2014 at 2:32 AM, <andybons@chromium.org> wrote: >>> >>>> Reviewers: bradfitz, >>>> >>>> Description: >>>> net/http: add method constants from RFC 2616. >>>> >>>> As defined in http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html >>>> >>>> Please review this at https://codereview.appspot.com/134550043/ >>>> >>>> Affected files (+18, -0 lines): >>>> A src/pkg/net/http/methods.go >>>> >>>> >>>> Index: src/pkg/net/http/methods.go >>>> =================================================================== >>>> new file mode 100644 >>>> --- /dev/null >>>> +++ b/src/pkg/net/http/methods.go >>>> @@ -0,0 +1,18 @@ >>>> +// Copyright 2014 The Go Authors. All rights reserved. >>>> +// Use of this source code is governed by a BSD-style >>>> +// license that can be found in the LICENSE file. >>>> + >>>> +package http >>>> + >>>> +// HTTP methods, defined in RFC 2616. >>>> +const ( >>>> + MethodHead = "HEAD" >>>> + MethodGet = "GET" >>>> + MethodPut = "PUT" >>>> + MethodPost = "POST" >>>> + MethodDelete = "DELETE" >>>> + >>>> + MethodConnect = "CONNECT" >>>> + MethodOptions = "OPTIONS" >>>> + MethodTrace = "TRACE" >>>> +) >>>> >>>> >>>> >>> Sign in to reply to this message.
Sounds good. On Mon Dec 01 2014 at 12:25:04 PM Brad Fitzpatrick <bradfitz@golang.org> wrote: > Let's wait until things have moved to Github. > > > On Mon, Dec 1, 2014 at 6:49 AM, Andy Bonventre <andybons@gmail.com> wrote: > >> Following up on this. >> >> On Wed, Nov 12, 2014 at 1:01 PM Andy Bonventre <andybons@gmail.com> >> wrote: >> >>> Sounds good. Will ping around Dec 1 assuming the tree is back open. >>> Thanks for taking a look, Brad. >>> >>> On Wed Nov 12 2014 at 1:00:35 PM Brad Fitzpatrick <bradfitz@golang.org> >>> wrote: >>> >>>> Sorry, I missed this CL earlier. The tree is closed in any case. >>>> >>>> Please ping this thread after Go 1.4 is out (and copy golang-dev@ in >>>> this case), around December 1st, and we can discuss. I could go either on >>>> this. Others may have opinions. >>>> >>>> >>>> On Wed, Oct 1, 2014 at 2:32 AM, <andybons@chromium.org> wrote: >>>> >>>>> Reviewers: bradfitz, >>>>> >>>>> Description: >>>>> net/http: add method constants from RFC 2616. >>>>> >>>>> As defined in http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html >>>>> >>>>> Please review this at https://codereview.appspot.com/134550043/ >>>>> >>>>> Affected files (+18, -0 lines): >>>>> A src/pkg/net/http/methods.go >>>>> >>>>> >>>>> Index: src/pkg/net/http/methods.go >>>>> =================================================================== >>>>> new file mode 100644 >>>>> --- /dev/null >>>>> +++ b/src/pkg/net/http/methods.go >>>>> @@ -0,0 +1,18 @@ >>>>> +// Copyright 2014 The Go Authors. All rights reserved. >>>>> +// Use of this source code is governed by a BSD-style >>>>> +// license that can be found in the LICENSE file. >>>>> + >>>>> +package http >>>>> + >>>>> +// HTTP methods, defined in RFC 2616. >>>>> +const ( >>>>> + MethodHead = "HEAD" >>>>> + MethodGet = "GET" >>>>> + MethodPut = "PUT" >>>>> + MethodPost = "POST" >>>>> + MethodDelete = "DELETE" >>>>> + >>>>> + MethodConnect = "CONNECT" >>>>> + MethodOptions = "OPTIONS" >>>>> + MethodTrace = "TRACE" >>>>> +) >>>>> >>>>> >>>>> >>>> > Sign in to reply to this message.
How about PATCH from http://tools.ietf.org/html/rfc5789? Sign in to reply to this message. |
