os/user: group lookup functions

os/user: group lookup functions Adding group lookup functions analogous to the user lookup ones to the os/user package. Updates issue 4589049.

[bradfitz, 2014-01-16 18:43:35]

Still interested in finishing this? We can do it in Go 1.3. The CL text should say "Fixes Issue 2617" instead of the Updates line you have now. https://codereview.appspot.com/13454043/diff/3001/src/pkg/os/user/lookup.go File src/pkg/os/user/lookup.go (right): https://codereview.appspot.com/13454043/diff/3001/src/pkg/os/user/lookup.go#n... src/pkg/os/user/lookup.go:41: // In indicates whether the user is a member of the given group. In reports whether ... https://codereview.appspot.com/13454043/diff/3001/src/pkg/os/user/lookup.go#n... src/pkg/os/user/lookup.go:47: func (g *Group) Members() ([]string, error) { let's leave this one out for now. We can add it later if needed. Also, the return type is weird ([]string) ... why not []*User? Otherwise this should clarify that it returns userids, not users. https://codereview.appspot.com/13454043/diff/3001/src/pkg/os/user/user.go File src/pkg/os/user/user.go (right): https://codereview.appspot.com/13454043/diff/3001/src/pkg/os/user/user.go#new... src/pkg/os/user/user.go:31: Gid string // group id More docs on what these mean. See the docs on User above. https://codereview.appspot.com/13454043/diff/3001/src/pkg/os/user/user.go#new... src/pkg/os/user/user.go:53: type UnknownGroupIdError int an int here is weird. The UnknownUserIdError type was probably a mistake in retrospect. We don't need to repeat it.

[hblanks.lf, 2014-06-15 05:51:33]

All, It seems like this patch is a few minor edits from making it in. Andre, are you still up for finishing it? This would be a good feature to have. I'm not the best person to finish it, both for limited experience and time. But, if you're indisposed, please let me know. I could try to sort out these last bits of review from Brad. -HJB

[andre, 2014-06-16 18:35:45]

On 2014/06/15 05:51:33, hblanks.lf wrote: > All, > > It seems like this patch is a few minor edits from making it in. Andre, are you > still up for finishing it? This would be a good feature to have. > > I'm not the best person to finish it, both for limited experience and time. But, > if you're indisposed, please let me know. I could try to sort out these last > bits of review from Brad. > > -HJB Hi I've created a new issue with a current version of the patch: https://codereview.appspot.com/101310044 Probably did something wrong and couldn't edit this one with a new version... The version in the new patch doesn't include (*Group) Members() as per Brad's comment.