Issue 13373047: check_vat_mx

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13373047: check_vat_mx

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by zodman

Modified:
12 years, 1 month ago

Reviewers:
ced

Visibility:
Public.

More Reviews

Description

check_vat_mx

Patch Set 1 #

Patch Set 2 : More testing case #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -0 lines)			Patch
	M	vatnumber/__init__.py	View		2 chunks	+83 lines, -0 lines	1 comment	Download
	M	vatnumber/tests.py	View	1	2 chunks	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

https://codereview.appspot.com/13373047/diff/3001/vatnumber/__init__.py File vatnumber/__init__.py (right): https://codereview.appspot.com/13373047/diff/3001/vatnumber/__init__.py#newco... vatnumber/__init__.py:1295: if char not in string.uppercase + "&Ñ": I think you should use a unicode https://codereview.appspot.com/13373047/diff/3001/vatnumber/tests.py File vatnumber/tests.py (right): https://codereview.appspot.com/13373047/diff/3001/vatnumber/tests.py#newcode186 vatnumber/tests.py:186: ('MX','XAXX010101000 ',False), space after ,

Expand All Messages | Collapse All Messages