Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1408)

Issue 13362043: code review 13362043: database/sql: improved performance scanning bool types

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by lukemauldin
Modified:
11 years, 9 months ago
CC:
golang-codereviews
Visibility:
Public.

Description

database/sql: improved performance scanning bool types Performance was 58.0 ns/op for the tip code and 26.7 ns/op with the updated fast path code.

Patch Set 1 #

Patch Set 2 : diff -r 2e89feb1297b https://code.google.com/p/go #

Patch Set 3 : diff -r 2e89feb1297b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/pkg/database/sql/convert.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/database/sql/convert_test.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8
lukemauldin
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, lukemauldin@gmail.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 1 month ago (2013-08-28 19:34:06 UTC) #1
lukemauldin
Additional note: Performance was 58.0 ns/op for the tip code and 26.7 ns/op with the ...
12 years, 1 month ago (2013-08-28 19:36:13 UTC) #2
gobot
R=bradfitz@golang.org (assigned by r@golang.org)
11 years, 10 months ago (2013-12-19 21:24:28 UTC) #3
lukemauldin
Brad, Do I need to respond to this? This is my first CL against the ...
11 years, 10 months ago (2013-12-19 21:28:53 UTC) #4
bradfitz
I was just assigned as the reviewer. I still need to review it. You sent ...
11 years, 10 months ago (2013-12-19 21:31:01 UTC) #5
lukemauldin
Okay, thank you for helping me understand the process. Let me know if you have ...
11 years, 10 months ago (2013-12-20 13:14:30 UTC) #6
gobot
Replacing golang-dev with golang-codereviews.
11 years, 10 months ago (2013-12-20 16:26:00 UTC) #7
bradfitz
11 years, 9 months ago (2014-01-16 19:02:58 UTC) #8
R=close There's already a reflect-free path for bools, via driver.Bool.ConvertValue below. It's a function call, but I think that's fine. This isn't enough of a win for added code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b