code review 13362043: database/sql: improved performance scanning bool types

database/sql: improved performance scanning bool types Performance was 58.0 ns/op for the tip code and 26.7 ns/op with the updated fast path code.

[lukemauldin, 2013-08-28 19:34:06]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, lukemauldin@gmail.com), I'd like you to review this change to https://code.google.com/p/go

[lukemauldin, 2013-08-28 19:36:13]

Additional note: Performance was 58.0 ns/op for the tip code and 26.7 ns/op with the updated fast path code.

[gobot, 2013-12-19 21:24:28]

R=bradfitz@golang.org (assigned by r@golang.org)

[lukemauldin, 2013-12-19 21:28:53]

Brad, Do I need to respond to this? This is my first CL against the Go standard library so I am not sure of the process. I still think the change is a good one because it optimizes the fast-path for bools like the package already does for other common data types.

[bradfitz, 2013-12-19 21:31:01]

I was just assigned as the reviewer. I still need to review it. You sent the CL off during the Go 1.2 code freeze, so there was no urgency in reviewing it then. On Thu, Dec 19, 2013 at 1:28 PM, <lukemauldin@gmail.com> wrote: > Brad, > Do I need to respond to this? This is my first CL against the Go > standard library so I am not sure of the process. > I still think the change is a good one because it optimizes the > fast-path for bools like the package already does for other common data > types. > > https://codereview.appspot.com/13362043/ > 

[lukemauldin, 2013-12-20 13:14:30]

Okay, thank you for helping me understand the process. Let me know if you have any questions/concerns during the review process. On Thursday, December 19, 2013 3:30:59 PM UTC-6, Brad Fitzpatrick wrote: > > I was just assigned as the reviewer. I still need to review it. You sent > the CL off during the Go 1.2 code freeze, so there was no urgency in > reviewing it then. > > > > On Thu, Dec 19, 2013 at 1:28 PM, <lukem...@gmail.com <javascript:>> wrote: > >> Brad, >> Do I need to respond to this? This is my first CL against the Go >> standard library so I am not sure of the process. >> I still think the change is a good one because it optimizes the >> fast-path for bools like the package already does for other common data >> types. >> >> https://codereview.appspot.com/13362043/ >> > >

[gobot, 2013-12-20 16:26:00]

Replacing golang-dev with golang-codereviews.

[bradfitz, 2014-01-16 19:02:58]

R=close There's already a reflect-free path for bools, via driver.Bool.ConvertValue below. It's a function call, but I think that's fine. This isn't enough of a win for added code.