Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 13245045: Bundle Topology

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bcsaller
Modified:
12 years, 2 months ago
Reviewers:
benjamin.saller, mp+182516
Visibility:
Public.

Description

Bundle Topology Provide a reusable view of topologies with a much more limited and non-interactive service module. The tests show how this works but don't wire the view into any current UI which comes later. https://code.launchpad.net/~bcsaller/juju-gui/renderBundle2/+merge/182516 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Bundle Topology #

Patch Set 3 : Bundle Topology #

Patch Set 4 : Bundle Topology #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1746 lines, -571 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 3 5 chunks +68 lines, -4 lines 0 comments Download
M app/assets/javascripts/d3-components.js View 3 chunks +3 lines, -0 lines 0 comments Download
M app/config-debug.js View 1 chunk +1 line, -1 line 0 comments Download
M app/config-prod.js View 1 chunk +1 line, -1 line 0 comments Download
M app/index.html View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M app/models/charm.js View 1 chunk +1 line, -1 line 0 comments Download
M app/models/model-controller.js View 5 chunks +30 lines, -6 lines 0 comments Download
M app/models/models.js View 1 chunk +19 lines, -0 lines 0 comments Download
M app/modules-debug.js View 1 chunk +3 lines, -0 lines 0 comments Download
M app/store/charm.js View 1 chunk +25 lines, -0 lines 0 comments Download
M app/store/env/env.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/store/env/fakebackend.js View 1 chunk +7 lines, -1 line 0 comments Download
M app/store/env/go.js View 5 chunks +23 lines, -5 lines 0 comments Download
M app/store/env/python.js View 1 chunk +6 lines, -1 line 0 comments Download
M app/store/env/sandbox.js View 1 2 3 4 chunks +4 lines, -1 line 0 comments Download
M app/subapps/browser/browser.js View 1 2 3 12 chunks +51 lines, -19 lines 0 comments Download
M app/subapps/browser/templates/editorial.handlebars View 1 chunk +0 lines, -1 line 0 comments Download
M app/subapps/browser/views/editorial.js View 3 chunks +0 lines, -31 lines 0 comments Download
M app/subapps/browser/views/minimized.js View 5 chunks +15 lines, -8 lines 0 comments Download
M app/subapps/browser/views/view.js View 6 chunks +7 lines, -53 lines 0 comments Download
D app/templates/category-icons.partial View 1 chunk +0 lines, -57 lines 0 comments Download
M app/templates/ghost-config-viewlet.handlebars View 2 chunks +12 lines, -0 lines 0 comments Download
M app/templates/inspector-header.handlebars View 1 chunk +3 lines, -1 line 0 comments Download
M app/templates/service-config-wrapper.handlebars View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/templates/service-constraints-viewlet.partial View 1 chunk +2 lines, -2 lines 0 comments Download
M app/templates/service-overview-constraints.handlebars View 1 chunk +24 lines, -19 lines 0 comments Download
M app/views/charm.js View 1 chunk +3 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/environment.js View 2 chunks +2 lines, -2 lines 0 comments Download
M app/views/ghost-inspector.js View 4 chunks +17 lines, -4 lines 0 comments Download
M app/views/inspector.js View 5 chunks +31 lines, -8 lines 0 comments Download
A app/views/topology/bundle.js View 1 chunk +390 lines, -0 lines 0 comments Download
M app/views/topology/relation.js View 1 chunk +3 lines, -0 lines 0 comments Download
M app/views/topology/topology.js View 3 chunks +15 lines, -12 lines 0 comments Download
M app/views/utils.js View 2 chunks +5 lines, -4 lines 0 comments Download
M app/views/viewlets/inspector-header.js View 1 chunk +5 lines, -18 lines 0 comments Download
M app/views/viewlets/service-constraints.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/viewlets/service-ghost.js View 1 chunk +17 lines, -10 lines 0 comments Download
M app/widgets/viewmode-controls.js View 1 2 3 2 chunks +87 lines, -0 lines 0 comments Download
M lib/views/browser/charm-full.less View 1 chunk +0 lines, -1 line 0 comments Download
M lib/views/browser/charm-token.less View 3 chunks +0 lines, -9 lines 0 comments Download
M lib/views/juju-inspector.less View 8 chunks +15 lines, -7 lines 0 comments Download
A test/data/wp-deployer.yaml View 1 chunk +41 lines, -0 lines 0 comments Download
M test/index.html View 1 chunk +1 line, -1 line 0 comments Download
M test/test_app.js View 7 chunks +26 lines, -13 lines 0 comments Download
M test/test_browser_app.js View 1 2 3 9 chunks +101 lines, -1 line 0 comments Download
M test/test_browser_editorial.js View 1 chunk +0 lines, -20 lines 0 comments Download
M test/test_charm_panel.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_charm_store.js View 2 chunks +30 lines, -1 line 0 comments Download
M test/test_charm_view.js View 4 chunks +11 lines, -12 lines 0 comments Download
M test/test_endpoints.js View 6 chunks +14 lines, -9 lines 0 comments Download
M test/test_env.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_env_go.js View 6 chunks +28 lines, -8 lines 0 comments Download
M test/test_env_python.js View 3 chunks +13 lines, -2 lines 0 comments Download
M test/test_fakebackend.js View 2 chunks +27 lines, -1 line 0 comments Download
M test/test_ghost_inspector.js View 3 chunks +74 lines, -8 lines 0 comments Download
M test/test_inspector_constraints.js View 4 chunks +12 lines, -15 lines 0 comments Download
M test/test_inspector_overview.js View 8 chunks +73 lines, -25 lines 0 comments Download
M test/test_inspector_settings.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_login.js View 3 chunks +19 lines, -18 lines 0 comments Download
M test/test_model.js View 3 chunks +43 lines, -51 lines 0 comments Download
M test/test_model_controller.js View 5 chunks +31 lines, -3 lines 0 comments Download
M test/test_notifications.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_sandbox_go.js View 6 chunks +67 lines, -29 lines 0 comments Download
M test/test_sandbox_python.js View 6 chunks +41 lines, -3 lines 0 comments Download
M test/test_service_config_view.js View 1 chunk +5 lines, -4 lines 0 comments Download
M test/test_service_view.js View 8 chunks +18 lines, -24 lines 0 comments Download
M test/test_startup.js.bottom View 1 chunk +6 lines, -2 lines 0 comments Download
M test/test_topology.js View 2 chunks +40 lines, -0 lines 0 comments Download
M test/test_unit_view.js View 7 chunks +21 lines, -20 lines 0 comments Download
M test/test_viewlet_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_viewmode_controls_widget.js View 1 2 3 2 chunks +82 lines, -0 lines 0 comments Download
M test/test_websocket_logging.js View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6
bcsaller
Please take a look.
12 years, 2 months ago (2013-08-27 23:01:32 UTC) #1
bcsaller
Please take a look.
12 years, 2 months ago (2013-08-27 23:04:14 UTC) #2
benjamin.saller
diff is totally broken, I'll try to repair this.
12 years, 2 months ago (2013-08-27 23:05:32 UTC) #3
bcsaller
Please take a look.
12 years, 2 months ago (2013-08-28 17:02:21 UTC) #4
bcsaller
Please take a look.
12 years, 2 months ago (2013-08-28 17:06:35 UTC) #5
benjamin.saller
12 years, 2 months ago (2013-08-28 17:13:19 UTC) #6
After repeated attempts this is still not getting a proper diff for me. bzr diff -r ancestor:../path/to/trunk will show it though. Sorry and thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b