Issue 13094045: Improve deployer import story

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13094045: Improve deployer import story

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bcsaller

Modified:
12 years, 2 months ago

Reviewers:
mp+181343, jeff.pihach, matthew.scott

Visibility:
Public.

Description

Improve deployer import story Real world deployer files specify charm names a number of ways, this makes resolving those more flexible. This add charm id normalization and find methods as well as connecting up YAML imports to the drop handler. This doesn't provide a UI around import target disambiguation. https://code.launchpad.net/~bcsaller/juju-gui/charmFind/+merge/181343 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve deployer import story #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -40 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/charm.js	View	1	1 chunk	+34 lines, -1 line	0 comments	Download
M	app/models/models.js	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	app/store/charm.js	View	1	3 chunks	+41 lines, -5 lines	0 comments	Download
M	app/views/environment.js	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	app/views/topology/service.js	View		1 chunk	+53 lines, -21 lines	0 comments	Download
A	test/data/blog.yaml	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	test/test_charm_store.js	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/test_databinding.js	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	test/test_inspector_charm.js	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	test/test_model.js	View		1 chunk	+36 lines, -3 lines	0 comments	Download
M	test/utils.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

*** Submitted: Improve deployer import story Real world deployer files specify charm names a number of ways, this makes resolving those more flexible. This add charm id normalization and find methods as well as connecting up YAML imports to the drop handler. This doesn't provide a UI around import target disambiguation. R=matthew.scott, jeff.pihach CC= https://codereview.appspot.com/13094045

Expand All Messages | Collapse All Messages