Issue 1199045: code review 1199045: Add support for Socketpair

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1199045: code review 1199045: Add support for Socketpair

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by taruti

Modified:
15 years, 5 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

Add support for Socketpair

Patch Set 1 #

Patch Set 2 : code review 1199045: Add support for Socketpair #

Patch Set 3 : code review 1199045: Add support for Socketpair #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -3 lines)			Patch
M	src/pkg/syscall/syscall_bsd.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_linux_386.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_amd64.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_arm.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_386.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_amd64.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_386.go	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_amd64.go	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

There's another CL trying to add Socketpair too. I'm not sure which was here first, but since I looked at the other one more recently, I'm going to leave this one alone. Sorry for the duplicated effort.

Expand All Messages | Collapse All Messages