Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(662)

Issue 11479045: Two graphs created with D3.js library and with little boostrap navbar.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by arni.reynir89
Modified:
12 years, 3 months ago
Reviewers:
M-A
CC:
swarming-eng_googlegroups.com
Base URL:
https://code.google.com/p/swarming.isolate-server@master
Visibility:
Public.

Description

Two graphs created with D3.js library and with little boostrap navbar. Javascript seperate under static/js, hopefully linked correctly. The html views are overview.html and request.html R=maruel@chromium.org

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -0 lines) Patch
A static/js/multigraph.js View 1 chunk +110 lines, -0 lines 3 comments Download
A static/js/requests.js View 1 chunk +64 lines, -0 lines 0 comments Download
A templates/overview.html View 1 chunk +47 lines, -0 lines 0 comments Download
A templates/request.html View 1 chunk +47 lines, -0 lines 2 comments Download

Messages

Total messages: 2
arni.reynir89
12 years, 3 months ago (2013-07-17 22:09:04 UTC) #1
M-A
12 years, 3 months ago (2013-07-18 01:56:49 UTC) #2
Please remove the "BUG=" at the start of the CL description. It was added automatically by git-cl but it's not needed here. https://codereview.appspot.com/11479045/diff/1/static/js/multigraph.js File static/js/multigraph.js (right): https://codereview.appspot.com/11479045/diff/1/static/js/multigraph.js#newcode1 static/js/multigraph.js:1: Please add the following copyright: /* Copyright 2013 The Swarming Authors. All rights reserved. * Use of this source code is governed by the Apache v2.0 license that can be * found in the LICENSE file. */ https://codereview.appspot.com/11479045/diff/1/static/js/multigraph.js#newcode26 static/js/multigraph.js:26: .range(["#98abc5", "#8a89a6", "#7b6888", "#6b486b", "#a05d56", "#d0743c", "#ff8c00"]); Please keep the code <= 80 cols https://codereview.appspot.com/11479045/diff/1/static/js/multigraph.js#newcode43 static/js/multigraph.js:43: var url = "https://isolateserver.appspot.com/stats/json?days=6"; Technically, all this would probably better be inside a single function to not leak variables. https://codereview.appspot.com/11479045/diff/1/templates/request.html File templates/request.html (right): https://codereview.appspot.com/11479045/diff/1/templates/request.html#newcode6 templates/request.html:6: <link href="//netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/css/bootstrap-combined.min.css" rel="stylesheet"> https https://codereview.appspot.com/11479045/diff/1/templates/request.html#newcode7 templates/request.html:7: <script src="http://d3js.org/d3.v3.min.js" charset="utf-8"></script> https
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b