Leaderboard for median review time

Leaderboard for median review time

[M-A, 2013-07-18 01:50:25]

So that gives an idea of how the final file layout would look like, without the actual implementation. As we discussed previously, the goal here is to implement a scoring function and use this present the last reviewers in the N days doing at least M reviews, sorted by the score value. Think of gamification to incentive lower review response time. The score value would be defined by the median initial review latency. I had given as the reference implementation _process_issue_latency() in https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/master/my_... as an example. Note that we cannot commit mocks, so in this specific case, the actual python code would have to be implemented. I've still attached a few review comments. https://codereview.appspot.com/11479043/diff/1/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/11479043/diff/1/codereview/views.py#newcode122 codereview/views.py:122: please remove https://codereview.appspot.com/11479043/diff/1/codereview/views.py#newcode1422 codereview/views.py:1422: Please keep 2 lines between file level symbols, e.g. one additional line here, one additional line after 1425. https://codereview.appspot.com/11479043/diff/1/codereview/views.py#newcode1424 codereview/views.py:1424: return respond(request, 'top.html') So basically, there would be a TODO here to implement the actual code. https://codereview.appspot.com/11479043/diff/1/settings.py File settings.py (right): https://codereview.appspot.com/11479043/diff/1/settings.py#newcode63 settings.py:63: Not needed? https://codereview.appspot.com/11479043/diff/1/templates/top.html File templates/top.html (right): https://codereview.appspot.com/11479043/diff/1/templates/top.html#newcode1 templates/top.html:1: That's interesting, because the rest of Rietveld's UI is quite consistent, but somehow we'd *want* to get this page definitely outstanding in its design. Normally, I would have said that you need to use: {%extends "base.html"%} and then create the remaining below the standard header. See search.html for an example but then the white on black effect would probably not work well. Then you need a proper html page with a doctype. https://codereview.appspot.com/11479043/diff/1/templates/top.html#newcode23 templates/top.html:23: <tr> For the record, we don't commit mocks but that gives an idea. https://codereview.appspot.com/11479043/diff/1/templates/top.html#newcode56 templates/top.html:56: 10 POINTS FOR CQ IN THE PAST 24 HOURS<br> This would have to be updated to the actual calculations involved once coded.