Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(135)

Issue 11426043: code review 11426043: go.tools: add common stuff to the hgignore file

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by bradfitz
Modified:
11 years, 10 months ago
CC:
golang-codereviews
Visibility:
Public.

Description

go.tools: add common stuff to the hgignore file Really we should sync all subrepos' hgignore files.

Patch Set 1 #

Patch Set 2 : diff -r ed36d5306203 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r ed36d5306203 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 82eb52613b57 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 82eb52613b57 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M .hgignore View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
12 years, 3 months ago (2013-07-17 07:16:53 UTC) #1
chai2010
On 2013/07/17 07:16:53, bradfitz wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
12 years, 3 months ago (2013-07-17 07:22:55 UTC) #2
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 3 months ago (2013-07-17 07:22:59 UTC) #3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 3 months ago (2013-07-17 07:23:38 UTC) #4
r
I'm sure I'm a lone voice but how about if we don't do this? The ...
12 years, 3 months ago (2013-07-17 09:20:45 UTC) #5
bradfitz
Then let's remove them everywhere. I don't like hacking in the subrepos feeling different than ...
12 years, 3 months ago (2013-07-17 09:22:13 UTC) #6
r
I would be happy to remove them anywhere, but I may be alone in that ...
12 years, 3 months ago (2013-07-17 09:35:43 UTC) #7
dsymonds
The right use of a checked-in ignore file is to only cover the things to ...
12 years, 3 months ago (2013-07-17 10:07:48 UTC) #8
gobot
Replacing golang-dev with golang-codereviews.
11 years, 10 months ago (2013-12-20 16:25:55 UTC) #9
r
11 years, 10 months ago (2013-12-21 00:11:45 UTC) #10
R=close Closing because we want to unify the .hgignores
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b