Issue 10452046: code review 10452046: compiler: reject method definition on types from other ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10452046: code review 10452046: compiler: reject method definition on types from other ...

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by remyoudompheng

Modified:
12 years, 4 months ago

Reviewers:
iant, gofrontend-dev

CC:
gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: reject method definition on types from other packages. Fixes issue 27.

Patch Set 1 #

Patch Set 2 : diff -r c85c21ae9a6c https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r c85c21ae9a6c https://code.google.com/p/gofrontend/ #

Total comments: 1

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	go/parse.cc	View	1	1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

I'm not sure that we can reliably check this property in the parser. A better place for this check might be Check_types_traverse::function. https://codereview.appspot.com/10452046/diff/6001/go/parse.cc File go/parse.cc (right): https://codereview.appspot.com/10452046/diff/6001/go/parse.cc#newcode2379 go/parse.cc:2379: if(type->named_type() != NULL && For future reference, the && should go at the start of the next line.

Expand All Messages | Collapse All Messages