upload.py - Issue 10117044: Treat svg as text, not image.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: upload.py

Issue 10117044: Treat svg as text, not image.

Patch Set: Created 12 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: upload.py

===================================================================

--- a/upload.py

+++ b/upload.py

@@ -1163,7 +1163,7 @@

mimetype = mimetypes.guess_type(filename)[0]

if not mimetype:

return False

- return mimetype.startswith("image/")

+ return mimetype.startswith("image/") and not mimetype.startswith("image/svg")

def IsBinaryData(self, data):

"""Returns true if data contains a null byte."""

« no previous file with comments | « no previous file | no next file » | no next file with comments »