Add Issue/Comment Reactions#557

Merged

mmarif merged 22 commits from opyale/GitNex:issue-reactions into master

2020-11-08 19:58:48 +01:00

opyale commented

2020-06-25 16:17:03 +02:00

Member

Closes #73

Closes #73

opyale added the

🎯 Enhancement

labels

2020-06-25 16:17:03 +02:00

6543 was assigned by opyale

2020-06-25 16:17:25 +02:00

opyale self-assigned this

2020-06-25 16:17:25 +02:00

6543 referenced this pull request

2020-06-25 16:41:39 +02:00

[WIP] Add Issue/Comment Reactions #490

6543 commented

2020-06-25 16:41:49 +02:00

Member

@opyale can you resolve the conflicts?

@opyale can you resolve the conflicts?

opyale added the

⌚ Major-release

label

2020-07-20 08:49:45 +02:00

opyale commented

2020-09-22 23:46:53 +02:00

Author

Member

@6543 Conflicts resolved.

@6543 Conflicts resolved.

opyale added this to the 3.3.0 milestone

2020-11-02 16:51:50 +01:00

mmarif changed title from ~~[WIP] Add Issue/Comment Reactions~~ to Add Issue/Comment Reactions

2020-11-08 15:14:08 +01:00

6543 commented

2020-11-08 17:27:52 +01:00

Member

just testing this now :=)

works good so var.

we only need some lib who can convert :hooray: into 🎉 (alias -> utf8)

just testing this now :=) works good so var. we only need some lib who can convert `:hooray:` into :hooray: (alias -> utf8)

6543 commented

2020-11-08 17:30:23 +01:00

Member

by the way we should use this lib for markdown then too ... (just view commit above with GitNex and compare with Web)

by the way we should use this lib for markdown then too ... (just view commit above with GitNex and compare with Web)

opyale commented

2020-11-08 17:31:24 +01:00

Author

Member

@6543 Could you read the messages I wrote in the discord chat? I was already referring to this issue there. 😉

@6543 Could you read the messages I wrote in the discord chat? I was already referring to this issue there. 😉

6543 reviewed

2020-11-08 17:34:24 +01:00

app/build.gradle Outdated

              @ -108,5 +108,6 @@ dependencies {  
      implementation "androidx.work:work-runtime:$work_version"  
      implementation "com.eightbitlab:blurview:1.6.4"  
      implementation "io.mikael:urlbuilder:2.0.9"  
      implementation 'com.vdurmont:emoji-java:5.1.1'  
  

6543 commented

2020-11-08 17:34:24 +01:00

Member

did you tested it against https://github.com/iris2iris/iris-emoji-java ?

did you tested it against https://github.com/iris2iris/iris-emoji-java ?

opyale commented

2020-11-08 17:36:05 +01:00

Author

Member

They don't provide a maven dependency.

They don't provide a maven dependency.

6543 marked this conversation as resolved

mmarif approved these changes

2020-11-08 19:54:12 +01:00

mmarif referenced this pull request from a commit

2020-11-08 19:58:47 +01:00

Add Issue/Comment Reactions (#557) Minor performance improvements. Merge branch 'master' of https://codeberg.org/gitnex/GitNex into issue-reactions Improving color of selected elements. First, fully working implementation of reactions. Merge branch 'master' of https://codeberg.org/gitnex/GitNex into issue-reactions Conflicts: app/src/main/res/layout/bottom_sheet_issue_comments.xml app/src/main/res/layout/list_issue_comments.xml (Hopefully) fixing merge issues. Merge branch 'master' of https://codeberg.org/gitnex/GitNex into issue-reactions Conflicts: app/src/main/java/org/mian/gitnex/interfaces/ApiInterface.java app/src/main/res/layout/activity_issue_detail.xml app/src/main/res/layout/bottom_sheet_issue_comments.xml app/src/main/res/layout/bottom_sheet_single_issue.xml app/src/main/res/values/colors.xml Moving reactions below time frame on comments. Merge branch 'master' into layout-reactions Add IssueReactions Merge remote-tracking branch 'origin/layout-reactions' into layout-reactions Merge branch 'master' of https://gitea.com/gitnex/GitNex into layout-reactions Merge branch 'master' into layout-reactions Applying to pulls and issues. Merge branch 'master' of https://gitea.com/gitnex/GitNex into layout-reactions Providing external layouts. Some improvements. Adding comment emote indications. Adding circle around emotes. Adding some padding. First tests. Co-authored-by: opyale <opyale@noreply.gitea.io> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/557 Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>

mmarif merged commit ade7b797f1 into master

2020-11-08 19:58:48 +01:00

opyale deleted branch issue-reactions

2020-11-08 20:39:42 +01:00

Sign in to join this conversation.

No reviewers

No labels

⌚ Major-release

⌚ Minor-release

⛏️ Breaking

➡️ Frontport

➡️ Needs-frontport

🌐 Translation

🎯 Enhancement

👋 Good-first-issue

💀 Deprecation

💡 Suggestion

💬 Discussion

💭 Brainstorming

📄 Documentation

📈 Performance

📌 Priority-critical

📌 Priority-high

📍 Priority-low

📍 Priority-medium

📡 Needs-feedback

🔙 Has-backport

🔙 Needs-backport

🔙 Regression

🔭 Cannot-reproduce

🗄️ Repository

🗒️ Changelog

🗓️ Summary

🤾 Google-play

🧺 Needs-cleanup

🩹 External-dependecy

🙇‍♂️ Needs-help

🚀 Improvement

🚨 Investigate

🛡️ Blocked

🛰️ API-dependency

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#557

No description provided.