Calculate ImageContrastColor more precise & some doc nits#544

opyale · 2020-06-22T22:45:49+02:00

opyale commented

2020-06-22 22:45:49 +02:00

No description provided.

opyale added this to the 3.0.0 milestone

2020-06-22 22:45:49 +02:00

opyale added the

🐛 Bug

label

2020-06-22 22:45:49 +02:00

opyale changed title from ~~Fixing color bug, updating license headers, README and CONTRIBUTORS~~ to Fixing color bug, updating license headers and CONTRIBUTORS

2020-06-23 03:45:29 +02:00

mmarif requested changes

2020-06-23 14:59:19 +02:00

CONTRIBUTORS.md Outdated

              @ -7,3 +8,3 @@  
        
     # Translators  
     This part lists all PUBLIC individuals having contributed content to the translation.   
     This part lists all PUBLIC individuals having contributed content to the translation.  
  

There was a reason to have this in next line and be italic.

If you want to remove next line, then it should have comma at the end.

There was a reason to have this in next line and be italic. If you want to remove next line, then it should have comma at the end.

I mean dot(.)

I didn't notice that. This was probably caused by my IDE.

Should be fixed with 03d0866c8a0b78d942c2ddca6387d80e20bb72a2

mmarif commented

2020-06-23 16:16:39 +02:00

+This part lists all PUBLIC individuals having contributed content to the translation.<br>

Just use double space instead of br.

``` +This part lists all PUBLIC individuals having contributed content to the translation.<br> ``` Just use double space instead of br.

opyale commented

2020-06-23 16:26:20 +02:00

@mmarif Ok, done.

6543 commented

2020-06-23 16:26:23 +02:00

do you have a screenshot of the bug so I know what you are fixing with this :)

opyale commented

2020-06-23 16:27:37 +02:00

@6543

@6543 ![grafik](/attachments/a4a235fe-59f9-4826-abfc-8e13c676d1e4)

grafik.png

22 KiB

6543 approved these changes

2020-06-23 16:32:42 +02:00

6543 changed title from ~~Fixing color bug, updating license headers and CONTRIBUTORS~~ to Calculate ImageContrastColor more precise & some doc nits

2020-06-23 16:35:47 +02:00

mmarif approved these changes

2020-06-23 16:53:50 +02:00

mmarif referenced this pull request from a commit

2020-06-23 16:54:28 +02:00

Calculate ImageContrastColor more precise & some doc nits (#544) Fixing color bug, updating license headers and CONTRIBUTORS Co-authored-by: opyale <opyale@noreply.gitea.io> Reviewed-by: 6543 <6543@noreply.codeberg.org> Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>

mmarif closed this pull request

2020-06-23 16:54:28 +02:00

opyale deleted branch color-fix

2020-06-23 16:54:36 +02:00

Sign in to join this conversation.

No reviewers