Fork 40

Don't save draft every time you stop typing for a moment.#1298

New issue

Closed

opened 2023-09-05 11:51:27 +02:00 by Andre601 · 3 comments

Andre601 commented

2023-09-05 11:51:27 +02:00

Instead would I recommend saving a draft if you stopped typing for a considerable time (i.e. 2 seconds).

While I appreciate the app saving a draft for a comment do I feel like saving it every time you stop typing for even a brief second is kind of overkill here. It's somewhat distracting when typing as the text constantly flashes. Instead would I recommend saving a draft if you stopped typing for a considerable time (i.e. 2 seconds).

mmarif commented

2023-09-08 03:12:06 +02:00

Owner

Actually I am thinking of removing that flashing msg each time. Maybe one time or no message at all.

mmarif added the

🚀 Improvement

label

2023-09-08 03:12:51 +02:00

Andre601 commented

2023-09-08 13:19:06 +02:00

Author

Actually I am thinking of removing that flashing msg each time. Maybe one time or no message at all.

Wouldn't it also be an idea to only save a draft on close? Or have a prompt to ask if a draft should be saved?
I don't think saving that frequently (Which from what I can tell seems to be every time you stop typing) is a good aproach here. Mainly because it perhaps could impact a smartphone's performance?
That's just me speculating tho...

> Actually I am thinking of removing that flashing msg each time. Maybe one time or no message at all. Wouldn't it also be an idea to only save a draft on close? Or have a prompt to ask if a draft should be saved? I don't think saving that frequently (Which from what I can tell seems to be every time you stop typing) is a good aproach here. Mainly because it perhaps could impact a smartphone's performance? That's just me speculating tho...

mmarif commented

2023-09-09 08:32:17 +02:00

Owner

Well, we initially thought about it this way, but there are other scenarios, like pressing the home button suddenly or turning off the phone screen, etc. It would be hard to recover from those situations. So the best option is to save after each keystroke. There has been no performance degradation in my tests so far.

mmarif added this to the 5.2.0 milestone

2023-09-17 07:49:24 +02:00

mmarif self-assigned this

2023-09-17 07:49:30 +02:00

mmarif referenced this issue from a pull request that will close it,

2023-09-17 07:49:51 +02:00

Dashboard view #1279

mmarif referenced this issue from a commit

2023-09-19 07:23:57 +02:00

Dashboard view (#1279)

mmarif closed this issue

2023-09-19 07:23:58 +02:00