Fork 39

Markdown issue link shortener removes some characters after it#1161

New issue

Closed

opened 2022-07-03 15:31:17 +02:00 by qwerty287 · 4 comments

qwerty287 commented

2022-07-03 15:31:17 +02:00

Contributor

Instead of (#123), (#123 is shown. As example, see #1155 (comment)
(first line)

Instead of `(#123)`, `(#123` is shown. As example, see https://codeberg.org/gitnex/GitNex/pulls/1155#issue-136954 (first line)

qwerty287 added the

🐛 Bug

label

2022-07-03 15:31:23 +02:00

qwerty287 changed title from ~~Markdown issue link shortener removes )~~ to Markdown issue link shortener removes some characters after it

2022-07-03 15:32:00 +02:00

Ghost referenced this issue

2022-07-23 15:37:28 +02:00

Gitnex crashes when opening issue/pr from another app with incorrect capitalization #1172

qwerty287 referenced this issue

2022-10-02 07:58:34 +02:00

Add support for commit statuses #1212

mmarif commented

2022-10-02 09:40:01 +02:00

Owner

Is this a custom function or by Markown?

qwerty287 commented

2022-10-02 10:45:41 +02:00

Author

Contributor

That's a custom function. The code itself is in https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L602-L623, but I'm not sure if the error is there.

mmarif commented

2022-10-04 12:20:43 +02:00

Owner

So from my quick tests, I found these:

If you have a URL like https://codeberg.org/gitnex/GitNex/issues/1161 then this will break (missing) the characters after.
If use #1161, this will work fine.

Further digging from your provided file, I guess the problem is coming from the Regex, https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L699.

So from my quick tests, I found these: - If you have a URL like `https://codeberg.org/gitnex/GitNex/issues/1161` then this will break (missing) the characters after. - If use `#1161`, this will work fine. Further digging from your provided file, I guess the problem is coming from the Regex, https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L699.

👍 1

qwerty287 commented

2022-10-04 15:12:04 +02:00

Author

Contributor

If I remember correctly this regex was something from markwons sample application.