Codeberg/pages-server
Codeberg/pages-server
Fork 51
Code Issues 109 Pull requests 10 Releases 31 Packages 1 Wiki Activity

Refactor: move gitea api calls in own "client" package#78

Merged
6543 merged 27 commits from refactor-add-more-logging-and-tests into main 2022-06-11 23:02:06 +02:00
Conversation 4 Commits 27 Files changed 19 +374 -194
6543 commented 2022-05-15 22:09:19 +02:00
Contributor
Copy link

continue #75
close #16

  • fix regression (from #34) thanks to @crystal
  • create own gitea client package
  • more logging
  • add mock impl of CertDB
continue #75 close #16 - fix regression (from #34) _thanks to @crystal_ - create own gitea client package - more logging - add mock impl of CertDB
add unittest for mockCert()
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
5ecb63426f
fix lint
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
1bb6e09e23
Merge branch 'main' into refactor-add-more-logging-and-tests
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
4b2df4aac2
6543 changed title from Add more logging and tests to WIP: Add more logging and tests 2022-05-15 22:09:35 +02:00
ci: add branches filter
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
0742782a0d
wip
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
ec7fcca0f5
6543 changed title from WIP: Add more logging and tests to WIP: Add more logging and tests & refactor 2022-05-16 00:43:51 +02:00
modernize ForbiddenMimeTypes
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
d35e41fa9f
start using "errors"
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
d9127d1ed9
Merge remote-tracking branch 'main/main' into refactor-add-more-logging-and-tests
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
0f662157ff
6543 changed title from WIP: Add more logging and tests & refactor to Refactor: move gitea api calls in own "client" package 2022-06-02 15:44:00 +02:00
create giteaClient once
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
5c508c5d13
6543 requested review from momar 2022-06-02 15:58:39 +02:00
6543 reviewed 2022-06-02 16:10:24 +02:00
server/upstream/upstream.go
@ -101,3 +81,3 @@
// Handle errors
if (res == nil && !cachedResponse.exists) || (res != nil && res.StatusCode() == fasthttp.StatusNotFound) {
if (err != nil && errors.Is(err, gitea.ErrorNotFound)) || (res == nil && !cachedResponse.Exists) {
6543 commented 2022-06-02 16:10:24 +02:00
Author
Contributor
Copy link

INFO: here we can also handle 404 page

INFO: here we can also handle 404 page
6543 commented 2022-06-02 16:14:01 +02:00
Author
Contributor
Copy link

cristalls pull will already do so :)

cristalls pull will already do so :)
6543 marked this conversation as resolved
6543 commented 2022-06-10 13:11:58 +02:00
Author
Contributor
Copy link

I'm going to merge if nobody have any objections ...

I'm going to merge if nobody have any objections ...
Merge branch 'main' into refactor-add-more-logging-and-tests
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
98f1880dea 
AuthorizationHeaderToken requires API tokens to be prepended with "token "
fix gitea client
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
7be32d4de2 
path.Join() mangles giteaRoot by changing https://codeberg.org to https:/codeberg.org This causes the upstream requests to fail every time, always resulting in 424 Failed Dependency
Merge branch 'main' into refactor-add-more-logging-and-tests
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
4d45be2d18
6543 added this to the v4.0 milestone 2022-06-11 15:00:48 +02:00
6543 modified the milestone from v4.0 to v3.0 2022-06-11 15:00:51 +02:00
6543 force-pushed refactor-add-more-logging-and-tests from f53bae252a
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
to 7eeafdbc5f
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
2022-06-11 22:24:16 +02:00 Compare
less aloc
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
8add62ee2f
crapStone requested changes 2022-06-11 22:46:54 +02:00
server/database/mock.go Outdated
@ -0,0 +40,4 @@
func (p tmpDB) Compact() (string, error) {
p.intern.Truncate()
return "Turncate done", nil
crapStone commented 2022-06-11 21:59:28 +02:00
Owner
Copy link

Truncate

Truncate
6543 marked this conversation as resolved
server/gitea/client.go Outdated
@ -0,0 +43,4 @@
}
// TODOs:
// * handle 404 -> page will show 500 atm
crapStone commented 2022-06-11 22:01:11 +02:00
Owner
Copy link

Is there an open issue for that?

Is there an open issue for that?
6543 commented 2022-06-11 22:50:04 +02:00
Author
Contributor
Copy link

yes and a pull - I remove it here since it is tracked there

yes and a pull - I remove it here since it is tracked there
6543 marked this conversation as resolved
server/upstream/domains.go Outdated
@ -32,3 +28,1 @@
domain = strings.TrimSpace(domain)
domain = strings.TrimPrefix(domain, "http://")
domain = strings.TrimPrefix(domain, "https://")
domain = strings.TrimPrefix(
crapStone commented 2022-06-11 22:29:42 +02:00
Owner
Copy link

they compile to the exact same assembly and imho the old version was much better readable

they compile to the exact same assembly and imho the old version was much better readable
6543 marked this conversation as resolved
create fastClient once
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
4e42bca189
address review
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
d86b25e7da
6543 removed review request for momar 2022-06-11 22:59:40 +02:00
crapStone approved these changes 2022-06-11 23:01:45 +02:00
6543 merged commit 02bd942b04 into main 2022-06-11 23:02:06 +02:00
6543 deleted branch refactor-add-more-logging-and-tests 2022-06-11 23:02:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
crapStone
Labels
Clear labels   
breaking

   
bug

Something is not working

  
build_pr_image

When this label is set, Pull Requests will build and publish images for testing purposes

  
documentation

Something is not correctly documented

  
​d̶u̶p̶l̶i̶c̶a̶t̶e̶

This issue or pull request already exists

  
feature

New feature

  
good first issue

easy to contribute

  
improvement

An improvement to the existing code or an existing feature

  
​i̶n̶v̶a̶l̶i̶d̶

Something is wrong

  
open questions

More information is needed

  
performance

improve performance

  
refactor

Maintain existing code

  
research required

More research is needed to solve the issue

No labels
breaking
bug
build_pr_image
documentation
​d̶u̶p̶l̶i̶c̶a̶t̶e̶
feature
good first issue
improvement
​i̶n̶v̶a̶l̶i̶d̶
open questions
performance
refactor
research required
Milestone
Clear milestone
No items
No milestone
v3.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#86 Add integration tests
Codeberg/pages-server
Reference
Codeberg/pages-server!78
No description provided.