Enhance joinURL and return error on gitea client on start instead while running#88
crapStone
crystal Labels
No labels
breaking
bug
build_pr_image
documentation
d̶u̶p̶l̶i̶c̶a̶t̶e̶
feature
good first issue
improvement
i̶n̶v̶a̶l̶i̶d̶
open questions
performance
refactor
research required
No project
No assignees
3 participants 
Notifications
Due date No due date set.
Dependencies
No dependencies set.
Reference
Codeberg/pages-server!88
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "advanced-joinURL"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WIP: Enhance joinURL and return error on gitea client on start instead while runningto Enhance joinURL and return error on gitea client on start instead while runningIt looks like adding the result of
path.Jointob.Pathis causingGiteaRawContentto break because it converts?ref=to%!F(MISSING)ref=. That's why the redirect test is failing,GiteaRawContentis producing a bad request when it looks for the.domainsfile.noticed :D good to finaly have integration tests I would say
Enhance joinURL and return error on gitea client on start instead while runningto WIP: Enhance joinURL and return error on gitea client on start instead while running@ -17,3 +17,3 @@type Client struct {giteaRoot stringgiteaRoot *url.URLWhat is the benefit of changing the string to URL when fasthttp uses strings for URLs anyway?
we do have to parce it once and if there is an issue, pages server will fail srtaight on start and not have broken websites
the main reason is, that i like to utilize the url.Parse() func to alter and build query urls
changed as implementation of joinPath changed
WIP: Enhance joinURL and return error on gitea client on start instead while runningto Enhance joinURL and return error on gitea client on start instead while runningfwiw the
net/urlpackage is getting aJoinPathfunction in Go 1.19 which can probably be used here instead, but for now we'll need this.https://github.com/golang/go/issues/47005
nice to know, I'll add a todo mark
outdated
ok that'S an interesting bug within gitea.
if you lgtm and the reject. afterwards you dismiss the review you have a lgtm again :O