implement custom 404 pages#81
No reviewers
6543 Labels
No labels
breaking
bug
build_pr_image
documentation
d̶u̶p̶l̶i̶c̶a̶t̶e̶
feature
good first issue
improvement
i̶n̶v̶a̶l̶i̶d̶
open questions
performance
refactor
research required
No project
No assignees
2 participants 
Notifications
Due date No due date set.
Dependencies
No dependencies set.
Reference
Codeberg/pages-server!81
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "crystal/pages-server:custom404"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is my attempt at solving #56. I made my commit against the v2.5a tag because I couldn't get pages-server to connect to my Gitea server for testing when I built against main.
404.html, like GitHub Pages404.htmlfile at it's rootpagesbranch, the 404.html file from thepagesrepository is usedWIP: Depends on #78, I'll get this ready to go as soon as that's merged.close #56
I created a tag that contains just the initial commits for v2.5a here
In crystal/pages-server#1 I managed to get it working with the newer code by preemptively merging #78 and manually fixing a couple things that caused the main branch to not work at all for me.
thanks for the initial work :)
I'll try to finish the refactor asap and then have a look into this :)
@6543 Thanks. The work you have on the refactor looks good so far, but there are quirks in the way the
path.Join()function and the Gitea authorization header work that prevents the server from connecting to Gitea at all in it's current state. I managed to iron that and a couple other problems I had during testing out in mycustom404-refactor-fixbranch if you want to take a look. If you don't like the way I went about solving those problems that's OK, I tried to make the commit messages detailed so you can easily understand what the problem is.P.S. I was compiling with Go 1.17, maybe the
path.Join()quirk doesn't exist in Go 1.18, I haven't tried it.@crystal please update your pull 💙
WIP: implement custom 404 pagesto implement custom 404 pagesez ❤️
since integration tests did land, do you have a repo to test this against and add it into this tests?
https://codeberg.org/Codeberg/pages-server/src/branch/main/integration/get_test.go#L18-L28
Sure, I'll upload one of the test repos I've been using for development.
i can't believe i made gofumpt mad again, i should've checked it before i committed
great work