Codeberg/pages-server
Codeberg/pages-server
Fork 51
Code Issues 109 Pull requests 10 Releases 31 Packages 1 Wiki Activity

Allow serving custom error page#393

Merged
crapStone merged 2 commits from Gnaaarwhal/pages-server:error-page into main 2024-11-17 17:28:53 +01:00
Conversation 2 Commits 2 Files changed 3 +33 -6
Gnaaarwhal commented 2024-10-12 19:24:36 +02:00
Contributor
Copy link

It might be useful for those self-hosting a Codeberg Pages instance to be able to serve a different error page than the one embedded with go:embed

It might be useful for those self-hosting a Codeberg Pages instance to be able to serve a different error page than the one embedded with go:embed
crapStone force-pushed error-page from 72f83a4144 to ef44077f7b
Some checks failed
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
2024-11-05 22:01:50 +01:00 Compare
crapStone requested changes 2024-11-05 22:14:55 +01:00
html/html.go Outdated
@ -54,0 +57,4 @@
contents, err := os.ReadFile("custom/error.html")
if err != nil {
if !os.IsNotExist(err) {
log.Err(err).Msg("could not load custom error page")
crapStone commented 2024-11-05 22:14:41 +01:00
Owner
Copy link

It would be nice to give the users a absolute path where the pages-server expects the file to be.

It would be nice to give the users a absolute path where the pages-server expects the file to be.
crapStone marked this conversation as resolved
Gnaaarwhal force-pushed error-page from ef44077f7b
Some checks failed
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
to df06003584
Some checks failed
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/build Pipeline failed
Details
2024-11-09 18:22:49 +01:00 Compare
run formatters
Some checks failed
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline failed
Details
71f01e6dd0
crapStone commented 2024-11-17 17:29:16 +01:00
Owner
Copy link

Thanks for your contribution!

Thanks for your contribution!
Sign in to join this conversation.
Reviewers
No reviewers
crapStone
Labels
Clear labels   
breaking

   
bug

Something is not working

  
build_pr_image

When this label is set, Pull Requests will build and publish images for testing purposes

  
documentation

Something is not correctly documented

  
​d̶u̶p̶l̶i̶c̶a̶t̶e̶

This issue or pull request already exists

  
feature

New feature

  
good first issue

easy to contribute

  
improvement

An improvement to the existing code or an existing feature

  
​i̶n̶v̶a̶l̶i̶d̶

Something is wrong

  
open questions

More information is needed

  
performance

improve performance

  
refactor

Maintain existing code

  
research required

More research is needed to solve the issue

No labels
breaking
bug
build_pr_image
documentation
​d̶u̶p̶l̶i̶c̶a̶t̶e̶
feature
good first issue
improvement
​i̶n̶v̶a̶l̶i̶d̶
open questions
performance
refactor
research required
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/pages-server!393
No description provided.