Codeberg/pages-server
Codeberg/pages-server
Fork 51
Code Issues 109 Pull requests 10 Releases 31 Packages 1 Wiki Activity

Tell fasthttp to not set "Content-Length: 0" on non cached content#107

Merged
6543 merged 4 commits from fix-97 into main 2022-07-15 21:06:06 +02:00
Conversation 4 Commits 4 Files changed 3 +5 -1
6543 commented 2022-07-15 19:09:15 +02:00
Contributor
Copy link

fix #97

fix #97
6543 added this to the v4.0 milestone 2022-07-15 19:09:15 +02:00
fix #97
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
8390f77ecd
Gusted commented 2022-07-15 19:37:47 +02:00
Owner
Copy link

The -1 content-length indicates to FastHTTP to send a chunked response. Is that the correct behavior?

The -1 content-length indicates to FastHTTP to send a [chunked response](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding). Is that the correct behavior?
6543 commented 2022-07-15 19:58:08 +02:00
Author
Contributor
Copy link

It fix the issue ...

Improving things is not the aim

It fix the issue ... Improving things is not the aim
Gusted commented 2022-07-15 20:39:18 +02:00
Owner
Copy link

I'm just trying to confirm that this would be the new correct behavior. Given that we currently doesn't send chunked response. But I'll approve as it does seem to work.

I'm just trying to confirm that this would be the new correct behavior. Given that we currently doesn't send chunked response. But I'll approve as it does seem to work.
Gusted approved these changes 2022-07-15 20:39:35 +02:00
add todo
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
4459ddc45a
:
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
0b7e40a098
6543 modified the milestone from v4.0 to v3.1 2022-07-15 21:01:55 +02:00
6543 merged commit 5411c96ef3 into main 2022-07-15 21:06:06 +02:00
6543 deleted branch fix-97 2022-07-15 21:06:07 +02:00
6543 changed title from Tell fasthttp to not set "Content-Length: 0" to Tell fasthttp to not set "Content-Length: 0" on non cached content 2022-07-15 21:06:27 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Gusted
Labels
Clear labels   
breaking

   
bug

Something is not working

  
build_pr_image

When this label is set, Pull Requests will build and publish images for testing purposes

  
documentation

Something is not correctly documented

  
​d̶u̶p̶l̶i̶c̶a̶t̶e̶

This issue or pull request already exists

  
feature

New feature

  
good first issue

easy to contribute

  
improvement

An improvement to the existing code or an existing feature

  
​i̶n̶v̶a̶l̶i̶d̶

Something is wrong

  
open questions

More information is needed

  
performance

improve performance

  
refactor

Maintain existing code

  
research required

More research is needed to solve the issue

No labels
breaking
bug
build_pr_image
documentation
​d̶u̶p̶l̶i̶c̶a̶t̶e̶
feature
good first issue
improvement
​i̶n̶v̶a̶l̶i̶d̶
open questions
performance
refactor
research required
Milestone
Clear milestone
No items
No milestone
v3.1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/pages-server!107
No description provided.