Codeberg-CI/examples
Codeberg-CI/examples
Fork 28
Code Issues 10 Pull requests 2 Activity

Add PHP Lint for recent versions#40

Merged
pat-s merged 5 commits from martijndeb/examples:php_8_lint into main 2024-04-11 20:50:12 +02:00
Conversation 10 Commits 5 Files changed 2 +20
martijndeb commented 2024-02-03 15:27:26 +01:00
Contributor
Copy link

This example adds a matrix step for the 4 most recent supported PHP versions. It uses a bash command and the PHP built-in linter to find errors. It doesn't print much output due to the nature of the linter, but the build step fails with exit code 1 if linting fails.

This example adds a matrix step for the 4 most recent supported PHP versions. It uses a bash command and the PHP built-in linter to find errors. It doesn't print much output due to the nature of the linter, but the build step fails with exit code 1 if linting fails.
Adds a recursive lint operation for the currently 4 supported php 8.x releases.
Add PHP lint to README
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
1558db361e
6543 commented 2024-02-03 18:46:46 +01:00
Owner
Copy link

@sexybiggetje nice, but could you fix the linter issue :)

@sexybiggetje nice, but could you fix the linter issue :)
Update lint.yaml for linter
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
5e687c9c1d 
Adds newline character to the end of the file.
martijndeb commented 2024-02-03 19:29:41 +01:00
Author
Contributor
Copy link

@sexybiggetje nice, but could you fix the linter issue :)

I see, minor issue, fixed :)

> @sexybiggetje nice, but could you fix the linter issue :) I see, minor issue, fixed :)
6543 approved these changes 2024-02-04 00:39:39 +01:00
pat-s requested changes 2024-02-04 23:39:49 +01:00
pat-s left a comment
Owner
Copy link

Please see point 2 in the README

If you only add one file: name it .woodpecker.yaml. If you want to add multiple files: add a .woodpecker directory and use descriptive names for the individual yaml files.

Please see point 2 in the README > If you only add one file: name it .woodpecker.yaml. If you want to add multiple files: add a .woodpecker directory and use descriptive names for the individual yaml files.
README.md Outdated
@ -17,6 +17,7 @@ Pull requests are welcome!
| [tectonic/.woodpecker.yml](tectonic/.woodpecker.yml) | LaTeX | Tectonic | Builds a TeX file and pushes the resulting PDF file to a given repository. |
| [Jekyll/jekyll.yml](Jekyll/jekyll.yml) | Markdown | Jekyll | CI step to build static website files and publish them to Codeberg Pages using Jekyll |
| [Hugo/hugo.yml](Hugo/hugo.yml) | Markdown | Hugo | CI step to build static website files and publish them to Codeberg Pages with Hugo |
| [PHP/.woodpecker/lint.yaml](PHP/.woodpecker/lint.yaml) | PHP | Bash | CI step lint PHP files and report on errors |
pat-s commented 2024-02-04 23:39:03 +01:00
Owner
Copy link

Please format the table so that all column are aligned

Please format the table so that all column are aligned
martijndeb marked this conversation as resolved
6543 commented 2024-03-25 17:25:10 +01:00
Owner
Copy link

Conflicting now :/

Conflicting now :/
pat-s commented 2024-04-10 08:54:45 +02:00
Owner
Copy link

@sexybiggetje Do you want to resolve conflicts?

@sexybiggetje Do you want to resolve conflicts?
martijndeb commented 2024-04-10 18:51:47 +02:00
Author
Contributor
Copy link

I tried merging and updating, but the pipeline fails on prettier now? Can't seem to see as to why it fails in the details

I tried merging and updating, but the pipeline fails on prettier now? Can't seem to see as to why it fails in the details
pat-s commented 2024-04-10 18:53:50 +02:00
Owner
Copy link

There's a prettier lint issue in the README, as reported in CI. Run prettier -w on the repo root and commit the diff :)

There's a prettier lint issue in the README, as reported in CI. Run `prettier -w` on the repo root and commit the diff :)
Reformatted README.md for PHP
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
cb66dd11bf
martijndeb commented 2024-04-11 17:16:49 +02:00
Author
Contributor
Copy link

Great success!

Great success!
pat-s commented 2024-04-11 20:50:06 +02:00
Owner
Copy link

Thanks for contributing!

Thanks for contributing!
❤️ 1
pat-s merged commit f629af8e6a into main 2024-04-11 20:50:12 +02:00
pat-s referenced this pull request from a commit 2024-04-11 20:50:13 +02:00
Add PHP Lint for recent versions (#40)
Sign in to join this conversation.
Reviewers
No reviewers
6543
pat-s
Labels
Clear labels   
enhancement

   
good first issue

   
government

   
request for example
No labels
enhancement
good first issue
government
request for example
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Codeberg-CI/examples#40
No description provided.
Delete branch "martijndeb/examples:php_8_lint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?