~snappy-dev/snapd/+git/snapd-pawel:taskrunner-single-line-multi-tasksets-undo

Last commit made on 2022-03-10
Get this branch:
git clone -b taskrunner-single-line-multi-tasksets-undo https://git.launchpad.net/~snappy-dev/snapd/+git/snapd-pawel

Branch merges

Branch information

Name:
taskrunner-single-line-multi-tasksets-undo
Repository:
lp:~snappy-dev/snapd/+git/snapd-pawel

Recent commits

182cb40... by Paweł Stołowski

Fix format.

020a1b6... by Paweł Stołowski

Simplify the test

Co-authored-by: Miguel Pires <email address hidden>

cd1e532... by Paweł Stołowski

Make the transition from AbortStatus to DoneStatus a noop in task's
SetStatus. This is to avoid the race where if the tasks are in same
change and lane but run concurrently (i.e. they are not chained) and one
of them fails, taskrunner would abort the other that's currently in
running, and if the aborted task explicitly sets own status to DoneStatus, it wouldn't get undone.

af8a1ea... by Sergio Cazzolato

tests: validate tests tools just on google and qemu backends (#11473)

* Validate tests tools just on google backend

The idea is to avoid spending time validating testing tools on other
backends such as external.

Those tests are making longer the edge/beta validations for example.

* Allow qemu too

dd799e0... by Sergio Cazzolato

Squashed 'tests/lib/external/snapd-testing-tools/' changes from 872b64e05b..58418c3f7e (#11451)

58418c3f7e Merge pull request #15 from snapcore/testing-jammy
f015a34899 Fix issue about how info is saved for Debug output
1ee4240e79 Adding jammy to the test systems in spread.yaml
61a4c3142d Merge pull request #14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool
575f5d2016 Merge pull request #13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request #10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request #12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
5cfa7cb84d New shellcheck for spread tasks

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 58418c3f7ed998e3f327f5104588ee8c8dc48651

3401bb2... by Sergio Cazzolato

tests: skip interfaces-cups-control from debian-sid (#11472)

* Skip interfaces-cups-control from debian-sid

The last update for cups package produced failures for the cups related
tests. The research showed that the problem is with the cups deb
package.

To ensure snapd is not responsible of the error, I created a new debian
sid image with not snapd installed and run:

dmesg command is showing some denials as well:

[ 13.532910] audit: type=1400 audit(1646305531.156:14):
apparmor="DENIED" operation="capable" profile="/usr/sbin/cupsd" pid=470
comm="cupsd" capability=12 capname="net_admin"

I tried the same in debian 11 and it works well

I see this in the journal log

Mar 03 11:05:31 mar031105-863937 kernel: audit: type=1400
audit(1646305531.156:14): apparmor="DENIED" operation="capable"
profile="/usr/sbin/cupsd" pid=470 comm="cupsd" capability=12
capname="net_admin"
Mar 03 11:05:31 mar031105-863937 audit[470]: AVC apparmor="DENIED"
operation="capable" profile="/usr/sbin/cupsd" pid=470 comm="cupsd"
capability=12 capname="net_admin"

* Adding associated issue

* Update the bug related to the issue

87e5a7c... by Sergio Cazzolato

Increase the times in snapd-sigterm for arm devices (#11479)

The maximun time allowed to stop snapd on arm devices needs to be higher
than 5 seconds because those devices are slower than the google vms

Those are some time examples that I got from a dragonboard. Other
devices are showing similar times.

ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl stop snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "inactive"' && date +"%T.%3N"
12:30:08.833
Warning: Stopping snapd.service, but it can still be activated by:
  snapd.socket
12:30:17.368
ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl start snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "^active"' && date +"%T.%3N"
12:40:44.515
12:40:45.614
ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl stop snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "inactive"' && date +"%T.%3N"
12:40:48.100
Warning: Stopping snapd.service, but it can still be activated by:
  snapd.socket
12:40:57.387
ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl start snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "^active"' && date +"%T.%3N"
12:41:56.590
12:41:57.684
ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl stop snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "inactive"' && date +"%T.%3N"
12:42:01.561
Warning: Stopping snapd.service, but it can still be activated by:
  snapd.socket
12:42:09.446
ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl start snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "^active"' && date +"%T.%3N"
12:42:12.820
12:42:13.959
ubuntu@localhost:~$ date +"%T.%3N" && sudo systemctl stop snapd.service
&& ./retry -n 100 --wait 0.1 --quiet sh -c 'systemctl is-active
snapd.service | grep -Eq "inactive"' && date +"%T.%3N"
12:42:17.192
Warning: Stopping snapd.service, but it can still be activated by:
  snapd.socket
12:42:25.524

58cf958... by Michael Vogt

Merge pull request #11440 from oSoMoN/browser-support-rtkit-realtimewithpid

interfaces/browser-support: allow RealtimeKit's MakeThreadRealtimeWithPID

57b1cec... by Michael Vogt

Merge pull request #11444 from bboozzoo/bboozzoo/misc-analyzer-fixes

cmd: misc analyzer fixes

6a548dc... by Michael Vogt

Merge pull request #11465 from bboozzoo/bboozzoo/account-consumer-pam-tally2

interfaces/builtin/account-control: allow to execute pam_tally2