Merge lp:~shnatsel/ppa-purge/drop-awk-dependency into lp:ppa-purge
Proposed by Sergey "Shnatsel" Davidoff
| Status: | Needs review |
|---|---|
| Proposed branch: | lp:~shnatsel/ppa-purge/drop-awk-dependency |
| Merge into: | lp:ppa-purge |
| Diff against target: | 27 lines (+3/-3) 2 files modified debian/control (+1/-1) ppa-purge (+2/-2) |
| To merge this branch: | bzr merge lp:~shnatsel/ppa-purge/drop-awk-dependency |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stefano Rivera (community) | Needs Information | ||
| Review via email: | |||
Description of the change
I've replaced the only AWK command with a combination of grep and cut for readability and consistency with the rest of the script. This also drops additional dependency on awk.
To post a comment you must log in.
Unmerged revisions
- 60. By Sergey "Shnatsel" Davidoff
-
well, it seems to be sorted to me, but comm disagrees
this will make it happy for sure - 59. By Sergey "Shnatsel" Davidoff
-
added dependencies to debian/control - depending only on aptitude and hoping everything else is in place is not a good idea
- 58. By Sergey "Shnatsel" Davidoff
-
fixed matching "install" in package name and "deinstall" state
- 57. By Sergey "Shnatsel" Davidoff
-
replaced the only awk command with combination of grep and cut for readability; this also drops awk dependency
Thanks for the patch, but I'm not entirely convinced of its necessity.
mawk is Priority: required, so it's present on every image and the dependency isn't a big deal.
Also, you want to grep for 'install$', otherwise you'll catch packages with "install" in their name.