debian-cd

Merge lp:~mwhudson/debian-cd/change-grub-labels into lp:~ubuntu-cdimage/debian-cd/ubun3

  1. change-grub-labels
  2. Merge into ubun3
Proposed by Michael Hudson-Doyle
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp:~mwhudson/debian-cd/change-grub-labels
Merge into: lp:~ubuntu-cdimage/debian-cd/ubun3
Prerequisite: lp:~mwhudson/debian-cd/document-xorriso-options
Diff against target: 21 lines (+2/-2)
1 file modified
tools/boot/groovy/boot-amd64 (+2/-2)
To merge this branch: bzr merge lp:~mwhudson/debian-cd/change-grub-labels
Reviewer Review Type Date Requested Status
Steve Langasek (community) Needs Information
Dimitri John Ledkov Pending
Review via email: mp+387016@code.launchpad.net

Description of the change

This doesn't really depend on the other branches but I'm too lazy to remember how to rebase things in bzr.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Dimitri, I think this came in as part of your changes, was this a deliberate change w/ input from Design?

Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On Wed, 8 Jul 2020, 19:26 Steve Langasek, <email address hidden>
wrote:

> Dimitri, I think this came in as part of your changes, was this a
> deliberate change w/ input from Design?
>

It was deliberate yes.

Input from Design -> not quite completely of the things changed.

We used to have a mix of wording of:
- nothing shown / hidden
- Install $flavour
- Try $flavour
- Start $flavour

Depending on boot mode & flavour.

General guidance is to keep install time menu, same as installed one.

For groovy all flavours, in all modes, just use "$flavour".

With Hidden/Install/Try/Start all dropped.

As all flavours in groovy boot to a live session, which can be user
interactively, for recovery, or to complete the install.

Please do not introduce divergence, or impose "Install" which was used by
minority of flavours.

Please note "Install $foo" comes from the days of separate live & install
media, as well as jumbo media that required a reboot if one wanted to
install versus complete the install. Yet for more than a decade now, we had
live session that can do everything.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

OK this makes sense I guess.

The thing that prompted me to send this is that I get confused sometimes as to whether it's the installer media or the existing install that's booting. But maybe that's a bit niche.

Unmerged revisions

2080. By Michael Hudson-Doyle

change grub menu labels to "Install $HUMANPROJECT"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/boot/groovy/boot-amd64'
2--- tools/boot/groovy/boot-amd64 2020-07-08 04:10:51 +0000
3+++ tools/boot/groovy/boot-amd64 2020-07-08 04:10:51 +0000
4@@ -123,7 +123,7 @@
5 set menu_color_normal=white/black
6 set menu_color_highlight=black/light-gray
7
8-menuentry "$HUMANPROJECT" {
9+menuentry "Install $HUMANPROJECT" {
10 set gfxpayload=keep
11 linux /casper/vmlinuz $KERNEL_PARAMS
12 initrd /casper/initrd
13@@ -133,7 +133,7 @@
14 # All but server get safe-graphics mode
15 if [ "$PROJECT" != "ubuntu-server" ]; then
16 cat >> $CDDIR/boot/grub/grub.cfg <<EOF
17-menuentry "$HUMANPROJECT (safe graphics)" {
18+menuentry "Install $HUMANPROJECT (safe graphics)" {
19 set gfxpayload=keep
20 linux /casper/vmlinuz nomodeset $KERNEL_PARAMS
21 initrd /casper/initrd

Subscribers

People subscribed via source and target branches