snapd

~mvo/snapd/+git/snapd-mvo:run-checks-fixes-fedora

  1. Git
  2. lp:~mvo/snapd/+git/snapd-mvo
  3. run-checks-fixes-fedora
Last commit made on 2023-08-28
Get this branch:
git clone -b run-checks-fixes-fedora https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
run-checks-fixes-fedora
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

2c9cb26... by Michael Vogt

snap: fix TestParseQuotas when no snapd.socket is avilable

The TestParseQuotas was hitting the /v2/quota/<group> endpoint
and with no snapd available it would hang forever. This commit
fixes this by adding the missing fake handler.

4082fe7... by Michael Vogt

devicestate: re-init dirs.SetRootDir after mocking ReleaseInfo

When MockReleaseInfo is called the dirs.SetRootDir() must be
called again because when running on e.g. fedora the
dirs.SnapMountDir is set to /var/lib/snapd/snaps but when
mocking a different release dirs.SnapMountDir may not actually
point to /snap leading to test failures.

This commit fixes this by calling dirs.SetRootDir() again
in the firstboot test.

6fcce8d... by Michael Vogt

install: fix hardcoded /snap to use dirs.SnapMountDir in tests

110f791... by Michael Vogt

snapstate: fix hardcoded /snap prefix in tests

Some tests use a hardcoded /snap prefix in the tests. This will
make unit tests on fedora fail as it uses /var/lib/snapd/snaps
for the mount points. This commit changes the code to use
`dirs.SnapMountDir` instead of hardcoding the path.

051b144... by Miguel Pires

i/b/shared-memory: handle "private" plug attribute in shared-memory interface correctly (#13107)

* i/b/shared-memory: error on invalid plug attribute

The isPrivate() method assumes that a plug has been sanitised by
BeforePreparePlug and panics if there's no "private" attribute.
There's been a customer report of this happening and even though the
it's unclear how the attribute is missing/wrong, we should handle it
as gracefully as we can instead of panicking.

Signed-off-by: Miguel Pires <email address hidden>

* i/b/shared-memory: split else/if

Signed-off-by: Miguel Pires <email address hidden>

* interfaces: deal with missing shared-mem `private` attr correctly

The private attribute in the shared-memory interface may be
not in the `isPrivate()` call. This can even happen if
"SanitizePlugsSlots()" is called (which in turn calls
BeforePreparePlug() which will set `private`).

The code-path in which this happens is an upgrade from snapd
2.54.4 where shared-memory did not have the "private" attribute
yet. Then the ConnectedPlug data is written into the
interface repo without this attribute and on regeneration
of security profiles the connectedPlug is loaded from the
interface repository in the state and not from the
snap.yaml so this attribute is missing.

The correct behavior is that `private` is set to false which
is the default when it's not set in snap.yaml as it can only
end up in this state if it was unset.

---------

Signed-off-by: Miguel Pires <email address hidden>
Co-authored-by: Michael Vogt <email address hidden>

b98e4af... by Philip Meulengracht

i/apparmor: support for home.d tunables from /etc/ (#13118)

* i/apparmor: support for home.d tunables from /etc/

* tests: update snapd-homedirs-vendored to run on all ubuntu versions

* i/apparmor: add additional unit test

Only enable the spread test for ubuntu 20 and newer as any distro before don't support the neccessary features

---------

Co-authored-by: Michael Vogt <email address hidden>

dcb8ad2... by Alfonso Sanchez-Beato

tests: make muinstaller capable of installing Ubuntu Core (#13026)

* tests/muinstaller: allow installing Ubuntu Core images

* tests/muinstaller-core: add test using muinstaller for UC installation

This new test runs muinstaller installing Ubuntu Core images.

* tests/muinstaller: build statically and update deps

* tests: change order of arguments for muinstaller invocations

* tests/muinstaller: use better function names, remove unneeded arg

* tests/muinstaller-core: some minor fixes

c3cd8b4... by Sergio Cazzolato

tests: fix cgroup-tracking-failure test on ubuntu mantic (#13069)

* Fic cgroup-tracking-failure test on ubuntu mantic

Ubuntu mantic is using systemd 253 so tests.session is not using busctl
anymore to execute commands

* Fix the case for ubuntu mantic

* Fix test for ubuntu lunar

* tests: fix cgroup-tracking-failure for root tracking too

---------

Co-authored-by: Michael Vogt <email address hidden>

40ec59e... by Valentin David

tests/main/uc20-create-partitions: do not check for shim on boot partition

This was never used and then removed in
snapcore/pc-gadget@a6d5e0dabca77663f6a32eb3b089b244ea428978

06ef455... by Oliver Calder

sandbox/apparmor/notify: clarified descriptions of Error fields in messages

Signed-off-by: Oliver Calder <email address hidden>