~mvo/snapd/+git/snapd-mvo:fix-code-duplication-ns-support

Last commit made on 2023-08-04
Get this branch:
git clone -b fix-code-duplication-ns-support https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
fix-code-duplication-ns-support
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

36699f6... by Michael Vogt

snap-confine: extract helper from sc_join_preserved_{per_user,}_ns

The tiobe quality check found that we have some duplicated code
in sc_join_preserved_ns() and sc_join_preserved_per_user_ns().

Given that the code is relatively nested and important this
commit extracts two common helpers that will fix most of
the duplication and makes the code also (IMHO) more readable.

22e1eb3... by Sergio Cazzolato

tests: fix error in gadget-config-defaults-to-snaps test (#13033)

* Fix error in gadget-config-defaults-to-snaps test

The test fails when either two variants are executed in the same machine
or the test execution is reapetead

The problem is that the snap lib ie cleaned but the
test-snapd-with-configure and test-snapd-with-default-configure snaps
are leaving leftovers in /snap and /var/snap, so during the second
execution, the files in SNAP_COMMON are the created in the first one.

The solution is to remove test-snapd-with-default-configure and clean
the leftovers for test-snapd-with-configure snap

* fix shellcheck

ab6d918... by Miguel Pires

aspects: optimise aspect tx Get

Cache a copy of the transaction's databag so that a new one doesn't have
to be created and all the deltas applied.

0b69df7... by Zeyad Gouda

interfaces/builtin/pulseaudio_test: fix apparmor checking incorrect permissions

Signed-off-by: Zeyad Gouda <email address hidden>

d0c82eb... by Philip Meulengracht

daemon: allow nil stored rebootInfo

Otherwise this causes getRebootArguments to try to resolve a bootloader when even when there is no RebootInfo set as a part of HandleRestart.

f1de83c... by Sergio Costas

interfaces/audio: allow to provide pipewire/pulse slots from a containerized pipewire/desktop (#12865)

* UDENG-535: allow access to pipewire socket

This PR ports UDENG-418 to upstream, that enables audio in core
Desktop. It allows access to the pipewire socket from snapped
applications, and allows to have pipewire running inside a snap
container. To avoid security issues, it only allows to access
the sockets located at the folder belonging to the snap that
owns the slot.

With this patch, audio works fine in Core Desktop, and also
screen sharing.

* Replace PLUG_SECURITY_TAGS with SLOT_SECURITY_TAGS

* Remove unneeded "ImplicitOnCore: false" statements

* Better explanation for the /etc/pulse rule

* Add pulseaudio tests

ebf1df4... by Oliver Calder

gadget: remove unused private types after refactor

Signed-off-by: Oliver Calder <email address hidden>

d9e4ab8... by Valentin David

osutil/kcmdline: simplify names

c9bbf25... by Valentin David

osutil: extract kcmdline to its own package

7e5c845... by Valentin David

osutil/kcmdline.go: add command line to string conversion

Also fix quotation when a space is in a parameter part of the
argument.