Issue 141073009: Add forgive_all to enable experimental builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141073009: Add forgive_all to enable experimental builders. (Closed)

Created:
6 years, 11 months ago by ghost stip (do not use)

Modified:
6 years, 11 months ago

Reviewers:
cmp, hinoka

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, iannucci

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

More Reviews

Description

Add forgive_all to enable experimental builders. This enables us to notify specific watchers of waterfalls without radically altering gatekeeper.json. This patch enables that for both master.chromium and master.lkgr. It enables this on both master.chromium and master.chromium.lkgr, and removes sheriffing on master.chromium. This paves the way to remove the chromium-build whitelist, unblocking 304763. It also adds wfh and scottmg to gatekeeper.json. BUG=304763, 335234 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245711

Patch Set 1 #

Patch Set 2 : Correct typo. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -9 lines)			Patch
M	scripts/slave/gatekeeper.json	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	scripts/slave/gatekeeper_ng.py	View		3 chunks	+18 lines, -5 lines	0 comments	Download
M	scripts/slave/unittests/gatekeeper_ng_test.py	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Change committed as 245711

Expand Messages | Collapse Messages