| commit | 6cb72a333a0838a741a97d4fdc1df2ed4ace3d21 | [log] [tgz] |
|---|---|---|
| author | Gavin Mak <gavinmak@google.com> | Thu Jan 06 23:34:24 2022 |
| committer | Gavin Mak <gavinmak@google.com> | Wed Jan 12 20:36:36 2022 |
| tree | 922e7a8b16e473d94d52ba7690a872aa39fbf4a9 | |
| parent | 50db026711ead6816cf8a0ced522a7d73c6fe469 [diff] |
Remove 'Binary Size' panel This CL makes the Checks tab the only way to view binary size changes. Bug: 1228935 Change-Id: Ib472dd8956255046db8356f37870d69582a5b4f8
The plugin queries the android-binary-size trybot for the current patchset on Gerrit, and gets the binary_size_plugin property. This property contains the metadata about the binary size metrics affected by the patchset in question. It then shows a table with the metric deltas + links to SuperSize output under the Checks tab.
This plugin is configured via the chromium-binary-size.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).
An example chromium-binary-size.config is below (this enables the plugin on the chromium/src repo using the android-binary-size trybot:
[host] gerrit = "chromium-review.googlesource.com" [repo "chromium/src"] builder = "android-binary-size" bucket = "try" project = "chromium"
All changes to chromium-binary-size.config files are instantly reflected. There is no caching period or need to restart the server.
This plugin must be placed inside the Gerrit plugins directory:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit/plugins git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-binary-size
For running Java unit tests execute:
bazel test --test_output=all //plugins/chromium-binary-size:chromium-binary-size_tests
For running TypeScript unit tests execute:
bazel test --test_output=all //plugins/chromium-binary-size/web:karma_test
For checking or fixing eslint formatter problems run:
bazel test //plugins/chromium-binary-size/web:lint_test bazel run //plugins/chromium-binary-size/web:lint_bin -- --fix "$(pwd)/plugins/chromium-binary-size/web"
For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/chromium-binary-size folder:
bazel build //plugins/chromium-binary-size/web:chromium-binary-size cp -f bazel-bin/plugins/chromium-binary-size/web/chromium-binary-size.js plugins/chromium-binary-size
and let the Dev Helper redirect from .+/plugins/chromium-binary-size/static/chromium-binary-size.js to http://localhost:8081/plugins_/plugins/chromium-binary-size.js.