Activity
From 08/14/2024 to 08/20/2024
08/20/2024
-
06:37 PM Revision 1d68a735 (git): [ruby/tempfile] Don't unlink in finalizer when already unlinked
- https://github.com/ruby/tempfile/commit/f677941ea2
-
06:37 PM Revision bd7eda60 (git): [ruby/tempfile] Fix subprocess tests requires
- Using `-rtempfile` requires the tempfile built into Ruby, not the
currently developed one, so the tests aren't testing this tempfile.
https://github.com/ruby/tempfile/commit/ea2dec6f46 -
06:29 PM Revision 2f67610f (git): Remove dependency on Tempfile::Remover in leakchecker.rb
-
06:07 PM Revision a68331e7 (git): [ruby/tempfile] Add FinalizerManager to manage finalizers
- As @jeremyevans pointed out for commit eb2d8b1:
> Each Tempfile instance has a separate File instance and file descriptor:
> ...
FinalizerManager will keep track of the open File objects for the
particular file and will only unlink the ... -
01:28 PM Revision 41b427a2 (git): [ruby/tempfile] Ensure finalizer order in Tempfile
- The Closer and Remover finalizers are defined on different objects in
Tempfile. The Closer is defined on the Tempfile object while the Remover
is defined on the finalizer_obj. This means that there is no guarantee
of the finalizer order.... -
11:16 AM Revision d6f18b22 (git): Remove extraneous lock files
- See https://github.com/rubygems/rubygems/pull/7939
-
11:03 AM Revision 72d016e9 (git): [ruby/reline] typofix
- https://github.com/ruby/reline/commit/d44fbf9f7b
- 09:36 AM Revision 927a44b4 (git): Rewrite #test_redefinition_mismatch to use a dedicated test class
- This test is checking what happens if you try and define a class in a C
extension where that constant is already not a class. It was doing this
by overriding ::Date and then trying to require 'date. The issue with
this is that if we ever... -
09:00 AM Revision 5e3dd6d3 (git): Decrease the timeout in assert_darwin_vm_dump_works (#11412)
-
06:17 AM Misc #20683 (Closed): Propose @ono-max as a committer
- I've finished account setup for ono-san.
-
04:29 AM Misc #20683: Propose @ono-max as a committer
- @hsbt
Yes. I sent the email to the address. -
03:23 AM Misc #20683: Propose @ono-max as a committer
- @ono-max Can you give Required and Optional information of https://github.com/ruby/ruby/wiki/Committer-How-To#how-to-register-you-as-a-committer to `cvs-admin@ruby-lang.org`?
-
03:26 AM Revision f73d4352 (git): Check compile_branch_condition results
-
03:26 AM Revision 995b4c32 (git): Make same structures same
- 02:48 AM Revision edd3fc62 (git): Bump github/codeql-action from 3.26.2 to 3.26.3
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.2 to 3.26.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
02:00 AM Bug #20679 (Closed): Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- Applied in changeset commit:git|ea7ceff82cec98d0c419e9807dcb33dcc08b56fa.
----------
Avoid hash allocation for certain proc calls
Previously, proc calls such as:
```ruby
proc{|| }.(**empty_hash)
proc{|b: 1| }.(**r2k_array_with_empty_h... -
02:00 AM Revision ea7ceff8 (git): Avoid hash allocation for certain proc calls
- Previously, proc calls such as:
```ruby
proc{|| }.(**empty_hash)
proc{|b: 1| }.(**r2k_array_with_empty_hash)
```
both allocated hashes unnecessarily, due to two separate code paths.
The first call goes through CALLER_SETUP_ARG/vm_call... -
01:27 AM Revision 6dccb013 (git): Sort links [ci skip]
08/19/2024
-
11:51 PM Feature #20664: Add `before` and `until` options to Enumerator.produce
- @matheusrich In my opinion `take_until` might be an interesting method to add, but I think we are unnecessarily complicating the example with `it` and `nil?`.
The expression is simply:
```ruby
Enumerator.produce(File, &:superclass).take... -
09:05 PM Feature #20664: Add `before` and `until` options to Enumerator.produce
- > The one problem we don’t currently have neither Enumerable#take_until, nor Object#not_nil?, to write something like
After [proposing `Object#chain_of`](https://bugs.ruby-lang.org/issues/20625), I realized how missing one of these re... -
11:46 PM Bug #20686: URI::HTTPS can build URI with blank, invalid host
- jhawthorn (John Hawthorn) wrote in #note-2:
> jeremyevans0 (Jeremy Evans) wrote in #note-1:
> ...
Thank you for pointing that out. I obviously should have read a little further. I submitted a pull request to reject empty host for `URI... -
10:59 PM Bug #20686: URI::HTTPS can build URI with blank, invalid host
- Interestingly RFC2396_PARSER seems to allow nil for a host but not empty string, so the newer behaviour is at least more consistent. It does seem like we are missing some expected validation here though.
```
> URI::HTTPS.new(nil, nil... -
10:45 PM Bug #20686: URI::HTTPS can build URI with blank, invalid host
- jeremyevans0 (Jeremy Evans) wrote in #note-1:
> It appears RFC 3986 allows empty hosts (https://datatracker.ietf.org/doc/html/rfc3986#section-3.2.2: `reg-name = *( unreserved / pct-encoded / sub-delims )`), so I think this is not a b... -
08:04 PM Bug #20686: URI::HTTPS can build URI with blank, invalid host
- ronricardo (Roniece Ricardo) wrote:
> In Ruby 3.4.0+, calling `URI::HTTPS.build(host: "")` does not raise `URI::InvalidComponentError` as expected. Instead, it returns `#<URI::HTTPS https://>`
> ...
That PR only affects `#to_s`, not `... -
07:40 PM Bug #20686 (Closed): URI::HTTPS can build URI with blank, invalid host
- In Ruby 3.4.0+, calling `URI::HTTPS.build(host: "")` does not raise `URI::InvalidComponentError` as expected. Instead, it returns `#<URI::HTTPS https://>`
I think this was introduced in [this PR](https://github.com/ruby/uri/pull/90).... -
10:32 PM Bug #20586: Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted
- Anonymous wrote in #note-8:
> `rb_getpwdirnam_for_login` currently does not have any explicit
> ...
I think this is expected. The consensus seems to be that we should raise an error. Maybe we could change the handling to retry certa... -
09:19 AM Bug #20586: Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted
- Hey! As usual thanks for picking up these thorny bugs :)
The fix looks good! In particular I've re-tested it with a modified version of the Datadog profiler where I force it to interrupt threads without GVL (the bug is very hard to t... -
10:09 PM Bug #20679: Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> Definitely related to the `ruby2_keywords` optimization. I'll keep digging to find the root cause. I'll leave this open until I have a working fix.
I submitted a pull request for the fi... - 07:21 PM Revision e398e84c (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.100 to 0.9.101.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.100...v0.9.101)
---
updated-dep... - 05:55 PM Revision d1b2479b (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.100 to 0.9.101.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.100...v0.9.101)
---
updated-dep... -
02:58 PM Revision cb284877 (git): Make assertions allow incremental GC when disabled
- When assertions are enabled, the following code triggers an assertion
error:
GC.disable
GC.start(immediate_mark: false, immediate_sweep: false)
10_000_000.times { Object.new }
This is because the GC.start ignores that the ... -
11:48 AM Revision 786d0006 (git): [ruby/rdoc] Avoid potentially loading the same extension from different versions of the same gem
- Avoids warnings like
```
/path/to/ruby/3.3.4/lib/ruby/gems/3.3.0/gems/rbs-3.4.0/lib/rdoc/discover.rb:10: warning: method redefined; discarding old scan
/path/to/ruby/3.3.4/lib/ruby/gems/3.3.0/gems/rbs-3.5.1/lib/rdoc/discover.rb:10: warn... -
10:50 AM Revision cd0d4ec0 (git): Single letter ASCII operator is same as the corresponding ID
-
10:13 AM Misc #20685: Ruby 3.2.4 tag mentions unrelated changes (CVE-2024-27280)
- Thank you for your greate catch! You are totally right. ruby-3.2 seriese contains stringio-3.0.4 from the beginning.
I remove the CVE reference in the GitHub release page now. https://github.com/ruby/ruby/releases/tag/v3_2_4
I will... -
09:21 AM Misc #20685 (Closed): Ruby 3.2.4 tag mentions unrelated changes (CVE-2024-27280)
- # Problem
According to https://github.com/ruby/ruby/releases/tag/v3_2_4,
it mentions "CVE-2024-27280: Buffer overread vulnerability in StringIO"
as a security fix, but https://www.ruby-lang.org/en/news/2024/03/21/buffer-overread-cve... -
09:20 AM Feature #20684 (Closed): Add optimized instructions for frozen literal Hash and Array
- # Context
Methods that take empty arrays or empty hashes as default values allocate a new object each time the method is called without the argument. Often they don't mutate the parameter. To prevent an allocation, in performance crit... -
06:36 AM Revision 566f2eb5 (git): Merge `rb_fork_ruby2` into `rb_fork_ruby`
-
06:35 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- https://github.com/ruby/ruby/pull/11405 - I think this should fix it. It seems new toolchains truncate the section name, rather than throwing that error about "length is between 1 and 16 characters", but in any case the section is meanin...
-
05:44 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- > deciding if BTI/PAC is available.
Silly me, this is about amd64.
So what you're running into is that I added a `.note.gnu.property` to the amd64 one in https://github.com/ruby/ruby/commit/8ec67052e67dff62b828820e381a94a3acc73459 ... -
04:58 AM Misc #20683: Propose @ono-max as a committer
- Approved.
Matz.
-
02:34 AM Misc #20683 (Assigned): Propose @ono-max as a committer
- +1
Our test suite and CI are complex and complicated. We need more maintainer for that. -
02:04 AM Misc #20683: Propose @ono-max as a committer
- I forgot to mention that he has expressed his willingness to accept committer's proposal here: https://bugs.ruby-lang.org/issues/20682#note-3
-
02:01 AM Misc #20683 (Closed): Propose @ono-max as a committer
- I'd like to propose @ono-max as a committer.
He has contributed to Ruby's test framework, starting with the introduction of Launchable (#20254, #20661).
Also he has been an ongoing contributor to the investigation and correction of f... -
01:53 AM Bug #20682: Slave PTY output is lost after a child process exits in macOS
- mame (Yusuke Endoh) wrote in #note-2:
> The PR looks good to me.
> ...
Sure! I would be delighted to accept a committer.
-
01:51 AM Bug #20682: Slave PTY output is lost after a child process exits in macOS
- The PR looks good to me.
@ono-max Do you want to merge it yourself? If you are willing, I'd like to propose you as a committer. -
01:21 AM Bug #20682: Slave PTY output is lost after a child process exits in macOS
- I created the PR: https://github.com/ruby/ruby/pull/11404
This change works in my macOS environment. -
01:16 AM Bug #20682 (Closed): Slave PTY output is lost after a child process exits in macOS
- According to Launchable, the following PTY tests are flaky only on macOS.
https://app.launchableinc.com/organizations/ruby/workspaces/ruby/data/test-paths/file%3Dtest%2Ftest_pty.rb%23%23%23class%3DTestPTY%23%23%23testcase%3Dtest_spawn... -
12:04 AM Revision 70613595 (git): [rubygems/rubygems] Change new gem README template to have copyable code blocks
- https://github.com/rubygems/rubygems/commit/c805e9b558
08/18/2024
-
01:22 PM Bug #19374: Issue with Ractor.make_shareable with curried procs
- Hey y'all -
I'm commenting here to say that this bug seems to be the only way I was able to pass a Proc to a Ractor even though it doesn't reference self - so wondering what the path is for that instead of exploiting this bug. For cont... -
10:15 AM Feature #18368 (Closed): Range#step semantics for non-Numeric ranges
- Applied in changeset commit:git|d450f9d6a28f01b7ca6030a925921dbf35cee439.
----------
Make Range#step to consistently use + for iteration (#7444)
Make Range#step to consistently use + for iteration [Feature #18368]
Previously, non-num... -
10:15 AM Revision d450f9d6 (git): Make Range#step to consistently use + for iteration (#7444)
- Make Range#step to consistently use + for iteration [Feature #18368]
Previously, non-numerics expected step to be integer,
and iterated with begin#succ, skipping over step value
steps. Since this commit, numeric and non-numeric iteratio... -
09:30 AM Bug #20344: argument stack underflow (-1)
- ruby_3_2 commit:21c708ee802e1a59901eccc6448e40e8f72189b8 merged revision(s) commit:992596fb7af18a7f472589a607d0eb3fbb03b49a.
-
09:07 AM Revision 21c708ee (git): merge revision(s) 992596fb7af18a7f472589a607d0eb3fbb03b49a: [Backport #20344]
- Fix next inside block argument stack underflow
[Bug #20344]
Fix compile_next adding removable adjust label -
09:03 AM Bug #20490: Process.waitpid2(-1, Process::WNOHANG) misbehaves on Ruby 3.1 & 3.2 with detached process
- Merged at https://github.com/ruby/ruby/commit/65fed1c3e439bc47bcf6ec884431a86cb9ebd1dc. Thank you!
-
09:02 AM Revision 65fed1c3 (git): Allow waitpid(-1, Process::WNOHANG) to be woken if a waitpid(pid) is
- ...pending
If two threads are running, with one calling waitpid(-1, Process::WNOHANG),
and another calling waitpid($some_pid), and then
$some_other_pid exits, we would expect the waitpid(-1,
Process::WNOHANG) call to retrieve that exit ... -
08:30 AM Bug #20681: Regular expression warnings are treated as compiler warnings during runtime
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> You may want to re-define `Warning.warn`.
Thank you, that works. Apologies for the wrong report. -
03:25 AM Bug #20681 (Feedback): Regular expression warnings are treated as compiler warnings during runtime
- You may want to re-define `Warning.warn`.
-
03:51 AM Bug #20586: Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted - On 2024-08-16 21:59:04, "jeremyevans0 (Jeremy Evans) via ruby-core" <ruby-core@ml.ruby-lang.org> spake thus:
>Issue #20586 has been updated by jeremyevans0 (Jeremy Evans).
>
>
>I've submitted a pull request that I hope will address ... -
02:20 AM Bug #20649: Ripper fails to tokenize `def f; (x)::A =`
- ruby_3_2 commit:a8a25291447e3630d455e82851ca58fc8ac372ec merged revision(s) commit:97449338d6cb42d9dd7c9ca61550616e7e6b6ef6.
-
02:19 AM Bug #20571: Compile error on for loop
- ruby_3_2 commit:50399eebd96c76ce808ea4d84fe39693f585a531 merged revision(s) commit:1870505f478cc75993b296b7144a45137ace6937.
-
02:19 AM Bug #20651: `false && (1 in 1)` produces argument stack underflow (-1)
- ruby_3_2 commit:50399eebd96c76ce808ea4d84fe39693f585a531 merged revision(s) commit:1870505f478cc75993b296b7144a45137ace6937.
-
02:19 AM Revision 50399eeb (git): merge revision(s) 1870505f478cc75993b296b7144a45137ace6937: [Backport #20651] [Backport #20571]
- Fix wrong unreachable chunk remove when jump destination label is unremovable
-
02:03 AM Bug #20654: Floor and ceil have unexpected behaviour when ndigits is large
- Thank you for preparing the backport PRs. They were merged.
-
01:52 AM Revision a8a25291 (git): merge revision(s) 97449338d6cb42d9dd7c9ca61550616e7e6b6ef6: [Backport #20649]
- [Bug #20649] Allow `nil` as 2nd argument of `assign_error`
Fallback to the last token element in that case, for the backward
compatibilities.
08/17/2024
-
12:42 PM Bug #20667: Backport REXML CVE fixes
- ruby_3_2 commit:0f2f6b31aa6433fd800f0621b5bedbaf0da12a6f merged revision(s) commit:2a7da0b6e76929c684cd948630a897c1d5b16c26.
-
12:41 PM Revision 0f2f6b31 (git): merge revision(s) 2a7da0b6e76929c684cd948630a897c1d5b16c26: [Backport #20667]
- Update bundled gems list as of 2024-08-12
-
11:08 AM Bug #20681 (Feedback): Regular expression warnings are treated as compiler warnings during runtime
- I have some code that recieves arbitrary input and parses it as a regexp. To supress potential warnings I'm defining the `warn` method. Unfortunately it is not getting called:
```rb
def warn(...)
puts "CALLED"
end
source = "/\... - 10:36 AM Revision 4dbf386c (git): [DOC] Add `$;` to the list of deprecated global variables
-
09:57 AM Bug #20680 (Closed): No "void context" warning for literals/etc. in ensure block
- Providing this code, I would expect ruby to emit a void context warning:
```rb
begin
foo
rescue
bar
ensure
42
end
```
`ensure` blocks don't return a value unless `return` is used explicitly. Am I right in my assumptio... - 07:00 AM Revision 694181a9 (git): Update bundled gems list as of 2024-08-16
-
12:59 AM Bug #20679: Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- Reverted in commit:d56470a27c5a8a2e7aee7a76cea445c2d29c0c59
Here's a failing example that does not require Rails:
```ruby
class A
def self.get(uri, params = {}, env = {}, &block)
env['HTTPS']
end
ruby2_keywords ... -
12:59 AM Revision d56470a2 (git): Revert "Avoid hash allocation for certain proc calls"
- This reverts commit abc04e898b627ab37fa9dd5e330f239768778d8b.
This caused problems in a Rails test.
08/16/2024
-
11:46 PM Bug #20679: Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- Thanks for the report. I will revert and then try to work on a fix.
-
11:08 PM Bug #20679 (Closed): Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- Rails CI against Ruby master branch gets failed since abc04e898b627ab37fa9dd5e330f239768778d8b
### Steps to reproduce
```
git clone https://github.com/rails/rails
cd rails/railties
bundle install
bin/test test/application/rende... -
09:59 PM Bug #20586: Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted
- I've submitted a pull request that I hope will address most of these issues: https://github.com/ruby/ruby/pull/11393
It adds error checking for `readdir`, `telldir`, and `closedir` calls in `dir.c`.
The `closedir` check caught an a... -
08:12 PM Revision 2fe6a4f8 (git): Fix assertion error when TracePoint has incompatible events
- TracePoints with incompatible events (i.e. events not in ISEQ_TRACE_EVENTS)
with a method target will fail an assertion error because it does not
filter for the supported events. For example, the following lines will
cause an assertion e... -
08:11 PM Revision 77ac853c (git): [DOC] Tweaks to Array#assoc (#11384)
- 05:10 PM Revision 1917c8c8 (git): [ruby/openssl] Remove test_ed25519_not_approved_on_fips.
- This commit fixes the following failure on OpenSSL master FIPS case.
```
1) Failure: test_ed25519_not_approved_on_fips(OpenSSL::TestPKey): OpenSSL::PKey::PKeyError expected but nothing was raised.
/home/runner/work/openssl/openssl/vendo... -
04:01 PM Bug #20623 (Closed): Unexpected behavior of blocks in Enumerator::Lazy#zip
-
01:26 PM Revision bbbe07a5 (git): Speed up finalizers for objects without object ID
- If the object being finalized does not have an object ID, then we don't
need to insert into the object ID table, we can simply just allocate a
new object ID by bumping the next_object_id counter. This speeds up
finalization for objects t... -
12:52 PM Bug #20675: Parse error with required kwargs and omitted parens
- > for `f k:<newline>val`, I found about 500 cases.
Thank you for searching. That's a lot more than I was able to find in my 950 sample gems, and with such a number I would vote to not change anything.
-
08:43 AM Bug #20675: Parse error with required kwargs and omitted parens
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> I believe Matz was talking about changing the behavior of `f k:<newline>`, so method definition `def foo k:<newline>` would remain the same.
> ...
for `f k:<newline>val`, I found about 500 c... - 08:42 AM Revision 703305bd (git): Revert soname changes
- - only i386-ucrt soname is changed to fix building on x86 clang
- fix detection of x86intrin.h on x86 system
- mingw does not have LIBRUBY_SONAME -
07:55 AM Revision 21dfe34a (git): Stringize VM_ASSERT expression before expansion
-
06:43 AM Revision 196d59f6 (git): Parenthesize macro arguments
-
06:43 AM Revision 129b4936 (git): Simplify and clarify bitmask calculation
- 06:09 AM Revision 08db4bc6 (git): [ruby/openssl] test_s_generate_parameters: Consider a DSA error in FIPS.
- DSA kengen is not FIPS-approved. The `EVP_PKEY_paramgen` in the
`OpenSSL::PKey.generate_parameters("DSA")` raises a DSA error in FIPS by the
following commit. Split the test for DSA.
https://github.com/openssl/openssl/commit/49a35f0#dif... - 05:51 AM Revision 018bd07f (git): Fix some warnings
- * Fix unused functions when no `mmap`.
```
shape.c:285:1: warning: unused function 'redblack_insert' [-Wunused-function]
285 | redblack_insert(redblack_node_t * tree, ID key, rb_shape_t * value)
| ^~~~~~~~~~~~~~~
```
... -
12:47 AM Revision c06fbb19 (git): Fix flaky TestSetTraceFunc#test_remove_in_trace by filtering trace events
08/15/2024
-
10:12 PM Bug #20675: Parse error with required kwargs and omitted parens
- The reason for this inconsistency is backwards compatibility, so as not to break existing code when omitted hash value support was added in Ruby 3.1.
There is historical precedence for breaking backwards compatibility for a very simil... -
04:04 PM Bug #20675: Parse error with required kwargs and omitted parens
- I believe Matz was talking about changing the behavior of `f k:<newline>`, so method definition `def foo k:<newline>` would remain the same.
Although `f k:<newline>expr` would be incompatible, what about `f(k:<newline>expr)` ?
-
02:16 AM Bug #20675: Parse error with required kwargs and omitted parens
- This change is compatibility issue and I counted the number of `def foo k:<newline>` patterns and I found about 4000 cases in recent gems.
https://gist.github.com/ko1/cd46d87c40df6896f2c885094133bf88 -
08:00 PM Revision abc04e89 (git): Avoid hash allocation for certain proc calls
- Previous, proc calls such as:
```ruby
proc{|| }.(**empty_hash)
proc{|b: 1| }.(**r2k_array_with_empty_hash)
```
both allocated hashes unnecessarily, due to two separate code paths.
The first call goes through CALLER_SETUP_ARG/vm_caller... -
06:33 PM Revision 2c6e16eb (git): Don't assume st_data_t and VALUE are the same in rb_gc_impl_object_id
-
05:34 PM Revision de28ef7d (git): [PRISM] Use src encoding not ext encoding
-
05:34 PM Revision eb08a280 (git): [PRISM] test_invalid_jump assertion updates for prism
-
05:34 PM Revision a402b18c (git): [PRISM] test_syntax_check assertion updates for prism
-
04:59 PM Revision 2d66ef71 (git): Show anonymous and ambiguous params in ISeq disassembly
- Previously, in the disasesmbly for ISeqs, there's no way to know if the
anon_rest, anon_kwrest, or ambiguous_param0 flags are set. This commit
extends the names of the rest, kwrest, and lead params to display this
information. They are r... -
04:52 PM Revision 33bffde9 (git): [DOC] Tweaks for Array#at
-
04:50 PM Revision 5cb6954b (git): [ruby/prism] Fix up lex result constants
- https://github.com/ruby/prism/commit/084baca463
-
04:49 PM Revision d2361ba1 (git): [DOC] Tweaks for Array#push
-
04:48 PM Revision edda29a1 (git): [DOC] Fix Related for Array#all?
-
04:46 PM Revision 1f994683 (git): [DOC] Tweaks for Array#any?
-
04:40 PM Revision cbf508da (git): [ruby/prism] Special error for too short unicode errors
- https://github.com/ruby/prism/commit/9f1f7d08bd
-
02:38 PM Revision 8312c5be (git): Fix GC_ASSERT for gc.c and gc/default.c
- gc.c mistakenly defined GC_ASSERT as blank, which caused it to be a
no-op. This caused all assertions in gc.c and gc/default.c to not do
anything. This commit fixes it by moving the definition of GC_ASSERT
to gc/gc.h. -
01:33 PM Revision 923e36ab (git): [ruby/rdoc] Fix sidebar scroll again and add missing footer back
- (https://github.com/ruby/rdoc/pull/1154)
* Add missing footers
In #1152 the footer partial was only added to the index.rhtml file.
This commit adds the footer partial to the other template files.
* Remove unnecessary middle divs in na... -
10:11 AM Bug #20678 (Closed): Doxygen document doesn't print Ruby C APIs properly
-
10:11 AM Bug #20678: Doxygen document doesn't print Ruby C APIs properly
- Ufuk, thank you for info!
I found the document about the `rb_scan_args` (`ruby_doxygen_rb_scan_args.png`) by clicking "Modules" (`doc/capi/html/modules.html`) - "Defining methods" on my environment.
And it's nice to see the online do... -
10:04 AM Bug #20678: Doxygen document doesn't print Ruby C APIs properly
- I believe it is being generated. Probably not where you expect it to be, though: https://docs.ruby-lang.org/capi/en/master/d7/d19/group__defmethod.html#gaa7bed88640f01bee619f85fda09d28d7
Btw, since https://bugs.ruby-lang.org/issues/20... -
09:53 AM Bug #20678 (Closed): Doxygen document doesn't print Ruby C APIs properly
- I am looking for how to see a list of Ruby C API descriptions written in the comment area by a command.
For example, in the case of the `rb_scan_args`, the description is below.
https://github.com/ruby/ruby/blob/908305a2977856264a932... - 08:16 AM Revision 2a933609 (git): Delete unnecessary rubocop disable comment
-
06:55 AM Revision 8a7e6f68 (git): Improve base time of assert_linear_performance (#11369)
- Remove `.ceil` from base time calculation that makes 10x gap.
This will make the assertion more strict and also less flaky. - 03:09 AM Revision a1d8ef6e (git): Bump github/codeql-action from 3.26.1 to 3.26.2
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.1 to 3.26.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
01:14 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- Ah. I might have to add some feature detection to the configure script for this when deciding if BTI/PAC is available.
Can you tell me, does it work if you compile with `ASFLAGS=-fno-integrated-as`?
08/14/2024
-
08:23 PM Revision fd974f5d (git): Increase timeout of test_finalizer
- The test is timing out on lpi4a so a longer timeout should fix it.
-
08:16 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- byroot (Jean Boussier) wrote in #note-36:
> As for the API, my two cents is that it would make the most sense in `Process`. e.g. `Process.argv`, such as:
I don't mind using "Process", but the "argv" name is really ambiguous. For the ... -
07:39 PM Revision 09bf3c9d (git): [PRISM] Trigger moreswitches off shebang
-
07:27 PM Bug #20675: Parse error with required kwargs and omitted parens
- I agree that `f k:` at end of line should be parsed as `f(k:)`. Even though it is backward incompatible, it can be detected statically, so the migration path is easy. Ruby 3.4 could output a deprecation warning at parse time. We could ha...
-
06:06 PM Revision 002e785e (git): [ruby/irb] Fix kill pager pid throwing Errno::ESRCH when pager
- process already terminated
(https://github.com/ruby/irb/pull/989)
https://github.com/ruby/irb/commit/949f032e9b -
05:49 PM Revision 0610f1b0 (git): Fix crash when GC runs during finalizers at shutdown
- We need to remove from the finalizer_table after running all the
finalizers because GC could trigger during the finalizer which could
reclaim the finalizer table array.
The following code crashes:
1_000_000.times do
o = Objec... -
05:47 PM Revision 85f99b38 (git): [DOC] Tweaks to Array#all? (#11365)
-
05:40 PM Revision a952ea24 (git): [ruby/prism] Callback on shebang switches
- Add the ability to receive a callback when the parser encounters a
shebang that contains additional switches after the Ruby engine.
This is necessary because some command-line flags may be present
there that will alter the parse.
https:... -
05:19 PM Revision 66312ad9 (git): Re-initialize vm->ractor.sched.lock after fork (#11372)
- [Bug #20633] Re-initialize vm->ractor.sched.lock after fork
Previously under certain conditions it was possible to encounter a
deadlock in the forked child process if ractor.sched.lock was held.
Co-authored-by: Nathan Froyd <froydnj@gm... -
04:35 PM Feature #20676: Pathnames aren't Comparable
- It looks like I got it wrong. `<=>` does case-sensitive matching and doesn't behave the way I thought it did. Generally, I agree `Pathname#inside?(path)` would be a good addition that addresses my concern.
Thank you! -
01:48 PM Feature #20676: Pathnames aren't Comparable
- > I think we should add Pathname#start_with?(path) for convenience, or maybe Pathname#inside?(path).
Yes, having methods to check if a path is a child or parent of the other would be very convenient. Should be opened as a new feature ... -
01:20 PM Feature #20676: Pathnames aren't Comparable
- I think we should add `Pathname#start_with?(path)` for convenience, or maybe `Pathname#inside?(path)`.
FWIW it already exists in my `path` gem: https://github.com/eregon/path/blob/a5e1d4d35a66466cfe8ab201f67982916cbbe845/lib/path.rb#L91... -
12:59 PM Feature #20676: Pathnames aren't Comparable
- Hanmac (Hans Mackowiak) wrote in #note-4:
> nobu (Nobuyoshi Nakada) wrote in #note-2:
> ...
It doesn't, at least not in the way the original poster asked for or as @nobu suggested. This is clear from @byroot's [example above](https://b... -
12:50 PM Feature #20676: Pathnames aren't Comparable
- nobu (Nobuyoshi Nakada) wrote in #note-2:
> Probably you may want to do:
> ...
Pathname class already has this kind of logic in the `<=>` function
it just doesn't include the `Comparable` module to add the other compare functions li... -
12:01 PM Feature #20676 (Feedback): Pathnames aren't Comparable
-
11:56 AM Feature #20676: Pathnames aren't Comparable
- Probably you may want to do:
```ruby
(Pathname("/a/b/c").to_s+"/").start_with?(Pathname("/a/b").to_s+"/")
``` -
08:00 AM Feature #20676: Pathnames aren't Comparable
- > to check if pathnames are subdirectories of each other
I don't understand.
```ruby
> ...
=> true
>> Pathname("/a/b").to_s <= Pathname("/a/c").to_s
=> true
```
`<=` doesn't tell you the right hand-side is a subdirectory of... -
04:28 PM Revision 88954a0e (git): [ruby/prism] Tweak inspect representation of `Prism::Location`
- This PR tweaks inspect representation of `Prism::Location`.
## Before
During debugging, the meaning of `@location=https://github.com/ruby/prism/commit/21474836481` was unclear:
```console
$ ruby -Ilib -rprism -e 'p Prism.lex("puts :hi... -
02:51 PM Revision 264175db (git): [DOC] Update comment about how object ID is calculated
- The object ID no longer treats symbols in a special way so we can simplify
the comment about how it is calculated. -
08:41 AM Misc #20661: Stop retrying tests in `make test-all` command by default
- I add some background.
As a result of the introduction of Launchable (#20254), it was discovered that many test failures were being unintentionally masked by automatic retry. Many were test-side problems, such as timeouts, but some we... - 07:01 AM Revision d0954741 (git): Update bundled gems list as of 2024-08-14
-
05:48 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- @kjtsanaktsidis Could you take a look?
-
04:32 AM Bug #20677 (Closed): error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- ruby (the development version as of 2024-08-11) does not build on macOS 11 or earlier with Apple Clang 1300 or earlier:
```
coroutine/amd64/Context.S:74:14: error: mach-o section specifier requires a segment whose length is between... -
04:06 AM Revision f2f177ed (git): [ruby/irb] Improve easter_egg logo resolution
- (https://github.com/ruby/irb/pull/987)
https://github.com/ruby/irb/commit/ab394db93f -
03:24 AM Revision e7046f1f (git): Increase the default timeout in assert_darwin_vm_dump_works
- 03:14 AM Revision 983d91cf (git): Bump github/codeql-action from 3.26.0 to 3.26.1
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md...