Activity
From 08/11/2024 to 08/17/2024
08/17/2024
-
12:42 PM Bug #20667: Backport REXML CVE fixes
- ruby_3_2 commit:0f2f6b31aa6433fd800f0621b5bedbaf0da12a6f merged revision(s) commit:2a7da0b6e76929c684cd948630a897c1d5b16c26.
-
- Update bundled gems list as of 2024-08-12
-
11:08 AM Bug #20681 (Feedback): Regular expression warnings are treated as compiler warnings during runtime
- I have some code that recieves arbitrary input and parses it as a regexp. To supress potential warnings I'm defining the `warn` method. Unfortunately it is not getting called:
```rb
def warn(...)
puts "CALLED"
end
source = "/\... - 10:36 AM Revision 4dbf386c (git): [DOC] Add `$;` to the list of deprecated global variables
-
- Providing this code, I would expect ruby to emit a void context warning:
```rb
begin
foo
rescue
bar
ensure
42
end
```
`ensure` blocks don't return a value unless `return` is used explicitly. Am I right in my assumptio... - 07:00 AM Revision 694181a9 (git): Update bundled gems list as of 2024-08-16
-
12:59 AM Bug #20679: Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- Reverted in commit:d56470a27c5a8a2e7aee7a76cea445c2d29c0c59
Here's a failing example that does not require Rails:
```ruby
class A
def self.get(uri, params = {}, env = {}, &block)
env['HTTPS']
end
ruby2_keywords ... -
12:59 AM Revision d56470a2 (git): Revert "Avoid hash allocation for certain proc calls"
- This reverts commit abc04e898b627ab37fa9dd5e330f239768778d8b.
This caused problems in a Rails test.
08/16/2024
-
- Thanks for the report. I will revert and then try to work on a fix.
-
11:08 PM Bug #20679 (Closed): Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b
- Rails CI against Ruby master branch gets failed since abc04e898b627ab37fa9dd5e330f239768778d8b
### Steps to reproduce
```
git clone https://github.com/rails/rails
cd rails/railties
bundle install
bin/test test/application/rende... -
- I've submitted a pull request that I hope will address most of these issues: https://github.com/ruby/ruby/pull/11393
It adds error checking for `readdir`, `telldir`, and `closedir` calls in `dir.c`.
The `closedir` check caught an a... -
08:12 PM Revision 2fe6a4f8 (git): Fix assertion error when TracePoint has incompatible events
- TracePoints with incompatible events (i.e. events not in ISEQ_TRACE_EVENTS)
with a method target will fail an assertion error because it does not
filter for the supported events. For example, the following lines will
cause an assertion e... -
08:11 PM Revision 77ac853c (git): [DOC] Tweaks to Array#assoc (#11384)
- 05:10 PM Revision 1917c8c8 (git): [ruby/openssl] Remove test_ed25519_not_approved_on_fips.
- This commit fixes the following failure on OpenSSL master FIPS case.
```
1) Failure: test_ed25519_not_approved_on_fips(OpenSSL::TestPKey): OpenSSL::PKey::PKeyError expected but nothing was raised.
/home/runner/work/openssl/openssl/vendo... -
-
- If the object being finalized does not have an object ID, then we don't
need to insert into the object ID table, we can simply just allocate a
new object ID by bumping the next_object_id counter. This speeds up
finalization for objects t... -
12:52 PM Bug #20675: Parse error with required kwargs and omitted parens
- > for `f k:<newline>val`, I found about 500 cases.
Thank you for searching. That's a lot more than I was able to find in my 950 sample gems, and with such a number I would vote to not change anything.
-
08:43 AM Bug #20675: Parse error with required kwargs and omitted parens
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> I believe Matz was talking about changing the behavior of `f k:<newline>`, so method definition `def foo k:<newline>` would remain the same.
> ...
for `f k:<newline>val`, I found about 500 c... - 08:42 AM Revision 703305bd (git): Revert soname changes
- - only i386-ucrt soname is changed to fix building on x86 clang
- fix detection of x86intrin.h on x86 system
- mingw does not have LIBRUBY_SONAME -
07:55 AM Revision 21dfe34a (git): Stringize VM_ASSERT expression before expansion
-
-
- 06:09 AM Revision 08db4bc6 (git): [ruby/openssl] test_s_generate_parameters: Consider a DSA error in FIPS.
- DSA kengen is not FIPS-approved. The `EVP_PKEY_paramgen` in the
`OpenSSL::PKey.generate_parameters("DSA")` raises a DSA error in FIPS by the
following commit. Split the test for DSA.
https://github.com/openssl/openssl/commit/49a35f0#dif... - 05:51 AM Revision 018bd07f (git): Fix some warnings
- * Fix unused functions when no `mmap`.
```
shape.c:285:1: warning: unused function 'redblack_insert' [-Wunused-function]
285 | redblack_insert(redblack_node_t * tree, ID key, rb_shape_t * value)
| ^~~~~~~~~~~~~~~
```
... -
12:47 AM Revision c06fbb19 (git): Fix flaky TestSetTraceFunc#test_remove_in_trace by filtering trace events
08/15/2024
-
- The reason for this inconsistency is backwards compatibility, so as not to break existing code when omitted hash value support was added in Ruby 3.1.
There is historical precedence for breaking backwards compatibility for a very simil... -
- I believe Matz was talking about changing the behavior of `f k:<newline>`, so method definition `def foo k:<newline>` would remain the same.
Although `f k:<newline>expr` would be incompatible, what about `f(k:<newline>expr)` ?
-
- This change is compatibility issue and I counted the number of `def foo k:<newline>` patterns and I found about 4000 cases in recent gems.
https://gist.github.com/ko1/cd46d87c40df6896f2c885094133bf88 -
- Previous, proc calls such as:
```ruby
proc{|| }.(**empty_hash)
proc{|b: 1| }.(**r2k_array_with_empty_hash)
```
both allocated hashes unnecessarily, due to two separate code paths.
The first call goes through CALLER_SETUP_ARG/vm_caller... -
-
05:34 PM Revision de28ef7d (git): [PRISM] Use src encoding not ext encoding
-
-
-
- Previously, in the disasesmbly for ISeqs, there's no way to know if the
anon_rest, anon_kwrest, or ambiguous_param0 flags are set. This commit
extends the names of the rest, kwrest, and lead params to display this
information. They are r... -
-
- https://github.com/ruby/prism/commit/084baca463
-
-
-
-
- https://github.com/ruby/prism/commit/9f1f7d08bd
-
- gc.c mistakenly defined GC_ASSERT as blank, which caused it to be a
no-op. This caused all assertions in gc.c and gc/default.c to not do
anything. This commit fixes it by moving the definition of GC_ASSERT
to gc/gc.h. -
01:33 PM Revision 923e36ab (git): [ruby/rdoc] Fix sidebar scroll again and add missing footer back
- (https://github.com/ruby/rdoc/pull/1154)
* Add missing footers
In #1152 the footer partial was only added to the index.rhtml file.
This commit adds the footer partial to the other template files.
* Remove unnecessary middle divs in na... -
10:11 AM Bug #20678 (Closed): Doxygen document doesn't print Ruby C APIs properly
-
- Ufuk, thank you for info!
I found the document about the `rb_scan_args` (`ruby_doxygen_rb_scan_args.png`) by clicking "Modules" (`doc/capi/html/modules.html`) - "Defining methods" on my environment.
And it's nice to see the online do... -
10:04 AM Bug #20678: Doxygen document doesn't print Ruby C APIs properly
- I believe it is being generated. Probably not where you expect it to be, though: https://docs.ruby-lang.org/capi/en/master/d7/d19/group__defmethod.html#gaa7bed88640f01bee619f85fda09d28d7
Btw, since https://bugs.ruby-lang.org/issues/20... -
- I am looking for how to see a list of Ruby C API descriptions written in the comment area by a command.
For example, in the case of the `rb_scan_args`, the description is below.
https://github.com/ruby/ruby/blob/908305a2977856264a932... - 08:16 AM Revision 2a933609 (git): Delete unnecessary rubocop disable comment
-
06:55 AM Revision 8a7e6f68 (git): Improve base time of assert_linear_performance (#11369)
- Remove `.ceil` from base time calculation that makes 10x gap.
This will make the assertion more strict and also less flaky. - 03:09 AM Revision a1d8ef6e (git): Bump github/codeql-action from 3.26.1 to 3.26.2
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.1 to 3.26.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
01:14 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- Ah. I might have to add some feature detection to the configure script for this when deciding if BTI/PAC is available.
Can you tell me, does it work if you compile with `ASFLAGS=-fno-integrated-as`?
08/14/2024
-
- The test is timing out on lpi4a so a longer timeout should fix it.
-
- byroot (Jean Boussier) wrote in #note-36:
> As for the API, my two cents is that it would make the most sense in `Process`. e.g. `Process.argv`, such as:
I don't mind using "Process", but the "argv" name is really ambiguous. For the ... -
-
- I agree that `f k:` at end of line should be parsed as `f(k:)`. Even though it is backward incompatible, it can be detected statically, so the migration path is easy. Ruby 3.4 could output a deprecation warning at parse time. We could ha...
-
- process already terminated
(https://github.com/ruby/irb/pull/989)
https://github.com/ruby/irb/commit/949f032e9b -
- We need to remove from the finalizer_table after running all the
finalizers because GC could trigger during the finalizer which could
reclaim the finalizer table array.
The following code crashes:
1_000_000.times do
o = Objec... -
-
- Add the ability to receive a callback when the parser encounters a
shebang that contains additional switches after the Ruby engine.
This is necessary because some command-line flags may be present
there that will alter the parse.
https:... -
05:19 PM Revision 66312ad9 (git): Re-initialize vm->ractor.sched.lock after fork (#11372)
- [Bug #20633] Re-initialize vm->ractor.sched.lock after fork
Previously under certain conditions it was possible to encounter a
deadlock in the forked child process if ractor.sched.lock was held.
Co-authored-by: Nathan Froyd <froydnj@gm... -
04:35 PM Feature #20676: Pathnames aren't Comparable
- It looks like I got it wrong. `<=>` does case-sensitive matching and doesn't behave the way I thought it did. Generally, I agree `Pathname#inside?(path)` would be a good addition that addresses my concern.
Thank you! -
01:48 PM Feature #20676: Pathnames aren't Comparable
- > I think we should add Pathname#start_with?(path) for convenience, or maybe Pathname#inside?(path).
Yes, having methods to check if a path is a child or parent of the other would be very convenient. Should be opened as a new feature ... -
01:20 PM Feature #20676: Pathnames aren't Comparable
- I think we should add `Pathname#start_with?(path)` for convenience, or maybe `Pathname#inside?(path)`.
FWIW it already exists in my `path` gem: https://github.com/eregon/path/blob/a5e1d4d35a66466cfe8ab201f67982916cbbe845/lib/path.rb#L91... -
- Hanmac (Hans Mackowiak) wrote in #note-4:
> nobu (Nobuyoshi Nakada) wrote in #note-2:
> ...
It doesn't, at least not in the way the original poster asked for or as @nobu suggested. This is clear from @byroot's [example above](https://b... -
12:50 PM Feature #20676: Pathnames aren't Comparable
- nobu (Nobuyoshi Nakada) wrote in #note-2:
> Probably you may want to do:
> ...
Pathname class already has this kind of logic in the `<=>` function
it just doesn't include the `Comparable` module to add the other compare functions li... -
-
- Probably you may want to do:
```ruby
(Pathname("/a/b/c").to_s+"/").start_with?(Pathname("/a/b").to_s+"/")
``` -
- > to check if pathnames are subdirectories of each other
I don't understand.
```ruby
> ...
=> true
>> Pathname("/a/b").to_s <= Pathname("/a/c").to_s
=> true
```
`<=` doesn't tell you the right hand-side is a subdirectory of... -
04:28 PM Revision 88954a0e (git): [ruby/prism] Tweak inspect representation of `Prism::Location`
- This PR tweaks inspect representation of `Prism::Location`.
## Before
During debugging, the meaning of `@location=https://github.com/ruby/prism/commit/21474836481` was unclear:
```console
$ ruby -Ilib -rprism -e 'p Prism.lex("puts :hi... -
- The object ID no longer treats symbols in a special way so we can simplify
the comment about how it is calculated. -
08:41 AM Misc #20661: Stop retrying tests in `make test-all` command by default
- I add some background.
As a result of the introduction of Launchable (#20254), it was discovered that many test failures were being unintentionally masked by automatic retry. Many were test-side problems, such as timeouts, but some we... - 07:01 AM Revision d0954741 (git): Update bundled gems list as of 2024-08-14
-
- @kjtsanaktsidis Could you take a look?
-
04:32 AM Bug #20677 (Closed): error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- ruby (the development version as of 2024-08-11) does not build on macOS 11 or earlier with Apple Clang 1300 or earlier:
```
coroutine/amd64/Context.S:74:14: error: mach-o section specifier requires a segment whose length is between... -
- (https://github.com/ruby/irb/pull/987)
https://github.com/ruby/irb/commit/ab394db93f -
- 03:14 AM Revision 983d91cf (git): Bump github/codeql-action from 3.26.0 to 3.26.1
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md...
08/13/2024
-
11:13 PM Revision b20957bd (git): [ruby/resolv] test_dns: Fix failure on Windows
- (https://github.com/ruby/resolv/pull/58)
test_dns: Fix failure on Windows
1. Switch to #with_udp_and_tcp helper method for EACCES retries on Windows;
the given UDP socket is unnecessary though.
2. Using 127.0.0.1 should be fine, as ... -
- 👋
I was working with Pathnames recently and noticed that I could do:
```rb
Pathname("/a/b").to_s <= Pathname("/a/b/c").to_s
```
but could not do:
```rb
Pathname("/a/b") <= Pathname("/a/b/c")
```
to check if pathnames are sub... -
09:09 PM Revision 094e5336 (git): [ruby/resolv] Reuse open TCP connection
- [RFC7766] Section 5 recommends stub resolvers to reuse open TCP
connections to a nameserver.
[RFC7766]: https://datatracker.ietf.org/doc/html/rfc7766
https://github.com/ruby/resolv/commit/9bf1b08f5c -
09:09 PM Revision 4be9b72f (git): [ruby/resolv] Fix TCP fallback with multiple nameservers
- Under the following conditions the exception
`Resolv::DNS::Requester::RequestError: host/port don't match` is raised:
- Multiple nameservers are configured for Resolv::DNS
- A nameserver falls back from UDP to TCP
- TCP request hits Reso... -
08:56 PM Revision 525008cd (git): Delete newarraykwsplat
- The pushtoarraykwsplat instruction was designed to replace newarraykwsplat,
and we now meet the condition for deletion mentioned in
77c1233f79a0f96a081b70da533fbbde4f3037fa. -
- Fixed by https://github.com/ruby/ruby/commit/87a85550edd786665e081b355c6af62c4854b1d7
-
- We don't need to set the stack end in rb_gc_mark_roots because it is
already set in mark_current_machine_context. -
- Needs a bit of polish (e.g. doc and spec), but that's essentially what I think we should do: https://github.com/ruby/ruby/pull/11370
-
- It might make sense to split this ticket into two requests: one for `Process.argv` or similar and one for re-executing the current process with the same or additional flags (`Process.reexec`??). These seems like slightly different reques...
-
- As for the API, my two cents is that it would make the most sense in `Process`. e.g. `Process.argv`, such as:
```bash
$ ruby --yjit -e "p Process.argv"
["--yjit", "-e", "p Process.argv"]
```
So a self re-exec would be:
```rub... -
- This need came up again in https://github.com/rubygems/rubygems/pull/7933.
AFAICT there is currently no good way for a program to re-exec itself with all the same arguments. -
- Previously under certain conditions it was possible to encounter a
deadlock in the forked child process if ractor.sched.lock was held.
Co-authored-by: Nathan Froyd <froydnj@gmail.com> -
01:19 PM Bug #20675: Parse error with required kwargs and omitted parens
- I think this would be *great* and would *love* to use keyword parameters without parenthesis...but I don't know how complicated this would be for the parser (including backwards compatibility which Jeremy (Evans) has mentioned before). I...
-
02:12 AM Bug #20675 (Closed): Parse error with required kwargs and omitted parens
- As pointed out in https://github.com/mruby/mruby/issues/6268, keyword arguments without surrounding parens are a bit confusing, e.g.
```ruby
def foo arg:
123
end
```
is parsed as
```ruby
def foo(arg:)
123
end
```
... - 01:10 PM Revision 908305a2 (git): Sync rdoc
-
- https://github.com/ruby/prism/commit/50d79b734b
-
-
- ```ruby
require 'active_support'
require 'active_support/core_ext'
Time.zone = "Central Time (US & Canada)"
p Time.at(1728018000, in: Time.zone) #=> 2024-10-04 00:00:00 -0500
```
-
- `Time.zone=` method is not defined in Ruby itself, ~~probably defined by ActiveSupport~~, I don't know from where it comes.
So `Time.at` is not affected by it at all, and -4 would have come from your "TZ" environment variable or system ... -
-
- I'm curious about your use case.
For what purpose and how do you want to use it? -
- Matz accepted this idea so now I merged it.
-
- Some case it is difficult to know the calling method uses a block
or not with `send` on a general framework. So this patch stops
showing unused block warning on `send`.
example with test/unit:
```ruby
require 'test/unit'
class T < Tes... - 01:48 AM Revision eedf6c35 (git): Revert change of "mingw-ucrt" platform string
- ... of commit 00176cd40fe9f385231e9c20b956fc4a84d240b9.
The reverted change was made only for constistency, as discussed in
https://github.com/ruby/ruby/pull/11358#issuecomment-2282222369
But the platform string "mingw-ucrt" should n... -
08/12/2024
-
- https://github.com/ruby/prism/commit/7c9ca47ac5
-
04:18 PM Bug #20674 (Rejected): Time zone conversion issue Time.at
- `Time.at` converts the epoch time to the local time zone But there seems a weird case with Central Time (US & Canada)
where it convert it one hour earlier for example
take this timestamp 1728018000 when converted it to Central Time (US... -
- RUBY_TYPED_DEFAULT_FREE will only free the rand_loop_t, but it will cause
the buf to be leaked. This commit fixes the memory leak by implementing
a free function for the rand_loop_t type. -
- Applied in changeset commit:git|992596fb7af18a7f472589a607d0eb3fbb03b49a.
----------
Fix next inside block argument stack underflow
[Bug #20344]
Fix compile_next adding removable adjust label -
- [Bug #20344]
Fix compile_next adding removable adjust label - 07:01 AM Revision 2a7da0b6 (git): Update bundled gems list as of 2024-08-12
08/11/2024
-
- It just wastes memory.
-
09:58 AM Bug #20666: Segmentation fault instead of LoadError exception
- Did some minimising.
# Three sources:
## `extconf.rb`
> require 'mkmf'
> ...
## `good.cpp`
> #include <ruby.h>
> ...
## `load.rb`
> begin
> ...
# Result on Linux
`$ ruby extconf.rb; make; ruby -I. load.rb; echo $?`
> creating extconf.h
... -
- ```
../../.././include/ruby/internal/special_consts.h:349:36: error: conversion to ‘VALUE’ {aka ‘long unsigned int’} from ‘int’ may change the sign of the result [-Werror=sign-conversion]
349 | return RB_SPECIAL_CONST_P(obj) * RUBY... -