Activity
From 08/03/2024 to 08/09/2024
08/09/2024
-
08:28 PM Revision 7b7dde37 (git): [ruby/psych] Guard from memory leak in Psych::Emitter#start_document
- When an exception is raised, it can leak memory in `head`. There are two
places that can leak memory:
1. `Check_Type(tuple, T_ARRAY)` can leak memory if `tuple` is not an
array.
2. `StringValue(name)` and `StringValue(value)` if they... -
08:06 PM Revision 4e85b6b4 (git): rb_str_bytesplice: skip encoding check if encodings are the same
- If both strings have the same encoding, all this work is useless.
-
- If the string only contain single byte characters we can
skips all the costly checks. -
- `rb_enc_from_index` is a costly operation so it is worth avoiding
to call it for the common encodings.
Also in the case of UTF-8, it's more efficient to scan the
coderange if it is unknown that to fallback to the slower
algorithms. -
08:06 PM Bug #20670 (Closed): fork deadlocks in child process due to timer thread
- We've been seeing an occasional failure in the Rails CI related to a test which forks and I managed to reduce it to the following reproduction.
``` ruby
Thread.new do
loop { sleep 0.0001 }
end
1000.times do
pid = fork{}
... -
08:02 PM Revision 5a570421 (git): [DOC] Regexp.last_match returns `$~`, not `$!`
-
-
- https://github.com/ruby/psych/commit/64bfc308f8
-
- https://github.com/ruby/psych/commit/74a6b4d226
-
07:31 PM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- Isn't it fair to assume any Exception from calling `Marshal.load` is an error while de-marshaling the data?
I think it is.
If it's about `serializer.load(value)` and `serializer` not being always Marshal, that's easy to deal with: ju... -
- > We may be able to create a sub-class of class LoadError < ArgumentError but it fundamentally seems wrong to me (should really be a RuntimeError).
There's little way around it, lots of code today expects `ArgumentError`, if you start... -
07:27 AM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- Changed the proposal to be about one error class. Thanks, KJ!
-
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-1:
> I agree it might be nice if Marshal had its own error class like `MarshalError` or some such. However, I don't really see why we need to _differentiate_ between different kinds of unm... -
03:31 AM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- I agree it might be nice if Marshal had its own error class like `MarshalError` or some such. However, I don't really see why we need to _differentiate_ between different kinds of unmarshaling errors? Any one of these things from dalli (...
-
-
- https://github.com/ruby/psych/commit/e7d64c9848
-
-
08:31 AM Bug #20634: ruby uses 1/2 (7 out of 16) cores for 16 ractors with RUBY_MAX_CPU=16 environment variable set
- I just checked - the problem doesn't repro-es on HEAD (ruby 3.4.0dev (2024-08-09T03:16:23Z master f57167d338) [x86_64-linux])
Could you close it ? -
- It's not necessary for the GC implementation to call rb_gc_mark_roots
which calls back into the GC implementation's rb_gc_impl_objspace_mark. -
02:15 PM Bug #20663 (Rejected): Reading characters from IO does not recover gracefully from bad data pushed via IO#ungetc
-
01:47 PM Bug #20663: Reading characters from IO does not recover gracefully from bad data pushed via IO#ungetc
- After reviewing the sources, I see that this behavior is a consequence of how character conversion is handled. Fetching the next character always looks at an internal buffer for bytes to compose the character. When that buffer is empty...
-
- `STR_EMBED_P` uses `FL_TEST_RAW` meaning we already assume `str`
isn't an immediate, so we can use `FL_TEST_RAW` here too. -
- If we assume that most strings we modify are not frozen and
are independent, then we can optimize this case by replacing
multiple flag checks by a single mask check. -
01:13 PM Bug #20662: pack("g") completely discards any actual NaN value and always packs the same single-precision bytes for a NaN
- https://github.com/ruby/ruby/pull/11352
I'm uncertain that it is a nice idea to expose such internals of `Float` though. -
- Apologies I missed this - I just rebased the branch, I think it should be OK for a stable backport to 3.2.
-
- I have no objection to disabling automatic re-runs, but one thing:
> Just click the "Re-run jobs" button via the GitHub UI.
Is this available to people who aren't a member of the Ruby organisation on Github? I think it might not be... -
03:16 AM Revision f57167d3 (git): Increase timeout in `test_darwin_invalid_call` method
08/08/2024
-
11:13 PM Revision 77ffdfe7 (git): YJIT: Allow tracing fallback counters (#11347)
- * YJIT: Allow tracing fallback counters
* Update yjit.md about --yjit-trace-exits=counter -
08:09 PM Revision ec5436bc (git): [DOC] Tweaks for Array#[]= (#11329)
-
-
-
-
- 08:02 PM Revision 64a7b87e (git): Sync rdoc to fix master doc's display issue (#11345)
- Sync rdoc
This syncs changes made in https://github.com/ruby/rdoc/pull/1148, which
will fix https://docs.ruby-lang.org/en/master/'s display on certain screens. -
- YJIT currently uses the YJIT root object to mark objects during GC and
update references during compaction. This object otherwise serves no
purpose.
This commit changes it YJIT to be step when marking the GC root. This
saves some memory... -
- We're seeing a crash during shutdown in rb_gc_impl_objspace_free because
it's running lazy sweeping during shutdown. It appears that it's due to
`finalizing` being set, which causes GC to not be aborted and not
disabled which causes it t... -
11:30 AM Bug #20666: Segmentation fault instead of LoadError exception
- # Testing with `mkmf`
It is worse.
I build the extension in `Test` using `mkmf`.
Now both Ruby issue a Segmentation fault.
Ruby 3.1.6 and Ruby 3.2.5.
<br>
Using `-L<Ruby lib dir> -l<Ruby lib> <RbConfig::CONFIG["LIBS"]>`
Works with the ... -
- Make it possible to differentiate general non-marshal errors from failures to decode Marshal data using a specific exception class.
## Background
There are a variety of error conditions that can cause Marshal to fail, including bot... - 09:07 AM Revision 11f5dc61 (git): * 2024-08-08 [ci skip]
-
09:07 AM Revision 08ff38f8 (git): Added bootstrap job for release workflow for Ruby 3.1
-
-
-
-
- Like the following scenario with bootsnap, that frames are same or smaller than frame_to_skip(=3).
---
"/Users/hsbt/.local/share/rbenv/versions/3.3-dev/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'"
"/Users/... -
- The `2` skipped frames went out of sync and now it should be `3`.
Rather than just update the offset, we can implement a way that
is adaptative as long as all require decorators are also called require.
Also we should compute the corre... -
- This change didn't work with Ruby 3.3.
We should revert this to test bundled_gems.rb with Ruby 3.3. -
- This reverts commit c3becc3ba6c584fbeabd5182e304e61529235fe6.
-
- https://github.com/ruby/uri/commit/898b889811
-
- https://github.com/ruby/uri/commit/9997c1acee
08/07/2024
-
11:54 PM Revision 8d399391 (git): [ruby/rdoc] Use ascii chatacter in HTML file
- https://github.com/ruby/rdoc/commit/40a6690010
-
-
- 10:49 PM Revision 34715bdd (git): Tune codegen for rb_yield() calls landing in ISeqs
- Unlike in older revisions in the year, GCC 11 isn't inlining the call
to vm_push_frame() inside invoke_iseq_block_from_c() anymore. We do
want it to be inlined since rb_yield() speed is fairly important.
Logs from -fopt-info-optimized-in... -
- > Note: Perhaps we are building wrongly, or we might need changes in our source code due to changes in Ruby 3.2.5.
Does it crash if you build the extension using `mkmf`? It seems `mkmf` should pass a different set of build flags than ... -
-
- ~~source.zip added~~
To build shared library using MinGW-w64 ucrt64:
`g++ -c -std=c++20 import_fragments_wrap.cxx -I<Ruby dir> -I<Ruby arch dir>`
`g++ -shared -std=c++20 import_fragments_wrap.o -L<Ruby lib dir> -l<Ruby lib> <RbConfig::C... -
- I do add the new Ruby to the SWIG project testing.
If I would suspect it is a SWIG bug, I would not hesitate and report it there.
The same test works with older Ruby:
ruby 3.1.6p260 (2024-05-29 revision a777087be6) [x64-mingw-ucrt]
... -
- With big and complex native extensions like SWIG, the problem is probably not in Ruby itself. The reproducer you provide is also probably too large to expect volunteers to diagnose. Maybe you should report this to SWIG, or minimize the r...
-
- The problem was I add `-static-libstdc++ -static-libgcc` and `-lucrt` to the linking.
But once I removed and left only `-l<Ruby lib> <RbConfig::CONFIG["LIBS"]>` in linking.
All my tests passed smoothly.
Sometime Windows require some hac... -
-
- The following memory leak gets reported with RUBY_FREE_AT_EXIT and YJIT
enabled because the memory for yjit_root is never freed.
STACK OF 1 INSTANCE OF 'ROOT LEAK: <calloc in rb_gc_impl_calloc>':
11 dyld ... -
-
-
04:58 PM Feature #20621: Check libruby.so hardening by annocheck
- The libruby.so was added to the annocheck test by the PR <https://github.com/ruby/ruby/pull/11324>. I am not sure if we can close this ticket due to the PR.
By the way, if we add other so and *.o files to the test, it's better to fix ... - 04:51 PM Revision 53f3036b (git): tool/test-annocheck.sh: Refactor with double-quotes.
- 04:51 PM Revision aed468ae (git): CI: Run annocheck for libruby.so
- When building with the `--shared` option, most functionality is kept in
`libruby.so`. Therefore also run annocheck for `libruby.so`.
Use `ARG IN_DIR` to propagate multiple files into the container instead of
`ARG FILES` in the `Dockerfi... -
04:22 PM Feature #20594: A new String method to append bytes while preserving encoding
- No opinion on method name / API, but we've verified effectiveness of this optimization using our protobuf implementation and you can see the results [here](https://github.com/Shopify/protoboeuf/pull/116).
-
- For example, the following code leaks:
class MyRipper < Ripper
def initialize(src, &blk)
super(src)
@blk = blk
end
def warn(msg, *args) = @blk.call(msg)
end
$VERBOSE = true
def call_pa... - 03:30 AM Revision 60bbd9e4 (git): Bump github/codeql-action from 3.25.15 to 3.26.0
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.15 to 3.26.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.m... - 03:29 AM Revision d5447357 (git): Bump actions/upload-artifact from 4.3.5 to 4.3.6
- Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.5 to 4.3.6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/89ef40... -
- 01:51 AM Revision 3b6f1d18 (git): * 2024-08-07 [ci skip]
-
-
-
- `.bundle/specification/foo-x.y.z.gemspec` may be changed our toolchain
-
-
-
- This reverts commit 76c61c9993e59af0b4c400b44f169f4af99c3efa.
-
-
01:17 AM Revision 671f6e78 (git): Use 20min for parallel test worker timeout
-
08/06/2024
-
-
-
-
-
-
-
-
05:41 PM Bug #20668 (Closed): [3.3] shareable_constant_value: literal crash - Applied in changeset commit:git|65cca99b30c65d462aa67969e0f16f6e45db4705.
----------
parse.y: const_decl_path don't replace destination node by a literal (#11314)
[Bug #20668]
The `dest` node is assumed to be a `CDECL`, so overwriting... -
- I believe I found a fix: https://github.com/ruby/ruby/pull/11314
cc @k0kubun -
-
- 05:34 PM Revision 65cca99b (git): parse.y: const_decl_path don't replace destination node by a literal (#11314)
- [Bug #20668]
The `dest` node is assumed to be a `CDECL`, so overwriting it with
a `LIT` cause a crash on the next iteration.
Co-authored-by: Jean Boussier <jean.boussier@gmail.com> -
02:47 PM Feature #17166: net/http not supporting unix domain sockets
- Then build it. If it’s as widely used as you say, the PR is sure to be accepted.
-
02:24 PM Feature #17166: net/http not supporting unix domain sockets
- That's simply wrong.
Several widely used apps offer their REST API over unix domain sockets for security reasons, e.g. LXD, snapd, docker, podman, which are just four of the most commonly used applications in the Linux world.
How ... -
- No it means it's a very fringe use case and nobody with that use case (including you) bothered to work on it.
It's extremely rare to use HTTP over unix sockets, and even very popular HTTP libraries for very popular languages like Pyth... -
- For example, the following code leaks:
class MyRipper < Ripper
def initialize(src, &blk)
super(src)
@blk = blk
end
def warn(msg, *args) = @blk.call(msg)
end
$VERBOSE = true
def call_pa... -
- > The name is `String#append_as_bytes`, and the name provides a framing of "reinterpretation" that helps to explain the behavior of the method.
I like that name, I think it clears out any possible confusion.
> ...
I retired the `*o... -
-
-
- This reverts commit 0cc98ae353fd231bcd0e704c251198abc4406247.
-
- This reverts commit 367ad5055c3d5210c884d4611e08ffa32ec608ee.
-
-
-
- `.bundle/specification/foo-x.y.z.gemspec` may be changed our toolchain
-
-
-
- This reverts commit 65ab2c1ef23bd4a02120a27c371dce12ea9024d4.
-
-
-
- (https://github.com/ruby/uri/pull/113)
* Fallback missing constants with RFC3986_PARSER
* raise missing constant
* Update test/uri/test_common.rb
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
* Update lib/uri/common.rb
Co-a... -
-
06:38 AM Revision 65e3717d (git): [ruby/openssl] test/openssl/test_pkey_dsa.rb: skip all tests in FIPS mode
- OpenSSL running in the FIPS mode will stop supporting DSA key
generation and signature generation due to a FIPS 140-3 requirement.
Although it appears that FIPS 186-5 still allows signature
verification in some cases, there would be litt... -
08/05/2024
-
05:28 PM Revision 3005ed68 (git): [rubygems/rubygems] Don't remove existing platform gems when PLATFORMS section is badly indented
- https://github.com/rubygems/rubygems/commit/ec099ebf1e
-
- https://github.com/rubygems/rubygems/commit/eec6830c04
-
- https://github.com/rubygems/rubygems/commit/d8cf4aa0cd
-
- https://github.com/rubygems/rubygems/commit/651cf3ea7a
- 05:26 PM Revision 2985770b (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.99 to 0.9.100.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.99...v0.9.100)
---
updated-depen... - 05:25 PM Revision 312a87cd (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.98 to 0.9.100.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.98...v0.9.100)
---
updated-depen... -
- (https://github.com/ruby/reline/pull/732)
Hash#inspect is proposed to change to {key: value, non_symbol_key => value} in https://bugs.ruby-lang.org/issues/20433#note-10
https://github.com/ruby/reline/commit/1fd73b358a -
-
08:27 AM Bug #20667 (Closed): Backport REXML CVE fixes
- It would be nice to have the recent REXML CVE fixes backported everywhere.
BTW it is surprising that REXML was recently bumped in 3.1 / 3.2 branches, but 3.3 branch stays with older REXML 3.2. -
- The following test script crashes in the parser:
```ruby
# shareable_constant_value: literal
FORM_STRATEGIES = {
'product' => Object,
'storefront_password' => String,
'contact' => Class,
}
```
The entire 3.3.x series... - 08:15 AM Revision 9d86864a (git): [ruby/uri] Add space after `bad URI`
- https://github.com/ruby/uri/commit/9f2c7ed5f2
-
- https://github.com/ruby/uri/commit/28af4e155a
-
-
- 03:28 AM Revision f4a23d96 (git): Bump actions/upload-artifact from 4.3.4 to 4.3.5
- Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.3.5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/0b2256... -
- When resolving on truffleruby, and multiple platforms are included in
the lockfile, Bundler will not respect existing platforms, but always
force ruby variants. That means removal of existing version specific
variants, introducing lockfi... -
02:28 AM Revision a35d3248 (git): [ruby/optparse] Fix parsing array arguments with `:into` option
- https://github.com/ruby/optparse/commit/19700e96d8
-
- Maybe https://github.com/ruby/setup-ruby/ helps you?
- 12:27 AM Revision cbc40bb1 (git): Sync rdoc
08/04/2024
-
- Now this is almost four years old without any reaction at all.
Has anyone ever taken any notice of this problem, which affects a lot of people which are those REST API frameworks? Or is ruby dead, and it's time to find a new language... -
- Using ruby -v
ruby 3.2.5 (2024-07-26 revision 31d0f1a2e7) [x64-mingw-ucrt]
From [GitHub windows 2022](https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md
)
We run the SWIG test:
[import_fragme... -
- I manage to run Ruby version 3.1.6 with MinGW-w64 UCRT.
I have a crash with 3.2.5, which I will investigate.
This bug can be closed!
Erez -
- Hi,
I try to add SWIG project testing with already installed Ruby on [GitHub Windows2022](https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md).
I manage to test with Ruby version 3.0.7 and instal... -
03:59 PM Bug #20662: pack("g") completely discards any actual NaN value and always packs the same single-precision bytes for a NaN
- > cabo (Carsten Bormann) wrote:
> ...
Right. The only interface Ruby provides to NaN values is via pack/unpack.
>> - `pack("g")` completely discards any actual NaN value and always packs the same bytes for a NaN
> ...
Indeed.
Th... - 02:53 PM Revision 7d5cb457 (git): [ruby/irb] Remove Ruby version checks
- (https://github.com/ruby/irb/pull/985)
https://github.com/ruby/irb/commit/9ce6972e71
08/03/2024
-
06:39 PM Feature #20664: Add `before` and `until` options to Enumerator.produce
- These options should take callables in this proposal. Procs and Methods certainly meet the condition: "Any value that responds to to_proc and returns a Proc object is accepted in these options".
The implementation does not bother to ca... -
- This proposal is based on the potential use cases I have experienced over the years. I've rarely seen a need for infinite sequences that can be defined with produce, and that is why I want to give produce() a feature-complete constructo...
-
05:31 PM Feature #20664: Add `before` and `until` options to Enumerator.produce
- I am not sure about this API.
I think in language core there aren’t many APIs that accept just a symbol of a necessary method (only `reduce(:+)` comes to mind, and I am still not sure why this form exists, because it seems to have be... -
- Enumerator.produce provides a nice way to generate an infinite sequence but is a bit awkward to define how to end a sequence. It lacks a simple and easy way to produce typical finite sequences in an intuitive syntax.
This proposal at... -
- cabo (Carsten Bormann) wrote:
> pack("G")/unpack("G") works great with NaN values. However,
First, Ruby provides only `Float::NAN`, and does not consider payloads of NaN values.
> ...
Since `"G"` preserves the payload, it may be better... -
- 07:01 AM Revision 657f4b99 (git): Update bundled gems list as of 2024-08-02
-
- The parallel testing framework may create strings in a separate thread.
```
1) Failure:
TestStringMemory#test_byteslice_prefix [D:/a/ruby/ruby/src/test/ruby/test_string_memory.rb:40]:
One object allocation is expected, but alloc... -
- If bytes that result in at least 2 invalid characters for the internal encoding of an IO object are pushed into the internal buffer with IO#getc, reading from the stream returns invalid characters composed of both bytes from the internal...
-