Activity
From 06/06/2024 to 06/12/2024
06/12/2024
-
08:16 PM Misc #20568 (Rejected): Look for test.rb in the current working directory
- Closing as per discussion in https://github.com/ruby/ruby/pull/10950
-
08:12 PM Bug #20577 (Closed): FREE_AT_EXIT segfaulting after 32683aa1
- Applied in changeset commit:git|7c46aa5ed4573ca04e6ffe1b19191e8227db2ab3.
----------
[Bug #20577] Fix freeing symbols when RUBY_FREE_AT_EXIT
Dynamic symbols point to a fstring. When we free the symbol, we hash the
fstring to remove it ... -
- I was able to reproduce this on nokogiri and prism test suites. I have a fix here: https://github.com/ruby/ruby/pull/10984
-
03:27 PM Bug #20577: FREE_AT_EXIT segfaulting after 32683aa1
- I can also reproduce this by running ruby_memcheck's tests with ruby master.
-
- @peterzhu2118 If it's helpful, the Nokogiri ruby-head CI jobs (run with ruby_memcheck) fail reliably:
- https://github.com/sparklemotion/nokogiri/actions/runs/9478882126/job/26116229709
- https://github.com/sparklemotion/nokogiri/act... -
- Thanks for the report, Mike! I tried to reproduce this but I haven't been able to:
```
$ RUBY_FREE_AT_EXIT=1 bundle exec valgrind ruby -e 'puts RUBY_DESCRIPTION'
warning: Free at exit is experimental and may be unstable
==22116== M... -
- One more note: I can't reliably reproduce this without `bundle exec`, but the project directory does not have a Gemfile and in case it's relevant here's my `bundle env`:
## Environment
```
Bundler 2.6.0.dev
Platforms ru... -
- After commit 32683aa1 on master, using `RUBY_FREE_AT_EXIT` results in a segfault. When run with valgrind, many invalid reads are reported.
Repro with
```
RUBY_FREE_AT_EXIT=1 bundle exec /path/to/ruby -e 'puts RUBY_DESCRIPTION'
``... -
- Dynamic symbols point to a fstring. When we free the symbol, we hash the
fstring to remove it from the table. However, the fstring could have
already been freed, which can cause a crash.
This commit changes it to remove the reference to... -
07:17 PM Revision 94a8f05f (git): [rubygems/rubygems] Fix test description
- https://github.com/rubygems/rubygems/commit/4bcdb854a2
-
06:57 PM Revision c81360db (git): Kernel#warn: don't call `Warning.warn` unless the category is enabled
- [Bug #20573]
Followup: https://github.com/ruby/ruby/pull/10960
I believe `Kernel#warn` should behave in the same way than internal
`rb_warning_* APIs -
05:33 PM Revision ce06924a (git): YJIT: add context cache hits stat (#10979)
- * YJIT: add context cache hits stat
This stat should make more sense when it comes to interpreting
the effectiveness of the cache on large deployed apps. -
05:25 PM Revision 85190d41 (git): Add regression test for Bug #20573
- Just a regression test to ensure behavior remains the same
-
04:57 PM Revision 783eaf70 (git): [ruby/irb] Invalid encoding symbol now raises SyntaxError also in
- 3.3
(https://github.com/ruby/irb/pull/969)
https://github.com/ruby/irb/commit/bad7492ab0 -
04:09 PM Revision 96974c6c (git): Simplify GC bitmap access macros
- Now that we're using the inline predicate functions everywhere, the only
remaining use of the RVALUE_?_BITMAP macros is inside their respective
inline function, so we can remove them. -
-
-
-
-
- 02:24 PM Revision 22ad7d72 (git): Update default gems list at 006ff5e29f596a4deb781c733f4f7b [ci skip]
-
02:23 PM Revision 006ff5e2 (git): [ruby/reline] Bump version to 0.5.9
- (https://github.com/ruby/reline/pull/724)
https://github.com/ruby/reline/commit/aff1d852bb -
- This function loops twice through the array of size pools. Once to set
up the pages list, and then again later on in the function to set the
allocatable_pages count.
We don't do anything with the size pools in between the invocation of
... -
12:46 PM Revision 6b6fd162 (git): [rubygems/rubygems] Fix typo
- https://github.com/rubygems/rubygems/commit/19a0e3730c
-
11:46 AM Bug #20572 (Closed): Compilation hangs with nested until
- Applied in changeset commit:git|32a555ea532fb15721ad403e6dce0a2ffc346f12.
----------
[Bug #20572] Abandon if replacing destination is the same -
-
10:42 AM Revision 278a7cb0 (git): [DOC] Fix a typo in dir.c
- s/Retruns/Returns/
-
10:17 AM Feature #20576: Add MatchData#bytebegin and MatchData#byteend
- Does this difference matter in realistic usages (e.g. that net-imap one)? How much improvement is it there?
Regarding naming, `byteend` seems hard to read, I think `byte_begin`/`byte_end` is much clearer. -
03:24 AM Feature #20576 (Closed): Add MatchData#bytebegin and MatchData#byteend
- I'd like to propose MatchData#bytebegin and MatchData#byteend.
These methods are similar to MatchData#begin and MatchData#end, but returns offsets in bytes instead of codepoints.
Pull request: https://github.com/ruby/ruby/pull/10973
... -
- Given it's a bug fix I think we should mark it for backport. But of course it's up to branch maintainers to decide whether the fix is worth backporting.
-
- (https://github.com/ruby/irb/pull/968)
https://github.com/ruby/irb/commit/905184ff9c -
- s/sepcifier/specifier/
-
06:36 AM Revision 1fc07637 (git): Introduce `ident_or_const` inline rule
-
- Applied in changeset commit:git|01b13886dc96eb13688d448019a8699f9bdee5ac.
----------
[Bug #20562] Categorize `RUBY_FREE_AT_EXIT` warning as experimental -
-
-
05:06 AM Revision 39c9d99f (git): 'SPEC_TEMP_DIR` should not be world-writable
- `SPEC_TEMP_DIR` is not present until `tmp()` method is called
on parallel run. In this case `tmp()` is called with `File.umask = 0`.
This patch makes `SPEC_TEMP_DIR` before `File.umask = 0`.
To solve the issue essentially, I think `SPEC... -
06/11/2024
-
11:54 PM Revision f1c7b6f4 (git): v3.3.3
-
- ruby_3_3 commit:97b1bf9ac11848c2783264d22bf7cdb7f32a21cf.
-
- Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
-
- Applied in changeset commit:git|1271ff72d5b627854c6812baefe796a2976cd793.
----------
Don't call `Warning.warn` unless the category is enabled
The warning category should be enabled if we want to call
`Warning.warn`.
This commit speeds... -
- byroot (Jean Boussier) wrote in #note-6:
> In [Feature #16345] it was stated:
> ...
I'm reading the ticket the same way. It sounds like this is a bug. -
- On Ruby 2.7.8 when `Warning[:deprecated] = false` was introduced:
```ruby
def Warning.warn(message, **)
p [:warn, message]
end
def foo(a, **b)
[a, b]
end
hash = {bar: 2}
foo(1, hash)
```
Produces no output, `Warning.... -
- In [Feature #16345] it was stated:
> We chose Warning.disable(:deprecated) instead of
re-defining Warning.warn in order to avoid string object generation.
The intent was clearly for `Warning.warn` not to be called. -
- Agreed, `Warning.warn` patches shouldn't be called for disabled categories.
I was actually 100% convinced this was the behavior, and this fix is consistent with `Warning.warn` not being invoked for verbose warnings when `$VERBOSE = fa... -
- The warning category should be enabled if we want to call
`Warning.warn`.
This commit speeds up the following benchmark:
```ruby
eval "def test; " +
1000.times.map { "' '.chomp!" }.join(";") + "; end"
def run_benchmark count
i = ... -
- Some of the places in Redmine (e.g. Associated revisions) print
revisions using only 8 characters. Even when I copied a revision from
there, I want to prepend commit: in the message. -
- Some of the places in Redmine (e.g. Associated revisions) print
revisions using only 8 characters. Even when I copied a revision from
there, I want to prepend commit: in the message. -
- ruby_3_3 commit:23f4b78ad8844ec81cb02fad25a6247a2d498582 merged revision(s) 27321290.
-
- [Bug #20521] ripper: Clean up strterm
-
- ruby_3_3 commit:d3b139821294f56e6b31e28608c534d9f0920fc2 merged revision(s) commit:1e08a9f0e9058186db18f29efc6458c00f10a856.
-
- [Bug #20499] Use Xcode owned tools for Xcode clang
Xcode has its own version tools that may be incompatible with genuine
LLVM tools, use the tools in the same directory. -
- ruby_3_3 commit:8951040aadca57fce633b0f714248de78a962c22.
-
- I created backport PRs:
- 3.2: https://github.com/ruby/ruby/pull/10963
- 3.3: https://github.com/ruby/ruby/pull/10962 -
- Applied in changeset commit:git|f0001a4fa7260d0c39e9ddba162f51c549cba2f8.
----------
compile.c: use putspecialobject for RubyVM::FrozenCore
[Bug #20569]
`putobject RubyVM::FrozenCore`, is not serializable, we
have to use `putspecialob... - 06:08 PM Revision 8951040a (git): [3.3 backport] compile.c: use putspecialobject for RubyVM::FrozenCore (#10962)
- compile.c: use putspecialobject for RubyVM::FrozenCore
[Bug #20569]
`putobject RubyVM::FrozenCore`, is not serializable, we
have to use `putspecialobject VM_SPECIAL_OBJECT_VMCORE`.
Co-authored-by: Jean Boussier <jean.boussier@gmail.com> -
- seems like a new feature to me too. I won't backport it to 3.3.
-
- ruby_3_3 commit:4c50d23245689761e04db450ced9fe9fa76997d0.
-
- I opened a PR for backport to 3.3: https://github.com/ruby/ruby/pull/10967
-
- [Bug #20280]
Backport of #10014. -
- 05:12 PM Revision c735f494 (git): [ruby/openssl] Pass through nil as digest when signing certificates
- (https://github.com/ruby/openssl/pull/761)
In order to sign certificates with Ed25519 keys, NULL must be passed
as md to X509_sign. This NULL is then passed
(via ASN1_item_sign_ex) as type to EVP_DigestSignInit. The
documentation[1] o... -
- * YJIT: add context cache size stat
* Allocate the context cache in a box so CRuby doesn't pay overhead
* Add an extra debug assertion -
- So that those lockfiles still work with older Bundler versions.
https://github.com/rubygems/rubygems/commit/880275bb66 -
- This removes the use of symbol and array objects when freeing the global
table so we can now free symbols and arrays earlier. -
01:43 PM Revision 89ebe899 (git): Ensure prism is testing everything
-
-
- https://github.com/rubygems/rubygems/commit/076aba8b1c
-
- When doing out-of-source builds I often end up wanting to use gdb from
inside a build directory.
Currently if I do that the `.gdbinit` in the ruby source directory is
not read.
Attempting to manually load the `.gdbinit` from the Ruby s... -
- https://github.com/ruby/prism/commit/73669b59f6
-
- https://github.com/ruby/prism/commit/cd66c478de
-
- This is another example, I imagine because of the same source problem. It also works if you disable optimizations:
```ruby
_ = _ rescue while 1
end
``` -
- Since `ruby --dump=i,-opt -e 'until while 1; end; end'` finishes immediately, it is a bug of optimization.
- 11:56 AM Revision b824b13e (git): .travis.yml: Update jaruga's email.
- I cannot receive Travis's notification via jaruga@ruby-lang.org, while another
committer with their @ruby-lang.org email can receive the notification.
The issue is my ruby-lang.org email address specific.
So far we haven't seen the root ... -
11:05 AM Bug #20520 (Closed): _FORTIFY_SOURCE=3 is not correctly respected - Applied in changeset commit:git|0ccb80d6bf57cd6e79ad622c024d3d0940ec6f3b.
----------
Extract hardening CFLAGS to a special $hardenflags variable
This changes the automatic detection of -fstack-protector,
-D_FORTIFY_SOURCE, and -mbranch... - 11:05 AM Bug #20154 (Closed): aarch64: configure overrides `-mbranch-protection` if it was set in CFLAGS via environment
- Applied in changeset commit:git|0ccb80d6bf57cd6e79ad622c024d3d0940ec6f3b.
----------
Extract hardening CFLAGS to a special $hardenflags variable
This changes the automatic detection of -fstack-protector,
-D_FORTIFY_SOURCE, and -mbranch... - 10:48 AM Revision 0ccb80d6 (git): Extract hardening CFLAGS to a special $hardenflags variable
- This changes the automatic detection of -fstack-protector,
-D_FORTIFY_SOURCE, and -mbranch-protection to write to $hardenflags
instead of $XCFLAGS. The definition of $cflags is changed to
"$hardenflags $orig_cflags $optflags $debugflags ... -
10:23 AM Bug #20079: alexandria testsuite began to segfault recently
- AMomchilov (Alexander Momchilov) wrote in #note-10:
> @luke-gru Can you please try this modified version of mame's patch?
> ...
This does not work (anymore?):
~~~
gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-sw... -
- ```
1)
Dir.mktmpdir when passed a block yields the path to the passed block ERROR
ArgumentError: parent directory is world writable but not sticky: /tmp/rubytest.wlu5cs_11
/tmp/ruby/src/trunk/lib/tmpdir.rb:113:in 'Dir.mktmpdir'
/tmp/ruby... -
- [Bug #20569]
`putobject RubyVM::FrozenCore`, is not serializable, we
have to use `putspecialobject VM_SPECIAL_OBJECT_VMCORE`. -
02:22 AM Misc #20575 (Closed): Syntax Moratorium til 3.4
- Hi,
As some may remember from the closing keynote at RubyKaigi, we are introducing Syntax Moratorium to support fair development of parsers.
During the Syntax Moratorium period, new syntactical changes will be suspended (changes no... -
01:11 AM Bug #19266: URI::Generic should use URI::RFC3986_PARSER instead of URI::DEFAULT_PARSER
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> I'm in favor of this change. However, be aware that uri is maintained at https://github.com/ruby/uri . Could you please submit a pull request to that repository?
Thanks Jeremy, I've r... -
12:44 AM Misc #20574 (Closed): DevMeeting-2024-07-11
- # The next dev meeting
**Date: 2024/07/11 13:00-17:00** (JST)
Log: https://github.com/ruby/dev-meeting-log/blob/master/2024/DevMeeting-2024-07-11.md
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at t... -
06/10/2024
-
- Oops, I send this before pasting the output of the script:
```
$ ./miniruby test.rb
false
{"test.rb:8: warning: variable $= is no longer effective\n"=>:deprecated}
```
You can see that "deprecated" warnings are not enabled, but... -
- Currently `Warning.warn` will be called for all warnings, even if that particular category is disabled.
For example
```ruby
module Warning
def warn(message, category:)
p message => category
end
end
def get_var
$=... -
- ruby_3_3 commit:40251ed0dfe99bb09c2fa542fce603ade25e3729.
-
- I opened a PR to backport [this patch](https://github.com/ruby/ruby/pull/9624) to Ruby 3.3: https://github.com/ruby/ruby/pull/10959
-
- [Bug #20180]
Backports #9624. -
- https://github.com/ruby/prism/commit/f7faedfb3f
-
- https://github.com/ruby/prism/commit/fe34a77df2
-
- This is a Rust regression and I've filed an issue [upstream].
I've worked with upstream to [hopefully have a fix ship][2] with 1.81.0,
but that will still leave a couple versions unusable.
If you install using `rustup`, avoid these ... -
05:07 PM Feature #19001 (Closed): Data: Add #to_h symmetric to constructor with keyword args [Follow-on to #16122 Data: simple immutable value object]
-
05:05 PM Feature #19001: Data: Add #to_h symmetric to constructor with keyword args [Follow-on to #16122 Data: simple immutable value object]
- Agreed, this need ended up being met by the initial implementation! Thank you, closing this ticket.
zverok (Victor Shepelev) wrote in #note-2:
> There isn't any need for this ticket as a separate request, as far as I am concerned.
>... -
- Commit 1471a16 seems to have fixed this flaky test, so we don't need to
skip it for YJIT or RJIT anymore. -
- (https://github.com/ruby/reline/pull/722)
Add xterm key bindings to comprehensive list
Add fallback escape sequence of cursor hide/show
https://github.com/ruby/reline/commit/e3c73bbe26 -
- The following example is easy to understand this issue:
```ruby
def foo(*, **nil); :ok; end
foo(1, **{}) #=> Ruby 3.2: :ok
#=> Ruby 3.3: :ok
foo(*[1], **{}) #=> Ruby 3.2: :ok
#=> Ruby 3.3: no ... -
02:08 PM Bug #20570: Nokey behavior changed since 3.3.
- I believe you’re *defining* with `**nil`, not *calling* with `**nil`. Your test should probably be `def foo(*, **); end; p foo(*[], **nil)`.
This does seem to be a bit of a regression for your particular use case. -
01:52 PM Bug #20570: Nokey behavior changed since 3.3.
- Real case https://github.com/ksss/raap/blob/fff046c98c971da48df9106d8c698fbe40daaa57/lib/raap/symbolic_caller.rb#L148-L155
-
- I am using code that transfers the following method call, but found that the behavior has changed since CRuby 3.3.
```ruby
receiver_value = Set.new
method_name = :merge
args = [1]
kwargs = {}
block = nil
receiver_value.__send__(... -
- ```ruby
until while 1
end
end
```
this code causes an infinite loop in the compiler. -
02:00 PM Revision 3cc9a126 (git): Fix CI when YJIT is enabled
-
-
- terminfo.rb
(https://github.com/ruby/reline/pull/721)
https://github.com/ruby/reline/commit/9da2cbcd82 -
- ```ruby
for _ in 1.5 or _ in []
end
```
raises a compile error for the current compiler only with
```
-- raw disasm--------
trace: 1
<L000> [sp: 0, unremovable: 1, refcnt: 1]
0000 putobject 1.5 ... -
- https://github.com/ruby/prism/commit/f09db18e46
-
- ```ruby
iseq = RubyVM::InstructionSequence.compile(<<~'RUBY')
# shareable_constant_value: literal
REGEXP = /#{}/
RUBY
iseq.to_binary
```
```
in `to_binary': ibf_dump_object_unsupported: 0x00000001026ac8b0 [3LM ] T_ICLASS... -
- [Github PR link](https://github.com/ruby/ruby/pull/10950)
The `test.rb` script used by `make run` etc is explicitly located in the `$srcdir` - the location of the Ruby source code.
The [Building Ruby](https://docs.ruby-lang.org/en/... -
11:51 AM Misc #20013: Travis CI status
- Travis support enabled my forked repositories of ruby/ruby, ruby/zlib and ruby/prism where Travis was used. It seems that we need to submit a list of github accounts to enable someone's forked repository from ruby/* organization. Maybe t...
-
- matz (Yukihiro Matsumoto) wrote in #note-20:
> First, If you clearly define what would happen when the (plugged) GC does not generational scanning, I am OK for it. @byroot told me that calling those methods would raise `NotImplementedEr... -
- ```
1)
TracePoint#inspect returns a String showing the event, method, path and line for a :call event FAILED
Expected "#<TracePoint:call 'call' /tmp/ruby/src/trunk/spec/ruby/core/objectspace/define_finalizer_spec.rb:33>" =~ /\A#<TracePoi... -
- I have checked with Ruby 3.3.2 and I was still able to hit the issue unfortunately. Although that was 1 of 15 builds.
This is the Fedora build (will be garbage collected soon):
https://koji.fedoraproject.org/koji/taskinfo?taskID=11... -
- `RUBY_FUNC_EXPORTED` is working on Windows since 906a86e4de71061dca05.
And as .def files are not processed by the preprocessor, it is less
flexible than `RUBY_FUNC_EXPORTED`, (e.g., select symbols by
conditions such as ruby version). -
- GC benchmarks will spend long time with assertions so we need
to respect `RUBY_TEST_SUBPROCESS_TIMEOUT_SCALE` environment variable.
@nobu pointed out that now `RUBY_TEST_TIMEOUT_SCALE` is primary
(and `RUBY_TEST_SUBPROCESS_TIMEOUT_SCALE... - 03:19 AM Revision 4c8f9c93 (git): Bump ruby/setup-ruby from 1.179.0 to 1.179.1
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.179.0 to 1.179.1.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/d5fb7a202fc07872cb44f00ba8e6197b70...
06/09/2024
-
11:50 PM Bug #20154: aarch64: configure overrides `-mbranch-protection` if it was set in CFLAGS via environment
- https://github.com/ruby/ruby/pull/10944 - would this solve the problem for you?
-
08:22 PM Revision 2959e1b5 (git): [ruby/irb] Suppress Ruby warnings in certain backtrace filtering
- tests
(https://github.com/ruby/irb/pull/966)
Since they're sensitive to the warnings, and the warnings are
not relevant to the tests, we can suppress them to keep the tests
simple.
https://github.com/ruby/irb/commit/ad642795da - 12:01 PM Revision 4dfd4e1d (git): Correct typo [ci skip]
-
- I wonder if making `win32ole` a bundled gem is a good idea.
From what I have seen the consequence of such changes seems in most cases to encourage gems to drop the dependency on the newly-bundled gem.
That may be good for e.g. ostruct w... -
- Applied in changeset commit:git|dd8903fed72c2d06fe7a0ca6b5ef88e9140be451.
----------
[Bug #20566] Mention out-of-range argument cases in `String#<<`
Also [Bug #18973]. -
- It is a [spec](https://bugs.ruby-lang.org/issues/18973#note-6).
-
12:22 AM Bug #20566 (Closed): string << 0xC2 should raise a RangeError if the string encoding is Encoding::ASCII
- I noticed that appending extended ASCII characters (0x80 - 0xff) works when the String's encoding is Encoding::ASCII, as well as Encoding::ASCII_8BIT. I was under the impression that Encoding::ASCII only covers the regular ASCII characte...
-
-
-
-
04:26 AM Bug #20516: The version of rexml in ruby 3.3.2 has not been updated since 3.2.6.
- Could you try REXML 3.2.9?
-
- It is fairly common now for JavaScript to include UTF-8 characters. If a misconfigured web server returns an `application/javascript` response for a JavaScript file, but *without* `charset=utf-8` in the `Content-Type`, `Net::HTTPResponse...
-
- Also [Bug #18973].
06/08/2024
-
-
02:30 PM Feature #20565: Relax formal argument at label
- > I knew you can use keywords as names here but am not quite sure about this. Positional arguments (against my expectations from keyword arguments) don't allow any of these three versions. Should they also work?
The reason why keyword... -
- I think it should remain forbidden, parametes must be local variables, but `C` and `$g` are not valid local variable names.
-
12:02 PM Feature #20565: Relax formal argument at label
- I knew you can use keywords as names here but am not quite sure about this. Positional arguments (against my expectations from keyword arguments) don't allow any of these three versions. Should they also work? I think it would be nice if...
-
- Just a thought: if `def foo(if:)` is possible, shouldn't `def foo(C:)` and `def foo($g:)` also be possible...?
-
- And from a quick look there is also [`_spawnv`](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/spawnv-wspawnv?view=msvc-170) which does take a `char**`, maybe we could use that on Windows?
-
- mame (Yusuke Endoh) wrote in #note-23:
> [...] instead of parsing the command line to a string array and passing it to `Kernel#exec`.
Don't we use `execve()` (which takes `char**`) as well on Windows for `Kernel#exec`?
It does see... -
- shyouhei (Shyouhei Urabe) wrote in #note-29:
> The current situation is that ruby is not the only valid executable that the method takes. Allowing untrusted inputs for it means it has to be secure for everything. This is too much a hu... -
10:59 AM Revision 69c0b143 (git): [ruby/openssl] Fix references to the license text
- Update the references to the file "LICENCE" with "COPYING".
The file LICENCE doesn't exist in ruby/ruby nor ruby/openssl. This has
been always the case since OpenSSL for Ruby 2 was merged to the ruby
tree as a standard library in 2003.
... -
- This is for consistency with ruby/ruby.
https://github.com/ruby/openssl/commit/00ad542791 -
- ruby/openssl is licensed under the terms of either the Ruby License or
the 2-Clause BSD License.
The git repository and built .gem files always contained the license
text for both license, but the metadata in the gemspec only specified
... -
10:57 AM Revision 0b92929e (git): [ruby/openssl] Add X509::Certificate#tbs_bytes
- Ref https://github.com/ruby/openssl/issues/519
This makes verifying embedded certificate transparency signatures
significantly easier, as otherwise the alternative was manipulating the
ASN1 sequence, as in
https://github.com/segiddins/s... -
-
-
-
- https://github.com/ruby/digest/commit/c5c1debd43
-
- https://github.com/ruby/digest/commit/9a22f921c9
-
- Happily I was able to turn all of those tests on with minimal changes. I'll clean this PR up next week, but all should be well with the additional tests (https://github.com/ruby/ruby/pull/10939).
-
12:32 AM Feature #20524: mswin and gmp
- I think this is a kind of new feature of ruby build system. I won't backport it to 3.2 branch. It's up to kokubun-san for 3.3 branch.
06/07/2024
-
- * YJIT: implement cache for recently encoded/decoded contexts
* Increase cache size to 512 -
- Ah, thank you @hsbt. We of course will not merge this until we are sure it is passing 100% of the tests. I think we will likely discover other things as well when we switch the default (before we merge), which is of course what we're loo...
-
- >Prism now passes all Ruby tests and specs.
No, https://github.com/ruby/ruby/blob/master/.github/workflows/prism.yml#L89 is not testing with `make test-syntax-suggest`, `make test-bundled-gems` and `make test-bundler-parallel`. At lea... -
- This issue is to propose switching the default parser for Ruby to Prism on the master branch. The main goal is to get this default into both master and the next preview so that the community has plenty of time to test before the eventual...
-
- * Implement BitVector data structure for variable-length context encoding
* Rename method to make intent clearer
* Rename write_uint => push_uint to make intent clearer
* Implement debug trait for BitVector
* Fix bug in BitVector::re... - 07:55 PM Revision faad2bc6 (git): Update default gems list at c90b5303a2fff58eddd7b87a06262a [ci skip]
-
-
- https://github.com/ruby/prism/commit/1528d3c019
-
- https://github.com/ruby/prism/commit/d218e65561
-
- https://github.com/ruby/prism/commit/100340bc6b
-
- https://github.com/ruby/prism/commit/4a9a7a62af
Co-authored-by: Jason Kim <jasonkim@github.com>
Co-authored-by: Adam Hess <HParker@github.com> -
05:56 PM Misc #20519: Porting regexp to pure ruby?
- I was at the kaigi but unfortunately missed that talk! I didn't realise a few weeks later I'd be digging in to it :) Looks like some interesting work has gone in to this area already. I'm going to spend some time looking in to this.
... -
- Hi @brightbits! I've investigated this one at length, and can give some context.
As you already discovered, Onigmo stretches well beyond regular expressions. It also provides all of the encoding support within CRuby, stretching all of... -
05:53 PM Bug #20218: aset/masgn/op_asgn with keyword arguments
- @matz Your post argued against a strawman that preserving kwargs in `[]=` would necessarily violate kwarg separation. Since that is obviously not true, `[]=` can be given real, separated kwargs, instead of removing them entirely, the mat...
-
-
- Using a SEGV signal for timeout makes it difficult to tell if it's a real
SEGV or if it timed out, so we should just use the default signals. -
03:38 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- Please note that I'm not necessarily against a way to call the current ruby executable. I just say doing so using exec is a bad idea, because exec is not designed for that purpose.
The current situation is that ruby is not the only v... -
02:53 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- > As you see there is no Windows API that takes `char**`. We cannot safely pass through what we have. You have to concatenate them into one argument string (`LPWSTR lpCommandLine`), with proper escaping of whitespace etc.
But this i... -
- shyouhei (Shyouhei Urabe) wrote in #note-26:
> In short the problem we see is feeding strings from untrusted sources to generic `Kernel#exec`. Sounds ultra risky, no?
It also sounds nothing like what this proposal is about. If the c... -
- In short the problem we see is feeding strings from untrusted sources to generic `Kernel#exec`. Sounds ultra risky, no?
Let's not do so. If what is needed is just launching a ruby process, we could perhaps design a workaround. -
- Eregon (Benoit Daloze) wrote in #note-24:
> @mame CRuby already needs to get arguments as an array to parse command-line flags, so `RbConfig.ruby_args` just exposes that.
> ...
This is true. Technically we can provide such array. But... -
- FWIW I think CRuby currently support subclassing Array and redefining `[]` and pattern matching will call that on CRuby, maybe it can be used for this purpose.
I don't think it's a good idea to rely on this behavior though, it might cha... -
- The implementation of pattern matching needs to read at indices from the return value of `deconstruct`, but `Enumerable` doesn't have `[]` or `at` or anything like that.
So I think it is difficult to support and could very well end up m... -
- Going to close this, as I think it should be fixed in other ways.
-
- This is the table of APIs that we are calling dynamically, and the available Windows versions.
DLL | API | Client | Server |
---------|--------------------------------|--------|--------|
iphlpapi | ConvertIn... -
-
-
-
-
-
- I'm okay to wait on this. My main reason is one day I would love to use C11 features, particularly _Generic, aligned_alloc, and static_assert. I assume/hope we will get there someday.
-
-
- This test seems flaky on macOS GitHub Actions
-
- https://github.com/ruby/error_highlight/commit/8ce3f6f145
-
- https://github.com/ruby/error_highlight/commit/69fbacfd49
-
- It is too flaky on macOS GitHub Actions
-
12:56 PM Bug #20518 (Closed): Escaped-newline in %W
- Applied in changeset commit:git|5e1001f754b34e1f0cc67563512c6036b6eb75ab.
----------
[DOC] document line continuation.
Document details of escape sequences including line continuation.
[Bug #20518] -
- Document details of escape sequences including line continuation.
[Bug #20518] -
- It was too big
-
-
- Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
-
-
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-7:
> Ah yeah, I did see that - I'll try and tackle these two together.
👍
> ...
I wish we could ignore `gem install`, but there is too many gems around (and Bundler). That leaves us i... -
- And two more questions:
* It seems that if you build with `CFLAGS=`, you totally overwrite Ruby's default optimisation flags & warning flags, whereas if you use `cflags=`, you prepend to them (or you can specifically overwrite `optfla... -
- Ah yeah, I did see that - I'll try and tackle these two together.
In general it seems that the CRuby build system is perhaps quite inflexible for distributors like yourself who want precise control over compilation flags and what not.... -
-
06:11 AM Bug #20561: Segfault with attr_writer, safe navigation and an "in" loop
- Just tried it with the latest git version (ruby 3.4.0dev (2024-06-07T04:38:11Z master a279463d0e) [x86_64-linux]), it is fixed indeed. I tried the `foo = nil` part as well, and that works too. I guess this one can be closed.
-
-
- I don't understand why this change was applied. This should be either enabled everywhere or disabled everywhere, not enabled on some random platforms. Please note that this should not be issue on aarch64 for a while.
Or was the issue ... -
-
- Applied in changeset commit:git|a279463d0ebb2fe1d4021ddd4675141deead514b.
----------
[Bug #20397] Removed obsoleted section about nkf -
-
-
-
04:29 AM Revision fcfbe06e (git): Bundle rbs-3.5 (#10929)
- * Bundle rbs-3.5.1
-
- Fix up 89cfc1520717257073012ec07105c551e4b8af7c.
-
- ```sh
$ RUBY_FREE_AT_EXIT=1 ruby -W:no-experimental -ep
ruby: warning: Free at exit is experimental and may be unstable
```
It should be categorized as experimental as its message. -
- Here is a survey which node (in Prism) are used in `defined?(expr)` (the node of `expr`)
https://gist.github.com/ko1/b31517a5037d55bbe50e7f12d79b9fc1
I understand the usage of :constant_read_node, :constant_path_node, :instance_varia... -
- Do not retry `fill_random_bytes` in `Init_RandomSeedCore`, just after
it failed first.
In other places, `rand_init_default` and `random_seed`, no more tweeks
needed once it succeeded -
- Also use a typed data.
-
- As well as `RUBY_ATOMIC_PTR_EXCHANGE` and `RUBY_ATOMIC_PTR_LOAD`.
-
- I think encoding modifiers for Regexp should be deprecated (and gradually removed), although the bug should be fixed anyway.
Matz.
06/06/2024
-
10:46 PM Bug #14480 (Closed): miniruby crashing when compiled with -O2 or -O1 on aarch64
- Applied in changeset commit:git|029d92b8988d26955d0622f0cbb8ef3213200749.
----------
Disable __builtin_setjmp usage on linux-aarch64
It is questionable whether __builtin_setjmp should default to yes
at all, but since it appears to stil... -
- It is questionable whether __builtin_setjmp should default to yes
at all, but since it appears to still have problems on this platform,
it seems safest to disable it.
Fixes [Bug #14480] -
-
- Applied in changeset commit:git|ad29527920b2a37ee427dc4991ff74d7a2f53e05.
----------
Fix Module#define_method to change visibility when passed existing method body
Fixes [Bug #19749] -
- Discussed at the dev meeting. @matz said `define_method(:foo, instance_method(:foo))` should change the visibility of `foo` to that of the current context.
-
- Fixes [Bug #19749]
-
-
- Merged.
-
- Discussed at the dev meeting. @matz said all cases should be accepted with no syntax error. So `def foo(bar = bar) = bar; foo` will return `nil` with no warning and error.
-
- https://bugs.ruby-lang.org/issues/20478
-
- Closing as duplicate as suggested.
-
- I don't understand what was the idea of "!=" here.
https://github.com/rubygems/rubygems/commit/06d5f1dcf1 -
- https://github.com/rubygems/rubygems/commit/a0af1baa2b
-
- I don't think we should add more of these.
https://github.com/rubygems/rubygems/commit/9eee9948cc -
- https://github.com/rubygems/rubygems/commit/7d1e8be2ce
-
- https://github.com/rubygems/rubygems/commit/31cb15d03f
-
- The `normalize_uri` method always gives back a String.
https://github.com/rubygems/rubygems/commit/246953010c -
- https://github.com/rubygems/rubygems/commit/e31df2d6ef
-
- Recent refactorings in test suite to not load `pathname` for launching
Bundler subprocesses make some specs fail due to the warnings Ruby prints
when autoloading `pathname` under a namespace. But enabling this spec
also reproduces the ha... -
- When launching bundler subprocesses for end to end testing, all of them
will load the `spec/support/rubygems_version_manager.rb` file passed as
a ruby's `-r` flag.
Unfortunately this file depends on `pathname`, so unless we drop that
de... -
- https://github.com/rubygems/rubygems/commit/f7c7bae940
-
- Not that I need it, but reads better.
https://github.com/rubygems/rubygems/commit/db3eca7b92 -
- https://github.com/rubygems/rubygems/commit/77bc6f1ecc
-
- https://github.com/rubygems/rubygems/commit/10f2ce1afb
-
- https://github.com/rubygems/rubygems/commit/6b3f555211
-
- https://github.com/rubygems/rubygems/commit/279740ed52
-
- https://github.com/rubygems/rubygems/commit/57576e27a1
-
- https://github.com/rubygems/rubygems/commit/2d9eeadb62
-
- Otherwise Ruby >= 3.2 gives a warning which makes several specs fail,
and truffleruby rejects it at all.
https://github.com/rubygems/rubygems/commit/ae2878484f -
- I believe this has already been fixed in https://bugs.ruby-lang.org/issues/20468. Can you try HEAD?
-
- I tried a few more Ruby versions. JRuby 9.4.7.0 works, but it results in an error when `foo = nil`. MRuby 3.3.0 and TruffleRuby 24.0.1 both work fine with this case and the `foo = nil` case.
-
- ```ruby
class Foo
attr_accessor :bar
end
foo = Foo.new
for foo&.bar in [1,2,3]
p foo
end
```
This code works fine when using `foo.bar` in the loop, without the safe navigator, but the safe navigator results in a segfault. ... -
- I created a proof of concept patch for colon style inspect https://github.com/ruby/ruby/pull/10924
-
- Discussed at the dev meeting.
In conclusion, @matz wanted to change the return value of `Hash#inspect` significantly and estimate its compatibility impact:
```ruby
{ :key => 42 } #=> {key: 42} # if the key is a symbol
{ :== ... -
- https://github.com/ruby/prism/commit/90d570aa50
-
-
-
-
- @mame CRuby already needs to get arguments as an array to parse command-line flags, so `RbConfig.ruby_args` just exposes that.
If CRuby can parse these Ruby command-line flags, for sure we can save them in some kind of array.
IIRC th... -
- I am afraid if it is more difficult than expected to do "launch subprocess Ruby instances with the same settings".
I am not very familiar with Windows, but I have heard that there is no concept of "an array of command-line arguments" ... -
- BTW since this is about overriding configuration options, I think that #20520 falls into the same bucket
-
- Thank you!
-
- The limit will be declared (for CRuby):
* maximum line: signed 32 bits (`eval` uses negative line numbers)
* maximum column: unsigned 32 bits
* maximum file byte size: unsigned 32 bits
Matz.
-
- https://github.com/ruby/prism/commit/f5c883af56
-
- https://github.com/ruby/prism/commit/6a4fe21088
-
- jaruga (Jun Aruga) wrote in #note-32:
> I noticed the following message is displayed on our Travis page. I will contact Travis support.
> ...
Travis support quickly responded and fix the issue removing the message. And I can see the Tr... -
- I noticed the following message is displayed on our Travis page. I will contact Travis support.
https://app.travis-ci.com/github/ruby/ruby
> We are unable to start your build at this time. You exceeded the number of users allowed fo... -
- Applied in changeset commit:git|27321290d954300192c82cdf5e2c794a695473f5.
----------
[Bug #20521] ripper: Clean up strterm -
-
- (https://github.com/ruby/reline/pull/717)
When Reline reads EOF, Reline.readline should return nil if and only if input is empty
https://github.com/ruby/reline/commit/cc74b3686a -
09:46 AM Misc #20432: Proposal for workflow changes related to teeny releases
- Thank you for considering my proposals and for the work you all have been doing to make a better release process. It is exciting to see more releases being made. The community is thankful for the work of all the current and past branch m...
-
- We already worked with proposal 2. It happened to be the same timing as security releases were required in recent years.
I and @nagachika and @k0kubun try to release with proposal 3. I'm not sure proposal 1 is good for branch maintain... -
- Applied in changeset commit:git|fbb61a26e71be9faccb4ad2392e71d0a561854d1.
----------
Mark old Data API as deprecated
[Feature #19998] -
- > Whether it is actually possible to remove the APIs may require careful consideration in the future.
Agreed. I'm not suggesting that yet. However I do have a proof of concept that degrades a bit the old API performance in favor of im... -
- Discussed at the dev meeting. Matz accepted build-time warning.
However, the author of a gem that is not well maintained is not likely to notice the build-time warning. Whether it is actually possible to remove the APIs may require ca... -
- [Feature #19998]
-
- Discussed at the dev meeting, and @matz agreed with @nobu. Closing
-
- Discussed at the dev meeting, but no one had a deep understanding of Jeremy's patch, and matz was unable to make any decision.
-
- Discussed at the dev meeting. @matz said `defined?([*a])`, `defined?(itself(*a))`, and `defined?({ a => a })` should all return nil.
Matz was not positive about restricting the expression of `defined?`. @ko1 said he will investigate t... -
- Discussed at the dev meeting, and @matz said `/#{"\x80"}/` should not raise a SyntaxError but return a binary encoded regexp object.
- 09:07 AM Revision d4aff75a (git): [ruby/logger] Add support for symbols in #shift_age
- Resolves issue: https://github.com/ruby/logger/issues/46
https://github.com/ruby/logger/commit/83502c2107 -
- First, If you clearly define what would happen when the (plugged) GC does not generational scanning, I am OK for it. @byroot told me that calling those methods would raise `NotImplementedError` when GC does not provide generational GC.
... -
- This reverts commit ba72cfa6616d377ceb62d94f10157097349634e5.
https://github.com/ruby/ruby/actions/runs/9396582605/job/25878058017#step:10:788
```
../../../../../../src/.bundle/gems/rbs-3.5.0/ext/rbs_extension/location.h:23:25: error: ... -
- I think:
1. If a `Regexp` source string contains non-US-ASCII chars, the source string encoding is honored.
2. If the source string contains US-ASCII chars only, falls back to
a. an encoding option if given.
b. US-ASCII.
-
-
- matz (Yukihiro Matsumoto) wrote in #note-18:
> It is the direction of Ruby's evolution to separate keyword arguments from normal arguments, just as Ruby 3.0 promoted the separation of keyword arguments. This proposal goes against this di... -
- It is the direction of Ruby's evolution to separate keyword arguments from normal arguments, just as Ruby 3.0 promoted the separation of keyword arguments. This proposal goes against this direction and cannot be accepted. We investigated...
-
- Sorry, I forgot to reply. Due to the compatibility concern, I'd like to keep this behavior even though it's inconsistent with direct constant accesses.
Matz.
-