Activity
From 03/26/2024 to 04/01/2024
04/01/2024
-
11:26 PM Revision 799e8548 (git): [Feature #20331] Simplify parser warnings for hash keys duplication and when clause duplication
- This commit simplifies warnings for hash keys duplication and when clause duplication,
based on the discussion of https://bugs.ruby-lang.org/issues/20331.
Warnings are reported only when strings are same to ohters. -
- In the past, it was imemo. However a075c55 changed it.
Therefore no need to use `VALUE` for the first field. -
10:17 PM Misc #20387: Meta-ticket for ASAN support
- > How about making ASAN enabled for ruby-debug builds
That's not a bad idea (avoid adding yet more combinations!) but do you know how widely these builds are currently used and what for? ASAN will make them a heck of a lot slower so t... -
01:20 PM Misc #20387: Meta-ticket for ASAN support
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-11:
> * Could we get an ASAN build of ruby into setup-ruby? This would make it easier to use ASAN with github actions and the like.
How about making ASAN enabled for ruby-debug builds a... -
07:39 PM Revision b25282e6 (git): [ruby/prism] Replace . with decimal point for strtod
- https://github.com/ruby/prism/commit/578a4f983e
-
- https://github.com/ruby/prism/commit/0cc3a9d63a
-
- https://github.com/ruby/prism/commit/fa7559d40b
-
- https://github.com/ruby/prism/commit/82fd0599ed
-
- https://github.com/ruby/prism/commit/f00ae59070
-
- https://github.com/ruby/prism/commit/1879a9d22e
-
- https://github.com/ruby/prism/commit/6b594d9d42
-
- https://github.com/ruby/prism/commit/27ad452436
-
- https://github.com/ruby/prism/commit/74bff9e834
-
-
- https://github.com/ruby/prism/commit/0d5a6d936a
-
- https://github.com/ruby/prism/commit/ddec1c163d
-
- https://github.com/ruby/prism/commit/71ea82f299
-
- https://github.com/ruby/prism/commit/aa2182f064
-
06:12 PM Revision a531cac3 (git): [ruby/reline] Refactor completion
- (https://github.com/ruby/reline/pull/647)
* Refactor completion: split autocompletion and tabcompletion logic and state
* Move completion candidate listup logic from dialog proc to LineEditor
https://github.com/ruby/reline/commit/c3c0... -
- (https://github.com/ruby/reline/pull/613)
https://github.com/ruby/reline/commit/a622704f62 -
04:00 PM Feature #20404: `2pi`
- This has been brought up before to add the constant `tau`
https://bugs.ruby-lang.org/issues/17496 -
02:26 PM Feature #20404: `2pi`
- The Tau Manifesto (https://tauday.com/) was introduced by Michael Hartl, a Rubyist, and handily `𝜏 == 2π` so it might be worth also considering the tau letter: 𝜏
-
11:24 AM Feature #20404: `2pi`
- Now that Ruby has been unicode aware for over a decade, it's probably better to use actual pi letter: `2π`
-
05:40 AM Feature #20404: `2pi`
- I really like this proposal. But I think for most of the world, it was a few hours too early. A time around 2024-04-01 12:00:00 UTC may have been easier to understand for most of the world.
-
03:03 PM Revision e2a1d0b5 (git): [rubygems/rubygems] Improve error message when strict resolution filters out everything
- https://github.com/rubygems/rubygems/commit/1ea44b3749
-
- https://github.com/rubygems/rubygems/commit/7b5cc51a96
-
- https://github.com/rubygems/rubygems/commit/6ca192649f
-
- We just need to filter versions belonging to the range, but don't need
anything else.
https://github.com/rubygems/rubygems/commit/8355a225d7 -
- https://github.com/rubygems/rubygems/commit/bb5727934c
-
- So that we don't need to reverse the Array.
https://github.com/rubygems/rubygems/commit/aeea5e2e00 -
- https://github.com/rubygems/rubygems/commit/ac24a68486
-
- We do that when first caching versions, and then it's no longer
necessary.
https://github.com/rubygems/rubygems/commit/ede15847db -
- https://github.com/rubygems/rubygems/commit/13294528c4
-
- And also so that it matches the method used by main PubGrub sample
resolver class.
https://github.com/rubygems/rubygems/commit/0e612361b8 -
- https://github.com/rubygems/rubygems/commit/0ddf25e5aa
-
02:26 PM Revision e26ac3ab (git): Test finalizer is ran in bootstraptest
-
08:53 AM Feature #20405: Inline comments
- vo.x (Vit Ondruch) wrote in #note-1:
> I like this proposal. But there are other possibilities, such as:
> ...
Thank you for the comment, but you may know `(:` can conflict existing code.
The reason I selected `(|` is that `/:|)` is u... -
08:41 AM Feature #20405: Inline comments
- I like this proposal. But there are other possibilities, such as:
~~~
(: This is comment :)
~~~
That would just underline Ruby as a "happy" language. Of course variants such as `(-: ... :-)` or even `(o: ... :o)` could even exte... -
- I propose a new inline comment syntax.
```ruby
p (| This is a comment (| and nested one |) /:|) (:|) #=> :|
``` -
08:17 AM Bug #20231: Don't wait in io_binwrite_string if not necessary.
- Thanks!
-
07:55 AM Revision 12329753 (git): add CI matrix for clang-19
-
- It is not an empty gzipped data, a gzipped empty dump data.
-
- Be careful when writing binary data on Windows.
```
$ ruby -e 's = Gem::Util.gzip("\x04\x08[\x05".b); p s.index("\n"); puts IO::Buffer.for(s).hexdump'
6
0x00000000 1f 8b 08 00 6c 3d 0a 66 00 03 63 e1 88 66 05 00 ....l=.f..c..f..
0x0000... -
06:32 AM Revision acfef7c4 (git): Use dummy data generated by RubyGems
-
03:05 AM Revision 0774232b (git): Remove unnecessary macros and functions for Universal Parser
-
01:06 AM Revision e07178d5 (git): [DOC] Fix scope resolution operator typo in `Process#wait` docs
03/31/2024
-
- Fixed in https://github.com/ruby/resolv/pull/49
-
11:57 PM Bug #20403 (Closed): TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback can flake if TCP port is in use - Applied in changeset commit:git|80bda107c84187d90eeff9497d465e086364b420.
----------
[ruby/resolv] Add an explicit with_udp_and_tcp helper to test_dns.rb
This helper tries to bind UDP and TCP sockets to the same port, by
retrying the b... -
- I opened https://github.com/ruby/ruby/pull/10413 for this.
-
- The test TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback wants to make a TCP and UDP DNS server on the same port. It achieves this by binding to a random UDP port (with `:0`), and then trying to bind to that TCP port. Howeve...
- 11:57 PM Revision 80bda107 (git): [ruby/resolv] Add an explicit with_udp_and_tcp helper to test_dns.rb
- This helper tries to bind UDP and TCP sockets to the same port, by
retrying the bind if the randomly-assinged UDP port is already taken in
TCP. This fixes a flaky test.
[Bug #20403]
https://github.com/ruby/resolv/commit/3d135f99d9 -
04:51 PM Feature #20404 (Rejected): `2pi`
- I propose a new Float literal: `2pi`.
```ruby
p 2pi #=> 6.283185307179586 == 2 * Math::PI
```
I am not proposing `1pi`, `3pi` or `4pi`. I do only `2pi`. Because in most cases, all you need is `2pi`. Any other multiple of pi is r... -
10:20 AM Bug #20245: Crash when checking symbol encoding
- ruby_3_2 27606daf8efeb0ae6d0590a2c9bb1c5aae07f140 merged revision(s) ac0163949a6ee678dfccec9f6e56422b91e5f0a9,01fd262e62076277a41af72ea13f20deb1b462a2.
-
- ruby_3_2 4f3ed07d5bfd581b630e4afc8b9bb170ce781e7f merged revision(s) ade56737e2273847426214035c0ff2340b43799a.
-
- ruby_3_2 bf6e9299ef4f10dbd23f32331c355ac875bfb5e3 merged revision(s) 2554c5d3b8738a248cedb2fea96dfab9fbe19417.
-
- ruby_3_2 1b5c74a2408d248f35cb811327dd51f49ee37c9e merged revision(s) b14674b236445fb70f484603e678722760f678f4.
- 10:12 AM Revision e02a06fb (git): Document how to run the tests under ASAN now that they pass!
-
- OK! Everything required to make `make check` pass on my machine with ASAN enabled has been merged! I opened https://github.com/ruby/ruby/pull/10412 to update the documentation to include the correct incantation.
The next things I woul... - 09:33 AM Bug #20402 (Closed): Double-free in TestIseqLoad#test_stressful_roundtrip
- Applied in changeset commit:git|9d0a5148ae062a0481a4a18fbeb9cfd01dc10428.
----------
Add missing RB_GC_GUARDs related to DATA_PTR
I discovered the problem in `compile.c` from a failing
TestIseqLoad#test_stressful_roundtrip test with AS... - 09:33 AM Revision 9d0a5148 (git): Add missing RB_GC_GUARDs related to DATA_PTR
- I discovered the problem in `compile.c` from a failing
TestIseqLoad#test_stressful_roundtrip test with ASAN enabled. The other
two changes in array.c and string.c I found by auditing similar usages
of DATA_PTR in the codebase.
[Bug #20402] -
- Compile code without Symbol GC always
---
symbol.c | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
Fix crash when checking symbol encoding
[Bug #20245]
... -
- The changeset bb59696614083660241ef272f222628cbfa95844 cannot be merged into ruby_3_2 branch cleanly and hard to me to write a patch. @tompng Could you kindly create the patch for ruby_3_2 branch?
-
- Fix coderange of invalid_encoding_string.<<(ord)
Appending valid encoding character can change coderange from invalid to valid.
Example: "\x95".force_encoding('sjis')<<0x5C will be a valid string "\x{955C}"
---
... -
- Memory leak with TracePoint on bmethod
[Bug #20194]
When disabling the TracePoint on bmethod, the hooks list is not freed.
For example:
obj = Object.new
obj.define_singleton_method(:foo... -
- Don't wait in `io_binwrite_string` if not necessary. (#9792)
---
io.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-) - 02:37 AM Revision 174b6716 (git): [rubygems/rubygems] [commands/rebuild] Remove unused DATE_FORMAT constant.
- https://github.com/rubygems/rubygems/commit/3c4e3fadc9
-
02:24 AM Revision 9579cf45 (git): If we have a shape cache we should use it
- If there is a shape cache, then we should believe the results instead of
doing a linear search for non-existent items
This fixes a case where checking the index of an undefined ivar would
result in an O(n) search. Now we get O(log n).
...
03/30/2024
-
- Add a Ruby script mode to `tool/missing-baseruby.bat` that checks if
`RUBY_VERSION` meets the required version. This will enable similar
checks on mswin as well. -
- 06:58 AM Revision a6d8837d (git): Update bundled gems list as of 2024-03-29
-
- https://github.com/ruby/ruby/pull/10408 should fix this
-
- With ASAN enabled, the TestIseqLoad#test_stressful_roundtrip fails with the following output:
```
2/9] TestIseqLoad#test_stressful_roundtrip = 7.26 s
1) Failure:
TestIseqLoad#test_stressful_roundtrip [/home/kj/ruby/test/-ext-/ise...
03/29/2024
-
-
- I think this is a duplicate of #20184 and should be fixed in 3.3.1.
- 07:27 PM Revision d7d59ea1 (git): [rubygems/rubygems] add test case to ensure updating with multiple sources + caching maintains the right lockfile
- https://github.com/rubygems/rubygems/commit/65839757e6
-
-
- https://github.com/ruby/prism/commit/9947ab13c0
-
- https://github.com/ruby/prism/commit/79a75258a4
-
-
- I agree, but I still think Ripper should match the parser's behavior here. Otherwise you can't get the AST of those kinds of files.
-
- Shebang makes sense only in an executable script file.
```sh
$ echo $'#!/bin/sh\np :sh' | ruby
ruby: no Ruby script found in input (LoadError)
bash: exit 1
$ ruby -e $'#!/bin/sh\np :sh'
:sh
``` -
- I've opened a PR here https://github.com/ruby/ruby/pull/10406. I'm assuming no one has an objection based on the silence, so I'll merge once CI passes.
-
-
- Thank you for the clarification!
-
- `BEGIN` blocks are:
a. executed in the order they appeared in the same nesting level.
b. executed in prior to outside the block.
> ```ruby
> ...
"2" is first because it is in the inner `BEGIN` in the block for "1".
> ```ruby
... - 08:03 AM Revision 38331c89 (git): [rubygems/rubygems] [gemspec_helpers] Fix Rubocop warning.
- https://github.com/rubygems/rubygems/commit/4ebf6ee5ac
- 08:03 AM Revision d19744fb (git): [rubygems/rubygems] [build, rebuild] Split common find_gemspec() out to GemspecHelpers.
- https://github.com/rubygems/rubygems/commit/2f80a595c4
- 08:03 AM Revision d916dbcb (git): [rubygems/rubygems] Improve formatting of "gem rebuild --help" output.
- https://github.com/rubygems/rubygems/commit/701550f9dd
- 08:03 AM Revision 54d90e13 (git): [rubygems/rubygems] [rebuild] If --diff is not passed and a rebuild fails, suggest passing --diff.
- https://github.com/rubygems/rubygems/commit/7caadd182c
- 08:03 AM Revision dfe83df0 (git): [rubygems/rubygems] [rebuild_command] Bail early if the RubyGems version doesn't match.
- https://github.com/rubygems/rubygems/commit/a691170dc7
- 08:03 AM Revision 88d7be46 (git): [rubygems/rubygems] [rebuild_command] Use Gem.* helpers.
- https://github.com/rubygems/rubygems/commit/8644ce7193
- 08:03 AM Revision fe096f64 (git): [rubygems/rubygems] [rebuild_command] Clean up help text.
- https://github.com/rubygems/rubygems/commit/4446389f2e
- 08:03 AM Revision 54e0b807 (git): [rubygems/rubygems] [rebuild_command] Use temporary directory instead of the working directory.
- https://github.com/rubygems/rubygems/commit/f2e4e5b56f
- 08:03 AM Revision a28087af (git): [rubygems/rubygems] [rebuild_command] Add --diff flag to try using diffoscope.
- https://github.com/rubygems/rubygems/commit/3e9545193a
- 08:03 AM Revision cd12dfd3 (git): [rubygems/rubygems] [rebuild_command] Avoid leaking files.
- https://github.com/rubygems/rubygems/commit/3b88553d0d
- 08:03 AM Revision e5def27f (git): [rubygems/rubygems] Add "gem rebuild" command.
- https://github.com/rubygems/rubygems/commit/6d661573f0
-
- Thank you, that fixed it yes. And it's a much better fix :)
-
- This behavior was discovered and briefly discussed during the previous dev meeting. The actual warning is
```
test.rb:4: warning: duplicated 'when' clause with line 2 is ignored
```
According to @nobu, this reads "The 'when' clau... -
- On the otherhand, if you have duplicated hash keys you get:
```ruby
{
bar: 1,
baz: 1,
bar: 1
}
```
For the warning: `warning: key :bar is duplicated and overwritten on line 4`. So this seems correct. -
- When you have a duplicated when clause, you get a warning for it. For example:
```ruby
case foo
when :bar
when :baz
when :bar
end
```
you get ``warning: duplicated `when' clause with line 2 is ignored``.
But the when claus... -
- https://github.com/ruby/ruby/pull/9357 may be fixed this.
03/28/2024
-
11:13 PM Revision 02d40b6c (git): Use ubf list on cygwin
-
09:41 PM Revision f3c35749 (git): YJIT: Optimize putobject+opt_ltlt for integers
- In `jit_rb_int_lshift()`, we guard against the right hand side changing
since we want to avoid generating variable length shifts. When control
reaches a `putobject` and `opt_ltlt` pair, though, we know that the right
hand side never chan... -
-
- https://github.com/ruby/prism/commit/418318e1c8
-
- https://github.com/ruby/prism/commit/bb78d83e88
-
07:21 PM Revision bb3cbdfe (git): YJIT: add iseq_alloc_count to stats (#10398)
- * YJIT: add iseq_alloc_count to stats
* Remove an empty line
---------
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> -
-
07:13 PM Feature #20394: Add an offset parameter to `String#to_i`
- byroot (Jean Boussier) wrote in #note-10:
> `StringIO` isn't as convenient as you make it out to be. Maybe it could become that, but it isn't today.
Hmm, it's not like it matters very much, but I get the weird feeling you misundersto... -
- > but rest assured once we can start using IO::Buffer exclusively, I will do so.
I'd be curious to see an HTTP1 parser using IO::Buffer. I don't see how you'd do it today. -
- My protocol gems have been around since Ruby 2.3+ so there are compatibility issues, but rest assured once we can start using `IO::Buffer` exclusively, I will do so. Using `String` for IO buffers is equally fraught with odd issues like e...
-
- > What about IO::Buffer? It was introduced somewhat stealthily and its API is somewhat unique, and yet by its idea it seems to be exactly that.
I'm aware of it, but it only offer binary oriented methods. Perhaps it could be extended t... -
07:20 AM Feature #20394: Add an offset parameter to `String#to_i`
- > I'd be all for a dedicated `Buffer` class that allow to efficiently parse text protocols like HTTP and RESP3, but right now all we got is String.
What about [IO::Buffer](https://docs.ruby-lang.org/en/master/IO/Buffer.html)? It was i... -
- > This interpretation mismatch could be a source of vulnerability.
Good catch @mame, that does indeed make the `to_i` proposal much more problematic. I guess I don't really have much of a proposal anymore.
> ...
Not today no. You c... -
- I thought of a security concern.
I suppose all methods proposed in this ticket would allow underscores as a digit separator. This is natural in Ruby, but usually an unnecessary feature outside of Ruby, including the Redis protocol.
T... -
- Right now there are specs for the order in which `BEGIN{}` should be executed, which is the order they appear in the file. For example:
```ruby
BEGIN { print "1" }
print "4"
BEGIN { print "2" }
print "5"
BEGIN { print "3" }
```
... -
-
-
- https://github.com/ruby/prism/commit/f540e830b5
-
- https://github.com/ruby/prism/commit/020756fb11
-
-
- https://github.com/ruby/prism/commit/2068e3c30a
-
03:54 PM Revision 97b2cc34 (git): Allow FormatError to take either String or Gem for source
- Most of the calls to `FormatError.new` pass `@gem` for the second argument, which has a `path` method.
But in one case—on package.rb:691 in `verify_gz`, the `source` argument is a `String`.
So if there's ever a GZip decode error when a... -
- All symbols in the GC are dynamic symbols, so we don't need to check it.
-
-
02:48 PM Revision 7055dcf9 (git): [ruby/prism] Improve description for InterpolatedStringNodeFlags
- https://github.com/ruby/prism/commit/caa576d63f
-
- Applied in changeset commit:git|2ab9fb1c2e659f1f819ed63796171b2129255185.
----------
[Bug #20398] Terminate token buffer at invalid octal number -
- Does this fix it?
```diff
diff --git a/parse.y b/parse.y
index 585130c3465..55619273b8e 100644
--- a/parse.y
+++ b/parse.y
@@ -10164,6 +10164,7 @@ parse_numeric(struct parser_params *p, int c)
/* prefixed octal */
... -
- https://github.com/ruby/ruby/pull/10393 should fix this
-
- I found the following ASAN error in `TestRubyLiteral#test_integer`. It appears that this code is calling strdup on a non-null terminated string.
```
[1/1] TestRubyLiteral#test_integer==================================================... -
- For the given script:
```ruby
#!/bin/sh
# -*- ruby -*-
exec "${RUBY-ruby}" "-x" "$0" "$@" && [ ] if false
#!ruby
# This needs ruby 2.0, Subversion and Git.
# As a Ruby committer, run this in an SVN repository
# to commit a chan... -
-
- 08:41 AM Feature #19057: Hide implementation of `rb_io_t`.
- "ioquatix (Samuel Williams) via ruby-core" <ruby-core@ml.ruby-lang.org> wrote:
> Issue #19057 has been updated by ioquatix (Samuel Williams).
>
>
> > Why don't you reconsider the "nested public interface" approach?
>
> My asses... -
06:52 AM Misc #20336: DevMeeting-2024-04-17
- * [Bug #19865] Segfault when calling user signal handlers during VM shutdown
* Seems like the bug is well understood and there is a patch for it (https://github.com/nobu/ruby/tree/signal-at-cleanup), can it be merged? -
- Any chance this could be backported into Ruby 3.2? It was a bit tricky because of the VWA-related changes in 3.3, but I did manage to open a PR to do this: https://github.com/ruby/ruby/pull/10394
I'm running into this problem with the... -
- We use the following site for that now:
* https://tools.ietf.org/ or http
* https://datatracker.ietf.org or http
Today, IETF said the official site of RFC is www.rfc-editor.org.
FYI: https://authors.ietf.org/en/references-in-rfcxml
I... -
-
-
01:15 AM Revision 84236132 (git): Launchable: Configure OS correctly in macos.yaml
03/27/2024
-
- I merged another few PR's related to unit tests in ASAN builds:
https://github.com/ruby/ruby/pull/10383
https://github.com/ruby/ruby/pull/10384
https://github.com/ruby/ruby/pull/10385
https://github.com/ruby/ruby/pull/10386 - 10:49 PM Revision dc9d2455 (git): Add a missing asan_unpoisoning_p in gc_set_candidate_object_i
- It walks the heap, and checks for T_NONE and T_ZOMBIE objects, so it
needs to unpoison these slots before accessing them when ASAN is
enabled. - 10:48 PM Revision 75234beb (git): Make TestParallel#test_retry_workers consider RUBY_TEST_TIMEOUT_SCALE
- This test currently fails if RUBY_TEST_TIMEOUT_SCALE is set, because the
worker timeout is scaled out but the duration of the sleep does not;
thus, the test-test-case does not timeout when it should. - 10:48 PM Revision 7bdd742c (git): Set ASAN_OPTIONS=disable_coredump=0 for test_execopts_rlimit test
- By default, ASAN sets RLIMIT_CORE to zero, "to avoid dumping a 16T+ core
file" on 64 bit systems. These tests are just asserting on the expected
value of RLIMIT_CORE, not actually dumping core files, so it's fine to
disable that behaviou... - 10:48 PM Revision 8c7b9bd0 (git): Disable ASAN handle_segv in test_rubyoptions.rb
- ASAN registers a sigsegv handler and causes extra output to be emitted
that these tests are not expecting. -
-
- mame (Yusuke Endoh) wrote in #note-6:
> Generalizing, we may want `IO#scanf`, but that's probably overkill?
This previously existed in the stdlib but was removed: #16170
byroot (Jean Boussier) wrote in #note-7:
> ...
With Stri... -
- > The idea of an offset in a string is perfectly represented via the cursor in IO/StringIO
Indeed, but the problem is that you then have very few methods to parse values or peak in the buffer to find elements. Lots of methods needed f... -
- As @eregon said, `String#to_i(offset:)` with byte offset looks strange to me.
I like `IO#get_i(base=10)` and `StringIO#get_i` (despite the name).
I was a little concerned that it returns infinitely large Bignum when the IO reads "9... -
-
- https://github.com/ruby/prism/commit/85263ade63
-
- But wait, maybe the ["old style" license](https://github.com/ruby/ruby/blame/e51014f9c05aa65cbf203442d37fef7c12390015/LEGAL#L1091-L1119) is crippled and it should really contain the additional paragraph, because otherwise as far as I und...
-
- Actually, there is one more occurrence of this situation:
https://github.com/ruby/ruby/blob/51e6becd391eac03fd3842e1db9b6907999d64ba/LEGAL?plain=1#L1090-L1093
and there is some history:
https://github.com/ruby/ruby/commit/cb47ae... -
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> Should we remove that note simply?
Yes, that seems to like something which should have been part of that commit. -
-
- https://github.com/ruby/prism/commit/faadd05693
-
-
-
-
05:41 PM Feature #20390 (Closed): Issue with StringIO and chilled strings
- Applied in changeset commit:git|0f5ab4ad5289d6385b74e800a73de005a48737b6.
----------
[ruby/stringio] Eagerly defrost chilled strings
[Feature #20390]
https://github.com/ruby/stringio/commit/17ee957f34
Co-authored-by: Jean Boussier <b... -
- https://github.com/ruby/stringio/commit/0da5b725c8
-
- https://github.com/ruby/stringio/commit/4e8e82fc30
-
- [Feature #20390]
https://github.com/ruby/stringio/commit/17ee957f34
Co-authored-by: Jean Boussier <byroot@ruby-lang.org> -
-
- The LEGAL file seems to contain [obsolete information](https://github.com/ruby/ruby/blob/a69f0047cb489c136001937442c1d2ffd8ea1dd7/LEGAL?plain=1#L730-L746) about nkf license.
It seems that nkf indeed use such license, but in upstream, ... -
-
- https://github.com/ruby/prism/commit/af0204a8ab
-
04:55 PM Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents
- This is a great addition! I've often used a post-processing script to remove the string data, so having it built in would be very helpful.
I think `false` would be a good default (but either way is fine by me). -
- > false on default is safer?
Agreed. Safer and faster. I only set it to `true` on default to not change the current behavior, but wouldn't mind flipping it to `false` by default. -
08:48 AM Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents
- false on default is safer?
-
- `ObjectSpace.dump_all` is a very useful method to debug memory leaks and such, hence is frequently needed in production. But since all the 7bit strings content is included in the dump, it incur the risk of leaking personal data, or secre...
-
-
- This is an optimization for compaction so that we only lookup in the
obj_to_id_tbl table only when FL_SEEN_OBJ_ID is set. -
02:12 PM Revision e4d64797 (git): Add array/hash implicit allocation tests
- These are designed to prevent allocation regressions (commits that
increase the number of implicitly allocated arrays and hashes). We
have already had three commits in the last couple weeks to fix
allocation regressions:
* 15dc3aaa311b3... -
- This is to stop crashes like:
.\miniruby.exe: [BUG] Segmentation fault
ruby 3.4.0dev (2024-03-26T15:38:26Z pull/10370/merge 040ea2ae2f) [x64-mswin64_140]
-- Control frame information ----------------------------------------... -
- This reverts commit 3680981c7b71df8c3a426164787ccefe5296bb25.
-
-
- Since ICLASS do not mark the classpath, we need to register it as a
global object before we convert RubyVM::FrozenCore as a ICLASS. -
- If a GC runs right during creating a rb_fix_to_s_static, it may cause
the previous ones to become swept by the GC because they have not been
registered by rb_vm_register_global_object. -
-
-
-
-
-
-
-
11:48 AM Bug #19716: SystemStackError occurs too easily on Alpine Linux (due to small stack size reported by pthread_attr_getstacksize on musl libc)
- hsbt (Hiroshi SHIBATA) wrote in #note-5:
> We welcome patch for them.
[Patch](https://bugs.ruby-lang.org/attachments/7081) has been available for for years. https://bugs.ruby-lang.org/issues/19716#note-2 confirms it still works for... -
-
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue... - 11:34 AM Revision 44b5c912 (git): [rubygems/rubygems] Allow installing plugins from path via CLI
- Also bring the man page up to date.
https://github.com/rubygems/rubygems/commit/a849bd6947 -
- 06:59 AM Revision 6498c439 (git): Update bundled gems list as of 2024-03-26
-
-
- This reverts commit a31ca3500d995b6706f94ff72166d699c5faeb27 which
broke debug inspector API. -
-
-
- TruffleRuby temporary
(https://github.com/ruby/strscan/pull/91)
The methods were added in #89 but they aren't implemented in TruffleRuby
yet. So let's omit them for now to have CI green.
https://github.com/ruby/strscan/commit/844d963b56 - 03:16 AM Revision 8896ac02 (git): [ruby/openssl] Fix test_pkey_dsa.rb in FIPS.
- Note that I created the `dsa2048.pem` and signature text
(`signature_encoded.txt`), that is used as a text to create the `signature0` in
the `test_sign_verify` by the following steps with the `openssl` CLI on FIPS
module.
```
$ OPENSSL_... -
- Sorry to my late action.
I recovered your account at redmine, github and our canonical repository. -
-
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue... -
-
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue... -
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue...
03/26/2024
-
- If an exception is raised the FBuffer is leaked.
For example, the following script leaks memory:
o = Object.new
def o.to_json(a) = raise
10.times do
100_000.times do
begin
JSON(o)
rescue
... - 10:52 PM Revision b2b665eb (git): [DOC] remove repetitive words in comments
- Signed-off-by: crazeteam <lilujing@outlook.com>
-
- Nobu approved this change on the PR, so I've merged it: https://github.com/ruby/ruby/commit/a7ff264477105b5dc0ade6facad4176a1b73df0b
I'll introduce a separate PR to add the test to ruby-spec. -
- @nobu can you please review <https://github.com/ruby/ruby/pull/10365> thanks!
Some more background found by @mame:
- Originally introduced in <https://github.com/ruby/ruby/commit/2d5061bd98a59fc1b9a477074f8f7a3500db8342>. It looks ... -
- In the following program, the behaviour of the parent process is affected by whether `Process.fork` is invoked or not.
```ruby
Thread.handle_interrupt(RuntimeError => :never) do
Thread.current.raise(RuntimeError, "Queued error")
... - 09:10 PM Revision a7ff2644 (git): Don't clear pending interrupts in the parent process. (#10365)
-
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> It doesn't seem like String#getbyte is much faster than File#getbyte, and StringIO#getbyte is fastest of all.
I'm seeing a similar result to what you show above with YJIT disabled, but `s... -
- byroot (Jean Boussier) wrote in #note-3:
> We tried this, but it was way slower (https://github.com/redis-rb/redis-client/pull/150), we haven't dug much as to why. But generally I'd love if I could just rely on the internal IO buffer in... -
- > I think #19315 is a more general solution for this.
I don't think so, because for the `to_i` case at least, you can already do this today with `byteslice`:
```ruby
def parse_int(offset)
@buffer.byteslice(offset, -1).to_i
end
```
B... -
- BTW I think the custom String#to_i makes a lot of sense, and might be faster than String#to_i because it needs to handle fewer cases and can e.g. handle reading directly from an IO vs going through a String in between.
-
- I think #19315 is a more general solution for this.
It feels unidiomatic to add `offset` kwargs to core methods just to avoid substrings, I think we should make substrings faster instead.
For unpack it's more natural to have an offse... -
- ### Context
I maintain the `redis-client` gem, and it comes with an optional swapable implementation in C that binds the `hiredis` C client, [which used to performs up to 5 times faster in some cases](https://github.com/redis-rb/redis... -
-
06:41 PM Revision 4a78d752 (git): [ruby/prism] Fix an incorrect range of `Prism::Location` when `PM_ERR_RETURN_INVALID`
- This PR fixes the following incorrect range of `Prism::Location` when `PM_ERR_RETURN_INVALID`.
It may be hard to tell from the text, but this Ruby error highlights `return`:
```console
$ ruby -e 'class Foo return end'
-e:1: Invalid ret... -
06:33 PM Revision 696b2716 (git): Return stdbool from recursive_check()
- The return value is used as a boolean value in C. Since it's not used as
a Ruby object, it just seems confusing that it returns a VALUE. -
06:29 PM Revision e16086b7 (git): Refactor init_copy gc attributes
- This PR moves `rb_copy_wb_protected_attribute` and
`rb_gc_copy_finalizer` into a single function called
`rb_gc_copy_attributes` to be called by `init_copy`. This reduces the
surface area of the GC API.
Co-authored-by: Peter Zhu <peter@p... -
- similarly to 332f4938cf3adbff8f15b647767dc660583a5bef
-
- It gives true/TRUE (int) instead of Qtrue (VALUE).
-
-
05:53 PM Revision 4bdb7961 (git): Mark frame info structs with rb_gc_mark_movable
- Using rb_gc_mark_movable and a reference update function, we can make
frame infos movable in memory, and avoid pinning frame info backtraces.
```
require "objspace"
exceptions = []
GC.disable
50_000.times do
begin
raise "some exce... -
-
- https://github.com/ruby/prism/commit/f49261a9b9
-
- https://github.com/ruby/prism/commit/c1400d8aed
-
- https://github.com/ruby/prism/commit/50372fee5c
-
03:02 PM Bug #20168: Process won't exit when Ractor.select waiting a Ractor
- I think I have encountered the same issue. I was able to reproduce the problem using a simpler code that results in a process hang when a Ractor, which internally raises an exception, is passed to `Ractor.select`.
Here is the minimal co... -
-
- https://github.com/ruby/prism/commit/c7a7af1eac
-
- Should we remove that note simply?
-
- I am looking into Ruby licenses and I stumble upon vsnprintf.c, namely about these lines:
~~~
/*
* IMPORTANT NOTE:
* --------------
* From ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
* paragraph 3 above is n... -
- Some extensions (like stringio) may need to differentiate between
chilled strings and frozen strings.
They can now use rb_str_chilled_p but must check for its presence since
the function will be removed when chilled strings are removed.... -
- https://github.com/ruby/irb/commit/2057248e40
-
- Applied in changeset commit:git|a850cd1a87bef738c40d9c550fb8823699083f2e.
----------
[Bug #20392] Block arguments duplication check at `super` -
- jeremyevans0 (Jeremy Evans) wrote in #note-4:
> It's missing entries for `NODE_SUPER` and `NODE_ZSUPER` in `get_nd_args`, so the `nd_args` are ignored for those nodes. At least those node types should be fixed, and all other node types... -
- https://github.com/ruby/ruby/pull/10361
-
12:57 AM Bug #20392: Delegate super calls with a block
- tenderlovemaking (Aaron Patterson) wrote in #note-3:
> Dan0042 (Daniel DeLorme) wrote in #note-1:
> ...
It's missing entries for `NODE_SUPER` and `NODE_ZSUPER` in `get_nd_args`, so the `nd_args` are ignored for those nodes. At least t... -
- Dan0042 (Daniel DeLorme) wrote in #note-1:
> In Ruby 3.2, example 3 raised an exception "both block arg and actual block given"
> ...
Thanks, I should have checked older versions. According to git bisect, this was introduced in fdc329... -
- `super(...){}`should be a syntax error, just as `foo(...){}` is.
`super` behavior in general is special. For example, `super(arg)` is not a zsuper, but still passes the block implicitly, you have to do `super(arg, &nil)` to avoid p... -
- After finding the "if if" typo, some additional typos identified by running `codespell` are also being corrected:
https://github.com/codespell-project/codespell
https://github.com/ruby/prism/commit/e6a34cfeeb -
-
- (maybe) from 9cf754b the test fails on some environments:
https://rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/20240325T200004Z.fail.html.gz
```
1) Failure:
TestGc#test_gc_stress_at_startup [/home/chkbuild/chkbuild/tmp/build/20240... -
- Implemented `Hash.new(capacity:)` in https://github.com/ruby/ruby/pull/10357
-
- For the time being, how about using rubylang/ruby image?
https://hub.docker.com/r/rubylang/ruby/
Currently, there is no core developer in Ruby responsible for alpine (or musl) support. Therefore, I don't think there is currently an... -
- https://github.com/ruby/ruby/pull/9673#issuecomment-2019028293