Activity
From 11/26/2023 to 12/02/2023
12/02/2023
-
09:17 PM Revision d4b1f56f (git): [Fix] Support when nil is assigned to variable `name` (#9105)
- * Add `!name.nil?` to if condition
-
06:06 PM Revision ad54fbf2 (git): Add missing GVL hooks for M:N threads and ractors
- [Bug #20019]
This fixes GVL instrumentation in three locations it was missing:
- Suspending when blocking on a Ractor
- Suspending when doing a coroutine transfer from an M:N thread
- Resuming after an M:N thread starts
Co-authored-by:... -
05:46 PM Revision 715cf9b6 (git): [DOC] More on What's Here (#9099)
- * More on What's Here
* More on What's Here -
02:46 PM Bug #19144: Ruby should set AI_V4MAPPED | AI_ADDRCONFIG getaddrinfo flags by default
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-5:
> @akr could you take a look at my PR when you get a chance? I think I addressed your feedback, please let me know if I have misunderstood!
It seems fine.
I agree that we remove the te... -
02:06 PM Revision d1691617 (git): Pin instruction storage
- The operands in each instruction needs to be pinned because if
auto-compaction runs in iseq_set_sequence, then the objects could exist
on the generated_iseq buffer, which would not be reference updated which
can lead to T_MOVED (and subs... -
01:17 PM Feature #20034: [mkmf] Support creating a compilation database for C language tooling
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-3:
> I wonder if a middle ground between "in cruby" and "in a gem that ~nobody knows about" would be to include this functionality in the `rake-compiler` gem.
This was my initial idea t... -
07:17 AM Feature #20034: [mkmf] Support creating a compilation database for C language tooling
- kjtsanaktsidis wrote:
> I wonder if a middle ground between "in cruby" and "in a gem that ~nobody knows about" would be to include this functionality in the rake-compiler gem.
This may be useful in that the functionality could beco... -
12:13 AM Feature #20034: [mkmf] Support creating a compilation database for C language tooling
- > It did not work for me (insomuch that I could not find the generated compile-commands.json)
I just had another play around with it - It did work (spat out `./ext/nio4r/compile_commands.json` when I tried to compile nio4r, for exampl... -
12:48 PM Revision 092a17e7 (git): [DOC] Markup class name `Time` as code
-
- So that it can be referred as a part of the document of `Time`.
-
- https://github.com/ruby/rdoc/commit/83f0149fc1
-
- I stared at this and did a bit of `printf` on it, and I _think_ I worked out that the formula for how many pages to add in one heap actually relates to how many objects there are in all the other heaps, even if they're not moved. Here's ...
-
09:58 AM Bug #19877: Non intuitive behavior of syntax only applied to literal value
- I found a similar behavior for MATCH node (Prism::MatchLastLineNode)
~~~ruby
RubyVM::AbstractSyntaxTree.parse 'if (1; //); end'
(none):1: warning: regex literal in condition
=>
(SCOPE@1:0-1:15
tbl: []
args: nil
body:
(IF@... -
08:58 AM Bug #20036: Backport 6ebcf25de2859b5b6402b7e8b181066c32d0e0bf
- ruby_3_2 82d39cb846748cd7de618b34b818f34d2c077e7e merged revision(s) 6ebcf25de2859b5b6402b7e8b181066c32d0e0bf.
-
- This is a backport management ticket.
I think https://github.com/ruby/ruby/commit/6ebcf25de2859b5b6402b7e8b181066c32d0e0bf should be backported into ruby_{3_1,3_2}. -
- GC guard catch_table_ary in iseq_set_exception_table
The function iseq_set_exception_table allocates memory which can cause
a GC compaction to run. Since catch_table_ary is not on the stack, it
can be moved, whic... -
04:32 AM Revision 4ee1f0fb (git): [ruby/irb] Implement `history` command
- (https://github.com/ruby/irb/pull/761)
* Implement `history` command
Lists IRB input history with indices. Also aliased as `hist`.
* Add tests for `history` command
* Address feedback: `puts` with multiple arguments instead of `join`...
12/01/2023
-
11:58 PM Revision 9f6c6f88 (git): Lrama v0.5.11
-
10:56 PM Revision 818813c2 (git): Implement paren node for `defined?`
- Implements and adds a test for passing a parentheses node to `defined?`.
- 10:51 PM Revision 6ecc1ca9 (git): [DOC] Update ARGF.readlines documentation to match/reference IO.readlines.
-
- Moving `-n`/`-p` makes impossible to check `break`/`next`/`redo` in parser.
```shell-session
$ ruby -c -p -e break < /dev/null
Syntax OK
$ ruby -c -e break < /dev/null
-e:1: Invalid break
break
-e: compile error (SyntaxError)
``` -
06:44 PM Misc #20035 (Closed): Command-line settings move from parser to compiler
- Right now, when you pass `-n`, `-p`, `-l`, or `-a`, these options are all passed to the parser to manipulate the parse tree into giving you the desired behavior. For example:
$ ruby --dump=parsetree -p -e "foo"
``` ruby
############... -
- The expandarray instruction can allocate an array, which can trigger
a GC compaction. However, since it does not increment the sp until the
end of the instruction, the objects it places on the stack are not
marked or reference updated by... -
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-1:
> Does this do what you want? (I haven’t used it in a year or so, so it could just be broken at the moment - if so let me know and I’ll try and fix it).
I found this during my search... -
- Oh, I wrote a gem for this a while ago! https://rubygems.org/gems/extconf_compile_commands_json
Does this do what you want? (I haven’t used it in a year or so, so it could just be broken at the moment - if so let me know and I’ll try ... -
- # Abstract
Ruby projects are often developed with C extensions. These can be easily compiled by ruby by using `create_makefile` in `mkmf.rb`. Unfortunately, most C tooling is unable to interpret the ruby build system for C files, and ... -
- A lot of tools use Ripper/RubyVM::AbstractSyntaxTree to determine
if a source is valid. These tools both create an AST instead of
providing an API that will return a boolean only.
This new API only creates the C structs, but doesn't bot... -
- 08:10 PM Revision 562d949e (git): [ruby/prism] Fix parsing heredoc ends
- https://github.com/ruby/prism/commit/aa8c702271
-
- This PR implements the following literals:
- String
- Symbols
- Integers
- Floats
- Regexs
- Ranges
- Lambdas
- Hashes
and tests for them. -
-
- Embedded shared strings cannot be moved because strings point into the
slot of the shared string. There may be code using the RSTRING_PTR on
the stack, which would pin the string but not pin the shared string,
causing it to move. -
07:50 PM Revision 0ed55bf0 (git): [rubygems/rubygems] Reduce array allocations when loading definition
- The same array was being re-created in a loop (as well as the `generic_local_platform`), which is avoidable by hoisting it to a frozen array created once
https://github.com/rubygems/rubygems/commit/009a3c6d0d -
- Applied in changeset commit:git|a607d62d8c5786087916413c369dbde0c62db573.
----------
[Bug #20033] Dynamic regexp should not assign captures -
- https://github.com/ruby/ruby/pull/9097
-
01:38 PM Bug #20033: `/#{''}(?<lvar>)/ =~ s` looks like a dynamic regexp match but assigns to local variable
- +1, it should only be static regexp literals which assign variables (= without `#{}`), that's much simpler for everyone to understand.
The current situation feels like mixing parsing and compilation/optimization in the parser. -
- I expect all of these code not to assign to lvar because all regexp looks like embedded dynamic regexp.
~~~ruby
/#{''}(?<lvar>)/ =~ '' # assings to lvar
/#{"#{''}"}(?<lvar>)/ =~ '' # does not assign to lvar
/#{<<A}(?<lvar>)/ =~ '... -
-
- https://github.com/ruby/prism/commit/e148e8fe6a
-
06:23 PM Revision 2a8d9c59 (git): [PRISM] Account for RescueNodes with no statements
- We need a PUTNIL if a RescueNode has no statements.
-
- This commit sets the ambiguous param flag if there is only one
parameter on a block node. It also fixes a small bug with a trailing
comma on params. -
06:04 PM Revision ef466ac9 (git): [ruby/irb] Scrub past history input before split
- (https://github.com/ruby/irb/pull/795)
* Scrub past history input before split
* Don't rewrite ENV["LANG"]
https://github.com/ruby/irb/commit/0f344f66d9 -
05:52 PM Revision 73440e1e (git): [rubygems/rubygems] Many major_deprecations supply :removed_message
- Generally the removed message is very similar, but often it needs to
specify that the feature has "been removed" instead of "will be
removed", or "been deprecated". And a few chunks of text needed more
substantial updates. And a number o... -
- If supplied, it uses that in place of the message for the case where the
deprecation version is already past.
https://github.com/rubygems/rubygems/commit/1deb73663c -
- Applied in changeset commit:git|e5e1f9813e23c427cf45a25181b2e6d3cf97411a.
----------
[Bug #19838] Flush delayed token nonconsecutive with the next token -
-
-
-
-
- Prior to this commit, we weren't accounting for hidden variables
on the locals table, so we would have inconsistencies on the stack.
This commit fixes params, and introduces a hidden_variable_count
on the scope, both of which fix paramet... -
-
- Previously numbered parameters were a field on blocks and lambdas
that indicated the maximum number of numbered parameters in either
the block or lambda, respectively. However they also had a
parameters field that would always be nil in ... -
04:40 PM Revision 90d9c20a (git): [PRISM] Compile RescueNode
-
- Thank you @nobu that fixes the regex, but we still need it for flip-flops:
https://github.com/ruby/prism/issues/1923
``` ruby
RubyVM::AbstractSyntaxTree.parse 'if (1; a..b); end'
# =>
(SCOPE@1:0-1:17
tbl: []
args: nil
bod... -
-
- https://github.com/ruby/prism/commit/f4c80c67dc
-
03:17 PM Revision cbe57caa (git): [ruby/prism] Fix comments after HEREDOCs again.
- The problem was deeper than just looking back a single token.
You can push the heredoc_end token way back into the list.
We need to save the last location of a heredoc end to see if
it's the last token in the file.
Fixes https://github.... -
03:15 PM Revision ffeec108 (git): [ruby/prism] Add missing context names to the switch in `debug_context`
- Now, `PM_DEBUG_LOGGING` can be available.
https://github.com/ruby/prism/commit/569ffacb5f -
- Fix https://github.com/ruby/prism/pull/1946
This fixes to set an error position for unterminated strings to the
opening delimiters. Previously, the error position was set to the end
of the delimiter.
The same fix applies to other strin... -
- I don't know when it is changed, but the `not_provided` signature is
changed.
https://github.com/ruby/prism/commit/0255cc307d -
-
-
-
- I played around a bit and both time and memory seem linear in the size of the input string on CRuby.
However the memory usage is indeed huge, ~2GB for 50MB string, ~4GB for 100MB string, ~8GB for 200MB string, etc.
I tried it on Truffle... -
12:46 AM Feature #20031: Regexp using greedy quantifier and unions on a big string uses a lot of memory
- I think this behavior is expected. The regex engine stretches the stack by the number of charaters in the input string because of backtracking. The size of the stack is visible as memory usage.
Simply put, `/.*(foo|bar)/` is inefficie... -
11:33 AM Revision 64c4bbb8 (git): [ruby/prism] Add test/prism/snapshots/heredoc_with_comment.txt
- https://github.com/ruby/prism/commit/97b296a0f7
- 07:48 AM Revision e005c517 (git): Update default gems list at 7d142c08cb5b65e4ba110b116c41a8 [ci skip]
-
-
- > https://github.com/flori/json/pull/525
> Rename escape_slash in script_safe and also escape E+2028 and E+2029
Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
> https://github.com/flori/json/pull/454
> Remove unnecessa... -
07:47 AM Revision 0dfeb172 (git): Rename escape_slash in script_safe and also escape E+2028 and E+2029
- It is rather common to directly interpolate JSON string inside
<script> tags in HTML as to provide configuration or parameters to a
script.
However this may lead to XSS vulnerabilities, to prevent that 3
characters need to be escaped:
... -
- They are allocated with ruby_xmalloc, they should be freed with
ruby_xfree. -
- https://github.com/flori/json/commit/ca546128f2
-
- Previously in the JSON::Ext parser, when we encountered an "Infinity"
token (and weren't allowing NaN/Infinity) we would try to display the
"unexpected token" at the character before.
https://github.com/flori/json/commit/42ac170712 - 07:47 AM Revision 854e6559 (git): [flori/json] tests/ractor_test.rb: make assert_separately available
- Require tests/lib/helper.rb to avoid:
NoMethodError: undefined method `assert_separately'
https://github.com/flori/json/commit/a81bcc0328 -
07:45 AM Revision 062b59ba (git): Fix typos [ci skip]
-
-
- Applied in changeset commit:git|d503e1b95a40e45d7767e0175de60092de4ba54e.
----------
[Bug #20030] dispatch invalid escaped character without ignoring it -
- https://github.com/ruby/ruby/pull/9091
This fixes another ripper scanner event issue at a syntax error too. -
-
-
03:20 AM Revision 52c26601 (git): Fixup with review comment
- https://github.com/ruby/ruby/pull/9088#discussion_r1411490445
-
- The test for Socket::ResolutionError#error_code fails in the FreeBSD environment with this test condition. Because Socket::ResolutionError#error_code returns Socket::EAI_FAIL instead of Socket::EAI_FAMILY.
https://rubyci.s3.amazonaws.co... -
- https://github.com/ruby/prism/commit/ce4c67fb3a
-
-
- https://github.com/ruby/prism/commit/b9510aed40
-
- https://github.com/ruby/prism/commit/f4b7beadc9
-
- https://github.com/ruby/prism/commit/c52c7f37ea
-
- https://github.com/ruby/prism/commit/98e218d989
-
- https://github.com/ruby/prism/commit/9461384b0c
-
-
- https://github.com/ruby/prism/commit/2d5b9c2b3c
-
- https://github.com/ruby/prism/commit/edfb54f039
-
- https://github.com/ruby/prism/commit/7ddf651bab
-
- https://github.com/ruby/prism/commit/ca3ab7ec89
-
- https://github.com/ruby/prism/commit/4c06b6c42e
-
-
- https://github.com/ruby/prism/commit/ba5218385a
-
- https://github.com/ruby/prism/commit/d040337ce9
-
-
-
- https://github.com/ruby/prism/commit/709fb6e09f
-
02:35 AM Revision ba1cdadf (git): YJIT: Cancel on-stack jit_return on invalidation (#9086)
- * YJIT: Cancel on-stack jit_return on invalidation
Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
* Use RUBY_VM_CONTROL_FRAME_STACK_OVERFLOW_P
---------
Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> -
-
-
12:50 AM Feature #20011: Reduce implicit array allocations on caller side of method calling
- I expanded the pull request to handle `getblockparamproxy` for block arguments, in addition to `getlocal` and `getinstancevariable`. `getblockparamproxy`is used inside methods, when the block being passed in the current calls was passed...
-
12:19 AM Revision 5888a16a (git): YJIT: Use `stats[:live_page_count]`, renamed from :compiled_page_count
- Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
11/30/2023
-
- Agreed. He is a great hacker who can write patches for very difficult areas and has the ownership to follow up on issues that arise after the merge.
-
- +1
-
- Thank you for your nomination! I very much appreciate it, it's a real privilege. It's been great fun being part of the Ruby community, and I look forward to working even more closely with you all on Ruby if accepted as a committer.
-
- +1
-
08:11 PM Misc #20032: Propose @kjtsanaktsidis as a commiter
- +1
-
- I'd like to propose @kjtsanaktsidis as a committer, with a focus on bug triaging and fixing. During RubyKaigi 2023, KJ expressed interest in helping triage and fix bugs, and since then, he has fixed numerous bugs. What's most impressiv...
-
- Indenting by 2 spaces wasn't yielding nested list up as intended. I guess
it's a quirk of RDoc's markdown parser:
https://github.com/ruby/rdoc/blob/v6.6.0/lib/rdoc/markdown.kpeg#L1128-L1130
NonindentSpace = / {0,3}/
Indent =... -
-
10:14 PM Revision 73e6d8a0 (git): YJIT: optimized codegen for `rb_ary_length()` (#9085)
- YJIT: optimized codegen for rb_ary_length()
-
- These assertions check that binary search tree invariants are held for
the new tree. -
-
- Instead of incrementing the depth using call by reference as we're
recursing up the stack we could instead store an offset for each known
scope where we know the depth is going to represented differently in the
Prism ast. -
- It's too difficult for me to keep track that y is the new node, x is the
new left node, z is the new right node, a is the new left left node,
b is the new left right node, c is the new right left node, and d is
the new right right node. ... -
07:58 PM Bug #19417 (Closed): Regexp \p{Word} and [[:word:]] do not match Unicode Other_Number character
- Applied in changeset commit:git|060f14bf62ad3f426a6666901c45b82d4334fa26.
----------
Update documentation for [[:word:]] and \p{Word} in regexps
Onigmo uses Decimal_Number and not Number for these.
Fixes [Bug #19417] - 07:58 PM Revision 7008d97b (git): [rubygems/rubygems] Only show "Defaulting to user installation" message when it matters.
- https://github.com/rubygems/rubygems/commit/61b0947225
-
-
07:26 PM Bug #19392: Endless method and parsing priorities
- Updated the description to underline the nature of the problem better.
-
- Onigmo uses Decimal_Number and not Number for these.
Fixes [Bug #19417] -
- 05:42 PM Revision 0d1917ae (git): [ruby/prism] Remove no-op assignment
- https://github.com/ruby/prism/commit/4b3079d9e8
-
05:41 PM Feature #20031 (Feedback): Regexp using greedy quantifier and unions on a big string uses a lot of memory
- Trying to match on some regexp using a greedy quantifier on any character (`.*`) and unions (`foo|bar`) uses a lot of memory if the string we want to match on is big.
# Reproduction code
```ruby
puts RUBY_DESCRIPTION
unless Fil... -
- Previously, vm_make_env_each() did:
1. ALLOC env_body
2. Copy locals into env_body
3. Allocate imemo_env
4. Set up imemo_env with env_body
If compaction runs during (3), locals copied to env_body could be
moved and the imemo_env... -
- ~~~ruby
Ripper.tokenize '"\\C-あ"' # or Ripper.tokenize "\"\\C-\u3042\""
# =>
["\"", "\x81", "\x82", "\""]
~~~
I expect all tokens to be valid_encoding if the source string is valid_encoding.
This is causing IRB crash when typing ... -
-
03:22 PM Revision f193f96d (git): [ruby/irb] Page evaluation result's output
- (https://github.com/ruby/irb/pull/784)
* Page evaluation result's output
This will make it easier to work with long output that exceeds the terminal's height.
* Use consistent TERM in rendering tests
This makes sure we get consistent... -
- https://github.com/ruby/rdoc/commit/dc56f6d0bd
-
- 3.3. got some major GC changes that do translate in very meaningful
performance gains, we should surface that. -
- It's possible for `defined?(A::B::C)` to raise an exception. `defined?`
must swallow the exception and return nil, so this commit adds a rescue
entry for `defined?` expressions on constant paths - 02:10 PM Revision 2c64041e (git): [ruby/prism] Fix typo in comment
- https://github.com/ruby/prism/commit/eb1a6ba263
-
- Fixes https://github.com/ruby/prism/pull/1874
https://github.com/ruby/prism/commit/304dd78dd2 -
01:32 PM Bug #19920: Ruby 3.1 fails to build with --enable-shared on macos-arm64: is an incompatible architecture (have 'arm64', need '')
- This problem happens only on SIP-disabled macOS, and I found that recent GitHub Actions macOS runners disable SIP... (It's enabled until macOS 11 runner)
The use of dyld environment variable has been removed since 3.2.0 by https://githu... -
01:28 PM Bug #20029 (Closed): coroutine/arm64/Context.S does not support PAC/BTI
- On aarch64/arm64, when we build with `-mbranch-protection=standard` to enable Pointer Authentication (PAC) and Branch Target Identification (BTI), the final link disable them, because `coroutine/arm64/Context.S` does not support PAC and ...
-
-
- Instead of `RUBY_REFERENCES_START` and `RUBY_REFERENCES_END`, so that
auto-indent works well. -
- Also move `struct` so that `typedef`-ed names can be used.
-
12:35 PM Revision 18f218d6 (git): Add some test cases to Data test
- I noticed that `deconstruct` and `hash` don't have enough coverage.
The behavior of `hash` is documented so I copied it. -
- mame (Yusuke Endoh) wrote in #note-21:
> * How much impact does exception generation have on performance? (Each frame of the backtrace needs to maintain self)
That's a good point. While the method name can be stored in the bytecode or s... -
- Agreed. I took the liberty to create a 3.4 target version and add it.
-
- Let's discuss this towards Ruby 3.4 :cry:
-
- https://rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20231130T103002Z.fail.html.gz
-
- https://github.com/ruby/ruby/pull/9077 ?
-
- [Feature #19630]
-
08:50 AM Feature #20024: SyntaxError subclasses
- I'm interested in this topic and proposed a while ago to add `SyntaxError#diagnostics` which is a more detailed information relating to parse errors and how to rectify them. I'd be interested in discussing this in more detail.
-
- # SyntaxError includes multiple errors
`SyntaxError` includes multiple errors like below, in this case two errors are included into one `SyntaxError`. Therefore it needs to consider how to handle such cases.
```ruby
begin
eval ... -
-
08:31 AM Misc #20028: I'd like my commit bit back
- Assigned to @hsbt. If he cannot do it, he will at least know who is in charge.
-
- That's @hsbt, but cvs-admin@ruby-lang.org seems to be the right contact. Here are the instructions you'll need to follow: https://github.com/ruby/ruby/wiki/Committer-How-To
-
06:55 AM Misc #20028 (Closed): I'd like my commit bit back
- It's been a while, in the svn -> git shuffle I lost commit privs. I'd like to help out more actively, triage issues, clean doco, etc.
Not sure who's doing admin work so I'm not sure who to assign to to expedite. -
- I wasn't too sure where to put `RUBY_CRASH_REPORT`, it's not exactly
a command line option but close enough. - 08:19 AM Revision 30e47780 (git): [ruby/cgi] Fix unescapeHTML
- https://github.com/ruby/cgi/commit/67610e6ca8
- 08:19 AM Revision 0daa0589 (git): [ruby/cgi] Add failing test cases for CGI::Escape.unescapeHTML
- https://github.com/ruby/cgi/commit/92fdb3316b
-
- @matz was absent today. We had a light discussion with the committers who were present, but will maybe hold the meeting again on 7th Dec. if matz can make it.
-
- @duerst I don't think your intuition about the character classes is correct:
``` ruby
"CAFÉ" =~ /[a]/i
# => 1
```
-
-
-
06:29 AM Misc #20015: Privacy policy for ruby-lang.org
- I would like to point out a few syntax errors in the published description or expressions whose meaning most likely departs from what was actually intended.
1
> We will not give away your email address to anyone, who is not related to ... -
- I published this at https://www.ruby-lang.org/en/privacy/.
-
- The two PRs are merged. Closing
- 04:38 AM Revision f2ad2460 (git): Update bundled gems list as of 2023-11-29
-
-
-
-
-
- Again, rsock_raise_socket_error is called only when getaddrinfo and getaddrname fail
-
- rsock_raise_socket_error is called only when getaddrinfo and getaddrname fail
-
- Socket::ResolutionError#error_code returns Socket::EAI_XXX
-
-
-
-
- Currently, auto-install with git gems fails, when
it would succeed with a rubygems-source gem
Fix the issue by doing the same fallback for git errors as we do for
missing gems, the git errors should only bubble up in these cases when
th... -
-
-
- We need to guard match from GC because otherwise it could end up being
reclaimed or moved in compaction.
11/29/2023
-
- Also make various minor edits to improve readability.
-
-
-
- Pathname::SEPARATOR_PAT is a constant and can safely be interpolated once, avoiding creating a new regexp object on every iteration
https://github.com/rubygems/rubygems/commit/75d9c0f1e4 -
- Prior to this commit, we were compiling an empty array as a
duparray of [] which meant we were allocating a new value
unnecessarily. With this commit, we emit a newarray with size 0
instead. -
-
- Prism introduced a new ImplicitRestNode. This adds tests for the
ImplicitRestNode cases, and changes one assert which is no longer
accurate. -
- This commit fixes a bug with locals in ensure nodes by setting
the local tables correctly. It also changes accessing locals to
look at local tables in parent scopes, and account for this
correctly on depths of get or setlocals. -
- The function iseq_set_exception_table allocates memory which can cause
a GC compaction to run. Since catch_table_ary is not on the stack, it
can be moved, which would make tptr incorrect. -
- 05:08 PM Revision 9fc40d2b (git): [ruby/prism] Add MacJapanese encoding
- MacJapanese (also aliased as MacJapan) is a modified Shift_JIS
encoding, but is implemented identically in Ruby
https://github.com/ruby/prism/commit/9e0a097699 -
- implementation
(https://github.com/ruby/irb/pull/772)
https://github.com/ruby/irb/commit/a4868a5373 -
- 04:15 PM Revision 9fada99c (git): [ruby/prism] added CP950 encoding
- https://github.com/ruby/prism/commit/9c2d1cf4ba
-
-
- https://github.com/ruby/prism/commit/ceae5727b8
-
03:22 PM Feature #19931: to_int is not for implicit conversion?
- > Why not try to_f, to_r, etc then? (or their implicit conversion variants, although they don't currently exist)
Because they're for explicit conversion. That would be like implicitly calling #to_i, and that's obviously a bad idea. -
- I think it would be a mistake to try `to_int` for arithmetic operators.
Why not try to_f, to_r, etc then? (or their implicit conversion variants, although they don't currently exist)
It might accidentally round values which seems prett... -
-
- Ruby allows for 0 or negative line start, this is often used
with `eval` calls to get a correct offset when prefixing a snippet.
e.g.
```ruby
caller = caller_locations(1, 1).first
class_eval <<~RUBY, caller.path, caller.line - 2
# fr... -
- Line numbers may be negative, so we need to introduce signed varint,
so renaming unsigned ones first avoid confusion.
https://github.com/ruby/prism/commit/90d862361e -
- Applied in changeset commit:git|8e93bf8e1fbac73b677c333b19a8b55ae9daddc3.
----------
[Bug #17037] Improve accuracy of division near precision limits
When dividing near the precision limit of `double`, use Bignum
division to get rid of ... -
- When dividing near the precision limit of `double`, use Bignum
division to get rid of rounding errors. -
- Applied in changeset commit:git|79eb75a8dd64848f23e9efc465f06326b5d4b680.
----------
[Bug #20025] Check if upper/lower before fallback to case-folding -
- https://en.wikipedia.org/wiki/Windows-1253#cite_note-5
> This is in addition to the existing μ at 0xEC, which remains in place. Unicode calls the one at 0xB5 "micro sign" (U+00B5) and the one at 0xEC "Greek small letter Mu" (U+03BC), al... -
- https://github.com/ruby/ruby/pull/9059
-
-
- You may want to write:
```ruby
begin
raise FooError
rescue FooError, BarError => e
puts "rescued #{e.class}"
end
``` -
- 02:21 AM Revision bd2b6b70 (git): [rubygems/rubygems] update Magnus library in Rust extension gem template
- https://github.com/rubygems/rubygems/commit/46f09800da
-
- Fix https://github.com/ruby/prism/pull/1936
https://github.com/ruby/prism/commit/232e77a003 -
- This also removes aliasing rule violations; the anonymous structs were
distinct types from `rb_method_refined_t`. -
12:39 AM Bug #20003 (Closed): Array#rassoc does not preform implicit conversion
- Applied in changeset commit:git|e4a11a1283da07fd1d94535298c605caf299a834.
----------
Array#rassoc should try to convert to array implicitly. Fixes #20003 -
-
-
11/28/2023
-
-
-
- This idea of subclasses/identifier is coming up in the context of Prism and SyntaxError, but I think it applies to any kind of Exception, so I would like to see this #issue added to Exception rather than just SyntaxError. For pretty much...
-
- @jeremyevans0
> That's already valid syntax
I am aware; I just have a feeling that repurposing it with PM might still be possible (the chance that a lot of code uses this syntax with `UpcasedMethods` to produce exception classes dyn... -
- @zverok That's an interesting proposal but let's move that discussion to another issue. I don't want this to become a syntax discussion because that could take us in a totally different direction.
-
- zverok (Victor Shepelev) wrote in #note-7:
> An aside note on this: in general, `rescue` clause is already looking very alike pattern-matching, and if we continue this approach (with adding causes/details to exceptions), we might once w... -
- > I don't like that you won't be able to rescue specific errors, but I understand the concern about forward compatibility.
An aside note on this: in general, `rescue` clause is already looking very alike pattern-matching, and if we c... -
- I think I am okay with that compromise. I don't like that you won't be able to rescue specific errors, but I understand the concern about forward compatibility.
My other desire for subclasses is that different syntax errors have diffe... -
- byroot (Jean Boussier) wrote in #note-3:
> Rather than sub classes, which have the annoying issue of having to stick around even if for some reason the case no longer exist, could we simply expose `SyntaxError#issue` (the name isn't ver... -
- A Symbol per type of SyntaxError seems easier to maintain and wouldn't create so many classes/constants/etc which would be messy in docs.
I think that's a much easier improvement to do than adding a bunch of subclasses.
It's also bette... -
- Rather than sub classes, which have the annoying issue of having to stick around even if for some reason the case no longer exist, could we simply expose `SyntaxError#issue` (the name isn't very inspired) that would return a symbol?
e... -
- I understand the need for compatibility with regard to Prism, but this ticket isn't about Prism specifically. I'm proposing this as a solution to the problem in general, devoid of the Prism context.
Regardless of other parsers, there ... -
- There are dozens of different error messages for SyntaxError so that would mean dozens of subclasses.
That seems a lot to me.
Also it would be equally hard to name all these subclasses.
And we could not rename them easily either (more... -
- Fundamentally, `foo { |bar,| }` is different from `foo { |bar, *| }`
because of arity checks. This PR introduces a new node to handle
that, `ImplicitRestNode`, which goes in the `rest` slot of parameter
nodes instead of `RestParameterNod... -
- YJIT: correctly handle case where there are no cfunc calls
Fix bug in top cfunc logging in `--yjit-stats` -
- Prior to this commit, we were conflating the size of the locals
list with the number of parameters. This commit distinguishes
the two, and fixes a related bug which would occur if we set a local
that was not a parameter -
- We are aware at parse time how many numbered parameters we have
on a BlockNode or LambdaNode, but prior to this commit, did not
store that information anywhere in its own right.
The numbered parameters were stored as locals, but this do... -
08:20 PM Feature #20027: Add Range Deconstruction
- Update title
-
- Ranges are a powerful tool in ruby. A common range I use is a date range such as `(Date.yesterday..Date.tomorrow)`. A range will often be passed around to methods because the dates hold meaning together such as a timeframe for a table fi...
-
- * [Bug #19392] Endless method vs `and`/`or`
* Not only `and`/`or` are affected, but also trailing `if`/`unless`: #19392#note-7
* When met with the behavior, it is very hard for users to diagnose the problem: #19731 which is a serio... -
- * [Bug #19877] Non intuitive behavior of syntax only applied to literal value (tompng)
* `if (1; cond1..cond2); end` becomes a flip-flop, because `1` and `()` are dropped
* `(1; (2; 3; (4; /(?<a>)/))) =~ s` assigns to `a`, because ... -
- * [Feature #18980] Re-reconsider numbered parameters: `it` as a default block parameter (k0kubun)
* Reminder to resume the discussion from the previous dev-meeting. I'll update here once I finish my action item. -
- A few weeks ago I experimented and tried to polyfill this via Object#coerce, and it doesn't result in `0 ^ 1.1 == 1`
```ruby
class Object
def coerce(other)
if self.respond_to?(:to_int)
to_int.coerce(other)
else
... -
- @matz Nobu found `0 ^ 1.1 #=> 1` by this change. Is it ok?
-
-
- Applied in changeset commit:git|982641939cf709d22dbc060df57cbed31acd3b97.
----------
Further fix the GVL instrumentation API
Followup: https://github.com/ruby/ruby/pull/9029
[Bug #20019]
Some events still weren't triggered from the r... -
-
- I thought about this again, my previous formula was incorrect. I think we need number of pages we need to add for each size pool is `num_pages(num_objects_moving_in + num_objects_in_size_pool) + 1`, where `num_objects_moving_in` is the n...
-
- > If we figure out the optimal size of every object and we set the heap to size (optimal_size * 2) + 1, it should guarantee that every object is moved before the cursors meet.
This sounds like a good idea (not least because it avoids ... -
- ko1 (Koichi Sasada) wrote in #note-4:
> Could you provide benchmarks?
I added a benchmark to the pull request. Here are the results:
```
arg_splat
after-patch: 11633482.8 i/s
before-patch: 660... -
04:53 AM Feature #20011: Reduce implicit array allocations on caller side of method calling
- Could you provide benchmarks?
-
- I should additionally mention that this is the only codepoint in any encoding that this impacts. I ran a brute-force script to find any violations, please check me work here: https://gist.github.com/kddnewton/089d23d49adb5551792293fdb5bf...
-
- When CRuby parses identifiers, it is encoding-dependent. Once the identifier is found, it determines if it starts with a uppercase or lowercase codepoint. This determines if the identifier is a constant or not.
The function is charge ... -
- Followup: https://github.com/ruby/ruby/pull/9029
[Bug #20019]
Some events still weren't triggered from the right place.
The test suite was also improved a bit more. -
- There was a bug with the rest argument in SplatNodes, this commit
fixes it, and adds more tests illustrating the behavior of
SplatNodes -
-
- mame (Yusuke Endoh) wrote in #note-7:
> @jeremyevans0 Could you measure the overhead?
Using the benchmark in the pull request, the pull request seems reliably ~5% faster in my testing for the member reader method, but mixed for other... -
- @jeremyevans0 Could you measure the overhead?
-
-
- Previously, we didn't invalidate the method entry wrapped by
VM_METHOD_TYPE_REFINED method entries which could cause calls to
land in the wrong method like it did in the included test.
Do the invalidation, and adjust rb_method_entry_clo... -
-
05:49 PM Bug #20026: Ruby doesn't throw a syntax error when rescuing with ||
- Actually I see what's going on here, this can be closed, not actually a ruby issue.
`FooError || BarError` is evaluating to `FooError` -
- We had a coworker new to ruby try an interesting syntax for rescue that doesn't result in a syntax error, and works partially.
Why does ruby allow the logical OR || operator, is there a purpose for this? If not this feels like it shou... -
-
- This impacted other tests. Please mind the commons.
/home/runner/work/ruby/ruby/src/test/ruby/test_compile_prism.rb:394: warning: already initialized constant Bar
/tmp/test_reline_config_60145/bazbarbob.rb:6: warning: previo... -
- https://github.com/ruby/prism/commit/1e6ecbaf04
-
- It is for supporting `def foo(bar = (def baz(bar) = bar; 1)) = 2` case.
https://github.com/ruby/prism/commit/c789a833c5 -
- https://github.com/ruby/prism/commit/896915de24
-
- Fix https://github.com/ruby/prism/pull/1637
https://github.com/ruby/prism/commit/0172d69cba -
- * Remove trailing spaces
* Migrate show_source tests to integration tests
Because show_source tests often need to define class and/or methods,
they can easily leak state to other tests. Changing them to integration
tests will ensure th... -
- 02:56 PM Revision 891ce461 (git): [ruby/irb] This enhancement allows a user to add the -s flag if they
- want to access a methods origin definition. It allows for chaining
of multiple esses to further go up the classes as needed.
(https://github.com/ruby/irb/pull/770)
https://github.com/ruby/irb/commit/eec1329d5a -
02:05 PM Revision 5fc71feb (git): [ruby/irb] Rescue errors from main.to_s/inspect when formatting
- prompt
(https://github.com/ruby/irb/pull/791)
Currently, IRB just terminates if `main.to_s` raises while IRB
constructs the prompt string. This can easily happen if the user wants
to start an IRB session in the instance scope of an unin... -
- Fix https://github.com/ruby/prism/pull/1924
https://github.com/ruby/prism/commit/7cde900065 -
- https://github.com/ruby/prism/commit/42b60b6e95
-
-
12:50 PM Feature #18551 (Closed): Make `Range#reverse_each` to raise an exception if endless
- Applied in changeset commit:git|458d079166ce7344c1d44b2403ff963b8c68d7d8.
----------
[DOC] Add a mention of [Feature #18551] to NEWS.md -
- In the previous dev meething, matz accepted this. I will merge the PR
-
-
- According to https://bugs.openjdk.org/browse/JDK-8268605, pthread_create
may fail spuriously. This change implements a simple retry as a modest
measure, which is also used by JDK. -
09:55 AM Bug #8299 (Closed): Minor error in float parsing
- hdtoa has the rounding logic, but it doesn't work well on x87, but no one use x87 now. This issue is resolved.
-
07:48 AM Feature #20005: Add C API to return symbols of native extensions resolved from features
- nobu (Nobuyoshi Nakada) wrote in #note-9:
> `dln_sym` has been used only to resolve and call immediately `Init_xxx` functions, and it would be reasonable to split error handling.
That makes sense.
> ...
I meant extensions, that ca... -
- Thanks, I will merge it.
-
- pcai (Peter Cai) wrote in #note-13:
> I'm unable to reproduce. Windows presents an ascii-safe alias of the TEMP folder for me so I can't seem to test the handling:
Thank you for testing.
Does it work after `set TEMP=C:\Users\희섭\tmp`... -
-
- Closed by commit:8427a8a655e2a04bfdc6a645ec967405d3617137
-
- I don't prefer this style, but it appears that a plurality of syntax
error messages between with un-capitalized messages in CRuby, so
we'll go with that for consistency, for now.
https://github.com/ruby/prism/commit/b02df68954 - 02:53 AM Revision 32b5f5be (git): [ruby/prism] Introduce char_is_identifier_utf8
- https://github.com/ruby/prism/commit/5f43e57b0f
- 01:39 AM Revision 031e81c8 (git): Update default gems list at def416899d2b72d2299ddfa97f1f94 [ci skip]
- 01:38 AM Revision def41689 (git): [ruby/stringio] Development of 3.1.1 started.
- https://github.com/ruby/stringio/commit/75da93d48f
11/27/2023
-
- * YJIT: gather call counts for individual cfuncs
Co-authored by Takashi Kokubun -
- We need to guard match from GC because otherwise it could end up being
reclaimed or moved in compaction. -
-
- * [Feature #20024] SyntaxError subclasses (kddnewton)
* Many tools rely on the specific error message coming from syntax errors.
* Many specs require a specific error message for syntax errors.
* It seems like the error message ... -
- There are many places around the Ruby ecosystem that handle syntax errors in different ways. Some provide highlighting, others provide recovery of some form, still more provide LSP metadata. In order to provide more rich information, mos...
-
-
-
-
-
-
-
- We need an answer on this in order to properly understand what we need to support. In particular,
``` ruby
(1; /(?<foo>)/) =~ s
```
assigning to the local seems incorrect. It would mean the only way for a parser (prism or any oth... -
- SplatNodes within ArrayNodes (e.g. [*1..2, 3]) need to be special
cased in the compiler because they use a combination of concatarray
and newarray instructions to treat each sequence of splat or non-splat
elements as independent arrays w... -
-
- The ary_make_shared call may allocate, which can trigger a GC
compaction. This can cause the array to be embedded because it has a
length of 0. -
- Fix https://github.com/ruby/prism/pull/1920
https://github.com/ruby/prism/commit/ee8e03bac7 -
- Fix https://github.com/ruby/prism/pull/1925
Fix https://github.com/ruby/prism/pull/1927
Previously pm_call_node_index_p does not check about a block argument
correctly and is not used in parse_write to check an index call node.
This co... -
- https://github.com/ruby/prism/commit/4d689fe1df
-
-
-
- This entirely changes how it is tested. Rather than to use counters
we now record the timeline of events with associated threads which
makes it much easier to assert that certains events are only preceded
by a specific event, and makes i... -
- Incremental marking prevents the GC from fully executing, so it may fail
to catch certain bugs. -
- https://github.com/ruby/rdoc/commit/2161157205
- 04:02 PM Revision 8427a8a6 (git): Fix flaky "Expected 499 to be >= 500" assertion in test_gc_compact.rb
- There have been some sproradically flaky tests related to GC compaction,
which fail with:
1) Failure:
TestGCCompact#test_moving_hashes_down_size_pools [/test/ruby/test_gc_compact.rb:442]:
Expected 499 to be >= 500.
What's happening h... -
- https://github.com/ruby/rdoc/commit/1f568e049d
-
- do_full_mark can change in gc_start, so we want to set auto-compaction
only after do_full_mark has been properly set. -
- Applied in changeset commit:git|ca4755b59a7bdaaffbaef05474c8d8ee187e8d7d.
----------
[Bug #20023] Resurrect fake string feature name before raising -
02:20 PM Bug #20023 (Closed): rb_require("noexist") causes segfault
- Extracted from swig 4.1.1 testsuite.
With commit:a07d84b63c (and probably with earlier commit), `rb_require("noexist") ;` seems segfault.
foo.rb:
```
#!/usr/bin/env ruby
begin
require "bar"
rescue LoadError => e
p e.to_s
... -
-
02:12 PM Misc #19980: Is the Ruby 3.3 ABI frozen?
- I've shipped a pre-release of rake-compiler dock, [v1.4.0.rc1](https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0.rc1), which supports compilation of native gems using Ruby 3.3.0-preview3.
This is only useful for t... -
- Otherwise, I think this patch makes sense. A better implementation of `GC.verify_compaction_references` has been on my todo list for a while, but I haven't gotten around to implementing it. Thank you for working on this!
-
- > Secondly, it compacts twice; once in order of ascending size pool, and once descending. This means that we are guaranteed to be able to move everything we want to move into a size pool before we start advancing that pool's own compact ...
-
- While debugging https://bugs.ruby-lang.org/issues/20021, I ran into a separate issue which I figured was worth resolving whilst I had it in my head.
The intention of GC.verify_compaction_references is, I believe, to force every single... -
-
-
-
- * Before this it was compiled but not used, because TruffleRuby has
a stringio.rb in stdlib and .rb has precedence over .so.
In fact that extension never worked on TruffleRuby,
because rb_io_extract_modeenc() has never been defined... -
10:39 AM Bug #14582: Unable to use `method__entry` and `method_return` tracing probes since 2.5
- Yes, this si still the case. And it is [documented](https://github.com/ruby/ruby/pull/3115). Nevertheless, I don't think this is acceptable. The original DTrace probes implementation imposed nearly zero cost for runtime. Later it was som...
-
- (https://github.com/ruby/irb/pull/789)
If `output_modifier_proc`'s `complete` arg is true, it means the input is
submitted. In that case, debugger hint doesn't provide value to users
and adds noise to the output. So we hide it in such c... -
- The test `TestGCCompact#test_moving_hashes_down_size_pools is flaky` is, I believe, flaky, and sometimes fails with this message:
```
1) Failure:
TestGCCompact#test_moving_hashes_down_size_pools [/home/chkbuild/chkbuild/tmp/build/... -
- > Valgind, I tend to be very confident in the results, but ASAN will be easier to integrate with CI and run consistently
That's how I see the two tools too
> ...
I don't think the ASAN stuff needs anything specific for free-on-exit... -
06:04 AM Revision 71a8daec (git): Opaque Etags for compact index requests
- This changes the CompactIndexClient to store etags received from the
compact index in separate files rather than relying on the MD5 checksum
of the file as the etag.
Smoothes the upgrade from md5 etags to opaque by generating them when ... -
06:04 AM Revision 794c879d (git): [rubygems/rubygems] Don't remember `--jobs` flag
- https://github.com/rubygems/rubygems/commit/9ab1136036
-
- https://github.com/rubygems/rubygems/commit/59a66e3560
-
- https://github.com/rubygems/rubygems/commit/cb4e26eabc
-
- https://github.com/rubygems/rubygems/commit/3fd627e486
-
- Configuration is now local by default.
https://github.com/rubygems/rubygems/commit/6bc7709aa8 -
- https://github.com/rubygems/rubygems/commit/ed4eaefac0
-
- tagomoris (Satoshi Tagomori) wrote in #note-8:
> I noticed that `dln_sym` raises LoadError when the specified symbol is not found. But I expect this API to return NULL when the symbol is not found.
> ...
`dln_sym` has been used only to... -
01:35 AM Revision 67ee91a3 (git): [ruby/psych] Prefer each_char in Psych::Visitors::Visitor::ToRuby#deserialize
- Use safe navigation operator with each_char to remove empty strings and improve readability.
https://github.com/ruby/psych/commit/5fe714b216
11/26/2023
-
10:08 PM Revision 52c7e43b (git): [rubygems/rubygems] Add missing --prefer-local to Synopsis in bundle-install.1.ronn
- https://github.com/rubygems/rubygems/commit/e956c5bbe4
-
- ```
==> memprof.after.txt <==
Total allocated: 1.13 MB (2352 objects)
Total retained: 10.08 kB (78 objects)
==> memprof.before.txt <==
Total allocated: 46.27 MB (38439 objects)
Total retained: 9.94 kB (75 objects)
```
Yes, we were al... -
- (https://github.com/ruby/irb/pull/788)
Similar to Pry, it displays user-defined aliases in the help message with
a dedicated section. With the current default aliases, it looks like:
```
...other sections...
Aliases
$ A... -
- - RDoc is not markdown, use `+` and `_` for code and variables
respectively, instead of backquotes.
- Remove useless backslashes. -
- I am sorry that only now I had time to further work on the feature.
I understand it is almost Decemeber and the feature might not make it in the 3.3 (though I would be happy if it would).
The generic backward iteration was implemen... -
- (https://github.com/ruby/irb/pull/783)
With either `IRB.conf[:USE_PAGER] = false` or `--no-pager` commnad line flag.
I decided use `--no-pager` instead of `--use-pager` because it matches with
Pry and git's command line flags.
https:/... -
-
- RDoc is not markdown.
-
- I noticed that `dln_sym` raises LoadError when the specified symbol is not found. But I expect this API to return NULL when the symbol is not found.
Which one should be better?
My expectation: libraries should raise LoadError under t... -
- To be completely honest, I think I have some counterarguments to the current conclusions.
I believe the code that looks "logically possible" should be "physically possible" (unless there is a good argument why it is impossible, like ... -
-
- - Unless `sizeof(BDIGIT) == 4`, (8-byte integer not available), the
size to be loaded was wrong.
- Since `BDIGIT`s are dumped as raw binary, the loaded byte order was
inverted unless little-endian. -
- https://github.com/ruby/resolv/commit/49aefa3bba