Activity
From 10/07/2023 to 10/13/2023
10/13/2023
-
11:59 PM Bug #19926: Range#size returns an incorrect result for ranges with a Rational endpoint
- I made a fix: https://github.com/ruby/ruby/pull/8660
-
- ```
% ~/tmp/ruby-master/bin/ruby -e '(1...3.1r).each { p _1 }'
1
2
3
```
```
% ~/tmp/ruby-master/bin/ruby -e 'p (1...3.1r).size'
2
```
```
% ~/tmp/ruby-master/bin/ruby -e 'p (1...3.1).size'
3
``` -
11:33 PM Revision 82c8f22a (git): Use the variable to skip the checkout
-
- 11:19 PM Revision d67880ab (git): Update default gems list at 0950f22cc0c848a73f1b80d0e63fcd [ci skip]
-
-
-
-
11:12 PM Revision 275c1852 (git): Allow `NON_SCALAR_THREAD_ID` machines
- s390x (Ubuntu) still fails tests with 62dfaeec2c.
-
- to bypass status checks of branch protection
-
09:11 PM Revision f6564fdd (git): [ruby/prism] Simplify DedentingHeredoc#to_a
- Move common ``results << token`` outside case-when.
https://github.com/ruby/prism/commit/84d0722ee9 -
07:48 PM Revision 81fbacb5 (git): [ruby/prism] Make PM_NODE_FLAG_COMMON_MASK into a constant
- https://github.com/ruby/prism/commit/ec66feb595
-
- https://github.com/ruby/prism/commit/1731bf4520
-
07:38 PM Revision 42484d12 (git): [ruby/prism] Move common flags to top bits
- Moves the common flag bits to the top. This lets us eliminate the `COMMON`
constant, and also allows us to group encoding flags on a nibble so we
can more easily mask them.
https://github.com/ruby/prism/commit/895508659e -
-
-
- https://github.com/ruby/prism/commit/11255f636e
-
- https://github.com/ruby/prism/commit/c82a9dad64
-
- https://github.com/ruby/prism/commit/bfcd8262a4
-
- https://github.com/ruby/prism/commit/4392775898
-
-
- https://github.com/ruby/prism/commit/abf9fd6863
-
- https://github.com/ruby/prism/commit/eedeec8f9a
-
- https://github.com/ruby/prism/commit/fadb5be520
-
- https://github.com/ruby/prism/commit/52504f8911
-
- https://github.com/ruby/prism/commit/21fad0c2ce
-
- https://github.com/ruby/prism/commit/c3f43b64a3
-
- https://github.com/ruby/prism/commit/c7ea4941c5
-
- https://github.com/ruby/prism/commit/fc49acfc59
-
- https://github.com/ruby/prism/commit/acec5a13cb
-
- https://github.com/ruby/prism/commit/66ce9280bb
-
- https://github.com/ruby/prism/commit/087cd8f28b
-
- https://github.com/ruby/prism/commit/341e027d23
-
- https://github.com/ruby/prism/commit/4334f0775b
-
- https://github.com/ruby/prism/commit/d912d48104
-
- https://github.com/ruby/prism/commit/831d5f4b45
-
- https://github.com/ruby/prism/commit/edb1674725
-
- https://github.com/ruby/prism/commit/dba9bd6b1f
-
- https://github.com/ruby/prism/commit/9c90d0a777
-
- https://github.com/ruby/prism/commit/b8420ea7ae
-
- https://github.com/ruby/prism/commit/27ca207ab3
-
- https://github.com/ruby/prism/commit/ba33607034
-
- https://github.com/ruby/prism/commit/be1d8ae8bb
-
- https://github.com/ruby/prism/commit/23b2336148
-
- https://github.com/ruby/prism/commit/c3a46e2de5
-
- https://github.com/ruby/prism/commit/e86196dde6
-
07:24 PM Revision d7058852 (git): [PRISM] Add --dump=prism mode (#8643)
-
06:35 PM Feature #18915: New error class: NotImplementedYetError or scope change for NotImplementedError
- > I wouldn't expect a test framework to rescue OutOfMemoryError for example,
Well Minitest does rescue Exception:
https://github.com/minitest/minitest/blob/6719ad8d8d49779669083f5029ea9a0429c49ff5/lib/minitest/test.rb#L196
Pretty ... -
06:27 PM Feature #18915: New error class: NotImplementedYetError or scope change for NotImplementedError
- byroot (Jean Boussier) wrote in #note-10:
> > since NotImplementedError doesn't inherit from StandardError I kind of wish there was a new exception class
> ...
It is something I would like rescued broadly. For example if I'm test driv... -
- > since NotImplementedError doesn't inherit from StandardError I kind of wish there was a new exception class
Could you elaborate? For this use case I think not inheriting from `StandardError` is better, as it's not something you'd wa... -
04:32 PM Feature #18915: New error class: NotImplementedYetError or scope change for NotImplementedError
- tenderlovemaking (Aaron Patterson) wrote in #note-8:
> I'm guilty of using `NotImplementedError` for abstract classes. I like the idea of changing the documentation, but on the other hand, since `NotImplementedError` doesn't inherit fr... -
- I'm guilty of using `NotImplementedError` for abstract classes. I like the idea of changing the documentation, but on the other hand, since `NotImplementedError` doesn't inherit from StandardError I kind of wish there was a new exceptio...
-
- * Fix compiling UndefNodes
* Fix compiling super on ClassNode
* Fix compile popped for ModuleNode
* Add checks for NULL nodes
* Only add newhash if not popped -
05:17 PM Bug #19921: TestYJIT#test_bug_19316 test failure
- @jaruga could you please help with the reproducer. I think you are the best person 😇
-
- I don't see anything that stands out in your build logs, so I'm still not sure if I can reproduce the issue myself. Since you seem to know how to reproduce this, could you consider reproducing the same issue on GitHub Actions (by modifyi...
-
- Trying to reproduce this, I have hit this on x86_64 as well as on aarch64, while it passed on other architectures. The build is here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=107436987
You can go into the architecture sp... -
03:07 AM Bug #19921: TestYJIT#test_bug_19316 test failure
- Replying to the comment I can do quickly for now:
k0kubun (Takashi Kokubun) wrote in #note-5:
> > 94) Failure:
> ...
Actually the other 93 tests are "Skipped". So build log shows something like:
```
Finished tests in 557.802217s... -
- It randomly fails like this:
https://github.com/ruby/ruby/actions/runs/6510372995/job/17683918027
and we don't want to pay for and use a larger runner for the job that
only generates false positives most of the time. -
- * [Feature #18915] Change documentation for `NotImplementedError` or introduce new exception
* People use `NotImplementedError` for abstract classes, but documentation says it's only for "a feature is not implemented on the current pl... -
03:31 AM Misc #19925 (Closed): DevMeeting-2023-11-07
- # The next dev meeting
**Date: 2023/11/07 13:00-17:00** (JST)
Log: *TBD*
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bug tracker.
- Dev meeting is a place we can ask Matz, nobu, nurse and o... -
- * on `__EMSCRIPTEN__` provides epoll* declarations, but no implementations.
* on `NON_SCALAR_THREAD_ID`, now we can not debug issues on x390s/Ubuntu so skip it.
x390s/RHEL works fine, so I think we can remove second limitation but
I cou... -
- * YJIT: Fallback opt_getconstant_path for const_missing
* Fix a comment [ci skip]
* Remove a wrapper function -
- I have not looked into the code, but it seems that the `:method` hash display order is different.
-
- Testing on Fedora Rawhide, I am facing the following test error on ppc64le:
~~~
94) Failure:
TestCoverage#test_coverage_suspendable [/builddir/build/BUILD/ruby-3.3.0-35edc14ee1/test/coverage/test_coverage.rb:870]:
pid 192974 exit ... -
02:41 PM Revision 0bf1749e (git): YJIT: Fix argument clobbering in some block_arg+rest_param calls (#8647)
- Previously, for block argument callsites with some specific argument
count and callee local variable count combinations, YJIT ended up
writing over arguments that are supposed to be collected into a rest
parameter array unmodified.
Dete... -
02:21 PM Revision 511571b5 (git): Only ruby/ruby repository runs on macos-arm-oss [ci skip]
-
02:00 PM Bug #19885: Invalid Warning for Default Gems That Will Move to Bundled Gems
- Thank you, that's much clearer.
If you want to make it perfect maybe just tweak the grammar:
"webrick is not part of the default gems since Ruby 3.0.0"
"webrick will no longer be part of the default gems in Ruby 3.0.0" -
08:28 AM Bug #19885 (Closed): Invalid Warning for Default Gems That Will Move to Bundled Gems
- I changed this warning feature only for `LoadError` at https://github.com/ruby/ruby/pull/8636.
The current behavior is here:
```
$ ruby -v -r bigdecimal -e ''
ruby 3.3.0dev (2023-10-13T07:22:09Z master 35edc14ee1) +YJIT [arm64-da... -
- If we introduce a new method for this, I think it would be better to design a more descriptive API instead of reusing a hacky pack format directive, such as `0x1234.to_binary_string(4, endian: :big) #=> "\x00\x00\x12\x34"`.
-
-
- ko1 (Koichi Sasada) wrote in #note-4:
> could you try with 10ba3fc302 (current master)?
Testing with commit:git|35edc14ee1 it seems the issue has bee fixed. Thx -
-
-
-
-
-
-
-
-
-
-
-
-
04:42 AM Bug #19910: Set#delete_if behavior inconsistent with Array/Hash
- Took a stab at it in https://github.com/ruby/ruby/pull/8642
-
- Just FYI: Documentation has been added at commit:c23b25f75f6180b7428f9650e063b1e50fc161e2 for the corner cases of minimum value.
-
- Discussed at the dev meeting. @matz said that he wanted to try to fix the behavior of Range#size instead of changing the document. If the incompatibilty is found significant, it will be reconsidered.
```ruby
(0.51..5.quo(2)).size #=>... -
- Discussed at the dev meeting. @nobu said he would investigate if he could fix it with M2.
Recovering from a stack overflow in C is not portable and complete, but it is a fact that they work almost well in Linux, which is the main prod... -
- Discussed at the dev meeting, and agreed that the current status be maintained.
* Dependency on external libraries is not very happy, but not a problem itself. Actually, set.rb had longly depended on rbtree gem.
* As long as it is na... -
-
12:19 AM Bug #19919 (Closed): Variable assignments in condition are warned however class variable assignment and constant declaration are not warned
- Applied in changeset commit:git|2794a8fef65eb16767c2f46f8f5058c10b4591b9.
----------
[Bug #19919] Warn class variable assignment and constant declaration in condition -
- With M:N thread scheduler, the native thread (NT) related resources
should be freed when the NT is no longer needed. So the calling
`native_thread_destroy()` at the end of `is will be freed when
`thread_cleanup_func()` (at the end of Rub...
10/12/2023
-
-
- --repeat-count=2 jobs are generally too slow for no good reason.
It doesn't seem related to testing the universal parser either. - 09:37 PM Revision b2808cc4 (git): Update default gems list at 3aba21511b37723b5212e44429f5e8 [ci skip]
-
09:36 PM Revision 3aba2151 (git): [ruby/irb] Bump version to 1.8.2
- https://github.com/ruby/irb/commit/47693a2213
-
- I cannot reproduce your problem in my x86_64-linux environment (Ubuntu 22.04). It also seems to succeed on Ruby CI's Fedora 38 x86_64 and all other CIs. It might be specific to how you build Ruby. Can you provide a way to reproduce your ...
-
- mtasaka (Mamoru Tasaka) wrote in #note-2:
> This is failing (for me) since https://github.com/ruby/ruby/commit/492e9437dd33f64e283a9de21f49c65d3195c1f0
Interesting. Thx for looking into this. I saw this commit, but ruled it out initi... -
- This is failing (for me) since https://github.com/ruby/ruby/commit/492e9437dd33f64e283a9de21f49c65d3195c1f0
-
- Just FTR, previously I was testing with 904413997f and everything worked just fine.
-
- Testing with 52709a4862 on Fedora Rawhide, I observe following failure:
~~~
94) Failure:
TestYJIT#test_bug_19316 [/builddir/build/BUILD/ruby-3.3.0-52709a4862/test/ruby/test_yjit.rb:1126]:
Expected no exits, but got
{:opt_and=>1}
... -
- matz (Yukihiro Matsumoto) wrote in #note-7:
> Array.pack1 is unlikely because there is no connection between the responsibilities of the method and the Array class. I also disagree with String.pack1 for the same reason.
> ...
Feature #... -
04:21 AM Feature #18573: Object#pack1
- Array.pack1 is unlikely because there is no connection between the responsibilities of the method and the Array class. I also disagree with String.pack1 for the same reason.
The most natural candidate is Object#pack1, but I question the... -
- Applied in changeset commit:git|17b0643392749f45b7aacb64fc1c1bd704d42b4c.
----------
[Bug #19924] Source code should be unsigned char stream
Use `peekc` or `nextc` to fetch the next character, instead of reading
from `lex.pcur` directl... -
- When you have a character literal, you can have an escaped character. For things that don't actually need escaping, this works out to just returning the character itself. For example:
``` ruby
?\d # => "d"
```
This works for ever... -
- could you try with 10ba3fc302 (current master)?
-
- The likely suspect would be N:M threads. cc @ko1
-
- Just FTR, previously I was testing with 904413997f and everything worked just fine.
-
- Let me share snippet of the log:
~~~
... snip ...
+ DISABLE_TESTS=
+ MSPECOPTS=
+ DISABLE_TESTS=' -n !/TestYJIT#test_bug_19316/'
+ make -C redhat-linux-build check 'TESTS=-v --show-skip -n !/TestYJIT#test_bug_19316/' 'MSPECOPT... -
-
- Use `peekc` or `nextc` to fetch the next character, instead of reading
from `lex.pcur` directly, for compilers that plain char is signed. -
-
04:54 PM Revision 1126bd8c (git): [ruby/irb] Fix require path completion disturbing string method
- completion
(https://github.com/ruby/irb/pull/726)
https://github.com/ruby/irb/commit/e42dc74ce0 -
- Some systems use not 4096 page size (64KB for example).
- 04:01 PM Revision 4387af1b (git): [ruby/prism] Fix parsing symbols in strings after labels
- https://github.com/ruby/prism/commit/e16531650d
-
03:26 PM Revision 5c876447 (git): [ruby/prism] Increase the depth for the For node index variable
- In CRuby's parser locals in for nodes appear deeper in the ast than they
do in Prism, but we can fix that with a transparent scope
https://github.com/ruby/prism/commit/460187f41e -
03:00 PM Revision c23b25f7 (git): describe the assumption for Range#overlap?.
- Range#overlap? assumes that there is no minimum value.
This assumption makes
+(...-Float::INFINITY).overlap?((...-Float::INFINITY))+ returns true
while +(...-Float::INFINITY)+ is empty. -
02:05 PM Revision b2e1ddff (git): YJIT: port call threshold logic from Rust to C for performance (#8628)
- * Port call threshold logic from Rust to C for performance
* Prefix global/field names with yjit_
* Fix linker error
* Fix preprocessor condition for rb_yjit_threshold_hit
* Fix third linker issue
* Exclude yjit_calls_at_interv from... -
- * cp macos.yml yjit-macos.yml
* Test YJIT on macOS Arm64 GitHub Actions
* Add a non-YJIT macOS Arm64 job as well -
- (https://github.com/ruby/irb/pull/728)
* Remove useless test setup and teardown that sets MAIN_CONTEXT to nil
* Avoid adding command methods to main object in test
https://github.com/ruby/irb/commit/f204829a08 -
12:56 PM Bug #19922 (Open): ObjectSpace.dump_all in multiple threads in parallel causes SEGV
- `ObjectSpace.dump_all` in multiple threads in parallel causes SEGV.
The reproduce code is here:
```
$ ruby -robjspace -e 'def dump; 10.times { ObjectSpace.dump_all } end; Thread.new { dump }; dump'
/home/wanabe/.rbenv/versions/master... -
- (https://github.com/ruby/irb/pull/701)
* Remove instance variable prompt and line_no from RubyLex
* Fix prompt test
* Rename prompt generating method and make it private
https://github.com/ruby/irb/commit/1ceb97fe2e -
11:52 AM Bug #19920: Ruby 3.1 fails to build with --enable-shared on macos-arm64: is an incompatible architecture (have 'arm64', need '')
- Proof that it fails without ruby-build: https://github.com/ruby/ruby-builder/actions/runs/6494853372/job/17638623490
With:
```yml
steps:
- run: curl -O https://cache.ruby-lang.org/pub/ruby/3.1/ruby-3.1.4.tar.gz
- run: ta... -
- See https://github.com/ruby/ruby-builder/actions/runs/6494296018/job/17636968796#step:18:9
```
installing bundled gems: /Users/runner/hostedtoolcache/Ruby/3.1.4/arm64/lib/ruby/gems/3.1.0
... -
- Applied in changeset commit:git|9694445051c4192c8f659529133acab253bd0bc3.
----------
[Feature #19422] Enable shared by default on macOS -
- We discuss this at dev meeting.
We only change default configuration to `--enable-shared` for macOS. If user want to use `--disable-shared` explicitly, we accept it. -
-
- Set to "--with-" options, not "--without-" keys.
-
- The extconf.rb in mysql2 gem repeats `dir_config('mysql')`, without
and with the default path. The third call returns the former results
even with the default path. Since it does not check the results of
the third call, that `nil` is p... -
-
-
-
- One drawback of `Range#empty?` is that we have several corner cases that cannot determine emptiness correctly (e.g., regarding exclude_end ranges or infinity).
Upon the fact we don't see the real-world use-case yet, we reject the propos... -
08:22 AM Revision 1c871c08 (git): Switch mid dump to dump_append_string_value
- I don't think it's possible to create a CI with a mid which would need
escaping to be in a JSON string, but I think we might as well not rely
on that assumption. -
- super() uses 0 as mid for its callinfo, so we need to check for that to
avoid a segfault when using dump_all. -
- I accept this as a performance improvement.
Matz.
-
-
- Applied in changeset commit:git|be1bbd5b7d40ad863ab35097765d3754726bbd54.
----------
M:N thread scheduler for Ractors
This patch introduce M:N thread scheduler for Ractor system.
In general, M:N thread scheduler employs N native threa... -
- https://github.com/ruby/securerandom/commit/029677584d
-
- This patch introduce M:N thread scheduler for Ractor system.
In general, M:N thread scheduler employs N native threads (OS threads)
to manage M user-level threads (Ruby threads in this case).
On the Ruby interpreter, 1 native thread is ... -
04:54 AM Bug #16927 (Rejected): String#tr won't return the expected result for some sign with diacritics
-
- As nobu says, since String#tr is for codepoints, so this proposal is rejected.
Maybe though a dedicated method for this use case can be reasonable, the current use case is not enough to design it. -
- This should be addressed.
Matz.
- 03:31 AM Revision 096ee064 (git): Bump ruby/setup-ruby from 1.155.0 to 1.156.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.155.0 to 1.156.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/d37167af451eb51448db3354e1057b75c4... -
02:41 AM Feature #5825: Sweet instance var assignment in the object initializer
- Maybe a different proposal, but if the `def initialize(@a, @b)` is ugly, how about a new method similar to `attr_{reader,writter}` like
```rb
class User
init_with :name, :age
# or maybe
attributes :name, :age
end
User....
10/11/2023
-
- Trying to avoid a flaky failure like:
https://github.com/ruby/ruby/actions/runs/6486918029/job/17616113816 -
- ubuntu.yml had that style because it needed a default value for configure.
For macos.yml, since `os` and `configure` always vary, there's no need
to declare them that way. -
- They appear on GitHub and this looks nicer.
-
-
- I don't think we need to test the same OS twice or the same
configuration twice. This is similar to .github/workflows/ubuntu.yml.
I also tweaked the label of Slack notifications. - 10:26 PM Revision 94508a8a (git): Fix Typo
-
10:18 PM Revision 9dcaa832 (git): [rubygems/rubygems] Avoid excess Arrays when partitioning Gem::Version.canonical_segments
- https://github.com/rubygems/rubygems/commit/338c48f935
- 07:07 PM Revision 8a8b23c0 (git): [lib/rubygems/path_support.rb] Rephrase comment
- Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
- 07:07 PM Revision be32109d (git): [rubygems/rubygems] Move "Defaulting to user installation ..." message, so `--install-dir` and `--user-install` can suppress it.
- https://github.com/rubygems/rubygems/commit/6677fc6853
- 07:07 PM Revision 28a6c4a1 (git): [rubygems/rubygems] Update incorrect comments.
- https://github.com/rubygems/rubygems/commit/6b21f593f3
- 07:07 PM Revision c83f8ad8 (git): [rubygems/rubygems] Simplify logic for Gem::PathSupport#home, and make GEM_HOME always overide it.
- https://github.com/rubygems/rubygems/commit/64273fd7e3
- 07:07 PM Revision e84b7339 (git): [rubygems/rubygems] Call check_that_user_bin_dir_is_in_path ANY time Gem.paths.home == Gem.user_dir.
- (As opposed to only if `--user-install` is passed.)
https://github.com/rubygems/rubygems/commit/0b42d0e869 - 07:07 PM Revision ee9cb86b (git): [rubygems/rubygems] Split out Gem::PathSupport#default_home_dir to fix "bundle doctor" specs.
- https://github.com/rubygems/rubygems/commit/d7f3f901f1
- 07:07 PM Revision 0b9b07a7 (git): [rubygems/rubygems] Allow test_gem_install_update_options to raise Errno::ACCES, in addition to Gem::FilePermissionError.
- https://github.com/rubygems/rubygems/commit/784fe2a814
- 07:07 PM Revision 225c05e3 (git): [rubygems/rubygems] Update tests to match new implementation of falling back to user-writable directories.
- https://github.com/rubygems/rubygems/commit/a06e657ac6
- 07:07 PM Revision 262f3453 (git): [rubygems/rubygems] [test_gem_install_update_options.rb] Fix linter warnings.
- https://github.com/rubygems/rubygems/commit/cdcb8394f6
- 07:07 PM Revision 4925570d (git): [rubygems/rubygems] Try a different approach for fallback to --user-install.
- https://github.com/rubygems/rubygems/commit/13e0704c40
- 07:07 PM Revision 7aebe2a5 (git): [rubygems/rubygems] If GEM_HOME exists + isn't writable, use --user-install.
- https://github.com/rubygems/rubygems/commit/6d20585645
-
- 👍
-
- byroot (Jean Boussier) wrote in #note-32:
> > this branch is bit of unstable.
> ...
Now I finished to ready-to-merge version (sorry too slow).
Naruse-san (release manager) allows me to merge it if it is easy to revert, so I want to tr... -
- https://github.com/ruby/prism/commit/ded8711807
-
-
- https://github.com/ruby/prism/commit/ca4943e3f9
-
- refactored for future extension
(https://github.com/ruby/irb/pull/707)
* Move completion implementation to completion/regexp_completor for future extension
* Remove constant CompletionProc and PerfectMatchedProc and add a class method
... -
- https://github.com/rubygems/rubygems/commit/6485adda54
-
- (https://github.com/ruby/irb/pull/725)
Since `debug` stores and updates the target thread via its Session's
`@tc` variable, we don't need to and shouldn't lock the UI to the thread
that activates the integration.
https://github.com/rub... -
-
- Whether or not that is useful, it is at least intentional as there are some tests for them.
-
- mame (Yusuke Endoh) wrote in #note-1:
> Assuming this is intentionally valid, I wonder if `a[&b] = c` should evaluate `b` before `c`.
That's the kind of complications which I think illustrates the Ruby syntax shouldn't support such e... -
06:24 AM Bug #19918: Should `a[&b]=c` be syntax valid?
- Is it bad that my first consideration is how this might be abused to do bad things for code golfing reasons? I blame mame.
-
- Assuming this is intentionally valid, I wonder if `a[&b] = c` should evaluate `b` before `c`.
-
- These codes are syntax valid now. Prism parses it as syntax error.
~~~ruby
a[&b]=c
a[&b]+=c
a[&b]&&=c
a[&b]||=c
~~~
Is this syntax intentional or should be error?
Issue of Prism
https://github.com/ruby/prism/issues/1636
... -
-
- * [Bug #19919] Variable assignments in condition are warned however class variable assignment and constant declaration are not warned
* Is it better to warn class variable assignment and constant declaration ? -
- Is it better to warn for class variable assignment and constant declaration in condition?
```ruby
(x, y = 1, 2) ? x : y # test.rb:1: warning: found `= literal' in conditional, should be ==
if a = 1 # test.rb:3: warning: found `= l... -
- Looks good, I think we should merge it.
(and this is already the case on TruffleRuby) -
- I've forgot this for years, and just happened to discover this branch.
https://github.com/ruby/ruby/pull/8624 -
- https://github.com/flori/json/commit/bab704eb49
-
- https://github.com/flori/json/commit/3804f38bf4
-
- https://github.com/flori/json/commit/6cbadf6b6e
-
- Given `SHAPE_MAX_NUM_IVS 80`, we transition to TOO_COMPLEX
way before we could overflow a 8bit counter.
This reduce the size of `rb_shape_t` from 32B to 24B.
If we decide to raise `SHAPE_MAX_NUM_IVS` we can always increase
that type ag... - 06:15 AM Revision e5d97308 (git): Update default gems list at 8f6a96e6ada05b2716ee6f441fd246 [ci skip]
-
- https://github.com/ruby/psych/commit/f306512d60
-
-
04:32 AM Revision 0fb10074 (git): Fix error when gems/src is read-only
- When I shared srcdir as read-only in lima-vm,
`make install` causes following error:
```
Update rbs to 33813a60752624d58dfe5ae770b39bfaf29fbaf1
error: cannot open .git/FETCH_HEAD: Read-only file system
```
I cannot find any ignore opti... -
-
- >I wonder what is the future of readline.rb? It still tries to load readline.so by default. Is this intended behavior?
It's intentional. `readline.rb` is same as `yaml.rb` for migrating backend.
`reline` is mostly compatible `libre... -
10/10/2023
-
-
-
-
- @nobu has said this already, but just to reiterate, if we changed `Foo&.bar` to do nothing in the case that it was undefined, it would break things like zeitwerk and other libraries that handle const_missing.
-
- This way the groth factor is encapsulated, which allows
rb_shape_transition_shape_capa to be smarter about ideal sizes. -
12:17 PM Bug #19917 (Closed): Segmentation fault or lost objects when using Ractor.select with moved exceptions
- I stumbled upon loss of messages with exceptions or even Segmentation fault during transfer of exception from Ractor when moving the exception. In versions 3.0 and 3.1 I saw only loss of messages, in 3.2 also Segmentation fault. Loss of ...
-
11:53 AM Bug #18914: Segmentation fault during Ruby test suite execution
- ruby_3_1 84f2aabd272a54e79979795d2d405090704a1d07 merged revision(s) ada9f8a9f78b3ccd8a5187775d06f45eb9f636f5.
- 11:52 AM Revision 84f2aabd (git): merge revision(s) ada9f8a9f78b3ccd8a5187775d06f45eb9f636f5: [Backport #18914]
- [ruby/fiddle] closure: follow variable name change
GitHub: GH-102
https://github.com/ruby/fiddle/commit/2530496602
---
ext/fiddle/closure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) -
- ruby_3_1 e031eff34387f300be27c24a725ddaa17f18f7e3.
-
11:28 AM Revision e031eff3 (git): Fix missing write barrier in iseq instruction list
- [Bug #19880]
There's a missing write barrier for operands in the iseq instruction
list, which can cause crashes.
It can be reproduced when Ruby is compiled with `-DRUBY_DEBUG_ENV=1`.
Using the following command:
```
RUBY_GC_HEAP_OLDOB... - 11:09 AM Revision 92d155ce (git): Should not do `brew upgrade`
- See 1b0da1e6236ad9a380abfe4ca8b51f06c34bb6f9
-
- ruby_3_1 eb54ed809f61fb25a0de101a7a6a649e8d4a434c merged revision(s) a28c5151f567cada0d2f5c0c3ec4df7f97b80784.
- 11:02 AM Revision eb54ed80 (git): merge revision(s) a28c5151f567cada0d2f5c0c3ec4df7f97b80784: [Backport #19855]
- Fix Array#bsearch when block returns a non-integer numeric value
---
array.c | 4 ++--
test/ruby/test_array.rb | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-) - 09:02 AM Revision fd214608 (git): [rubygems/rubygems] Update bundle-plugin man page
- The formatting was odd, and it hadn't been updated for how the global
source is handled.
https://github.com/rubygems/rubygems/commit/bf19a266ab -
-
-
- 07:00 AM Revision c68f92aa (git): Update bundled gems list at 2023-10-10
-
- If possible, could you merge the document and test update?
https://github.com/ruby/ruby/pull/7759
https://github.com/ruby/ruby/pull/7692
-
-
- While this is slightly off-topic, it's relevant to `MINIMUM`, so I'm noting it here.
`0.0..Float::INFINITY` represents the entire range of floating-point numbers that is greater or equal to 0.0.
Therefore, semantically, the range rep...
10/09/2023
-
-
10:48 PM Feature #19915: URI::HTTP.build accepts user: and password: keyboard arguments, but do not populate #user or #password
- I would expect either for unused options to raise an ArgumentError, or for `user:` and `password:` to be accepted and used. Since `URI::HTTP.build` is actually accepting a Hash [1], this makes it harder to validate the given Hash keys an...
-
12:25 AM Feature #19915: URI::HTTP.build accepts user: and password: keyboard arguments, but do not populate #user or #password
- `URI::HTTP.build` does not accept keyword arguments, it accepts an array/hash. If you pass keyword arguments, they get turned into a hash, similarly to any Ruby method that does not explicitly accept keyword arguments. The method only r...
-
- https://github.com/rubygems/rubygems/commit/834ae8a29a
-
- To fix the order of node IDs, for typeprof tests.
-
- Use `NODE_DEF_TEMP` as the wrapper of `NODE_DEFS` in ripper, not only
of `NODE_DEFN`, so that `endless_method_name` works consistently. -
- 03:05 PM Revision 6c952ac6 (git): testing_ruby.md: Document running test suites on s390x CPU architecture [ci skip] (#8589)
-
- * [Feature #13933] Add Range#empty?
* "empty?" is a basic concept for core classes
* Related to the implementation of `Range#overlap?` (empty_region_p) so why not make it a public interface?
* For beginless ranges we cannot use ... - 11:54 AM Revision f44cee90 (git): [rubygems/rubygems] Avoid duplicates -rbundler/setup in RUBYOPT with Ruby preview
- When using a Ruby preview the require path of `bundler/setup` is
similar to `-r/opt/ruby3.3.0-preview2/lib/ruby/3.3.0+0/bundler/setup`.
The special character `+` in the string makes the Regexp fail,
leading to multiple addition of the sa... -
- So when building instruction sequences for a scope we can reference
items from the ast node that requires the scope. This is useful for for
loops, where the local variable tables from the parent scope will need
to be referenced.
https:/... -
-
08:13 AM Bug #19916 (Closed): URI#to_s can serialize to a value that doesn't deserialize to the original
- It appears that when we're serializing a URI to string, we don't check/confirm that it is represented in a form that can be deserialized back into the original. I think it's fair to expect that serialize+deserialize produces an object th...
-
-
-
- In parse.y, node can be NODE_DEF_TEMP or NODE_EXITS.
Hit "unknown node" without taking care of them.
For example `ruby --dump=y lib/cgi/util.rb` causes
"[BUG] unknown node: 107". - 03:23 AM Revision a78acf18 (git): Bump ruby/setup-ruby from 1.154.0 to 1.155.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.154.0 to 1.155.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/52b8784594ec115fd17094752708121dc5... - 03:16 AM Revision a149ca51 (git): Bump ossf/scorecard-action from 2.2.0 to 2.3.0
- Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md...
10/08/2023
-
- I noticed that `URI::HTTP.build` accepts the `user:` and `password:` keyword arguments, but does not actually set the `user` or `password` attributes of the built URI object. It does however correctly accept a `userinfo:` keyword argumen...
-
07:31 PM Feature #19884: Make Safe Navigation Operator work on classes - ______________________________________________
-
10:40 AM Feature #19884: Make Safe Navigation Operator work on classes
- nobu (Nobuyoshi Nakada) wrote in #note-10:
> Rather the extension of `defined?` operator which returns the value (instead of the expression type string) or nil.
> ...
Yes, that would be nice. -
- What you want doesn't seem the extension of the safe navigation operator.
p8 (Petrik de Heus) wrote:
> If a constant isn't defined it will raise a NameError:
> ...
Rather the extension of `defined?` operator which returns the value (ins... -
04:30 AM Feature #19884: Make Safe Navigation Operator work on classes
- sawa (Tsuyoshi Sawada) wrote:
> > > > You stated that you want &. to work on classes, but that does not make sense. If ActiveRecord::Base is not defined, it is not a class. How would Ruby know that it is (supposed to be) a class?
p8 ... -
-
- pbvdon (pbv pbv) wrote in #note-3:
> Any solution for this ?
You can try 2.5.9 which had been released as the final 2.5 release, or more recent versions.
Anyway we can do nothing unless we know how to reproduce it at least, even if ... -
- I've forgot about inline option and comment, so it was complicated than I thought first.
https://github.com/nobu/ruby/tree/warn-multiline-regexp -
04:17 AM Revision 2b6228be (git): [rubygems/rubygems] Reduce allocations when parsing compact index
- This still allocates a ton (a string for each line, plus a bunch of
splits into arrays), but it helps a bit when Bundler has to go through
dependency resolution.
```
==> memprof.after.txt <==
Total allocated: 194.14 MB (2317172 objects)... -
- It has been documented.
https://github.com/ruby/rdoc/blob/master/lib/rdoc/parser/ruby.rb#L141-L142
> Note that by default, the :method: directive will be ignored if there is a
> ...
-
- It appears that the next method takes precedence over the `:method:` directive.
And that directive seems like parsed as a simple document. -
- With a simplified example like bellow, `private` does not affect the results.
```ruby
class Bug19914
##
# :method: foo
#
# :call-seq: foo(*args)
#
# Foo
private
end
```
-
01:36 AM Bug #19914: RDoc :method: directives swallowed by immediate private keyword
- zzak (zzak _) wrote:
> @jonathanhefner Recently discovered this bug in RDoc and fixed it in Rails, so I'm reporting it here on their behalf.
> ...
This should probably be reported to https://github.com/ruby/rdoc/issues instead. -
12:15 AM Bug #19914 (Feedback): RDoc :method: directives swallowed by immediate private keyword
- @jonathanhefner Recently discovered this bug in RDoc and fixed it in Rails, so I'm reporting it here on their behalf.
Examples:
* https://github.com/rails/rails/commit/c8b3642eded5a25ee5cc11c48395bed05f92424e
* https://github.com/...
10/07/2023
-
- From running in a random rails app I have locally, here are the changes
1) for `bundle lock --update --bundler` (forcing Bundler to go through
dependency resolution)
```
==> memprof.after.txt <==
Total allocated: 2.98 MB (48307 objects... -
- sawa (Tsuyoshi Sawada) wrote in #note-6:
> Then you should edit and write that in the description.
I've updated the description. Hopefully it's more clear now.
> ...
```ruby
defined?(UndefinedConstant) # returns nil instead of... -
- p8 (Petrik de Heus) wrote in #note-5:
> > Furthermore, the specification you are asking for is not clear. What Exception classes do you want `&.` to rescue?
> ...
Then you should edit and write that in the description.
> `defined?` ... -
- sawa (Tsuyoshi Sawada) wrote in #note-1:
> Currently, you can do `ActiveRecord::Base.some_method rescue nil`
That would also rescue UndefinedMethodError, ArgumentError, and any error occuring in `some_method`.
> ...
`NameError`
... -
- There's multiple examples in the Rails code base:
https://github.com/rails/rails/blob/7f7f9df8641e35a076fe26bd097f6a1b22cb4e2d/railties/lib/rails/generators/named_base.rb#L139
https://github.com/rails/rails/blob/7f7f9df8641e35a076fe26bd... -
02:24 AM Feature #19884: Make Safe Navigation Operator work on classes
- @rubyFeedback
It's common in library code, that want's to be flexible to different configurations of the target application. E.g. https://github.com/rubocop/rubocop/blob/a455e9d55771f1e3dfea0cc4183e66f9632b431c/lib/rubocop/lockfile.rb... -
-
-
-
-
-
-
- * [Misc #18984] Doc for Range#size for Float/Rational does not make sense (kyanagi)
* Range#size may return a non-nil value even if the range can't be iterated.
* Should it return nil?
* [Feature #18515] Add Range#reverse_each imp... -
- It seems that there is a similar issue with beginless ranges.
```
(..0).size # => Infinity
(..0).count # => Infinity
(..0).each {} # => can't iterate from NilClass (TypeError)
```
Is it reasonable to say the size is infinite ev...