Activity
From 08/03/2023 to 08/09/2023
08/09/2023
-
10:28 PM Revision 984109b8 (git): [ruby/irb] Skip nested IRB tests in Ruby Core CI
- (https://github.com/ruby/irb/pull/675)
Sometimes the subprocess gets stuck in the nested IRB session until timed
out. We don't have enough information to debug it yet, so skip the tests
to unblock CI.
https://github.com/ruby/irb/commit... -
09:46 PM Revision 1ccd0eae (git): YJIT: Chain guard method IDs for respond_to? (#8196)
-
- YJIT: Distinguish exit and fallback reasons
for invokesuper/invokeblock -
06:07 PM Bug #19836 (Closed): Parser leaks memory for incomplete lambdas
- Applied in changeset commit:git|0b8f15575a440f85ac686f5b0eae8f8b7c2b72e7.
----------
Fix memory leak for incomplete lambdas
[Bug #19836]
The parser does not free the chain of `struct vtable`, which causes
memory leaks.
The following ... -
- GitHub Pull Request: https://github.com/ruby/ruby/pull/8192
The parser does not free the chain of `struct vtable`, which causes memory leaks.
The following script reproduces this issue:
```ruby
10.times do
100_000.times do
... -
- Applied in changeset commit:git|5bc8fceca8d47ed1ef9c603c6531a408de36b60c.
----------
Fix memory leak in parser for incomplete tokens
[Bug #19835]
The parser does not free the `tbl` of the `struct vtable` when there are
leftover `lvtbl... -
- GitHub Pull Request: https://github.com/ruby/ruby/pull/8192
The parser does not free the `tbl` of the `struct vtable` when there are leftover `lvtbl` in the parser. This causes a memory leak.
The following script reproduces this is... -
- [Bug #19836]
The parser does not free the chain of `struct vtable`, which causes
memory leaks.
The following script reproduces this issue:
```
10.times do
100_000.times do
Ripper.parse("-> {")
end
puts `ps -o rss= -p #{$$}`... -
- [Bug #19835]
The parser does not free the `tbl` of the `struct vtable` when there are
leftover `lvtbl` in the parser. This causes a memory leak.
The following script reproduces this issue:
```
10.times do
100_000.times do
Ripper... -
- * YJIT: Count throw instructions for each tag
* Show % of each throw type -
05:12 PM Revision c9b30f9d (git): YJIT: implement imul instruction encoding in x86 assembler (#8191)
-
04:21 PM Revision a41c617e (git): Implement MUL instruction for aarch64 (#8193)
-
03:49 PM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- kddnewton (Kevin Newton) wrote in #note-16:
> I don't understand how you would go about statically detecting instance variable mutations.
Actually I'm starting to think this is doable. If we restrict ourselves to methods invoked on `sel... -
- > ```ruby
> ...
Well look at that! You learn something new every day :-D -
- I don't understand how you would go about statically detecting instance variable mutations. Consider
``` ruby
class Foo
def bar = instance_variable_set(:@baz, 1)
end
```
is `bar` "functionally pure" or not? Is it "destructive... -
01:17 PM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- Dan0042 (Daniel DeLorme) wrote in #note-13:
> it opens a big can of worms in terms of where do you draw the line for how the 'destructive' flag propagates? Which of those foo methods would you consider to be destructive?
I was really... -
08:21 AM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- Dan0042 (Daniel DeLorme) wrote in #note-13:
> shyouhei (Shyouhei Urabe) wrote in #note-12:
> ...
```ruby
STDOUT.freeze.printf("Hello, World!")
```
But yes, I agree that the word "destructive" here is kind of vague, and we are seei... -
- janosch-x (Janosch Müller) wrote in #note-11:
> A lot of everyday Ruby code seems to be destructive, not so much by setting instance variables, but rather by modifying them (e.g. Arrays or Hashes).
shyouhei (Shyouhei Urabe) wrote in... -
- Asserting that a method is destructive in spite of it does not modify its receiver is kind of safe. The problem is to prove that a method marked as non-destructive actually never do so. This is arguably impossible.
Dan0042 (Daniel D... -
- (https://github.com/ruby/irb/pull/652)
1. Dynamically including `HistorySavingAbility` makes things unnecessarily
complicated and should be avoided.
2. Because both `Reline` and `Readline` use a single `HISTORY` constant
to store ... -
02:01 PM Bug #19834: Segmentation fault while running in docker
- ramachandran@mallow-tech.com (Ramachandran A) wrote in #note-4:
> byroot (Jean Boussier) wrote in #note-3:
> ...
You probably can’t. The last version of Ruby 2.6 was Ruby 2.6.10, and you should try using that before trying to debug and... -
11:13 AM Bug #19834: Segmentation fault while running in docker
- You can of course attempt to debug it and patch it yourself.
But that version being end of life means Ruby core won't spend time on it. And even if we wanted we couldn't because you didn't include nearly enough information anyway. -
10:22 AM Bug #19834: Segmentation fault while running in docker - byroot (Jean Boussier) wrote in #note-3:
> Ruby 2.6.3 has reached end of life aeons ago.
We are working on legacy project, we can't update the ruby version in our project. How can I solve this issue without upgrading Ruby? -
- Ruby 2.6.3 has reached end of life aeons ago.
- 07:31 AM Bug #19834: Segmentation fault while running in docker
- This issue happens when ever I try to access the db from console or while making any request from browser.
ramachandran@mallow-tech.com (Ramachandran A) wrote:
> ```
> ...
> I am using Ruby 2.6.3 in my project. It works fine until t... - 07:26 AM Bug #19834 (Rejected): Segmentation fault while running in docker
- ```
2023-08-09 12:44:32 /usr/local/lib/ruby/2.6.0/openssl/buffering.rb:383: [BUG] Illegal instruction at 0x0000ffff90d911a0
2023-08-09 12:44:32 ruby 2.6.3p62 (2019-04-16 revision 67580) [aarch64-linux]
2023-08-09 12:44:32
2023-08-09... -
- * [Feature #19790] Optionally write Ruby crash reports into a file rather than STDERR (byroot)
* `STDERR` is often hard to exploit in production, as it's often shared by multiple process causing interwined logs.
* Being able to wri... -
-
01:47 PM Revision 5eef3ce2 (git): YJIT: Correct name of a counter (#8186)
-
-
-
-
-
06:35 AM Revision 86f4415f (git): Prevent a warning: global variable `$VERSION' not initialized
-
08/08/2023
-
- This has been unstable:
https://github.com/ruby/ruby/actions/runs/5797755676/job/15713988590
and I'm not sure if we need that in the first place, assuming the
OS image itself is maintained by GitHub. -
- Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
-
- Dan0042 (Daniel DeLorme) wrote in #note-10:
> For regular ruby code, probably the only way to know if a method is destructive is to check for instance variable assignments.
A lot of everyday Ruby code seems to be destructive, not s... -
- This is a great idea. No doubt there are many cases where it's impossible to know *for sure* if a method is destructive or not, but it should be possible to make it good enough to be useful.
> Consider for instance Array#map. Is this ... -
- Well yes this property could be very useful for Ractor, JIT, and many more... except it's impossible.
Consider for instance `Array#map`. Is this method destructive? Well it _could_ be used in a destructive way. But who knows.
A... -
- Functions rgengc_remembered, rgengc_remembered_sweep, and
rgengc_remembersetbits_get are just wrappers of RVALUE_REMEMBERED and
doesn't do much more. We can remove all those and use RVALUE_REMEMBERED
directly instead. -
01:21 PM Revision 397a7755 (git): [ruby/yarp] Fix wrong conversion and cast
- Conversions from `uint64_t`/`VALUE` to `long` may loose upper bits.
https://github.com/ruby/yarp/commit/c26f650d96 -
- https://github.com/ruby/yarp/commit/2d1135769d
-
12:04 PM Bug #19771: Backport Speed up rebuilding the loaded feature index and realpath cache - 79a4484, abfac22
- The fix is reverted by the bot, is it possible to take another look at this issue?
https://github.com/ruby/ruby/pull/8023#ref-commit-1c76244 -
- Applied in changeset commit:git|72d1a790cfe0e4a457db98c587f1acaa5e39f001.
----------
[Bug #19833] Fix index underflow at superclasses of `BasicObject` -
- https://github.com/ruby/ruby/pull/8185
-
08:52 AM Bug #19833: Superclass of BasicObject is broken.
- I can reproduce since 3.2.
```
$ docker run --platform linux/amd64 --rm -it ghcr.io/ruby/all-ruby env LANG=C.UTF-8 ALL_RUBY_SINCE=ruby-1.9 ./all-ruby -e 'class BasicObject; include ::Module.new; p superclass; end'
ruby-1.9.0-0 ... -
08:34 AM Bug #19833 (Closed): Superclass of BasicObject is broken.
- I encountered a phenomenon where a non-class object appeared in the superclass of BasicObject.
The minimum reproduction code is below.
```rb
module Mod
end
BasicObject.include Mod
# or BasicObject.prepend Mod
p BasicObject... -
10:37 AM Feature #19783: Weak References in the GC
- An alternative to recording the weak reference **fields** during tracing is recording the **objects** that contain weak references on creation. For example, we can record a `imemo_callcache` into a darray when the `imemo_callcache` is c...
-
-
- > also afraid if this can work well in a signal handler.
Yeah, as @kjtsanaktsidis said, in theory the current one already use things that aren't async signal safe, so I don't think it really change much here.
`open(2)` should be as... -
05:34 AM Feature #19790: Optionally write Ruby crash reports into a file rather than STDERR
- > afraid if this can work well in a signal handler.
The current bugreporter does lots of things which are not _really_ safe to do in a signal handler... even `fprintf` is not async-signal-safe (at least on Linux, according to signal-saf... -
- Note that the branch includes a testing feature, and is not ready to merge as-is.
-
- byroot (Jean Boussier) wrote in #note-2:
> Thank you @nobu, I wasn't expecting someone to implement it :)
> ...
I'm positive, but also afraid if this can work well in a signal handler. -
08/07/2023
-
-
-
-
- 06:44 PM Revision a5ffcfbd (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.79 to 0.9.81.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.79...v0.9.81)
---
updated-depende... - 05:12 PM Revision 33056c29 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.79 to 0.9.81.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.79...v0.9.81)
---
updated-depende... -
- (https://github.com/ruby/irb/pull/635)
* Remove unused InputMethod#initialize
The constructor takes a `file_name` argument, but it is never used. The
only input method that needs a file is `FileInputMethod`, which has its
own construct... -
01:51 PM Revision 589c01c4 (git): [DOC] RDoc for Process (#8179)
-
- Thank you @nobu, I wasn't expecting someone to implement it :)
I take it that you are supportive of the feature? -
- Just as the state was originally passed as the return value of
`longjmp`, the state stored in EC cannot be 0 when the jump is
captured now too.
08/06/2023
-
-
-
04:46 AM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- This may have some very interesting use-cases around Ractor of forbidding any state mutation methods inside of Ractor contexts.
Many of us who program Ruby enough probably know what is destructive, sure, but having that officially wri... -
04:39 AM Feature #19832 (Rejected): Method#destructive?, UnboundMethod#destructive?
- I propose to add `destructive?` property to `Method` and `UnboundMethod` instances, which shall behave like:
```ruby
String.instance_method(:<<).destructive? # => true
String.instance_method(:+).destructive? # => false
```
One m... -
08/05/2023
-
-
05:30 PM Revision ac07d881 (git): [ruby/yarp] Add a Requirements section in Build System docs
- https://github.com/ruby/yarp/commit/298025314c
-
- https://github.com/ruby/yarp/commit/f9db0c282b
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com> -
- https://github.com/ruby/yarp/commit/0b174b76f1
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com> -
- https://github.com/ruby/yarp/commit/85ae0e2816
-
- https://github.com/nobu/ruby/tree/bugreport_path
Implemented `%%`, `%e`, `%E`, `%f`, `%F`, `%p`, `%t` and `%NNN`(octal).
When invoking pipe, the string is split with white spaces first without quoting, `%040` would be useful to repre... -
- If the required name is different from the found gem name, return the
gem name, instead of true that means the required name is an exact gem
name. -
- Revert "Revert "Skip calling jit_exec on Wasm""
This reverts commit 2e94610f70baca4af004202f288a6b5dd10889ca.
It's not about whether it's optimized away or not. I just don't want to
leave and maintain the callsite (e.g. signature) in t... -
- This reverts commit e80752f9bbc5228dba3066cd95a81e2e496bd9d7.
RJIT and YJIT are never enabled on Wasm. When both are disabled,
`jit_exec` is defined to return `Qundef` constantly, and is optimized
away. -
02:39 AM Revision 4e7e9728 (git): Remove uneeded int2big property for Universal Parser
-
01:32 AM Revision f07ef1d5 (git): Lrama v0.5.3
08/04/2023
-
- We often break Wasm build when we modify how jit_exec works. I'm
planning to modify it again soon.
We actually don't support running Ruby JIT on Wasm, so it doesn't seem
worth the maintenance effort. -
-
- (https://github.com/ruby/irb/pull/668)
https://github.com/ruby/irb/commit/bbd20445ea -
- It doesn't feel elegant or concise to feed the element size to me.
For what use cases do you want it actually? -
07:42 AM Feature #19830: Allow `Array#transpose` to take an optional size argument
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> Why not `ary.transpose[1]&.join`?
That avoids the exception but returns `nil` instead of taking advantage of `#join`’s knowledge of the “correct” result for an empty array, i.e. the empty s... -
- Why not `ary.transpose[1]&.join`?
-
- Avoid generating long dispatch chains for all array lengths seen.
-
- This reverts commit c5abe0d08f8f7686422e6eef374cf8c78aefacb6.
-
- We don't need to check stack for moved objects after compaction because
the mutator cannot run between marking the stack and the end of
compaction. However, the stack may have moved objects leftover from
marking and sweeping phases. This... -
12:12 PM Revision 6b570ff2 (git): Display call location with bundled gems warning
-
-
-
-
- Also `flag_keyword_hash` sets to 0 or a hash object.
-
- (https://github.com/ruby/irb/pull/667)
https://github.com/ruby/irb/commit/79fc6dcf5f -
- Xcode 15 beta and macOS Sonoma beta show the following warnings with `make`
```
(snip)
linking miniruby
ld: warning: ignoring duplicate library '-lpthread'
miniruby: replacing existing signature
exe/ruby: replacing existing signa...
08/03/2023
-
-
- * YJIT: handle expandarray_rhs_too_small case
YJIT: fix csel bug in x86 backend, add test
Remove commented out lines
Refactor expandarray to use chain guards
Propagate Type::Nil when known
Update yjit/src/codegen.rs
Co-authored-by:... -
- Fix str_subseq so that it does not attempt to predict the size of the
object returned by str_alloc_heap. -
- One benefit of supplying an initial value to `Enumerable#inject` is that it avoids an annoying edge case when the collection is empty:
```
>> [1, 2, 3].inject(:+)
=> 6 # good
> ...
=> nil # bad
>> [].inject(0, :+)
=> 0 # good... -
-
- Function prototype for gc_mode_transition is not needed as it's not
used before the implementation. -
- Hello @tamaron. There is no update as of yet. One of the challenges is that it's not easy for us to have access to windows machines, it would be kind of a pain for us to debug things in a VM. This would also add complexity to our CI test...
-
10:27 AM Feature #19325: YJIT: Windows support lacking.
- Hello, any progress here?
I am very new to the Ruby community but interested in working on this. -
- ary_make_partial now uses the actual embed_capa of an allocated heap
array to guide whether make an embedded copy or a slice view. -
10:45 AM Bug #19829 (Closed): Enumerator.product called with keyword arguments raises exception with not precise message
- The `Enumerator.product` method, added in Ruby 3.2, when it's called with keyword arguments (but it expects only a list of enums) raises `unknown keyword: ... (ArgumentError)` exception:
```ruby
Enumerator.product([], a: 1)
# (irb):... -
08:14 AM Bug #19792: arm の alpine 上でネストしたハッシュに長い文字列を入れると segmentation fault が発生する
- 以下の環境でも再現しました
- Docker version 24.0.2, build cb74dfc
- M1 Max
- Ventura 13.5 -
-
-
-
- assert_separately adds --disable=gems so we don't need to add
--disable-gems when calling assert_separately.