Activity
From 08/02/2023 to 08/08/2023
08/08/2023
-
11:46 PM Revision 1b0da1e6 (git): Skip running brew upgrade (#8189)
- This has been unstable:
https://github.com/ruby/ruby/actions/runs/5797755676/job/15713988590
and I'm not sure if we need that in the first place, assuming the
OS image itself is maintained by GitHub. -
- Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
-
08:32 PM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- Dan0042 (Daniel DeLorme) wrote in #note-10:
> For regular ruby code, probably the only way to know if a method is destructive is to check for instance variable assignments.
A lot of everyday Ruby code seems to be destructive, not s... -
07:28 PM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- This is a great idea. No doubt there are many cases where it's impossible to know *for sure* if a method is destructive or not, but it should be possible to make it good enough to be useful.
> Consider for instance Array#map. Is this ... -
08:23 AM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- Well yes this property could be very useful for Ractor, JIT, and many more... except it's impossible.
Consider for instance `Array#map`. Is this method destructive? Well it _could_ be used in a destructive way. But who knows.
A... -
01:44 PM Revision 74b9c7d2 (git): Remove wrapper functions of RVALUE_REMEMBERED
- Functions rgengc_remembered, rgengc_remembered_sweep, and
rgengc_remembersetbits_get are just wrappers of RVALUE_REMEMBERED and
doesn't do much more. We can remove all those and use RVALUE_REMEMBERED
directly instead. -
01:21 PM Revision 397a7755 (git): [ruby/yarp] Fix wrong conversion and cast
- Conversions from `uint64_t`/`VALUE` to `long` may loose upper bits.
https://github.com/ruby/yarp/commit/c26f650d96 -
- https://github.com/ruby/yarp/commit/2d1135769d
-
12:04 PM Bug #19771: Backport Speed up rebuilding the loaded feature index and realpath cache - 79a4484, abfac22
- The fix is reverted by the bot, is it possible to take another look at this issue?
https://github.com/ruby/ruby/pull/8023#ref-commit-1c76244 -
- Applied in changeset commit:git|72d1a790cfe0e4a457db98c587f1acaa5e39f001.
----------
[Bug #19833] Fix index underflow at superclasses of `BasicObject` -
- https://github.com/ruby/ruby/pull/8185
-
08:52 AM Bug #19833: Superclass of BasicObject is broken.
- I can reproduce since 3.2.
```
$ docker run --platform linux/amd64 --rm -it ghcr.io/ruby/all-ruby env LANG=C.UTF-8 ALL_RUBY_SINCE=ruby-1.9 ./all-ruby -e 'class BasicObject; include ::Module.new; p superclass; end'
ruby-1.9.0-0 ... -
08:34 AM Bug #19833 (Closed): Superclass of BasicObject is broken.
- I encountered a phenomenon where a non-class object appeared in the superclass of BasicObject.
The minimum reproduction code is below.
```rb
module Mod
end
BasicObject.include Mod
# or BasicObject.prepend Mod
p BasicObject... -
10:37 AM Feature #19783: Weak References in the GC
- An alternative to recording the weak reference **fields** during tracing is recording the **objects** that contain weak references on creation. For example, we can record a `imemo_callcache` into a darray when the `imemo_callcache` is c...
-
-
06:48 AM Feature #19790: Optionally write Ruby crash reports into a file rather than STDERR
- > also afraid if this can work well in a signal handler.
Yeah, as @kjtsanaktsidis said, in theory the current one already use things that aren't async signal safe, so I don't think it really change much here.
`open(2)` should be as... -
05:34 AM Feature #19790: Optionally write Ruby crash reports into a file rather than STDERR
- > afraid if this can work well in a signal handler.
The current bugreporter does lots of things which are not _really_ safe to do in a signal handler... even `fprintf` is not async-signal-safe (at least on Linux, according to signal-saf... -
- Note that the branch includes a testing feature, and is not ready to merge as-is.
-
- byroot (Jean Boussier) wrote in #note-2:
> Thank you @nobu, I wasn't expecting someone to implement it :)
> ...
I'm positive, but also afraid if this can work well in a signal handler. -
08/07/2023
-
-
-
-
- 06:44 PM Revision a5ffcfbd (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.79 to 0.9.81.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.79...v0.9.81)
---
updated-depende... - 05:12 PM Revision 33056c29 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.79 to 0.9.81.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.79...v0.9.81)
---
updated-depende... -
03:30 PM Revision 0387b86c (git): [ruby/irb] Remove unused `InputMethod#initialize`
- (https://github.com/ruby/irb/pull/635)
* Remove unused InputMethod#initialize
The constructor takes a `file_name` argument, but it is never used. The
only input method that needs a file is `FileInputMethod`, which has its
own construct... -
01:51 PM Revision 589c01c4 (git): [DOC] RDoc for Process (#8179)
-
- Thank you @nobu, I wasn't expecting someone to implement it :)
I take it that you are supportive of the feature? -
- Just as the state was originally passed as the return value of
`longjmp`, the state stored in EC cannot be 0 when the jump is
captured now too.
08/06/2023
-
-
-
04:46 AM Feature #19832: Method#destructive?, UnboundMethod#destructive?
- This may have some very interesting use-cases around Ractor of forbidding any state mutation methods inside of Ractor contexts.
Many of us who program Ruby enough probably know what is destructive, sure, but having that officially wri... -
04:39 AM Feature #19832 (Rejected): Method#destructive?, UnboundMethod#destructive?
- I propose to add `destructive?` property to `Method` and `UnboundMethod` instances, which shall behave like:
```ruby
String.instance_method(:<<).destructive? # => true
String.instance_method(:+).destructive? # => false
```
One m... -
08/05/2023
-
-
05:30 PM Revision ac07d881 (git): [ruby/yarp] Add a Requirements section in Build System docs
- https://github.com/ruby/yarp/commit/298025314c
-
- https://github.com/ruby/yarp/commit/f9db0c282b
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com> -
- https://github.com/ruby/yarp/commit/0b174b76f1
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com> -
- https://github.com/ruby/yarp/commit/85ae0e2816
-
- https://github.com/nobu/ruby/tree/bugreport_path
Implemented `%%`, `%e`, `%E`, `%f`, `%F`, `%p`, `%t` and `%NNN`(octal).
When invoking pipe, the string is split with white spaces first without quoting, `%040` would be useful to repre... -
- If the required name is different from the found gem name, return the
gem name, instead of true that means the required name is an exact gem
name. -
- Revert "Revert "Skip calling jit_exec on Wasm""
This reverts commit 2e94610f70baca4af004202f288a6b5dd10889ca.
It's not about whether it's optimized away or not. I just don't want to
leave and maintain the callsite (e.g. signature) in t... -
- This reverts commit e80752f9bbc5228dba3066cd95a81e2e496bd9d7.
RJIT and YJIT are never enabled on Wasm. When both are disabled,
`jit_exec` is defined to return `Qundef` constantly, and is optimized
away. -
02:39 AM Revision 4e7e9728 (git): Remove uneeded int2big property for Universal Parser
-
01:32 AM Revision f07ef1d5 (git): Lrama v0.5.3
08/04/2023
-
- We often break Wasm build when we modify how jit_exec works. I'm
planning to modify it again soon.
We actually don't support running Ruby JIT on Wasm, so it doesn't seem
worth the maintenance effort. -
06:57 PM Revision 8d7861e3 (git): YJIT: expand bitwise shift support in x86 assembler (#8174)
-
- (https://github.com/ruby/irb/pull/668)
https://github.com/ruby/irb/commit/bbd20445ea -
- It doesn't feel elegant or concise to feed the element size to me.
For what use cases do you want it actually? -
07:42 AM Feature #19830: Allow `Array#transpose` to take an optional size argument
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> Why not `ary.transpose[1]&.join`?
That avoids the exception but returns `nil` instead of taking advantage of `#join`’s knowledge of the “correct” result for an empty array, i.e. the empty s... -
- Why not `ary.transpose[1]&.join`?
-
- Avoid generating long dispatch chains for all array lengths seen.
-
- This reverts commit c5abe0d08f8f7686422e6eef374cf8c78aefacb6.
-
- We don't need to check stack for moved objects after compaction because
the mutator cannot run between marking the stack and the end of
compaction. However, the stack may have moved objects leftover from
marking and sweeping phases. This... -
12:12 PM Revision 6b570ff2 (git): Display call location with bundled gems warning
-
-
-
-
- Also `flag_keyword_hash` sets to 0 or a hash object.
-
- (https://github.com/ruby/irb/pull/667)
https://github.com/ruby/irb/commit/79fc6dcf5f -
- Xcode 15 beta and macOS Sonoma beta show the following warnings with `make`
```
(snip)
linking miniruby
ld: warning: ignoring duplicate library '-lpthread'
miniruby: replacing existing signature
exe/ruby: replacing existing signa...
08/03/2023
-
-
- * YJIT: handle expandarray_rhs_too_small case
YJIT: fix csel bug in x86 backend, add test
Remove commented out lines
Refactor expandarray to use chain guards
Propagate Type::Nil when known
Update yjit/src/codegen.rs
Co-authored-by:... -
- Fix str_subseq so that it does not attempt to predict the size of the
object returned by str_alloc_heap. -
- One benefit of supplying an initial value to `Enumerable#inject` is that it avoids an annoying edge case when the collection is empty:
```
>> [1, 2, 3].inject(:+)
=> 6 # good
> ...
=> nil # bad
>> [].inject(0, :+)
=> 0 # good... -
-
- Function prototype for gc_mode_transition is not needed as it's not
used before the implementation. -
- Hello @tamaron. There is no update as of yet. One of the challenges is that it's not easy for us to have access to windows machines, it would be kind of a pain for us to debug things in a VM. This would also add complexity to our CI test...
-
10:27 AM Feature #19325: YJIT: Windows support lacking.
- Hello, any progress here?
I am very new to the Ruby community but interested in working on this. -
- ary_make_partial now uses the actual embed_capa of an allocated heap
array to guide whether make an embedded copy or a slice view. -
10:45 AM Bug #19829 (Closed): Enumerator.product called with keyword arguments raises exception with not precise message
- The `Enumerator.product` method, added in Ruby 3.2, when it's called with keyword arguments (but it expects only a list of enums) raises `unknown keyword: ... (ArgumentError)` exception:
```ruby
Enumerator.product([], a: 1)
# (irb):... -
08:14 AM Bug #19792: arm の alpine 上でネストしたハッシュに長い文字列を入れると segmentation fault が発生する
- 以下の環境でも再現しました
- Docker version 24.0.2, build cb74dfc
- M1 Max
- Ventura 13.5 -
-
-
-
- assert_separately adds --disable=gems so we don't need to add
--disable-gems when calling assert_separately.
08/02/2023
- 11:43 PM Revision 29fd0503 (git): * remove trailing spaces. [ci skip]
-
-
11:25 PM Bug #19828 (Closed): Segfault when `OpenSSL::X509::Certificate#public_key=` is given a `OpenSSL::PKey::DH` object
- The OpenSSL bindings cause a SegFault when creating a new OpenSSL::X509::Certificate object and setting it's `public_key` to the `public_key` of a new `OpenSSL::PKey::DH` key-pair.
### Steps To Reproduce
```ruby
#!/usr/bin/env rub... -
- because EP could be escaped.
-
- @ko1 Thank you!
-
- (https://github.com/ruby/irb/pull/654)
* Deprecate multi-irb commands
- Print deprecated message when any of the commands are used
- Put related commands under `Multi-irb` category with a deprecated
label
* Update readme
https://gi... -
- tests
(https://github.com/ruby/irb/pull/660)
The ability to run a test case in a subprocess is useful for testing
many other features, like nested IRB sessions. So I think it's worth
extracting them into a new test case class.
https://... -
- 03:33 PM Revision e20f1e44 (git): YJIT: Fallback setivar if the receiver isn't T_OBJECT (#8160)
- Followup: https://github.com/ruby/ruby/pull/8152
If the receiver is a T_MODULE or T_CLASS and has a lot of
ivars, `get_next_shape_internal` will return `NULL`.
Co-authored-by: Jean Boussier <byroot@ruby-lang.org> -
- * Follow-up of dbbc3583ba432c279f07b1fa0afb0a8a9ba50c91 which broke this.
-
-
-
-
-
01:32 PM Bug #19795: attr_accessor leading to nil values for re-assignment
- I got it in the end thanks to a peer. I misunderstood wrongly how this was working:
Running the following snippet helped me understand:
```ruby
# attr_accessor_nil.rb
class A
attr_accessor :a
def initialize
@a = 0
... -
- I guess that it is a local variable, but is it the expected behavior?
As a developer, I expect that I can access `a` without the `self.a`.
Since the following code works as expected without `self`:
```ruby
# attr_accessor_nil.rb
class... -
- This is an assignment to the local variable, not the accessor.
```ruby
a += 1
```
You have to write:
```ruby
self.a += 1
``` -
- ### Steps to reproduce:
- Create a class with an `attr_accessor` for an instance variable
- Create an instance method that reassign this variable using the current value stored in the variable
- Show that the variable is set to nil du... -
- Applied in changeset commit:git|1d096c1e53581ed9fe94694c9760babd1e12e580.
----------
Fix crash in NoMethodError for dummy frames
[Bug #19793]
Dummy frames are created at the top level when requiring another file.
While requiring a fil... -
- [Bug #19793]
Dummy frames are created at the top level when requiring another file.
While requiring a file, it will try to convert using encodings. Some of
these encodings will not respond to to_str. If method_missing is
redefined on Ob... -
-
-
- https://github.com/rubygems/rubygems/commit/6ed69223d4
- 09:18 AM Revision fd8dd719 (git): Implement StringIO#pread (#56)
- Both for being closer to real IOs and also because it's a convenient API
in multithreaded scenarios.
Co-authored-by: Jean Boussier <jean.boussier@gmail.com> -
- (https://github.com/ruby/irb/pull/634)
Its method `IRB.default_src_encoding` was only used in `magic-file.rb`,
which has been removed.
https://github.com/ruby/irb/commit/ed98983b1f - 09:17 AM Revision fe255277 (git): [ruby/fiddle] Include stdbool.h explicitly
- https://github.com/ruby/fiddle/commit/c313a74632
- 09:17 AM Revision 673f4493 (git): [ruby/fiddle] Include stdbool.h explicitly
- https://github.com/ruby/fiddle/commit/69ff680bf6
- 09:17 AM Revision 15e8cf7a (git): [ruby/fiddle] Add support for bool
- GitHub: fix https://github.com/ruby/fiddle/pull/130
Reported by Benoit Daloze. Thanks!!!
https://github.com/ruby/fiddle/commit/bc6c66bbb9 - 09:17 AM Revision 10588fa1 (git): [ruby/fiddle] Use ifdef
- https://github.com/ruby/fiddle/commit/6cdf53726d
-
- This reverts commit 3b88a0bee841aee77bee306d9d34e587561515cf.
This commit break aarch64 platform and Apple Silicon -
- Needs more investigations.
-
05:08 AM Bug #19794 (Assigned): Ruby 3.2.2 fails to build on macOS Sonoma betas
- With Big Sur, Apple deprecated putting dylibs in /usr/local/lib. In Sonoma (beta 4), this directory has disappeared completely. However, ruby's configure script depends on its existence. So, virtually every ruby installer (RVM, rbenv, as...
-
- Recent GitHub Actions Windows containers seem having Strawberry tools.
-
- According to @naruse, this `kprintf` was to avoid some segfaults, but
turned out it seemed another issue after all. -