Activity
From 04/26/2023 to 05/02/2023
05/02/2023
-
07:56 PM Misc #19599: DevMeeting-2023-05-10 @ Matsumoto, Japan
- * [Misc #18248] Add Feature Triaging Guide (jeremyevans0)
* Last discussed during October 2021 developer meeting, no decision made at the time.
* I think it would be useful to triage features, so that features in the issue tracker ... -
10:47 AM Misc #19599: DevMeeting-2023-05-10 @ Matsumoto, Japan
- [EDIT] Jemma Issrof will talk about YARP (https://github.com/Shopify/yarp) at the meeting.
-
08:43 AM Misc #19599: DevMeeting-2023-05-10 @ Matsumoto, Japan
- I want to introduce my parser project including https://github.com/yui-knk/lrama and https://rubykaigi.org/2023/presentations/spikeolaf.html#may11.
-
05:06 PM Revision 32cc6301 (git): [ruby/rdoc] [DOC] stop documenting fallback `MatchData#match_length`
- Also empty document of `Object`.
https://github.com/ruby/rdoc/commit/ce32a3102b -
03:31 PM Feature #19627: Ensure the VM is alive before accessing objspace in C API
- I reported a related issue in https://bugs.ruby-lang.org/issues/19580 which I fixed with https://github.com/ruby/ruby/pull/7663
Maybe you want to explore a similar fix which will short-circuit functions like `rb_gc_adjust_memory_usage... -
03:10 PM Misc #19431: DevMeeting at RubyKaigi 2023
- I'll attend
-
-
- Applied in changeset commit:git|b15e88e0fcccb03b9cc5e4c1478ec9b10e26c961.
----------
[Bug #19619] Preserve numbered parameters context
Preserve numbered parameters context across method definitions -
-
- Preserve numbered parameters context across method definitions
-
08:17 AM Feature #19626: Alias Base64 methods to non-64 suffixed methods
- > Aliasing singleton methods only?
That would make sense.
And while we're at it, I think it would be nice to also alias theses as `.load` and `.dump`, as it makes composing various encoders much easier (e.g. https://github.com/Shop... -
- https://github.com/ruby/rdoc/commit/945f0cb3e9
-
- Fixes https://github.com/ruby/rdoc/pull/1000
https://github.com/ruby/rdoc/commit/291e2b7e8b - 03:37 AM Revision 83a822f7 (git): Bump advanced-security/filter-sarif from 1.0.0 to 1.0.1
- Bumps [advanced-security/filter-sarif](https://github.com/advanced-security/filter-sarif) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/advanced-security/filter-sarif/releases)
- [Commits](https://github.com/advanced-security... -
12:57 AM Feature #19616: Remove ext/readline from Ruby 3.3
- https://github.com/ruby/ruby/pull/7781
-
- I agreed Matz's opinion.
Calm down, please.
- 12:04 AM Revision cf861c94 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.74 to 0.9.75.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.74...v0.9.75)
---
updated-depende...
05/01/2023
-
11:29 PM Feature #19627 (Closed): Ensure the VM is alive before accessing objspace in C API
- Currently, there is no supported way to check if the Ruby VM has been shut down. There are a couple of workarounds that I know of:
1. Setup an exit handler which sets a global variable (like I did in https://github.com/tmm1/stackprof/... - 09:01 PM Revision bd532fe3 (git): YJIT: Move exits in gen_send_iseq to functions and use ? (#7725)
-
12:20 PM Revision 13dfbcf7 (git): [ruby/reline] Rewrite dialog rendering
- (https://github.com/ruby/reline/pull/492)
* Rewrite dialog rendering
* Fix failing test of dialog with small screen
* Add multiple-dialog rendering test
* Add description comments for each part of render_dialog_changes -
10:30 AM Bug #19611: Ruby hangs up with `while true && true`
- Oh I didn't notice you already had a patch for this. Yeah, omitting the unreachable branches during the compile step entirely makes more sense.
-
- - Follow up RegexpLiteral at 9264d834215aa7ce14b0273032a7686c20141db9.
- Split the code to be generated so that `REGEXP` does not need
escapes.
- Use `REGEXP.match?` since support for Ruby 2.3 or earlier has been
dropped. -
- 07:58 AM Revision f93fcdb8 (git): Bump advanced-security/filter-sarif
- Bumps [advanced-security/filter-sarif](https://github.com/advanced-security/filter-sarif) from eac3ea6a5e1270952681bf7287598a6cd1a4d49d to bc96d9fb9338c5b48cc440b1b4d0a350b26a20db.
- [Release notes](https://github.com/advanced-security/f... - 03:51 AM Revision dc2a3dec (git): Bump ruby/setup-ruby from 1.147.0 to 1.148.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.147.0 to 1.148.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/6cecb48364174b0952995175c55f9bf552... -
- Aliasing singleton methods only?
```diff
diff --git a/lib/base64.rb b/lib/base64.rb
index 15c0b297ce2..e148adeaaf1 100644
--- a/lib/base64.rb
+++ b/lib/base64.rb
@@ -110,4 +110,10 @@
end
strict_decode64(str)
end
...
04/30/2023
-
11:29 PM Feature #19626 (Open): Alias Base64 methods to non-64 suffixed methods
- Long time Ruby user, first time issue poster. Apologies if this isn't the correct process of proposing this sort of change. Redirect me somewhere else if I need to be.
I'd like to propose aliasing the methods in the Base64 module to n... -
11:09 PM Revision 33833aaf (git): [DOC] hash.c: fix typo in `#<=>` docs
-
- Applied in changeset commit:git|814f52a9ebd035ec6e20641c602fa42f64b5dbe0.
----------
[Bug #19624] Hide internal IO for backquote -
02:56 PM Bug #19624 (Closed): Backticks - IO object leakage
- Hi,
This code works on ruby 3.0.6:
```ruby
`echo`
ObjectSpace.each_object(IO) do |io|
if ![STDIN, STDOUT, STDERR].include?(io)
io.close
end
end
```
but raises `IOError` on 3.2.2:
```
minimal-repro-case.rb:8:in `cl... -
-
07:48 PM Bug #19625 (Closed): Ruby 3.2 MJIT never triggers JIT compaction
- [This patch](https://github.com/ruby/ruby/pull/6900) accidentally removed a condition to trigger JIT compaction from Ruby 3.2.
This PR https://github.com/ruby/ruby/pull/7777 makes it work again. This ticket is to request a backport fo... -
-
-
- Ruby 3.2 MJIT crashes on railsbench when you use `--mjit-max-cache=10000`.
```
[2023-04-29T22:49:00.915217 #412381] FATAL -- : [bc56d52f-5930-4307-8af7-3f58a44eb089]
[bc56d52f-5930-4307-8af7-3f58a44eb089] NoMethodError (undefined...
04/29/2023
-
- Fix https://github.com/ruby/rdoc/pull/995
https://github.com/ruby/rdoc/commit/1311ca8c50 -
- Fix https://github.com/ruby/rdoc/pull/995
https://github.com/ruby/rdoc/commit/adfa7db5b9 -
- Some symbol argument might not be accepted by Process.clock_gettime.
-
- Get rid of accidents like 966f0d91e2a86fa1347cdafbe1af47e7350aa4ca.
04/28/2023
-
- This reverts commit 966f0d91e2a86fa1347cdafbe1af47e7350aa4ca.
-
05:20 PM Revision e9930b51 (git): [ruby/irb] Retire magic-file.rb
- (https://github.com/ruby/irb/pull/574)
`MagicFile` was introduced around v0.9.6, which was like 14~15 years ago.
It was needed because back then we needed to read a file's magic comment
to determine the encoding of it, and read it with ... -
-
- From https://github.com/ruby/ruby/commit/74028c210c23a13b3168886efcf837b4bf930468
https://github.com/ruby/rdoc/commit/badc518c57 -
- Split into title and body, like as the pull-request.
-
-
- Ah right. So an anonymous class is used to ensure there is no conflict with the generated method name and e.g. it can just be `render`.
Another way to do this would be to compile to a lambda, then an instance of MyTemplate would be all ... -
01:33 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
- Eregon (Benoit Daloze) wrote in #note-39:
> Why not `#<MyTemplate:0x000055e017895038 @path="path/to/file">` for an instance of MyTemplate and so no anonymous classes?
Because we want to compile the template to ruby once per process, ... -
- ioquatix (Samuel Williams) wrote in #note-38:
> In any case, this also affects the output of errors such that those names may not be "eval" able. @Eregon can you clarify if this is still a problem for you? If not, why not?
Yes, it is... -
02:38 PM Feature #8707: Hash#reverse_each
- Another point is that that hash.reverse_each already exists via enumerable, but with a highly suboptimal array conversion. If it didn't exist you could perhaps debate whether it should be added, but that's moot at this point. The only qu...
-
-
-
-
- - read files to copy once at first
- take the destination top directory from command line arguments
- fix a typo -
12:08 PM Bug #19622 (Closed): Undocumented behavior of Array#& and similar methods
- Currently, the [Array#& docs](https://ruby-doc.org/3.2.2/Array.html#method-i-26) only state that the objects are compared using `eql?` method. However, it turns out that if arrays are "big" (size more than `SMALL_ARRAY_LEN`), then the ha...
-
- I think `Method#defining_proc` and `UnboundMethod#defining_proc` make more sense, as most methods (all the ones defined with `def`) don't have a Binding so just having `Method#binding` defined would be misleading, and also if there are o...
-
-
10:05 AM Bug #19621: Resolv::Hosts uses ineffective File.read, making using big hosts file 'impossible'
- The reading does not seem to be the problem, but the hash operations.
-
- By default on unixoid systems, `Resolv` will read `/etc/hosts` once. Privacy- and security aware people might use the file to prevent unwanted traffic, developers use it to quickly manipulate address resolution.
`Resolv::Hosts` uses [... -
- Fix https://bugs.ruby-lang.org/issues/19621
https://github.com/ruby/resolv/commit/7faaa78847 -
- The -b flag is available since 2.28, but Ubuntu 20.04 uses 2.25.
-
- stillhart (Fabian Stillhart) wrote:
> Interestingly I while playing arround I found out that the Hash#first method works. But why is it not in the ruby-doc?
It is [`Enumerable#first`](https://docs.ruby-lang.org/en/3.2/Enumerable.html... -
04:58 AM Feature #19559: Introduce `Symbol#+@` and `Symbol#-@`, and eventually replace boolean arguments with symbols
- 以下のコメントに付き、松本さん以外の開発者の方でも対処できる方がいれば、対処をお願いします。
- 03:45 AM Revision 9b07d30d (git): Bump github/codeql-action from 2.3.0 to 2.3.2
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.0 to 2.3.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
... - 02:05 AM Revision 4134eb21 (git): Update bundled gems list at f6694b5bc89dffdc1d8b24f8c08ded [ci skip]
-
02:04 AM Revision f6694b5b (git): Bundle rbs-3.1.0 (#7766)
04/27/2023
-
09:49 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
- The difference between a dynamically defined `inspect` which can do anything vs `Module#name` which is cached is significant, including but not limited to execution time, exception handling and memory allocations. As already linked, http...
-
- Dan0042 (Daniel DeLorme) wrote in #note-35:
> But let's say it really is too slow to do a `rb_funcall` for each nested namespace;
Module#name is cached (and returns a frozen string) and should likely remain cached.
But you are not... -
- ioquatix (Samuel Williams) wrote in #note-33:
> @Dan0042 unfortunately your proposal doesn't really work for nested classes without major performance issues.
I sort of understand what you mean, but I think it's premature to dismiss a... -
- ioquatix (Samuel Williams) wrote in #note-33:
> doesn't really work for nested classes
Why not? Can you elaborate?
I think @Dan0042's idea is much less invasive than "breaking" Class#name and much more likely to be acceptable.
Es... -
- @Dan0042 unfortunately your proposal doesn't really work for nested classes without major performance issues.
-
- I also really want the ability to give better names to dynamically created classes. In particular for something that is created once via a registry, like `x = MyTemplate["path/to/file"]`, having `x.new.bad` produce an error like "undefin...
-
-
- > Do we really need it? What is use-cases?
When you have an ordered collection it seems self evident that you may need to iterate in reverse. This would for example back a performant `last(n = 1)` method (#12165)
Would you demand to kn... -
- Hash should absolutely have a performant last method that doesn't build an intermediate array (`hash.(values|keys).last`). This is connected to having a performant reverse_each (#8707)
-
08:04 PM Feature #19617: Add Method#binding and UnboundMethod#binding, similar to Proc#binding
- Another use-case is simply to match `Proc#binding`. I originally assumed that Method#binding and UnboundMethod#binding already existed. And when I asked several other very knowledgable rubyist's if they knew how to access the enclosed ...
-
- Perhaps I shouldn't have given the Regexp use-case, since there are many other approaches we can (and should) use to audit our regexps. Although that was the immediate trigger for this ticket, it wasn't the first or the most common reas...
-
Eregon (Benoit Daloze) wrote in #note-2:
> Maybe an easier/better/more portable way to do that would be to have a flag to check that all Regexp are linear when they are executed, e.g., by the test suite?
> ...
...
> It could also be...-
- Ah BTW one concern I have with https://github.com/ruby/net-imap/blob/92db350b24c388d2a2104f36cac9caa49a1044df/test/net/imap/regexp_collector.rb is it could only work CRuby due to using RubyVM::InstructionSequence.
That seems problematic... -
- ```ruby
module FooErrorFilter
def self.===(e)
e.message =~ /foo/
end
end
def foo_error_filter
FooErrorFilter
end
begin
raise 'foo error'
rescue foo_error_filter => e
p e.message
end
```
Filter matching ... -
- (https://github.com/ruby/irb/pull/571)
* Simplify Locale#load
Instead of loading file content with `MagicFile` and then evaluting it,
we can just use `Kernel.load` to load the file.
* Remove unused optional argument
* Remove unused L... -
- Since this doesn't work too, endless and/or singleton method definition doesn't seem to matter.
```ruby
1.times {p _1; def bar; end} #=> 0
1.times {p _1; def bar x; end} #=> nil
```
-
01:16 PM Revision fef8cca8 (git): Merge T_OBJECT case in rb_ivar_delete function
-
11:55 AM Bug #19606 (Closed): addr2line.c broken on Fedora 38
-
- (https://github.com/ruby/irb/pull/573)
`MagicFile` was introduced around v0.9.6, which was like 14~15 years ago.
It was needed because back then we needed to read a file's magic comment
to determine the encoding of it, and read it with ... -
- Applied in changeset commit:git|c7bacf84f04201787d26e4a4be8aca61ff1e454b.
----------
[Bug #19611] Remove never-reachable branch in logical expression -
- Mine:
https://github.com/ruby/ruby/pull/7753
https://github.com/ruby/ruby/pull/7754
kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-2:
> This code isn't optimal though. A second pass of the peephole optimizer would reduce this do... -
-
- These must not be changed once initialized.
- 02:25 AM Revision dd406c5a (git): Skip DW_FORM_GNU_* forms in addr2line.c
- DW_FORM_GNU_ref_alt and DW_FORM_GNU_strp_alt refer to data stored in an
external ELF file specified by a .gnu_debugaltlink attribute. These
attributes are generated by dwz(1), which extracts DWARF data common
amongst several files and st... -
- This number works better on yjit-bench (ruby-lsp).
-
04/26/2023
-
- Or iterate over all regexps through `ObjectSpace.each_object(Regexp)`? But I suppose it doesn't allow to only look at a specific namespace.
-
- > This would be a useful tool when debugging from the console. As another example, it might be used to scan a code base for dynamically generated regexps which are only reachable via the enclosed local variables and test that they are al...
-
- nevans (Nicholas Evans) wrote:
> For methods defined using the `def` keyword, the binding's local variables might be empty or might be all of the names in the method's locals table, with all values set to `nil`.
Rather, the `binding`... -
- Applied in changeset commit:git|adaff1fc496b6f01fb1c4c812b9b4082618e2f79.
----------
[Bug #19592] Fix ext/Setup support
After [1], using ext/Setup to link some, but not all extensions failed
during linking. I did not know about this op... -
-
- After [1], using ext/Setup to link some, but not all extensions failed
during linking. I did not know about this option, and had assumed that
only `--with-static-linked-ext` builds can include statically linked
extensions.
Include the s... -
05:37 PM Bug #19619: Numbered parameters don't work with method definition with parameters
- The result of the last code:
```
undefined method `bar' for #<Object:0x0000000108e20438> (NoMethodError)
``` -
- This works:
```ruby
class Foo
def bar(baz) = 'foo'
end
p Foo.new.bar('baz')
```
This also works:
```ruby
o = Object.new
o.tap { |obj| def obj.bar(baz) = 'foo' }
p o.bar('baz')
```
Even this works:
```ruby
o =... -
- path
(https://github.com/ruby/irb/pull/572)
https://github.com/ruby/irb/commit/0b648adf38 -
- (https://github.com/ruby/irb/pull/570)
https://github.com/ruby/irb/commit/710d5b1af5 -
- (https://github.com/ruby/irb/pull/569)
We don't have to load another file to define the legacy encoding aliases
map because there's only one definition of it. We can define it in
locale.rb directly. -
- Applied in changeset commit:git|6339cb70c3bcc54696e98c303dd4b26ed3d57afd.
----------
marshal.c: shallow freeze user objects
When `freeze: true` argument is passed.
[Bug #19427] -
- When `freeze: true` argument is passed.
[Bug #19427] -
02:21 PM Revision 78be6696 (git): Wrap `undef_method :a` with `ensure`
-
- Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
-
- Ensure it returns `nil` instead of segmentation faulting
-
- Prior to this commit, a segmentation fault occurred in `vm_defined`'s
`zsuper` implementation after NULL is returned as `BasicObject`'s superclass.
This fix returns false from `vm_defined` if the superclass is NULL.
For example, the fol... -
- * [Feature #18885] End of boot advisory API (byroot)
* I'm planning to merge the first optimizations for 3.3
* Are we still good with the `Process.warmup` name? Or would we rather expose something on `GC`?
* [Feature #19236] Allow to... -
08:59 AM Misc #19599: DevMeeting-2023-05-10 @ Matsumoto, Japan
- > [Misc #19608] Being a co-maintainer of the ruby/openssl for the OpenSSL FIPS mode
> ...
Thanks for adding the agenda! Note I opened the issue ticket. And I plan to attend this meeting to explain the topic's context in a later timing o... -
08:58 AM Revision ffce3117 (git): add new debug log line on `rb_ractor_terminate_all`
- to leave the trace.
-
- `RUBY_DEBUG_LOG()` doesn't show anything if `GET_EC()` returns NULL,
but print a separator "\t" to make consistent TSV. -
- `RUBY_DEBUG_LOG=stderr RUBY_DEBUG_LOG_PID=1 ruby ...` will prints
debug logs with PID. -
- When newer version released rather than gems/bundled_gems defined,
`spec.version == Gem::Version.new(v)` always abort like:
```
Unexpected versions between bundled_gems:3.0.4 and gemspec:3.1.0
``` -
- This is also causing test failures on my machine, because there are tests on the output of the bug reporter - e.g.
```
[17591/23407] TestBugReporter#test_bug_reporter_add = 0.15 s
4) Failure:
TestBugReporter#test_bug_reporter_a... -
- After my patch, the instruction sequence for this method is:
```
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(1,23)>
0000 jump 4 ( 1)[Li]
0002 putnil
0003 pop
0004 jump ... -
- Hm, interesting - it falls into an infinite loop in `iseq_peephole_optimize`, because it's doing useless jump elimination on labels that recursively point to each other.
At the beginning of `iseq_peephole_optimize`, the instruction se... -
- (https://github.com/ruby/irb/pull/568)
In https://github.com/ruby/irb/commit/3ee79e89adb8e21b63d796e53bcc86281685076d,
`encoding_aliases.rb` was introduced to return the correct encoding object for
`ujis` and `euc` encodings.
However, ... -
- This reverts commit e7cdce83e8c8797c481ccb54c260c0db1e1afa7c.
- 03:46 AM Revision 0c30425e (git): Bump ruby/setup-ruby from 1.146.0 to 1.147.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.146.0 to 1.147.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/55283cc23133118229fd3f97f9336ee23a... -
01:40 AM Feature #19588: Allow Comparable#clamp(min, max) to accept nil as a specification
- The Japanese manual is updated.
https://docs.ruby-lang.org/ja/latest/class/Comparable.html#I_CLAMP
https://github.com/rurema/doctree/pull/2801