Activity
From 03/31/2023 to 04/06/2023
04/06/2023
-
11:33 PM Revision fb822076 (git): [rubygems/rubygems] util/rubocop -A --only Style/LineEndConcatenation
- https://github.com/rubygems/rubygems/commit/67ece7b8b6
-
05:36 PM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
- @jprokop Thanks for letting us know. I fixed it in [bffadcd6d46ccfccade79ce0efb60ced8eac4483](https://github.com/ruby/ruby/commit/bffadcd6d46ccfccade79ce0efb60ced8eac4483).
-
10:18 AM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
- Please consider adding a guard to the test that comes with https://github.com/ruby/ruby/commit/3dc8cde70078ccb38f5f4b0818ad5eecded01bd5 .
There can be a case of not compiling with compaction, which we do with Ruby 3.1 on Fedora for pp... -
- Some platforms don't support compaction, so we should skip this test.
-
- Applied in changeset commit:git|bccec7fb468ad977be75e7e4c2644b4ea845ab0c.
----------
Fix crash in rb_gc_register_address
[Bug #19584]
Some C extensions pass a pointer to a global variable to
rb_gc_register_address. However, if a GC is... -
- GitHub PR: https://github.com/ruby/ruby/pull/7670
Some C extensions pass a pointer to a global variable to rb_gc_register_address. However, if a GC is triggered inside of rb_gc_register_address, then the object could get swept since i... -
- [Bug #19584]
Some C extensions pass a pointer to a global variable to
rb_gc_register_address. However, if a GC is triggered inside of
rb_gc_register_address, then the object could get swept since it does
not exist on the stack. -
03:34 PM Revision 89bdf6e9 (git): YJIT: Stack temp register allocation for arm64 (#7659)
- * YJIT: Stack temp register allocation for arm64
* Update a comment
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
* Update comments about assertion
* Update a comment
Co-authored-by: Maxime Chevalier-Boisver... -
01:35 PM Bug #19563: Ripper.tokenize(code).join != code when heredoc and multiline %w[] literal is on the same line
- I've opend a pull request to fix irb's test. Changes expected prompt and target code to avoid this bug in ruby 2.7~3.2.
https://github.com/ruby/irb/pull/558 -
12:03 PM Feature #19370: Anonymous parameters for blocks?
- sawa (Tsuyoshi Sawada) wrote in #note-4:
> I think nested anonymous arguments should be prohibited as with numbered parameters:
That's a good idea, but does it mean this would become valid?
```ruby
def test
proc { |*| p(*) }.c... -
02:19 AM Feature #19370: Anonymous parameters for blocks?
- zverok (Victor Shepelev) wrote in #note-2:
> Note that it might lead to very confusing behavior when the surrounding method does have anonymous arguments:
> ...
I think nested anonymous arguments should be prohibited as with numbered par... -
10:07 AM Feature #19474 (Closed): Reduce the number of NEWOBJ macros
- Applied in changeset commit:git|026321c5b976c5e95731046b94555b1226198be4.
----------
[Feature #19474] Refactor NEWOBJ macros
NEWOBJ_OF is now our canonical newobj macro. It takes an optional ec -
- The socket extensions rubysocket.h pulls in the "private" include/gc.h,
which now depends on vm_core.h. vm_core.h pulls in id.h
when tool/update-deps generates the dependencies for the makefiles, it
generates the line for id.h to be bas... -
- NEWOBJ_OF is now our canonical newobj macro. It takes an optional ec
-
- so that now shape can happily include gc.h
-
-
- We can just make newobj_of take a ractor
-
08:25 AM Bug #19583 (Closed): Unary minus inconsistency when used with variables and literals
- Yeah, I don't think this is a bug, and even if we decided another precedence would have been better, changing it would break way too much code.
-
07:23 AM Bug #19583: Unary minus inconsistency when used with variables and literals
- `-2` is a literal
`- 2` is a function call of `-@`
and -@ doesn't have preference over function call, see this:
```ruby
a = 2
v = -a.to_s
p v #=> 2
```
-
06:43 AM Bug #19583 (Closed): Unary minus inconsistency when used with variables and literals
- This feels a bit inconsistent and I could not find an explanation.
This is fine and `-` has higher precedence than `.`
```
-2.upto 0 do |arg|
puts arg
end
```
But this is not working, won't even compile (requires parens):
```... -
- This reverts commit d2eef4b7867578df302cfa9d7c97eebbef8d9ee4.
-
- Revert "[ruby/syntax_suggest] Remove unnecessary `--color` option"
This reverts commit 588dd44d418d56dce3f2a388c4021d11f9aa4324. - 07:18 AM Revision c78476ce (git): Update default gems list at 6ca1f3eec4222924c7e23642a68b51 [ci skip]
-
-
06:49 AM Revision 7ab640d9 (git): v1.0.4
-
- Fix a CI error and add a test to ensure we're testing the current version:
```
Run bundle exec rake test
bundler: failed to load command: rake (/home/runner/work/syntax_suggest/syntax_suggest/vendor/bundle/ruby/3.2.0/bin/rake)
/opt/host... -
- Because `syntax_suggest` is a default gem you can get conflicts when working on this project with Ruby 3.2+. To fix conflicts you can disable loading `syntax_suggest` as a default gem by using then environment variable `RUBYOPT` with the...
-
06:45 AM Revision d511e696 (git): [ruby/syntax_suggest] The annotation must end with a new line
- syntax_suggest did not work great when there is no new line at the end
of the input file.
Input:
```
def foo
end
end # No newline at end of file
```
Previous output:
```
$ ruby test.rb
test.rb: --> test.rb
Unmatched `end', missing keyw... -
- Originally I fixed https://github.com/ruby/syntax_suggest/pull/177 by making the process of comment removal indentation aware. The next commit is the more general fix and means we don't need to carry that additional logic/overhead.
Also... -
- https://github.com/ruby/syntax_suggest/commit/cecd12292c
-
- While #177 is reported as being caused by a comment, the underlying behavior is a problem due to the newline that we generated (from a comment). The prior commit fixed that problem by preserving whitespace before the comment. That guaran...
-
- When removing comments I previously replaced them with a newline. This loses some context and may affect the order of the indent search which in turn affects the final result. By preserving whitespace in front of the comment, we preserve...
-
- When `tmp/alias` already exists, I'm now getting phantom folders in the directory pointing at older aliases which is distracting/confusing. By checking and removing that alias before symlinking we can prevent this strange behavior (possi...
-
06:45 AM Revision 588dd44d (git): [ruby/syntax_suggest] Remove unnecessary `--color` option
- It is enabled automatically if possible. Forcing this option makes
https://github.com/rspec/rspec-core/pull/3017 useless.
https://github.com/ruby/syntax_suggest/commit/8e7141b472 - 06:24 AM Revision 061f5f43 (git): Add missing test for Data.initialize
-
- WIP https://github.com/nobu/ruby/tree/detect-tls
-
04:32 AM Feature #19430: Contribution wanted: DNS lookup by c-ares library
- Hello. I'm interested to take a look, but new to Ruby's development.
Is it acceptable to make the PoC merge-able first and work on macOS and per-platform resolvers later? Not really sure changing the c-ares for macOS (as below) is mor... - 04:07 AM Revision 69460791 (git): [rubygems/rubygems] Improve comment explaining the neccessity of `write_default_spec` method.
- The intention is not obvious from the commit log and it might avoid
temptation to remove the method without further consideration.
https://github.com/rubygems/rubygems/commit/8e17c50f64 -
04:07 AM Revision f3d69bed (git): [rubygems/rubygems] Fix resolver hangs when dealing with an incomplete lockfile
- While working on locking multiple platforms by default, I got an
infinite resolution loop in one of our resolver specs.
The culprit ended up being that when dealing with lockfile specs with
incomplete dependencies (spec appears in lockf... -
- This reverts commit 69580f8b72f41c58cae57d1ada4db909922b3891.
-
- This reverts commit https://github.com/rubygems/rubygems/commit/a20585b4512d.
https://github.com/rubygems/rubygems/commit/aa9102659e - 04:07 AM Revision b5f24329 (git): [rubygems/rubygems] Use TestCase#util_spec instead of custom code.
- https://github.com/rubygems/rubygems/commit/74d485ff1e
- 03:43 AM Revision 5d718f10 (git): Bump github/codeql-action from 2.2.9 to 2.2.10
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.2.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)... -
- Oops, I didn't intend to reopen it
-
- In terms of the SEGV issue, I think you are running the test suite of 3.2.2 by Ruby 3.2.1 for some reason. It looks like that the failing test was added in 3.2.2 for a SEGV bug of 3.2.1. (#19445)
Could you delete that build and retry ... -
- This issue fixed at https://git.ruby-lang.org/ruby.git/commit/?id=bccdc041665032b819fab1c04ed4dbdfeeeb366b
-
02:52 AM Bug #19582 (Closed): Segmentation fault when running the tests for Ruby 3.2.2
- When adding a package update to BLFS, our policy is to run the tests for the packages. When running the tests for Ruby-3.2.2, we're getting a segmentation fault that appears to happen in TestNumeric#test_step. I've attached a copy of Rub...
-
- Probably yes. Ruby 3.0 gave up OpenSSL 3.0.x support in order to maintain OpenSSL 1.0.1 support. Considering this, it is basically unlikely that Ruby 3.1 will drop OpenSSL 1.1.x support. However, if there are special circumstances that f...
-
01:53 AM Misc #19581 (Closed): Will Openssl 1.1.x fully support for Ruby3.1 throught the life time of Ruby3.1?
- Currently Ruby3.1 require openSSL 1.1.x / 3.0.x to build rubyGem. Does the requirement for openSSL will be the same for all future minor version of Ruby3.1 ?
04/05/2023
- 11:11 PM Revision 7b27ad9a (git): Add BIN as an entry in the glossary (#7667)
- I initially thought this macro is referencing binary, not basic instruction name
-
10:56 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
- FWIW, I've run into a desire for this feature on two separate occasions recently. In both cases, I'm writing an HTTP Client for an API, and want to provide a nice interface to it. The products behind the APIs are very customizable, so di...
-
- zverok (Victor Shepelev) wrote:
> If they are NOT planned to be implemented, I believe that at least error messages should be made much clearer, because currently, this would happen while running the code above:
> ...
Perhaps this mess... -
09:40 PM Revision 2f8e5c80 (git): [ruby/irb] Drop Ruby 2.6 support
- (https://github.com/ruby/irb/pull/555)
* Remove all Ruby 2.6 support
* Drop Ruby 2.6 specific testing conditions
* Only run Ruby 2.7+ on CI
* Bump Ruby requirement to 2.7+
https://github.com/ruby/irb/commit/3f714b616c -
- * YJIT: Add codegen for Integer methods
* YJIT: Update dependencies
* YJIT: Fix Integer#[] for argc=2 -
- I marked it for backporting to all versions of Ruby :)
-
05:24 PM Bug #19580: Ensure ruby_xfree won't segfault if called after ruby_vm_destruct
- Thank your for your feedback and merging. Is this something you'd consider backporting?
-
- Applied in changeset commit:git|52e571fa72debcd764765775bd1b76ee87e36d2d.
----------
Ensure ruby_xfree won't segfault if called after vm_destruct
[Bug #19580]
The real-world scenario motivating this change is libxml2's pthread
code wh... -
- Github PR: https://github.com/ruby/ruby/pull/7663
The POSIX Threads API provides the ability to define a destructor to clean up thread-local storage at thread exit by using `pthread_key_create` to bind a storage key and an associated ... -
05:41 PM Bug #19161: Cannot compile 3.0.5 or 3.1.3 on Red Hat Enterprise Linux 7
- @nobu, attached are the requested files. I also included files for Ruby 3.1.4 and 3.0.6. All three versions reported this was fixed but all three versions get the same build error.
I agree that GCC 4.8.5 has incomplete C11 support, bu... -
- The gcc on CentOS7 is based on old 4.8.5 and its C11 support seems half-baked, i.e., `_Thread_local` storage class is not supported.
-
- BTW, off topic:
You can check the checksum more simply.
```sh
RUN echo "4b352d0f7ec384e332e3e44cdbfdcd5ff2d594af3c8296b5636c710975149e23 *ruby-3.2.2.tar.xz" | sha256sum -c
``` -
- @eviljoel Can't you share the generated config.log and config.status files?
-
- @hsbt, @nagachika, and @nobu, despite the release notes, this was not successfully backported to Ruby 3.2 in Ruby 3.2.2. I've attached a Dockerfile that proves it. Assuming you have Docker installed, run the file with:
``` shell
docker... -
- [Bug #19580]
The real-world scenario motivating this change is libxml2's pthread
code which uses `pthread_key_create` to set up a destructor that is
called at thread exit to free thread-local storage.
There is a small window of time --... -
- To prevent influence from other processes.
-
-
- Increase the timeout limit when variance at rehearsal is small.
-
- Since Ruby 2.7 it prints the message and backtrace of $!
Fixes [Bug #19578] -
- Ah, from https://github.com/ruby/dev-meeting-log/blob/master/2022/DevMeeting-2022-01-13.md
> matz: we should not modify the behavior when the receiver is a String
I take that to mean Matz prefers not breaking compatibility. -
02:16 PM Feature #18368: Range#step semantics for non-Numeric ranges
- @Dan0042 I value backwards compatibility a lot (I mentioned it in original ticket).
I though believe that in _this_ particular case the old behaviour for non-numeric ranges is so weird that
1. Very small amount of code, if any, would... -
- I guess we just have different values regarding backward compatibility. Your arguments are not false, but to me they have a value several orders of magnitude below compatibility. It doesn't need to be a "very common" idiom, it just needs...
-
- @Dan0042 I don't think that "maintaining compatibility" here is valuable unless proven otherwise (e.g. it is a very common idiom for iterating through strings - while working on this ticket, I found no evidence for that).
My reasoning... -
-
01:49 PM Revision 3e1e09b2 (git): YJIT: Smoke test on Rust 1.58.0
- Since warnings might show up on older version but not newer ones.
-
- Encourages commenting about soundness of `unsafe` usages.
-
- This reverts commit 9e678cdbd054f78576a8f21b3f97cccc395ade22.
Without the `unsafe` annotations, the SAFETY comments make less sense.
I want to keep the SAFETY comments. -
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> I agree. Can you please submit a pull request for it?
Done: https://github.com/ruby/ruby/pull/7664
-
- Of course, I missed the word "not", sorry.
-
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> I agree. Can you please submit a pull request for it?
Will do.
nobu (Nobuyoshi Nakada) wrote in #note-4:
> ...
That's a great improvement! I can't believe I missed it. -
- Note that broken pipe on STDOUT error message will *not* be shown since ruby 3.0. #14413
-
01:34 AM Bug #19578: abort() shows stack trace when run within rescue clause
- Dan0042 (Daniel DeLorme) wrote in #note-2:
> But in that case I think the documentation should be updated.
I agree. Can you please submit a pull request for it? -
- Thank you, I searched but wasn't able to find it.
But in that case I think the documentation should be updated. This:
Terminate execution immediately, effectively by calling Kernel.exit(false). If msg is given, it is written to STD... -
- https://github.com/rubygems/rubygems/commit/9264d83421
-
-
-
-
-
-
-
- https://github.com/rubygems/rubygems/commit/d8a75a5f84
-
- https://github.com/rubygems/rubygems/commit/d900453ca2
-
- https://github.com/rubygems/rubygems/commit/f1a20c4c69
-
- https://github.com/rubygems/rubygems/commit/241f376c32
-
- https://github.com/rubygems/rubygems/commit/b18a4ef076
-
- https://github.com/rubygems/rubygems/commit/7f27ab32b8
-
- https://github.com/rubygems/rubygems/commit/ba3c985701
-
05:38 AM Revision 28d6c6d6 (git): [rubygems/rubygems] add some test suites under the Gem namespace, so as not to collide
- To avoid collisions especially in ruby/ruby
https://github.com/rubygems/rubygems/commit/e6b2359975 -
-
- 03:43 AM Revision f79912ea (git): Bump ruby/setup-ruby from 1.144.2 to 1.146.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.144.2 to 1.146.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/ec02537da5712d66d4d50a0f33b7eb5277...
04/04/2023
-
11:59 PM Revision 52ff2ce9 (git): Use `em_delete` in `key_delete` (#504)
- * Test existing behavior
Typing Ctrl-D ends editing but typing <Del> does not.
Also renamed a test that is not testing ed_delete_next_char but
key_delete.
* Check if line empty first in em_delete
By distributivity of AND over OR, we ... -
- We need to release Bundler 2.3.27 at first.
-
- This is a backport request for bundler, that regressed in 2.3.36 in a specific situation. Newer and older bundler versions that ship with Ruby are not problematic, only the version that ships with Ruby version >= 3.1.3.
A few weeks ag... -
11:44 PM Bug #19566 (Closed): OptionParser::on raises unsupported argument type: URI (ArgumentError) but shouldn't
- Applied in changeset commit:git|bb927acd3bd3a5a5797587bc4201724235ed26b5.
----------
[ruby/optparse] Document requires needed for Date/DateTime/Time/URI/Shellwords support
Fixes [Bug #19566]
https://github.com/ruby/optparse/commit/fb9... -
- I submitted a pull request to document the requires needed, not just for URI, but for Date/DateTime/Time/Shellwords as well: https://github.com/ruby/optparse/pull/54
-
- Applied in changeset commit:git|1da2e7fca35dc697d85dd91d2572ab58d08cd3bc.
----------
[Feature #19579] Remove !USE_RVARGC code (#7655)
Remove !USE_RVARGC code
[Feature #19579]
The Variable Width Allocation feature was turned on by def... -
- GitHub PR: https://github.com/ruby/ruby/pull/7655
The Variable Width Allocation feature was turned on by default in Ruby 3.2. Since then, we haven't received bug reports or backports to the non-Variable Width Allocation code paths, so... -
- Fixes [Bug #19566]
https://github.com/ruby/optparse/commit/fb91d97c10 -
- Remove !USE_RVARGC code
[Feature #19579]
The Variable Width Allocation feature was turned on by default in Ruby
3.2. Since then, we haven't received bug reports or backports to the
non-Variable Width Allocation code paths, so we assume... -
- for CI stability
-
08:41 PM Revision d26d3575 (git): YJIT: add stats for ratio of versions per block (#7653)
-
- I don't know if this fix is acceptable, but I have a PR here: https://github.com/ruby/ruby/pull/7656
-
- This was a deliberate change, see #16424.
-
- I sometimes use the pattern `print(str) rescue abort` in order to exit without stack trace when the output of a ruby program is interrupted by SIGPIPE, ex: `./printstuff.rb | head`
It seems that since ruby 2.7 this results in printing... -
07:59 PM Revision 8525603c (git): Revert "Fix transient heap mode"
- This reverts commit 87253d047ce35e7836b6f97edbb4f819879a3b25.
Revert "Implement `Process.warmup`"
This reverts commit ba6ccd871442f55080bffd53e33678c0726787d2. -
06:29 PM Bug #19568: Windows mingw rust, failures with test/rubygems/test_gem_ext_cargo_builder.rb
- @hsbt
Thanks.
JFYI, the problem also exists in [oxidize-rb/rb-sys](https://github.com/oxidize-rb/rb-sys/actions/workflows/ci.yml)'s CI. It may be MSYS2, but probably a Rust issue. As mentioned above, I couldn't find a change to R... -
- I ended up not using it.
-
-
- Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
-
- Applied in changeset commit:git|ba6ccd871442f55080bffd53e33678c0726787d2.
----------
Implement `Process.warmup`
[Feature #18885]
For now, the optimizations performed are:
- Run a major GC
- Compact the heap
- Promote all surviv... -
- Make sure the transient heap is in the right mode when we finish warming
the heap. Also ensure the GC isn't allowed to run while we iterate and
mutate the heap. -
- [Feature #18885]
For now, the optimizations performed are:
- Run a major GC
- Compact the heap
- Promote all surviving objects to oldgen
Other optimizations may follow. -
03:37 PM Misc #19431: DevMeeting at RubyKaigi 2023
- I will attend if the train schedules work out!
-
06:40 AM Misc #19431: DevMeeting at RubyKaigi 2023
- I'll attend.
-
-
- Please backport commit [537183cd2ac0163851277b46a2f21ea5914c11c0](https://github.com/ruby/ruby/commit/537183cd2ac0163851277b46a2f21ea5914c11c0). We've seen this crash in our production systems.
-
- Applied in changeset commit:git|a84c99468f26a9f79fec57926d561ed906505eac.
----------
Fix crash in Time on 32-bit systems
[Bug #19575]
struct vtm is packed causing it to have a size that is not aligned on
32-bit systems. When allocatin... -
- GitHub PR: https://github.com/ruby/ruby/pull/7650
struct vtm is packed causing it to have a size that is not aligned on 32-bit systems. When allocating it on the stack, it will have unaligned addresses which means that the fields won'... -
- [Bug #19575]
struct vtm is packed causing it to have a size that is not aligned on
32-bit systems. When allocating it on the stack, it will have unaligned
addresses which means that the fields won't be marked by the GC when
scanning the... -
- You are trying to run Ruby 2.6 on an Apple M1/M2 processor. I don't think Ruby 2.6 supported Apple M1/M2, but in any case, Ruby 2.6 is out of support. Please try with Ruby 3.1 or 3.2.
-
09:53 AM Bug #19574 (Closed): [BUG] Bus Error at 0x0000000102a7c000
-
- I have a little concern about the method name. `self.inherited(subclass)` reads as
> `self` is inherited by `subclass`.
Will an analogy work such that `self.singleton_inherited(s_class)` reads something like:
> ...
I am not sure. When... -
- https://github.com/rubygems/rubygems/commit/8c9ea5d180
-
- https://github.com/rubygems/rubygems/commit/52ae4452c2
-
- https://github.com/rubygems/rubygems/commit/b87ac64343
-
-
-
-
-
06:42 AM Revision f3acaf31 (git): `rb_th_serial(th)` allows `th == NULL`
-
- https://github.com/rubygems/rubygems/actions/runs/4598776839/jobs/8123290246
https://github.com/rubygems/rubygems/commit/5c3b0a112e -
-
- jeremyevans0 (Jeremy Evans) wrote in #note-4:
> hurricup (Alexandr Evstigneev) wrote in #note-3:
> ...
Thank you for the explanation. This is totally understandable for me.
I just saying that this may be non-intuitive for the languag... -
- hurricup (Alexandr Evstigneev) wrote in #note-3:
> And any expression is a valid argument for any call.
Just to be clear, while this may be a common belief, this is not the case. If you define valid expression to be a piece of Ruby ... -
- You are explaining from ruby developer perspective and it all makes sense.
But from pure language user this feels really strange and inconsistent. Especially `puts((...))` :D
`false or not false` is pretty valid expression. And any ... -
-
-
04/03/2023
-
- This issue is not only `make test-all`. see https://github.com/rubygems/rubygems/actions/runs/4598776839/jobs/8123289961
We should fix this on rubygems repo. -
- It's my understanding that these tests should not be run, they should be skipped by the method `skip_unsupported_platforms!`, at least they are skipped when I run `make test-all`. Were they being run before?
You can check this with: `... -
- because of 9720f5ac894566ade2aabcf9adea0a3235de1353
http://rubyci.s3.amazonaws.com/solaris11-sunc/ruby-master/log/20230403T130011Z.fail.html.gz
```
1) Failure:
TestThread#test_signal_at_join [/export/home/chkbuild/chkbuild-sunc/tmp/b... -
- * [Bug #4040] SystemStackError with Hash[*a] for Large _a_ (jeremyevans0)
* @ko1 fixed this issue for iseq methods accepting splats in Ruby 2.2.
* We fixed this issue for cfunc methods in January.
* I found this issue applies to... -
- - [Feature #19571] Add REMEMBERED_WB_UNPROTECTED_OBJECTS_LIMIT_RATIO to the GC (peterzhu2118)
- We tested on production traffic on Shopify's [Storefront Renderer](https://shopify.engineering/how-shopify-reduced-storefront-response-t... -
- * [Feature #18885] End of boot advisory API (byroot)
* I'm about to merge the first optimizations, are we still ok with `Process.warmup` as a name?
* [Feature #19561] ObjectSpace::WeakMap#delete and ObjectSpace::WeakKeyMap#delete (byro... -
- This would be similar to `Class#inherited`, but would be called with singleton classes of instances instead of subclasses. This could be used to warn or raise on singleton class creation, or modify the instance to change behavior, such a...
-
- **Summary**
Support a new `rescue` event type in TracePoint. When the event is triggered, `TracePoint#rescued_exception` can be used to access the exception.
**Reason**
Currently, TracePoint supports `raise` events, which can be h... -
-
- I think this is a bug in `Tempfile#{dup,clone}` that we should fix. I submitted a pull request for it: https://github.com/ruby/tempfile/pull/17
-
- > how the new parameter is used and how the current implementation calculate without new parameter
The default value is 0.01 (1%). It's calculated as 1% of the `old_objects` count. You can see the implementation is:
```c
objspace-... -
- Could you make clear the following?
* Please describe how the new parameter is used and how the current implementation calculate without new parameter.
* my understanding is this parameter is used for the major GC condition.
* This ne... -
- GitHub PR: https://github.com/ruby/ruby/pull/7577
The proposed PR adds the environment variable `RUBY_GC_HEAP_REMEMBERED_WB_UNPROTECTED_OBJECTS_LIMIT_RATIO` which is used to calculate the `remembered_wb_unprotected_objects_limit` usin... -
-
-
- Not all Ruby code is allowed directly as a method argument. You can surround the code with parentheses to allow it, so `puts((false or not false))` works. This is a similar issue as `puts(raise rescue false)`, but not exactly the same....
-
- This isn't a bug, nor does it appear to be introduced by #8851 (that added support for `%s` symbol literals with `alias`/`undef`, other symbol literals were already supported). `undef` and `alias` have always accepted symbols and bare w...
-
- Ah yes, sorry for that. Whenever I write and review something before posting, it seems fine. And whenever I re-read it a week later it feels too strong. Maybe it's a curse. Please accept my advance apologies if I'm doing the same thing i...
-
05:24 PM Bug #19570 (Closed): `Exception#full_message` raises an `EncodingError` if the exception contains UTF8 characters after a newline and `Exception#cause` contains UTF8 characters
- ```
e = begin
begin
raise "Übersicht"
rescue => e
raise "\n#{e.message}"
end
rescue => e
e
end
e.full_message
```
will reproduce the error with the exception `incompatible character encodings: ASCII-8BIT and U... -
- This fails on RubyCI due to RJIT warnings too often. It should be enough
to test RJIT feature in test_rjit_version. We only want warnings instead
of test failures when there are warnings, at least for this case. -
-
- What if there was a `american_english: true` magic comment that allowed this behavior? Then Ruby could support other English idioms and it would be extensible. Also British people could turn it off.
-
- You need to `require "optparse/uri"`. The docs should probably mention that if they don't already.
-
01:03 PM Bug #19569 (Closed): #map on Enumerator::Lazy block arguments seem to differ from regular #map
- A Ruby 2 to 3 upgrade surfaced the following issue:
Ruby 2:
```
irb(main):252:0> [1, 2, 3].to_enum.lazy.zip([:a, :b, :c]).map(&:last).to_a
=> [:a, :b, :c]
```
Ruby 3:
```
irb(main):020:0> [1, 2, 3].to_enum.lazy.zip([:a, :... -
- > Rails calls GC.stat(:total_allocated_objects) on every request
Yes, but it's actually a bit silly because it only works properly with non-threaded servers (e.g. Unicorn).
> ...
It's implemented as many `if (key == XXX) return att... -
-
-
-
-
-
-
-
-
-
-
- 05:32 AM Revision 0276c1d9 (git): * remove trailing spaces. [ci skip]
-
- 05:20 AM Revision 09ad7e20 (git): Update default gems list at 6fb6d85aeed3ed12cf92ae2af00908 [ci skip]
-
- https://github.com/ruby/fileutils/commit/7138d85156
-
-
-
- https://github.com/ruby/base64/commit/dda85a0839
-
- https://github.com/ruby/yaml/commit/8776bc2634
-
- https://github.com/ruby/tsort/commit/09f2275958
-
- https://github.com/ruby/find/commit/a24124a08a
-
02:05 AM Feature #19555: Allow passing default options to `Data.define`
- To clarify what I mean, this is a (very rough) demonstration:
``` ruby
class Data
def self.with_defaults(*symbols, **defaults, &block)
defaults&.each { |key, value| raise ArgumentError, "#{key} must be immutable" unless Racto... -
04/02/2023
-
-
-
- I've updated my pull request to include additional optimizations for:
* cfunc: 10-15* for f(*a) and 35-40% for f(*a, **kw) if kw is empty
* send: 5-115% depending on type of call
* symproc: 5-100% depending of type of call
* method... -
-
-
- to simplify the implementation
-
-
-
-
-
-
-
-
-
-
- The Windows ucrt & mingw builds recently started failing tests in:
test/rubygems/test_gem_ext_cargo_builder.rb TestGemExtCargoBuilder
Checking changed files from the last good build showed:
array.c
gems/bundled_gems
iseq.c
lib... -
- Ruby implementations like JRuby and TruffleRuby already indicate their
compatibility target with RUBY_VERSION. We don't need to exclude
them from accepting keyword arguments as long as they target 2.7+.
https://github.com/ruby/irb/commi... -
- * Remove unused ATTR_TTY and ATTR_PLAIN constants
They were added in https://github.com/ruby/irb/commit/d7d26b51bf47a52e4e2339e2ad509ace74f0e4c7
But the references were removed in https://github.com/ruby/irb/commit/1c76845cca59635bb0cf... -
- @Dan0042 Can you please elaborate your question (especially considering its extremely strong wording)?
This ticket is about changing the semantics of step to use `+` instead of `succ`, and Matz agreed to give it a try.
How exactly ... -
- Abort if `nm` is not available, since it is needed by configure.ac to
check for prefix of external symbols. -
-
06:51 AM Feature #8460: PATCH: optparse: add `keep_unknown` option
- Updated on top of master yet again.
-
-
-
-
-
-
-
-
- so that we can take an exit whenever we want.
As a starter, this commit also pops blockarg earlier than some
CantCompile exits. -
- because we want to do this way earlier for other types of calls.
-
-
- why not `, or` too?
-
-
-
04/01/2023
-
-
- Revert "Skip typeprof for now"
This reverts commit bdbf663cef31e2194bf87ae5c11dfe5525316ca8. -
- I'm curious about this as well. Would it make sense to have a separate method `.with_defaults`, that checks the mutability (i.e. `.frozen?`) of its arguments?
If the intention is for Data to be "deeply" immutable, I could see this mak... -
- It started failing probably because ISEQ removed an unused field.
I'll have a look at fixing it on the typeprof side, but let me skip it
until it's fixed. -
-
-
- This looks a lot like perl. Moving towards normal-text-like programming language may be a dangerous way.
Looks nice, but feels scary and unnecessary. -
- Ruby has regular commas:
```ruby
[a, b, c]
```
Ruby has trailing commas:
```ruby
[
a,
b,
c,
]
```
But I think both of these are hard to read compared to the Oxford comma.
We should introduce the Oxford comma so that... -
- The attached patch fails in an IRB test.
I'm not sure about this prompt transition, should this be fixed as expected?
As the line 004 ends the heredoc `C` but is inside `%W[`, isn't `]` ok here?
```
[25/39] TestIRB::TestRubyLex#tes... -
- Similar for Unicode codepoints.
```ruby
p Ripper.tokenize("<<EOS || %[\\u{4a\n""EOS\n\n\n\n""5a}]").join("")
# "<<EOS || %[EOS\n\n\n\n5a}]"
``` -
10:10 AM Bug #18743: Enumerator#next / peek re-use each others stacktraces
- Hello @ko1, let me know if the patch in the current form is acceptable.
Best,
Marcelo -
07:35 AM Revision 4ac8d117 (git): `*` in an array pattern should not be parsed as nil in ripper
- After 6c0925ba7017efde6091e2ec4f1a6be268166696, it was impossible
to distinguish between the presence or absence of `*`.
# Before the commit
Ripper.sexp('0 in []')[1][0][2][1] #=> [:aryptn, nil, nil, nil, nil]
Ripper.sexp('... -
- It was actually harder to type `cfp + 1`. `cfp 1` also works and is more
useful. -
- Somehow my gdb stopped recognizing VM_BLOCK_HANDLER_NONE (macro) today.
Just changing it to a safer code. -
-
04:43 AM Feature #19559 (Rejected): Introduce `Symbol#+@` and `Symbol#-@`, and eventually replace boolean arguments with symbols
- Giving `:"-exception"` symbol (plain) argument a meaning `exception: false` keyword argument is inconsistent. Making a few less strokes does not justify this weirdness.
Matz.
-
- rubyFeedback (robert heiler) wrote in #note-5:
> mame may like it
No -
- Interesting idea. But we reject for several reasons:
* Ruby uses upper/lower case to classify the type of variables/constants
* We already have method/variable names only differ in cases
For those reasons, ignoring cases would int... -
- because it does same thing.
03/31/2023
-
11:03 PM Bug #19566 (Closed): OptionParser::on raises unsupported argument type: URI (ArgumentError) but shouldn't
- The documentation says
> OptionParser comes with a few ready-to-use kinds of type coercion. They are
> ...
But when I try to use the class `URI` as a coercion class:
```
op = OptionParser.new
op.on("--uri URI", URI)
```
I g... -
- https://github.com/ruby/irb/commit/2517039812
-
- I'm not sure if this is a bug. There are many other cases where wrapping an object in a delegate changes behavior (e.g. `if false` vs. `if SimpleDelegator.new(false)`).
If we want to allow this to work, the most likely approach woul... -
05:44 PM Bug #19564 (Rejected): Range.cover? fails for Range wrapped in SimpleDelegator
- ```ruby
test 'built-in cover? method is broken for SimpleDelegator' do
class TimeRangeDelegator < SimpleDelegator
end
t1 = Time.now
t2 = t1+1.day
t3 = t1+1.week
r_long = t1..t3
r_short = t1..t2
assert r_l... -
-
06:02 PM Feature #19559: Introduce `Symbol#+@` and `Symbol#-@`, and eventually replace boolean arguments with symbols
- I think the idea is interesting; it also helps reduce the number of characters
used. mame may like it for golf code. :)
I do, however had, also think this may create a few issues. One I can think of
the top of the head may be that newco... -
07:19 AM Feature #19559: Introduce `Symbol#+@` and `Symbol#-@`, and eventually replace boolean arguments with symbols
- One of the benefits or Ruby used to be readability. There were great times when `Integer("2.3", :exception => false)` was standard. Than came the JS hash notation `Integer("2.3", exception: false)` which have not improved the situation a...
-
- @austin `-(-:chomp)` would simply be invalid just like when you pass some random symbol there `:some_random_symbol` that is not expected there. And why would you write `+:"-chomp"`? There is no point in doing that. In the first place, as...
-
- So, first april is on the horizon and in-before-we-go (nobu tends
to make quick first april proposals, so let's hurry up!)
It is here proposed to ignore case, that is, lower-case, and upper-case,
at the least for method calls. This ... -
-
-
- ~~~ruby
Ripper.tokenize "<<EOF || %w[hello\nEOF\n\n\n\nworld]"
# actual result
["<<EOF", " ", "||", " ", "%w[", "hello", "\n\n\n\n", "EOF\n", "world", "]"]
# expected result
["<<EOF", " ", "||", " ", "%w[", "hello", "\n", "EOF\n", "... -
- reorder `sleep_forever()` and so on.
-
-
-
-
- for future extension
-
- because `RUBY_DEBUG_LOG()` add "\n" at the end of message.
-
- to `rb_thread_t::has_dedicated_nt`
-
- `ec` can be NULL in future.
-
-
-
-
-
- This works like:
```
(gdb) cfp
CFP (count=3, addr=0x7ffff73fef50):
$1 = {pc = 0x555556bf7818, sp = 0x7ffff72ff078, iseq = 0x7ffff2603270, self = 140737344619296, ep = 0x7ffff72ff058, block_code = 0x0,
__bp__ = 0x7ffff72ff060, jit_retu... -
- It was crashing with:
No symbol "ROBJECT_EMBED_LEN_MAX" in current context. -
- This reverts commit 83667008b925c32b3ab70fb6ec70f7398e960d1e.
because not stable yet. -
- https://github.com/ruby/net-http/commit/4d31bde125
- 03:22 AM Revision eedcd696 (git): [ruby/net-http] Fix previous commit
- https://github.com/ruby/net-http/commit/1b276e2654
- 03:22 AM Revision d8b8294c (git): [ruby/net-http] Limit header length
- https://github.com/ruby/net-http/commit/c245f7f9c8
-
- Show native thread's serial on `RUBY_DEBUG_LOG`.
`nt->serial` is also stored into `ruby_nt_serial` if the compiler
supports `RB_THREAD_LOCAL_SPECIFIER`. -
- to test debug printing.
-
- Only `Bundler` might be defined. `EnvironmentPreserver` and its
`BUNDLER_PREFIX` would be defined together in the same file. -
- So that fixes crash with "invalid byte sequence in US-ASCII" on
ci.rvm.jp and some RubyCIs.
https://github.com/ruby/rdoc/commit/4b416644f0 -
- https://github.com/ruby/rdoc/commit/987c609df9
- 12:56 AM Revision 8523892d (git): Bump ossf/scorecard-action from 2.1.2 to 2.1.3
- Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.1.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md... -
12:38 AM Revision 3488eda4 (git): Fix gc_verify_internal_consistency error for pattern_matching in ripper
- `gc_verify_internal_consistency` reports "found internal inconsistency"
for "test_pattern_matching.rb".
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sp2-docker/4501173
Ruby's parser manages objects by two different ways.
1. For pars...