* [Feature #11689] Add methods allow us to get visibility from Method and UnboundMethod object. (eregon) * I think we should re-add (undo revert) {Method,UnboundMethod}#{public?,private?,protected?} on master, see https://bugs.ruby-la...Eregon (Benoit Daloze)
`Range#last(n)` with a single-element of Integer returns an empty Array. It should return a one-element Array. Interestingly, when the element is a String, `last(n)` returns a one-element Array, expectedly. I have checked the behav...masasakano (Masa Sakano)
Here is the dev meeting log: https://github.com/ruby/dev-meeting-log/blob/master/DevMeeting-2022-08-18.md#feature-18949-deprecate-and-remove-replicate-and-dummy-encodings-eregon > Conclusion: Just remove the dynamic UTF-16/32 endian d...Eregon (Benoit Daloze)
RubyBugs (A Nonymous) wrote in #note-58: > We hope that a Ruby-native solution might address some of the same needs we have in the gem: Can you please file a separate ticket to discuss `Data` extensions that don't exist in Struct? Ther...k0kubun (Takashi Kokubun)
Make Object#method and Module#instance_method not skip ZSUPER methods Based on https://github.com/jeremyevans/ruby/commit/c95e7e5329140f640b6497905485761f3336d967 Among other things, this fixes calling visibility method...nagachika (Tomoyuki Chikanaga)
The returned values of Range#size between Rational and Float and also with regard to `exclude_end` of true and false are inconsistent. The example below highlights the difference. The first and second should return the same value. The...masasakano (Masa Sakano)
Good catch, thank you for your report. I could recreate the issue without coverage. ``` RubyVM::InstructionSequence.compile_option = false eval("1&.tap { break }") #=> break from proc-closure (LocalJumpError) ``` Here is my anal...mame (Yusuke Endoh)
Enabling branch coverage leads to a false LocalJumpError where it should not be raised. ```ruby # test.rb require "coverage" Coverage.start(branches: true) # Coverage.start(lines: true) load "./test2.rb" ``` ```ruby # test...qnighy (Masaki Hara)
This is a ticket for backport management. https://github.com/ruby/ruby/pull/6125 Note: rbs-2.6.0+ is temporary for test fails with `Gem.use_gemdeps`. We should replace it with 2.6.1 or 2.7.0 after releasing a stable version. hsbt (Hiroshi SHIBATA)
A common pattern when the block is an explicit parameter is to branch based on the block parameter instead of using `block_given?`, for example `block.call if block`. This commit checks in the peephole optimizer for that case and uses t...jhawthorn (John Hawthorn)
Applied in changeset commit:git|064944c9029fae0552f120ea586f4f83ce206ec6. ---------- Stop using a callee-saved register for scratch0 on aarch64 (#6312) [Bug #18985] * Callee-save x22 for aarch64 * Just use a caller-saved register * ...k0kubun (Takashi Kokubun)
Tabs were expanded because the file did not have any tab indentation in unedited lines. Please update your editor config, and use misc/expand_tabs.rb in the pre-commit hook.git[bot]
Previously YARV bytecode implemented constant caching by having a pair of instructions, opt_getinlinecache and opt_setinlinecache, wrapping a series of getconstant calls (with putobject providing supporting arguments). This commit repla...jhawthorn (John Hawthorn)
> That behavior should be inherited from Cygwin. Thanks, never saw a specific reference to that. I'm ok to close, not sure about RubyInstaller2, probably better to have an issue there if there are issues with Bash bin files...MSP-Greg (Greg L)
[Bug #18985] * Callee-save x22 for aarch64 * Just use a caller-saved register * Update yjit/src/backend/arm64/mod.rs Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmai...k0kubun (Takashi Kokubun)
* Let --yjit-dump-disasm=all dump ocb code as well * Use an enum instead * Add a None Option to DumpDisasm (#444) * Add a None Option to DumpDisasm * Update yjit/src/asm/mod.rs Co-authored-by: Maxime Chevalier-Boisvert <maximecheval...k0kubun (Takashi Kokubun)
**3. Keyword arg constructors** Because a non-mutating copy-with-changes such as `#with` will need to take keyword arguments to indicate which values to change, it’s useful to provide a constructor form which also accepts keyword argu...RubyBugs (A Nonymous)
**2. Highly optimized hash and eql?** Because we use value objects in loops, profiling led us to the commits in our fork of tcrayford/values, which optimize these methods, so that using Value objects in Sets and as Hash keys will be a...RubyBugs (A Nonymous)
@eregon This is great news! At Panorama Education, we use maintain a fork of the tcrayford/values gem here for this purpose here: https://github.com/ms-ati/Values/tree/panoramaed-2.0.x We hope that a Ruby-native solution might addr...RubyBugs (A Nonymous)
I've found that sometimes, when matching nested patterns, I get an unexpected "duplicate key name" error but there's no duplicate key in any individual pattern. The "duplicated" key is actually in another pattern that's in scope, which I...zeke (Zeke Gabrielse)
zverok (Victor Shepelev) wrote in #note-31: > I am afraid I don't see a pattern that you hope to see (e.g., quoting #16120, that it would mostly be `{ _1.something(args) }`. Thank you. It's surprising to me, but very enlightening. N...Dan0042 (Daniel DeLorme)
> Now I'm almost giving it up because there are more people who dislike it than I expected. Is it really a problem though? This proposal is basically about a new alias for an existing feature. I don't think it logically need to please...byroot (Jean Boussier)
Or maybe making the restore more explicit ``` ruby obj.assign_attrs(foo: "bar") do # do something end.restore ``` ``` ruby obj.assign_attrs(foo: "bar") do |restorable| # do something ensure restorable.restore end ``` ``` ruby ob...p8 (Petrik de Heus)
The "dumb" terminal is considered only on MSys tty now. However, the `TERM` feature has been used on many Unix-like systems for decades, not MSys specific. https://github.com/ruby/reline/commit/53fd51ab62nobu (Nobuyoshi Nakada)
Now I'm almost giving `it` up because there are more people who dislike `it` than I expected. I thought compatibility was the only blocker of `it`, but it doesn't seem like the case. However, even if `it` is not gonna make it, the probl...k0kubun (Takashi Kokubun)
@Dan0042 > Out of curiosity, how many of those ~200 are used as the first token in the block (like { _1.foo }) vs. how many used in another way? I am afraid I don't see a pattern that you hope to see (e.g., quoting #16120, that it...zverok (Victor Shepelev)
Dan0042 (Daniel DeLorme) wrote in #note-29: > I'm also one of those who didn't manage to get used to this syntax. I'll use it sometimes in IRB, or in code samples in this tracker, but never in any code I commit... it just feels unclean ...austin (Austin Ziegler)
I'm also one of those who didn't manage to get used to this syntax. I'll use it sometimes in IRB, or in code samples in this tracker, but never in any code I commit... it just feels unclean for some reason. So far I count k0kubun and...Dan0042 (Daniel DeLorme)
Dan0042 (Daniel DeLorme) wrote in #note-10: > Also really like the idea, also ambivalent about such a short and generic name. > ... - `#override_with` - `#mut` - `#mutate` - `#borrow_with` - `#with_restore` - `#restore_do` - `#ta...austin (Austin Ziegler)
Also really like the idea, also ambivalent about such a short and generic name. I think it would be good if the name emphasized a bit more that the original values will be restored after the block. Something in the vein of `temporaril...Dan0042 (Daniel DeLorme)
* Better b.cond usage on AArch64 When we're lowering a conditional jump, we previously had a bit of a complicated setup where we could emit a conditional jump to skip over a jump that was the next instruction, and then write out the des...kddnewton (Kevin Newton)
I realize I'm late, but instead of "pointing the user to use ENV.to_h" it would be more helpful to just have dup/clone be aliases of to_h. It's the obvious behavior that everyone using ENV.clone was expecting in the first place.Dan0042 (Daniel DeLorme)
Ripper does not seems to recognize regexp named capture defining new local variables, fails to parse some code. ~~~ruby requie 'ripper' # expect syntax ok, got syntax error Ripper.sexp("/(?<a>)/ =~ ''; x = a **a, a if false") # ...tompng (tomoya ishida)
The current distributed package still contained libyaml and libffi sources. We will remove them and introduce the instructions to download them when building ruby like `./configure --enable-download-source`. hsbt (Hiroshi SHIBATA)
MSP-Greg (Greg L) wrote in #note-15: > Interesting thing that I found is that MSYS2's `which` command considers a file to executable if it is an exe file or if it starts with a shebang (`#!`). That behavior should be inherited from C...nobu (Nobuyoshi Nakada)
`BufferedIO` is a bit inefficient for reading large responses because it use the classic `buffer.slice!` technique which cause a lot of unnecessary string copying. This is particularly visible on line based protocol when reading line by...byroot (Jean Boussier)
svn.ruby-lang.org provides subversion write endpoint for stable maintainers and read endpoint for anonymous users. But Ruby 2.6 the last version, used subversion is EOL today. I will shut down the subversion service of svn.ruby-lang.o...hsbt (Hiroshi SHIBATA)
Hello @hsbt. Can you provide more details as to which version of Linux and which CPU you are running? Are you running this on a Raspberry Pi, or is this on an AWS Graviton instance? It might also be useful for us if you can try an ...maximecb (Maxime Chevalier-Boisvert)
When we use `-e` option with YJIT, It's always crush on aarch64-linux. ``` $ ruby --jit -e "puts :foo" /home/chkbuild/.rbenv/versions/3.2.0-dev/lib/ruby/3.2.0+2/aarch64-linux/rbconfig.rb:305: [BUG] Segmentation fault at 0x00000e80f9...hsbt (Hiroshi SHIBATA)
When a (Numeric) argument is given to `Range#last(n)` for a Range with `Float::INFINITY`, it runs into an infinite loop (see a small code snippet below). There is no use case for the feature as far as I can think of, and it is hard to d...masasakano (Masa Sakano)
> One thing that this "design space analysis" keeps ignoring, ... It doesn't (though I by no means consider it exhaustive or definitive, it is just "what I am thinking about when considering options"): > ... It doesn't mention `@` ...zverok (Victor Shepelev)
zverok (Victor Shepelev) wrote in #note-26: > My "design space analysis" was sourced by the same idea. I can say that I would NOT choose `it` (or any other name looking "regularly"), unless it would be a keyword (like `self`), having ...ufuk (Ufuk Kayserilioglu)
> if you were able to design Ruby from the ground up, would you still use a syntax that you think is a name compromise and looks weird for newcomers? My "design space analysis" was sourced by the same idea. I can say that I would NOT ...zverok (Victor Shepelev)
> Say, I considered `yield_self` so wrong naming choice I spent the good part of that year fighting for its renaming, but at the same time I started to use it (and it DID make code better, as my colleagues agreed, you just needed to get ...k0kubun (Takashi Kokubun)
> It's interesting that "Numbered parameters (_1, _2, ...) look like unused local variables" doesn't seem to resonate with you. It did initially, but let's say I got over it. There were several factors in play: 1. I am very concern...zverok (Victor Shepelev)
I just removed the line pointed out by @Eregon, so I guess all the workarounds added around the `FileUtils.rm_rf` in RubyGems teardown method can now be removed too!deivid (David Rodríguez)
@mame I agree with your analysis, but I have to say from experience that realworld bugs hidden by this behavior are pretty hard to fix too. The warning in verbose mode sounds great, but perhaps we could also mention this in documentation...deivid (David Rodríguez)
We're not fully in control of this folder, even when running our own tests, because MJIT creates some temp folders there when invoking GC. This bite tests running in ruby-core when making the behavior of `FileUtils.rm_rf` more strict, b...deivid (David Rodríguez)
I don't think people want to exit from a `while item = queue.pop` loop because the queue would block. `for (;;) { if (errno != EAGAIN) break; ... }` is a C idiom (people often break from a loop on error, _except_ EAGAIN).shyouhei (Shyouhei Urabe)
shyouhei (Shyouhei Urabe) wrote in #note-4: > +1 for avoiding exceptions but `nil` can be problematic? Because a closed queue would also return `nil` for `pop`. You cannot distinguish if a queue is closed or would just block. We co...jeremyevans0 (Jeremy Evans)
> but nil can be problematic? This was discussed in #18774: - `#pop` on closed queue already returns `nil` with no exception. `Queue.new.tap(&:close).pop # => nil` - `nil` make sense because you can use it in a loop such as `...byroot (Jean Boussier)
+1 for avoiding exceptions but `nil` can be problematic? Because a closed queue would also return `nil` for `pop`. You cannot distinguish if a queue is closed or would just block.shyouhei (Shyouhei Urabe)
@nobu Sorry the above are what I thought would work best with the ruby-loco builds. All three builds (mingw, mswin, & ucrt) are now done that way. Interesting thing that I found is that MSYS2's `which` command considers a file to ex...MSP-Greg (Greg L)
> Unused local variables are more like `_[a-z]\w+`, the number makes the variable "anonymous" so it can't be an unused local variable > ... It's interesting that "Numbered parameters (`_1`, `_2`, ...) look like unused local variables" d...k0kubun (Takashi Kokubun)
> I forgot, is _ problematic in practice? `_` is very widespread name to "I don't need that". TBH, till 5 min ago I thought it is processed specially in the case of parameter repetition: ```ruby [[1, 2, 3], [4, 5, 6]].map { |i, _,...zverok (Victor Shepelev)
The logical sigil for a single arguments would be `_` of course (given we have `_1`, `_2`, etc). I forgot, is `_` problematic in practice? The usage of it in irb/pry should not be an issue given the variable is explicitly declared th...Eregon (Benoit Daloze)
My 5c: I came to (almost) peace with `_1`, and we use it extensively in the codebase, and find it quite convenient. Choosing the designation for it is a hard choice, and after years of consideration, I believe that the current solutio...zverok (Victor Shepelev)
There are a lot of times when encoding AArch64 instructions that we need to represent an integer value with a custom fixed width. For example, the offset for a B instruction is 26 bits, so we store an i32 on the instruction struct and th...kddnewton (Kevin Newton)
Previously we cleared the cache for all the code in the system when we flip memory protection, which was prohibitively expensive since the operation is not constant time. Instead, only clear the cache for the memory region of newly writt...alanwu (Alan Wu)
* Add --yjit-dump-disasm to dump every compiled code * Just use get_option * Carve out disasm_from_addr * Avoid push_str with format! * Share the logic through asm.compile * This seems to negatively impact the compilation speedk0kubun (Takashi Kokubun)
* When we're storing an immediate 0 value at a memory address, we can use STUR XZR, Xd instead of loading 0 into a register and then storing that register. * When we're moving 0 into an argument register, we can use MOV Xd, XZR ins...kddnewton (Kevin Newton)
* Remove references to explicit instruction parts Previously we would reference individual instruction fields manually. We can't do that with instructions that are enums, so this commit removes those references. As a side effect, we can...kddnewton (Kevin Newton)
* Operand iterators There are a couple of times when we're dealing with instructions that we need to iterate through their operands. At the moment this is relatively easy because there's an opnds field and we can work with it directly. ...kddnewton (Kevin Newton)
Yet another case of `jit_mov_gc_ptr()` being yanked out during the transition to the new backend, causing a crash after object movement. The intresting wrinkle with this one is that not all callinfos are GC'ed objects, so the old code ha...alanwu (Alan Wu)
* Mutate in place for register allocation Currently we allocate a new instruction every time when we're doing register allocation by first splitting up the instruction into its component parts, mapping the operands and the output, and t...kddnewton (Kevin Newton)
* Only check lowest bit for _Bool type The `test AL, AL` got lost during porting and we were generating `test RAX, RAX` instead. The upper bits of a `_Bool` return type is unspecified and we were failing `TestClass#test_singleton_class_...alanwu (Alan Wu)
When we're pushing instructions onto the assembler, we previously would iterate through the instruction's operands and then assign the output operand to it through the push_insn function. This is easy when all instructions have a vector ...kddnewton (Kevin Newton)
Currently we use macros to define the shape of each of the instruction building methods. This works while all of the instructions share the same fields, but is really hard to get working when they're an enum with different shapes. This i...kddnewton (Kevin Newton)
* Create code generation func * Make rb_vm_concat_array available to use in Rust * Map opcode to code gen func * Implement code gen for concatarray * Add test for concatarray * Use new asm backend * Add comment to C func wrapperwildmaples (Maple Ong)
We have a large extern block in cruby.rs leftover from the port. We can use bindgen for it now and reserve the manual declaration for just a handful of vm_insnhelper.c functions. Fixup a few minor discrepencies bindgen found between the...alanwu (Alan Wu)
`YJIT.simulate_oom!` used to leave one byte of space in the code block, so our test didn't expose a problem with asserting that the write position is in bounds in `CodeBlock::set_pos`. We do the following when patching code: 1. save cu...alanwu (Alan Wu)
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.noahgibbs (Noah Gibbs)
* Iterator * Use the new iterator for the X86 backend split * Use iterator for reg alloc, remove forward pass * Fix up iterator usage on AArch64 * Update yjit/src/backend/ir.rs Co-authored-by: Maxime Chevalier-Boisvert <maximecheval...kddnewton (Kevin Newton)
* Port expandarray to the new backend IR * More use of into() * Break out live ranges * Refactor the code further * Reuse registers morek0kubun (Takashi Kokubun)
* Port gen_send_iseq to the new backend IR * Replace occurrences of 8 by SIZEOF_VALUE Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>k0kubun (Takashi Kokubun)
* Update flags for data processing on ARM * Update yjit/src/backend/arm64/mod.rs Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>kddnewton (Kevin Newton)
Previously, we patched in an x64 JMP even on A64, which resulted in invalid machine code. Use the new assembler to generate a jump instead. Add an assert to make sure patches don't step on each other since it's less clear cut on A64, wh...alanwu (Alan Wu)
* Left and right shift for IR * Update yjit/src/backend/x86_64/mod.rs Co-authored-by: Alan Wu <XrXr@users.noreply.github.com> Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>kddnewton (Kevin Newton)
* Port opt_eq and opt_neq to the new backend * Just use into() outside Co-authored-by: Alan Wu <XrXr@users.noreply.github.com> * Use C_RET_OPND to share the register * Revert "Use C_RET_OPND to share the register" This reverts commi...k0kubun (Takashi Kokubun)
* Port setivar to the new backend IR * Add a few more setivar test cases * Prefer const_ptr Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>k0kubun (Takashi Kokubun)
* Fix asm.load(VALUE) - `<VALUE as impl Into<Opnd>>` didn't track that the value is a value - `Iterator::map` doesn't evaluate the closure you give it until you call `collect`. Use a for loop instead so we put the gc offsets into th...alanwu (Alan Wu)
* Port gen_send_cfunc to the new backend * Remove an obsoleted test * Add more cfunc tests * Use csel_e instead and more into() Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> * Add a missing lea for build_kwa...k0kubun (Takashi Kokubun)
forward_pass adjusts the indexes of our opnds to reflect the new instructions as they are generated in the forward pass. However, we were using the old live_ranges array, for which the new indexes are incorrect. This caused us to previo...jhawthorn (John Hawthorn)
* Convert getinstancevariable to new backend IR * Support mem-based mem * Use more into() * Add tests for getivar * Just load obj_opnd to a register * Apply another into() * Flip the nil-out condition * Fix duplicated counts of si...k0kubun (Takashi Kokubun)
* Port gen_concatstring to new backend IR * Update yjit/src/codegen.rs Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>zack.ref@gmail.com (Zack Deveau)
* Port anytostring, intern, and toregexp * Port getspecial to the new backend (#349) PR: https://github.com/Shopify/ruby/pull/349k0kubun (Takashi Kokubun)
* Move allocation into Assembler::pos_marker We wanted to do this to begin with but didn't because we were confused about the lifetime parameter. It's actually talking about the lifetime of the references that the closure captures. Sinc...alanwu (Alan Wu)
* A64: Fix off by one in offset encoding for BL It's relative to the address of the instruction not the end of it. * A64: Fix off by one when encoding B It's relative to the start of the instruction not the end. * A64: Add some tests...alanwu (Alan Wu)
It allows for reserving a specific register and prevents the register allocator from clobbering it. Without this `./miniruby --yjit-stats --yjit-callthreshold=1 -e0` was crashing because the counter incrementing code was clobbering RAX i...alanwu (Alan Wu)
* Better splitting for Op::Add, Op::Sub, and Op::Cmp * Split stores if the displacement is too large * Use a shifted immediate argument * Split all places where shifted immediates are used * Add more tests to the cirrus workflowkddnewton (Kevin Newton)
* Refactor defer_compilation to use PosMarker * Port gen_direct_jump() to use PosMarker * Port gen_branch, branchunless * Port over gen_jump() * Port over branchif and branchnil * Fix use od record_boundary_patch_point in jump_to_ne...Maxime Chevalier-Boisvert
* get_dupn was allocating and throwing away an Assembler object instead of using the one passed in * Uncomment remaining tests in codegen.rs, which seem to work nownoahgibbs (Noah Gibbs)
* Implement PosMarker instruction * Implement PosMarker in the arm backend * Make bindgen run only for clang image * Fix if-else in cirrus CI file * Add missing semicolon * Try removing trailing semicolon * Try to fix shell/YAML sy...Maxime Chevalier-Boisvert
* ADR and ADRP for AArch64 * Implement Op::Jbe on X86 * Lera instruction * Op::BakeString * LeaPC -> LeaLabel * Port print_str to the new backend * Port print_value to the new backend * Port print_ptr to the new backend * Write n...kddnewton (Kevin Newton)
Previously we were using a `Box<dyn FnOnce>` to support patching the code when jumping to labels. We needed to do this because some of the closures that were being used to patch needed to capture local variables (on both X86 and ARM it w...kddnewton (Kevin Newton)
* More Arm64 lowering/backend work * We now have encoding support for the LDR instruction for loading a PC-relative memory location * You can now call add/adds/sub/subs with signed immediates, which switches appropriately based on sign ...kddnewton (Kevin Newton)
* Get initial wiring up * Split IncrCounter instruction * Breakpoints in Arm64 * Support for ORR * MOV instruction encodings * Implement JmpOpnd and CRet * Add ORN * Add MVN * PUSH, POP, CCALL for Arm64 * Some formatting and imp...kddnewton (Kevin Newton)
The output from `dbg!` was too verbose. For `test_jo` the output went from 37 lines to 5 lines. The added index helps parsing InsnOut indicies. Samples: ``` test backend::tests::test_jo ... [src/backend/ir.rs:589] &self = Assembler ...alanwu (Alan Wu)
* Remove x86-64 dependency from codegen.rs * Port over putnil and putobject * Port over gen_leave() * Complete port of gen_leave() * Fix bug in x86 instruction splittingmaximecb (Maxime Chevalier-Boisvert)
* Initial setup for aarch64 * ADDS and SUBS * ADD and SUB for immediates * Revert moved code * Documentation * Rename Arm64* to A64* * Comments on shift types * Share sig_imm_size and unsig_imm_sizemaximecb (Maxime Chevalier-Boisvert)
* Split instructions if necessary * Add a reusable transform_insns function * Split out comments labels from transform_insns * Refactor alloc_regs to use transform_insnskddnewton (Kevin Newton)
Ruby 3.1 has passed all the tests with `make check`. Ruby 2.7 and Ruby 3.0 failed some tests like Socket. But these are not related to these changes. hsbt (Hiroshi SHIBATA)
https://github.com/ruby/ruby/pull/6193 is needed by macOS 13.0(Ventura). I created the following patches. * for Ruby 2.7: https://github.com/ruby/ruby/pull/6297 * for Ruby 3.0: https://github.com/ruby/ruby/pull/6298 * for Ruby 3....hsbt (Hiroshi SHIBATA)
When `Range` consists of any Numeric, according to [Official docs for Ruby-3.1.2](https://ruby-doc.org/core-3.1.2/Range.html#method-i-size), `Range#size` should, > Returns the count of elements in self if both begin and end values ar...masasakano (Masa Sakano)
LevLukomskyi (Lev Lukomskyi) wrote in #note-25: > > You need to fail when someone passes you garbage (and `nil` is a garbage value in this case), or you need to ensure better default values (e.g., `{}`) at your call sites. > ... You do...austin (Austin Ziegler)
> You need to fail when someone passes you garbage (and `nil` is a garbage value in this case), or you need to ensure better default values (e.g., `{}`) at your call sites. When you pass `nil` you make less allocations, also you don't...LevLukomskyi (Lev Lukomskyi)
I feel like in the do/end form it's quite clear: ```ruby obj.with(foo: "bar") do # do something end ``` Just like `5.times do` doesn't need to be named `exec_times` to be clear. byroot (Jean Boussier)
I'll add my 2 cents as well: I really really like the proposed idea and I would love to see it added to Ruby for 3.2. However, I find `with` a little too generic as a name for the concept. Primarily, when I look at it, it doesn't tell...ufuk (Ufuk Kayserilioglu)
`Range#size` should, according to [Official docs](https://ruby-doc.org/core-3.1.2/Range.html#method-i-size), > Returns the count of elements in self if both begin and end values are numeric; otherwise, returns nil but it doesn't wi...masasakano (Masa Sakano)
- [Feature #18982] Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop (byroot) - The existing exceptions (ThreadError) are a bit awkward to deal with. - Queue is often used deep into th...byroot (Jean Boussier)
I'd suggest having the warning for $VERBOSE=false too (and so no warning for $VERBOSE=nil). When such an error happens it means something is going wrong, and I'd imagine it's a lot more helpful for anyone using `rm_rf` and getting a bug...Eregon (Benoit Daloze)
Thanks @mame, a warning in `$VERBOSE` mode is definitely better than nothing :) Thanks @eregon! I originally introduced that because one maintainer was getting test failures on her system otherwise, and because I thought we completely...deivid (David Rodríguez)
Those temporary directories should be separate, but I guess the issue is this line which means other things might get stored in that test temp dir: https://github.com/ruby/ruby/blob/7bdb999d0f28c7bb9d7a35ca775e405674527e5f/test/rubygems...Eregon (Benoit Daloze)
I have talked with @matz about this issue. He said let's revert this change. Instead, it will print a warning whenever it fails to delete a file (only when `$VERBOSE = true`). I will create a patch.mame (Yusuke Endoh)
mame (Yusuke Endoh) wrote in #note-14: > deivid (David Rodríguez) wrote in #note-13: > ... I think I have identified the mechanism. In short, my guess was correct. * rubygems attempts to delete TMPDIR by `FileUtils.rm_rf`. * `FileU...mame (Yusuke Endoh)
This reverts commit 7bdb999d0f28c7bb9d7a35ca775e405674527e5f. I think I confirmed the mechanism. GCC (invoked by MJIT) creates a temporary file in TMPDIR, which prevents rm_rf from removing the directory.mame (Yusuke Endoh)
This replaces [Feature #18965] Currently these methods raise in three occasions: - `ThreadError(queue empty)` for `#pop` in `nonblock=true` mode, and the operation would block. - `ThreadError(queue full)` for `SizedQueue#push`...byroot (Jean Boussier)
baweaver (Brandon Weaver) wrote in #note-17: > I do not see a distinct enough difference to justify `@1`, and would reiterate previous arguments that even if it is technically illegal syntax it will still be confused for instance variab...jeremyevans0 (Jeremy Evans)
> @1 syntax In case it wasn't clear, the alternative that @jeremyevans0, @graywolf, and I talked about was not `@1` but `@`. They're different. > ... I discussed that at https://bugs.ruby-lang.org/issues/18980#note-8. 2+ args cases a...k0kubun (Takashi Kokubun)
#### Aliasing While I understand that `_1` is not necessarily clear and immediately obvious it has seen a lot of use. Even if we were to introduce `it` or any other syntax it would effectively be an alias so as to not break compatibilit...baweaver (Brandon Weaver)
For your information, `@` was a candidate discussed and rejected when `@1` was changed to `_1`. I'm raising `it` partly because it hasn't been explicitly rejected. However, for the same reason discussed above, `@` is still a better compr...k0kubun (Takashi Kokubun)
jeremyevans0 (Jeremy Evans) wrote in #note-13: > If we are considering an alternative to `_1`, I'm going to vote again for `@` (bare at sign) (originally proposed in https://bugs.ruby-lang.org/issues/4475#note-10). This is currently in...graywolf (Gray Wolf)
LevLukomskyi (Lev Lukomskyi) wrote in #note-22: > > I also tend to do `**(options || {})` and I don’t write hard-to-read code like `**({id: id, name: name} if id.present?)`. > ... I disagree that it’s the same, but more to the point,...austin (Austin Ziegler)
This bug is fixed by "Microsoft(R) C/C++ Optimizing Compiler Version 19.33.31629 for x64". And applied to GitHub Actions at runner-image 20220821.1.nobu (Nobuyoshi Nakada)
Applied in changeset commit:git|ace2eee544378eb03ea95b95c89434508325e8c8. ---------- [Bug #18963] Separate string contents by here document terminatornobu (Nobuyoshi Nakada)
05:17 PM Misc #18977: DevMeeting-2022-09-22
05:07 PM Revision 45004bba (git): fake.rb needs id.h
03:20 PM Bug #18994 (Closed): Range#last(n) returns empty for single-element Integer Range
01:36 PM Revision fe865c52 (git): [DOC] Enhanced RDoc for Time (#6320)
08:41 AM Feature #16122: Data: simple immutable value object
06:57 AM Bug #18992: Update versions of the default gems for Ruby 3.1
06:54 AM Revision 4a9a38c3 (git): Bump typeprof version to 0.21.3
10:18 AM Bug #18991: False LocalJumpError when branch coverage is enabled
03:22 AM Bug #18991 (Closed): False LocalJumpError when branch coverage is enabled
02:14 AM Revision 9b48edd9 (git): Allow comparing against 64-bit immediates on x86 (#6314)
12:36 AM Revision fc2d9fed (git): Use getblockparamproxy with branch
09:59 PM Bug #18970: CRuby adds an invalid header to bin/bundle (and others) which makes it unusable in Bash on Windows
04:09 PM Feature #16122: Data: simple immutable value object
03:06 PM Bug #18990 (Closed): Pattern matching unexpectedly raises "duplicated key name" error
01:57 PM Feature #18980: `it` as a default block parameter
01:13 PM Feature #18980: `it` as a default block parameter
12:16 AM Feature #18980: `it` as a default block parameter
10:47 AM Revision f67ab7f3 (git): [ruby/did_you_mean] Fixed correction duplicates in VariableNameChecker
10:37 AM Feature #18951: Object#with to set and restore attributes around a block
06:01 AM Revision aa5c1a04 (git): [rubygems/rubygems] Support non gnu libc arm-linux-eabi platforms
05:01 AM Revision 941e9be0 (git): [ruby/reline] Remove loose operation in Dialog#render_each_dialog
08:53 PM Feature #18980: `it` as a default block parameter
04:05 PM Bug #18988 (Closed): Ripper cannot parse some code that has regexp named capture
03:56 PM Bug #18985: SEGV with YJIT on aarch64-linux
01:38 PM Feature #18980: `it` as a default block parameter
10:45 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
08:36 AM Feature #18982: Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop
12:42 AM Feature #18982: Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop
04:09 PM Revision 46007b88 (git): A64: Only clear icache when writing out new code (https://github.com/Shopify/ruby/pull/442)
04:09 PM Revision 93c5a5f0 (git): Fix and re-enable String to_s, << and unary plus (https://github.com/Shopify/ruby/pull/429)
03:47 PM Revision 5a76a15a (git): YJIT: Implement concatarray in yjit (https://github.com/Shopify/ruby/pull/405)
03:47 PM Revision cb15886e (git): Port opt_getinlinecache to the new backend (https://github.com/Shopify/ruby/pull/399)
12:40 AM Feature #18959: Handle gracefully nil kwargs eg. **nil
02:11 PM Feature #18951: Object#with to set and restore attributes around a block
05:42 AM Revision 78748a5d (git): Introduce `usage_analysis_clear`
09:57 PM Revision 055fc7b1 (git): Fix comment in timev.rb
09:21 PM Feature #18980: `it` as a default block parameter
04:42 PM Feature #18980: `it` as a default block parameter