Activity
From 05/27/2022 to 06/02/2022
06/02/2022
-
05:17 PM Feature #18815: instance_{eval,exec} vs Proc#>>
- zverok (Victor Shepelev) wrote in #note-3:
> @jeremyevans0 I don't think it is a "bug", but maybe a nice feature to have
That makes sense. Switching to feature request. -
04:56 PM Feature #18815: instance_{eval,exec} vs Proc#>>
- @jeremyevans0 I don't think it is a "bug", but maybe a nice feature to have (composite procs being a bit smarter than just a really thin syntax sugar over what you could've done manually). The realistic case I have is a constant with def...
-
- This is basically the same as #18067. I don't think it's a bug, because you get the exact same behavior with manual composition (see example in #18067). However, I welcome feedback from other committers.
-
- ```ruby
measure = proc { p "self=#{self}"; size }
multiply = proc { '*' * _1 }
'test'.instance_eval(&measure)
# "self=test"
# => 4
'test'.instance_eval(&measure >> multiply)
# "self=main"
# NameError (undefined local variabl... -
01:35 PM Misc #18803: DevMeeting-2022-06-16
- * [Feature #18773] Pass an optional range object to deconstruct
* It can be very expensive to compute the array for matching against deconstruct
* By passing a range object we can quickly dismiss matches that won't work
* This c... -
09:35 AM Misc #18803: DevMeeting-2022-06-16
- * [Bug #18813] Module#autoload isn't strict about the autoloaded constant (fxn)
* `module M; autoload :OpenSSL, "openssl"; end` works but is inconsistent.
* `M.constants(false) # => [:OpenSSL]`
* `M::OpenSSL # => ::OpenSSL`
*... -
01:23 PM Revision 4eb140b0 (git): [rubygems/rubygems] Remove redundant bitwise AND
- https://github.com/rubygems/rubygems/commit/a20bac7924
-
- I found that the current test cases did not cover the bitwise AND
performed on modified words after each iteration
(https://github.com/rubygems/rubygems/blob/7e5765a66c9fe5187b167f619f34db5db121f2df/bundler/lib/bundler/digest.rb#L50)
ht... -
11:59 AM Feature #18814: Ractor: add method to query incoming message queue size
- For instance in GO it is possible to query the current size of a channel:
``` go
c := make(chan int, 100)
for i := 0; i < 34; i++ {
c <- 0
}
fmt.Println(len(c)) // => 34
```
-
- ## Abstract
A simple method to query the current size of a Ractor's incoming queue from outside. Can be used to decide on the sender's side if a message is sent or postponed.
## Background
Ractors have an infinite incoming mess... -
11:24 AM Bug #18811: PTY I/O not working on AIX 7.x
- Another discovery... sleep *after* the commands makes it work as well:
``` shell
# ./ptytest.rb 'echo foo; sleep 1'
Got line "foo"
Exit status 0
#
```
So apparently, it's when the child process is exiting too soon the problem ari... -
- https://github.com/rubygems/rubygems/commit/7c6f15040d
-
- Changing this from Misc to bug, and I'll add it to the upcoming dev-meeting.
-
07:05 AM Revision af904338 (git): Typedef built-in function types
-
- Define `GC.verify_compaction_references` as a built-in ruby method,
according to GC compaction support via `GC::OPTS`. -
-
- 01:13 AM Revision f35c5a28 (git): * 2022-06-02 [ci skip]
-
06/01/2022
-
11:37 PM Bug #18813: Let Module#autoload be strict about the autoloaded constant
- I support raising an error when this fails to load the right constant. I think we can add a warning in 3.2 and make it an error in 3.3.
-
- Thanks for opening the ticket @fxn.
I'm in favor of this change, however I believe that a deprecation cycle is preferable.
This behavior is a bit of a cruft, but at the same time it's not really breaking much things, and it's not ... -
10:55 PM Bug #18813 (Closed): Let Module#autoload be strict about the autoloaded constant
- ## Introduction
Let's consider
```ruby
module M
autoload :X, 'x'
end
```
The constants API does not distinguish existing constants from potential constants:
```ruby
M.constants(false) # => [:X]
M.const_define... -
04:36 PM Bug #18730: Double `return` event handling with different tracepoints
- Here's some more information to round out this thread. I was a bit sloppy
in [ruby-core:108449] and the output I posted was misleading. The script
was observing return events from `tp.enable`. Tracing is tricky!
Here is an updated ver... -
02:42 PM Feature #18812 (Closed): Add ability to trace exit locations for YJIT
- Currently, when running yjit with `--yjit-stats` you are able to see method call exit reasons and the top 20 most frequent exits. This is useful to know where to spend time investigating whether an exit should be fixed, but in a larger c...
- 02:22 PM Revision 9d18661e (git): Revert incorrect string-guard optimisation. (#5969)
- Also add jhawthorn's test to for this bug.
Fix String#to_s invalidation test - 10:01 AM Revision 1177665e (git): [rubygems/rubygems] Fix `bundle remove` by invalidating cached `Bundle.defintion`.
- Prior to this commit, `bundle add GEM_NAME` updated the lockfile,
but `bundle remove GEM_NAME` left GEM_NAME in the lockfile.
By invalidating the cached `Bundle.definition`, the existing code
handles that without a problem.
https://git... -
- The installer is actually rewriting the spec's full gem path to be the
one of the newly installed gem, however the accessor was not properly
working for `StubSpecification` instances, and default gems are always
of this type, because the... -
- This change was never covered with a spec, and we have recently covered
the case of partially deleted gems with specs and it works fine
(installation is "auto-healed").
https://github.com/rubygems/rubygems/commit/6e66ee4235 -
- This issue was not detected because when all traces of old YAML parser
and emitter `Syck` were removed, this null-type.gemspec.rz marshalled
gemspec was updated to no longer load `YAML::Syck::PrivateType` but load
`Psych::PrivateType` in... -
- This test is making sure that RubyGems is able to load old marshalled
gemspecs that include a field loading `YAML::PrivateType` instances in
the `rubyforge_project` field instead of `nil` due to a bug in old YAML
emitters.
At some point... -
- This old bug used to affect the `rubyforge_project` field in serialized
gemspecs. However, this field has been removed and it's no longer
present in marshaled loaded gemspecs.
So, while the constant is still present in these marshalled ... -
02:01 AM Misc #18803: DevMeeting-2022-06-16
- * [Bug #18806] protected methods defined by refinements can't be called (shugo)
* I prefer "1. Treat defined methods as though they were defined on the refined class. "
* The pull request looks fine: https://github.com/ruby/rub...
05/31/2022
- 03:14 PM Revision 936e5406 (git): * 2022-06-01 [ci skip]
-
- Generally this warning is skipped for gemspec development dependencies.
I think because it's common to override them in the Gemfile to change
the source, for example.
But the order of conditions was not correct and the warning was still... -
- Indeed, thank you.
-
10:26 AM Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.
- > no, I requested it, but it's the release manager of each branch that is supposed to do the backport.
Sorry for my mistake. The "3.0: REQUIRED, 3.1: REQUIRED" (not DONE) shows the statuses clearly.
> ...
I see. How about changes b... -
- @jaruga no, I requested it, but it's the release manager of each branch that is supposed to do the backport.
These two commits are on master. The backported commits will likely be widely different as there was many changes in compacti... -
- > I'm marking 3.0 and 3.1 for backport. The two commits are:
> ...
Did you backport to ruby_3_0 and ruby_3_1 branches? I cannot find the 2 commit hashes above.
-
- This alternative really uses only the Gemfile, and can never end up
being absurd, because it will never be suggested when there's no
lockfile, and it suggests deleting the lockfile.
https://github.com/rubygems/rubygems/commit/5d154dd50e -
03:50 AM Revision 9241d75a (git): Add information from doc/hacking.md and doc/make_cheatsheet.md back i… (#5963)
- Add information from doc/hacking.md and doc/make_cheatsheet.md back into contributing docs
-
02:40 AM Revision 0cae30e1 (git): Skip failing test with freebsd
05/30/2022
- 11:43 PM Revision 360c5fd6 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/ianks/rb-sys) from v0.7.3 to v0.9.0.
- [Release notes](https://github.com/ianks/rb-sys/releases)
- [Commits](https://github.com/ianks/rb-sys/compare/4a5dd9782075fc6e197976eb2188231a388c3c95...https://git... -
10:39 PM Bug #18480 (Closed): Dtrace enabled build fails on systems with DTRACE_REBUILD=yes - Applied in changeset commit:git|31bd79dda3d26956976e68ff1c2f8c376c7e9ea5.
----------
Add yjit.o to DTRACE_DEPENDENT_OBJS
In principle, we have a DTrace probe in yjit.c, so yjit.o should be
in DTRACE_DEPENDENT_OBJS for DTRACE_REBUILD=ye... -
- Applied in changeset commit:git|a687756284187887835aa345adc89b2718054e4a.
----------
Fix use-after-free with interacting TracePoints
`vm_trace_hook()` runs global hooks before running local hooks.
Previously, we read the local hook lis... - 10:30 PM Revision 31bd79dd (git): Add yjit.o to DTRACE_DEPENDENT_OBJS
- In principle, we have a DTrace probe in yjit.c, so yjit.o should be
in DTRACE_DEPENDENT_OBJS for DTRACE_REBUILD=yes builds. This commit
adds to the list.
In practice DTRACE_REBUILD=yes implies the system has a Solaris-like
DTrace and YJ... - 10:10 PM Revision 7a0e6814 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/ianks/rb-sys) from v0.7.3 to v0.9.0.
- [Release notes](https://github.com/ianks/rb-sys/releases)
- [Commits](https://github.com/ianks/rb-sys/compare/4a5dd9782075fc6e197976eb2188231a388c3c95...https://git... -
08:06 PM Bug #18658: Need openssl 3 support for Ubuntu 22.04 (Ruby 2.7.x and 3.0.x)
- @mame I tried your approach and it seems to work (I tried on Fedora 36).
I was thinking the `make` would fail but CRuby 3.0.3 has an early check for openssl 3 and so it works as described.
CRuby 3.0.2 OTOH does not have that check, so ... -
06:36 PM Bug #18806: protected methods defined by refinements can't be called
- Patch implementing option 1: https://github.com/ruby/ruby/pull/5966
-
- Eregon (Benoit Daloze) wrote in #note-3:
> I'm not too keen on extra checks, but the checks for protected are already expensive and this won't make it significantly worse.
Agreed.
Matz, can I change protected methods defined by refinem... -
- `vm_trace_hook()` runs global hooks before running local hooks.
Previously, we read the local hook list before running the global hooks
which led to use-after-free when a global hook frees the local hook
list. A global hook can do this b... - 05:30 PM Revision 3bef9584 (git): * 2022-05-31 [ci skip]
-
05:30 PM Revision c50c9d40 (git): [ruby/fileutils] [DOC] Enhanced RDoc (https://github.com/ruby/fileutils/pull/77)
- Treats:
::copy_entry
::copy_file
::copy_stream
::mv
https://github.com/ruby/fileutils/commit/d6d7e5330d -
04:00 PM Bug #18768 (Closed): Inconsistent behavior of IO, StringIO and String each_line methods when return paragraph and chomp: true passed
- Applied in changeset commit:git|609d73e8925f807786686caf635178bb1de74256.
----------
[ruby/stringio] Fix handling of chomp with paragraph separator
Try to mirror IO behavior, where chomp takes out the entire paragraph
separators betwee... -
- Applied in changeset commit:git|adaaf12857ce41d35b282e3fb5aa330934ce45c6.
----------
[ruby/stringio] Ignore chomp keyword for nil separator
nil separator means no separator at all, so nothing should be
chomped.
Partial fix for Ruby [B... -
- Applied in changeset commit:git|1f82269f4e1bf037e3e5504c6071b905f26fec6f.
----------
[ruby/stringio] Fix each with multiple character string and chomp
Previously, this could result in an infinite loop. Always update
the e pointer in t... -
- I had some instances with inconsistent behavior and got an idea...
``` shell
# ./ptytest.rb 'echo foo'
Exit status 0
# ./ptytest.rb 'echo foo'
Exit status 0
# ./ptytest.rb 'echo foo'
Exit status 0
# ./ptytest.rb 'sleep 1;echo foo... -
08:17 AM Bug #18811 (Feedback): PTY I/O not working on AIX 7.x
- @kanemoto Can you handle this ticket?
This is my impression, but the maintenance state of AIX is not good. The CI for AIX has not been working for a long time. This issue is probably unlikely to be fixed unless you provide a patch; ev... -
- The attached test script simply executes a command under a PTY and captures the output and exit code.
This works on Linux (all supported versions of Redhat, Debian, Ubuntu, and SuSE) as well as Solaris 11.4 on sparc and x86.
But on AIX... -
-
- https://github.com/rubygems/rubygems/commit/2d99277328
-
- If BUNDLE_PATH is configured to a symlinked path, installing gems with
symlinks would crash with an error like this:
```
Gem::Package::SymlinkError: installing symlink 'man/man0/README.markdown' pointing to parent path /usr/home/stevewi... -
- https://github.com/rubygems/rubygems/commit/70ff7cee9f
-
- https://github.com/rubygems/rubygems/commit/8e68c57457
-
- https://github.com/rubygems/rubygems/commit/f5dd5204ca
-
- https://github.com/ruby/stringio/commit/0fe2e0c1e5
-
- Fix https://github.com/ruby/stringio/pull/16
https://github.com/ruby/stringio/commit/c8a69e80d2 -
-
-
- Try to mirror IO behavior, where chomp takes out the entire paragraph
separators between entries, but does not chomp a single line separator
at the end of the string.
Partially Fixes [Bug #18768]
https://github.com/ruby/stringio/commit... -
- https://github.com/ruby/stringio/commit/1edc88587e
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
- nil separator means no separator at all, so nothing should be
chomped.
Partial fix for Ruby [Bug #18770]
https://github.com/ruby/stringio/commit/feaa2ec631 -
- Previously, this could result in an infinite loop. Always update
the e pointer in this case, setting w when chomping so the chomped
data is not included in the output.
Fixes [Bug #18769]
https://github.com/ruby/stringio/commit/4bf64d5130 -
- https://github.com/ruby/stringio/commit/a35268a3ac
-
- I cannot understand this change well. Could you show me a code example to demonstrate this change?
I tried the following code in Ruby 3.1, but I couldn't observe the behavior that `A` and `B` are interleaved.
```
a = ["A" * 100_00... -
- Reduce duplicate replacements so that reflect macros in command lines
consitently. So that reflect macros in command lines. Others than
`nmake` have no problems with nested expansions. -
-
- Now FreeBSD 12 fails as well. Probably because we upgraded the machine to 12.3.
http://rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20220529T183002Z.fail.html.gz
```
1) Failure:
TestThreadQueue#test_thr_kill [/usr/home/chk... -
- Since `Kernel#p` is a method for debugging, I think this spec would be useful. If it is made interruptable, it will be difficult to use `Kernel#p` in a block of `Thread.handle_interrupt(TimeoutError => :on_blocking)`.
05/29/2022
-
- We want to make it convenient for people to build YJIT and Rust version 1.58.1
or above is available on Ubuntu Jammy, Debian testing, and Fedora 36 through
the usual package manager on those systems. This saves the need to install
`rustu... - 03:27 PM Revision 93d1eb71 (git): * 2022-05-30 [ci skip]
-
- Apparently old versions of MacOS would set `GEM_HOME` to a `/System`
folder, and trying to create a file there raises `Errno::EROFS`.
We ignore the error. Any permission issues should be better handled
further down the line.
https://gi... -
- This kind of error can happen when setting `GEM_HOME` to a path
under MacOS System Integrity Protection.
We ignore the error. Any permission issues should be better handled
further down the line.
https://github.com/rubygems/rubygems/co...
05/28/2022
-
- 07:20 PM Revision 931b013b (git): * 2022-05-29 [ci skip]
-
- Restores doc for the methods that were cited in https://bugs.ruby-lang.org/issues/18765.
-
- https://github.com/rubygems/rubygems/commit/a7f81cc7ee
-
- It's already done before.
https://github.com/rubygems/rubygems/commit/49d28cfde5 -
- https://github.com/rubygems/rubygems/commit/9f3b21192d
-
06:26 AM Feature #18809: Add Numeric#ceildiv
- Julia provides [`cld`](https://docs.julialang.org/en/v1/base/math/#Base.cld) and [`fld`](https://docs.julialang.org/en/v1/base/math/#Base.fld) for the ceiling and flooring division, respectively. They are implemented as aliases of `div`...
-
- I'm positive.
It may be nice to alias `div` as `floordiv` too? -
-
04:16 AM Misc #18689: Windows mswin builds, Actions, OpenSSL 3
- All of the above has been implemented. Re Actions & Windows builds, using an mswin build (currently only available as a head build, 'mswin') will install all the vcpkg dependencies needed to build Ruby, similar to mingw & ucrt builds. ...
-
- PR: https://github.com/ruby/ruby/pull/5967
-
- While figuring out https://bugs.ruby-lang.org/issues/18465 I found a test which fails when `rb_io_flush` becomes blocking.: https://github.com/ruby/ruby/commit/fe6b2e20e9f17ed2c2900aa72994e075ffdc7124
It seems unusual to me that `Kern... -
- Merged changes and follow up issue: https://bugs.ruby-lang.org/issues/18810
-
-
- In some cases, `Kernel#p` can block when calling `rb_io_flush` if the output is a pipe. Because of that, `rb_io_blocking_region` can be interrupted while doing flush. This causes the spec `test_async_interrupt_and_p` to fail, because it ...
- 03:44 AM Revision 6b0131db (git): Make `Kernel#p` completely uninterruptible.
- 03:44 AM Revision 753d3055 (git): Tidy up usage of write_lock.
- 03:44 AM Revision 1589ac62 (git): Improve handling of zero length writes.
- 03:44 AM Revision 4efccd28 (git): Improve consistency of `io_binwritev_internal` implementaiton.
- 03:44 AM Revision ac499bb5 (git): Improve error handling in `finish_writeconv`.
- 03:44 AM Revision c6cd9e18 (git): Better handling of `error`.
- 03:44 AM Revision 585e9714 (git): Always allocate write_lock
- 03:44 AM Revision 216593f5 (git): Add IO write throughput/locking overhead benchmark.
- 03:44 AM Revision 15ebfe28 (git): Make `io_binwritev` atomic.
- 03:44 AM Revision ce23cfa5 (git): Make `io_binwrite` atomic.
-
-
- This is working as expected, we have implemented it in the async gem.
05/27/2022
-
10:23 PM Feature #18809 (Closed): Add Numeric#ceildiv
- pull request: https://github.com/ruby/ruby/pull/5965
I have needed to implement "rounding up division" several times.
("rounding up division" means getting a quotient of division which is rounded up to the nearest integer.)
Typi... -
-
- 08:38 PM Revision c3fd2e49 (git): * 2022-05-28 [ci skip]
-
- rb_class_get_superclass returns the immediate SUPER, including T_ICLASS.
rb_ivar_lookup isn't implemented for T_ICLASS so it uses the default
behaviour, which always returns Qnil.
This commit avoids checking T_ICLASS for ivars. -
-
- Right, agreed that 1 is best semantically.
I'm not too keen on extra checks, but the checks for protected are already expensive and this won't make it significantly worse.
1 implies 2 BTW in terms of optimizations, i.e., if it's an f... -
- protected is for a method call with an explicit receiver, so I prefer 1.
private is enough for fcalls.
-
- Instead of guessing on the culprit.
We actually have a helper, `Bundler.rm_rf`, with exactly the behavior
that we want:
* Allow the passed folder to not exist.
* No exception swallowing other than that.
https://github.com/rubygems/rub... -
- Follow up of https://github.com/ruby/ruby/pull/5927
`pthread_threadid_np()` is not even be declared in outdated SDKs.
Also, the `__API_AVAILABLE` macro does not work on gcc, which does not
support the [availability] attribute of clang,... -
04:10 AM Bug #18608: `require': cannot load such file -- ripper (LoadError) after `make distclean`
- I guess this is because either `bison` is not installed in the build environment or the environment variable `YACC` is not correctly set. Note that `make distclean` among other things removes `ext/ripper/ripper.c` which requires `YACC` (...
-
-
- This reverts commit 2f5edfa47d06c9605a5a0aa3ad72d7fef4d44fa3.