Activity
From 04/28/2022 to 05/04/2022
05/04/2022
- 08:05 PM Revision 4f25971f (git): * remove trailing spaces. [ci skip]
-
08:04 PM Revision 197f9e9d (git): [DOC] More on format specs (#5877)
- * Update doc/format_specifications.rdoc
Co-authored-by: Peter Zhu <peter@peterzhu.ca> - 07:49 PM Revision 8009d8a9 (git): * 2022-05-05 [ci skip]
-
07:49 PM Revision d7df8c69 (git): Unpoison freelist when iterating over it in gc_sweep_page
-
-
05:54 PM Misc #18691: An option to build Ruby with build only flags not propagated to `rbconfig.rb`.
- A little related to this ticket, I sent PR to set `V = 1` in `mkmf.rb` by `configure --enable-mkmf-verbose`.
https://github.com/ruby/ruby/pull/5879
-
- nobu (Nobuyoshi Nakada) wrote in #note-7:
> Do not use `Q=`.
> ...
Thanks for the info. I see a little bit difference of printed logs between `make Q=`, `make install Q=` and `make V=1 ECHO0=echo` and `make install V=1 ECHO0=echo`. But t... -
01:24 PM Revision bff31b32 (git): Remove unneeded cast
- `start` is of type uintptr_t so it does not need to be casted to VALUE.
-
11:59 AM Misc #18747: DevMeeting-2022-05-19
- - [Feature #18339] GVL instrumentation API
- The patch is ready and went through several reviews: https://github.com/ruby/ruby/pull/5500
- The overhead is close to zero if no callback is registered.
- May I merge it?
05/03/2022
-
09:45 PM Revision 9d61c451 (git): [rubygems/rubygems] Also speed up the case when nothing changed
- https://github.com/rubygems/rubygems/commit/fa0ac74883
-
- https://github.com/rubygems/rubygems/commit/fabc357e70
-
- https://github.com/rubygems/rubygems/commit/c43d5f979a
-
- https://github.com/rubygems/rubygems/commit/ea09bc4680
-
08:48 PM Revision 379f5a6e (git): Update reference for RCLASS_INCLUDER during compaction
- We didn't update the includer field during compaction so it could become
a dangling pointer after compaction. It's only recently that we started
to dereference the field, and we were only comparing the pointer before
then, so the omissio... -
08:08 PM Feature #18762: Add an Array#undigits that compliments Integer#digits
- @sawa If this feature is accepted and for whatever reason a Ruby version is used instead of C, yours is more performant Ruby code than mine. It might look like the following. We'd want to implement this in C like Integer#digits, right?
`... -
- sawa (Tsuyoshi Sawada) wrote in #note-5:
> @shan (Shannon Skipper)
> ...
I think you'd just need to reverse it, since this result seems backwards. I think it's easy to get the implementation wrong and a handy method to have.
``` ruby
... -
06:25 PM Feature #18762: Add an Array#undigits that compliments Integer#digits
- @shan (Shannon Skipper)
Sorry. I had the code wrong. A similar code works for an array in backwards.
```ruby
[].inject(0){_1 * 10 + _2} # => 0
[2, 1].inject(0){_1 * 10 + _2} # => 21
[3, 2, 1].inject(0){_1 * 10 + _2} # => 321
[6... -
- sawa (Tsuyoshi Sawada) wrote in #note-3:
> Using a chain of two methods `each_with_index` and `sum` as well as `**` for such a simple task is an overkill, and perhaps that is why you feel you want a built-in method. You can simply do:
... -
- Using a chain of two methods `each_with_index` and `sum` as well as `**` for such a simple task is an overkill, and perhaps that is why you feel you want a built-in method. You can simply do:
```ruby
[2, 4].inject{_1 + _2 * 10} # => 42
``` -
05:44 PM Revision cf71e5f6 (git): Add a regression test for opt_plus with unknown type (#5878)
- 05:00 PM Revision 4d28553c (git): * 2022-05-04 [ci skip]
-
04:59 PM Misc #18756: make V=1 or Q= for verbose?
- Do not use `Q=`.
`Q`, `Q1` and `V1` are intermediate variables.
You may want to set `ECHO0=echo` unconditionally. -
-
- darray was used in YJIT which required the functions to not trigger GC.
YJIT has now moved to Rust and does not use darray anymore, so we can
remove the functions that don't trigger GC and only keep the ones that
trigger GC. -
12:03 PM Revision 5a578f10 (git): merge revision(s) 44c44b9b4af14f42a0dc6df9287c45d9689847bb:
- Ignore warnings at reading debug info for now
Something seems changed on FreeBSD 13.
---
test/ruby/test_rubyoptions.rb | 1 +
1 file changed, 1 insertion(+) -
- Skip three tests on FreeBSD 13
Some tests that use signals frequently fail randomly on FreeBSD 13.
Maybe something around signals has changed in FreeBSD 13.
This change skips them tentatively.
---
... -
- Exclude TestThread#test_signal_at_join on FreeBSD 13 for now [ci
skip]
---
test/excludes/TestThread.rb | 3 +++
1 file changed, 3 insertions(+)
exclude name must be Regexp or Symbol
ht... -
- Bump github/codeql-action from 1 to 2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://g...
05/02/2022
-
- @zverok here's a Ruby example with Fibers that I ported from `skynet.cr`.
``` ruby
require 'async'
require 'async/queue'
def skynet(c, num, size, div)
if size == 1
c << num
else
rc = Async::LimitedQueue.new(div)
... -
- I've found Integer#digits convenient and useful but several times have needed to go from the place-value notation back to an Integer after manipulation and wished there was a complimentary Array#undigits.
``` ruby
class Array
def ... -
- Turned out to be a one-character fix :)
-
- I sent the PR <https://github.com/ruby/ruby/pull/5875>.
-
- > So, my conclusion is the current logic for V and Q is intentional. And I would close this ticket.
Sorry for confusion. I changed my mind. I want to make `V=1` print the logs like current `Q=`, because I think when users set `make V=... -
- To simplify the difference, I tested only running the target `$(MAINOBJ)` in `uncommon.mk`, adding the debug log below in `uncommon.mk`.
```
$(MAINOBJ): $(srcdir)/$(MAINSRC)
@echo "n: $(n)"
@echo "V: $(V)"
@echo "Q: $(... -
- > Aren't both handlers same (global) in my first example?
They are, but the two invocations are coming from two
separate events while my script is concerned with handling
within one event. You can see this from a slightly modified
... -
- YJIT can't support these builds so it's better to reject with a message
than to crash at runtime. -
- The `capstone` crate on crates.io does not need `libcapstone` on the system
because it builds from [source].
`gdbm` is now a separate gem (thanks for extracting it!).
[source]: https://github.com/capstone-rust/capstone-rs/blob/c31409905... -
- 04:09 PM Revision 503f2292 (git): * 2022-05-03 [ci skip]
-
- Detailed introductory material.
https://github.com/ruby/getoptlong/commit/1544f2fb7b -
02:05 PM Revision 8587bacc (git): YJIT: Remove redundant `extern crate` (#5869)
- Follow up https://github.com/ruby/ruby/commit/0514d81
Rust YJIT requires Rust 1.60.0 or later. So, `extern crate` looks unnecessary
because it can use the following Rust 2018 edition feature:
https://doc.rust-lang.org/stable/edition-gui... -
10:22 AM Misc #18761: provide an example wasm project
- Thank you for reporting. `ruby/ruby.wasm` repository provides a simple example and prebuilt rubies to try it easily. https://github.com/ruby/ruby.wasm#quick-example-how-to-package-your-ruby-application-as-a-wasi-application
Is this en... - 02:22 AM Revision 63932ec3 (git): Bump github/codeql-action from 1 to 2
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commi...
05/01/2022
-
11:58 PM Revision 2e901368 (git): Fix a typo [ci skip]
- 05:27 PM Revision 72c8d4fd (git): * 2022-05-02 [ci skip]
-
- * Repair internal links
* Minor changes to format spec -
- [rubygems/rubygems] Fix a test for `bin/bundle update --bundler` to
pass on ruby/ruby.
Consider the case that the latest Bundler version on RubyGems is higher than
the `system_bundler_version` (= `Bundler::VERSI... -
-
- Update zlib version to 1.2.12
---
.appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) -
-
- Add the relevant test code for 73f45e5e96ccc13a131f7c0122cf8600ce5b930f.
04/30/2022
-
07:25 PM Misc #18761 (Assigned): provide an example wasm project
- Neither the release notes nor the wasm/README.md include any runnable examples.
Please provide a docker image that can be used to generate a wasm binary (even if it's just "hello world"),
to show how this is supposed to work. -
07:01 PM Bug #17871: TestGCCompact#test_ast_compacts test failing again
- wanabe (_ wanabe) wrote in #note-10:
> Note for the backport maintainer:
> ...
I think that this should be covered by #18746 and the related tickets -
09:45 AM Bug #17871: TestGCCompact#test_ast_compacts test failing again
- Note for the backport maintainer:
The issue seems to be still reproduced in 3.0.
http://rubyci.s3.amazonaws.com/ppc64le/ruby-3.0/log/20220430T053940Z.fail.html.gz -
05:41 PM Misc #18747: DevMeeting-2022-05-19
- tenderlovemaking (Aaron Patterson) wrote in #note-4:
> * [Feature #18611] Promote best practice for combining multiple values into a hash code
> ...
Looks like [Feature #18611] was merged, so please remove it from the agenda. Thanks! -
10:58 AM Feature #18611 (Closed): Promote best practice for combining multiple values into a hash code
- Merged.
-
10:57 AM Revision 3a8d60f5 (git): Document best-practices for writing hash methods (#5805)
- * Discussion is as per https://bugs.ruby-lang.org/issues/18611.
Co-authored-by: Sam Bostock <sam.bostock@shopify.com> -
05:32 AM Bug #18730: Double `return` event handling with different tracepoints
- alanwu (Alan Wu) wrote in #note-6:
> So having just read the code, I understand why you are seeing this behavior.
> ...
Aren't both handlers same (global) in my first example?
```ruby
def bar
42 #bp here
end
def set_return_tp
Trace... -
- So having just read the code, I understand why you are seeing this behavior.
We run global handlers before local handlers, so if you have a global
handler G and a local handler L, and G enables L, they both run. It is weird
because th...
04/29/2022
-
- `rustc` performs in depth dead code analysis and issues warning
even for things like unused struct fields and unconstructed enum
variants. This was annoying for us during the port but hopefully
they are less of an issue now.
This patch ... -
- This new document would eventually replace the format spec discussion at Kernel#sprintf.
-
07:07 PM Feature #18611: Promote best practice for combining multiple values into a hash code
- I found some _interesting_ implementations while working on the Rubocop Cop, including some in Ruby itself. For example:
- [`rgeo/rgeo`](https://github.com/rubocop/rubocop/pull/10441/files#r835693586)
- [Ruby's `IPAddr#hash`](https:/... -
- I think this is a good idea. [Searching GitHub](https://cs.github.com/?q=%22def+hash%22+language%3ARuby) shows many example of the not-so-great XOR pattern, but also shows many people doing `[a, b, c].hash`. It makes sense to me that w...
- 07:04 PM Revision d0ff7a59 (git): * 2022-04-30 [ci skip]
-
- This adopts most suggestions that rust-clippy is confident enough to
auto apply. The manual changes mostly fix manual if-lets and take
opportunities to use the `Default` trait on standard collections.
Co-authored-by: Kevin Newton <kddne... -
- * [Feature #18611] Promote best practice for combining multiple values into a hash code
* Encourage people that implement `hash` to use Array#hash for implementation
* We can easily optimize `[x, y, z].hash` to eliminate array allo... -
- - [Feature #18595] Alias `String#-@` as `String#dedup`
- Unary operator have some precedence oddities, forcing to use parantheses.
- `dedup` is quite an explicit name.
- 02:07 PM Revision f8e4488e (git): YJIT: Do not create `CodeBlock.asm_comments` if the `asm_comments` feature is disabled (#5863)
-
- jeremyevans0 (Jeremy Evans) wrote in #note-4:
> I've submitted a pull request to fix the use-after-free bug: https://github.com/ruby/ruby/pull/5862
I can confirm that with this patch, behavior is consistent and do not depend on `tp0` st... -
- @duerst Yes, of course, I only criticize the benchmark.
@zverok Note how the README doesn't mention anything based on N native threads?
That's because this benchmark doesn't make sense for that case, and would fail too with N=100000 ... -
05:02 AM Bug #18760: Ractors vs "skynet" microbenchmark
- Eregon (Benoit Daloze) wrote in #note-1:
> However I heard @ko1 is working on pooling multiple Ractors per native thread, which would help for this microbenchmark (which is rather silly if you ask me, because it's like the worst case ... -
- jeremyevans0 (Jeremy Evans) wrote in #note-2:
> Can you try https://github.com/ruby/ruby/pull/5862 and see if that fixes the issue? I'm not sure it will, but the segfault in your backtrace occurs in `exec_hooks_body`, the same place th... -
- Failing here:
-
- jeremyevans0 (Jeremy Evans) wrote in #note-2:
> Can you try https://github.com/ruby/ruby/pull/5862 and see if that fixes the issue? I'm not sure it will, but the segfault in your backtrace occurs in `exec_hooks_body`, the same place th... - 08:19 AM Revision 5741ae37 (git): [rubygems/rubygems] Generalize description to account for different push servers
- https://github.com/rubygems/rubygems/commit/cbf13edd3a
- 08:19 AM Revision 3cf107fd (git): [rubygems/rubygems] Clarify description of owner-flags
- https://github.com/rubygems/rubygems/commit/28864b1057
-
04:14 AM Revision cf45d30f (git): Prevent a "warning: `*' interpreted as argument prefix"
04/28/2022
-
- Previously, we relied on shell word splitting, which leads
to passing the wrong arguments when there are white spaces
in the path.
Avoiding command substitution also makes this script more
likely to work under Solaris 10, where `/bin/sh... -
10:39 PM Bug #18750 (Feedback): Segmentation fault on SIGINT when waiting in TracePoint handler
- Can you try https://github.com/ruby/ruby/pull/5862 and see if that fixes the issue? I'm not sure it will, but the segfault in your backtrace occurs in `exec_hooks_body`, the same place the segfault occurs in the test included in https:/...
-
- I've submitted a pull request to fix the use-after-free bug: https://github.com/ruby/ruby/pull/5862
-
- This fixes a bug where Ruby on macOS running on ARM would try to look in
`/usr/local/lib` for things to link against, but the libraries in that
directory are from the x86 installation of Homebrew
[ruby-core:108424] -
-
-
- * YJIT: replace BLOCKID_NULL with Option<BlockId>, more idiomatic
* Update yjit/src/core.rs
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
* Update yjit/src/core.rs
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
Co... -
07:53 PM Bug #18760: Ractors vs "skynet" microbenchmark
- > this microbenchmark (which is rather silly if you ask me, because it's like the worst case overhead for concurrency primitives, not representative of anything real world)
I think that's the point (as it is for many microbenchmarks):... -
- Each Ractor currently uses one pthread behind the scenes, so you're spawning N threads and that's of course slow.
This benchmark works likely a lot better with `Fiber` instead of `Ractor`.
However I heard @ko1 is working on pooling mult... -
- I recently stumbled upon [skynet](https://github.com/atemerev/skynet) concurrency microbenchmark and tried to adapt it to Ruby ractors.
The microbenchmarks of this kind are obviously limited, but at least they allow to do super-rough es... -
07:32 PM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
- I've opened a PR, though there are failing tests since it still monkeypatches `require` https://github.com/ruby/ruby/pull/5859. @nobu do you have some time to take a look at making `SyntaxError` monkeypatchable?
-
- > Thanks. I fixed it now.
Thanks! I was able to upload files at https://bugs.ruby-lang.org/issues/18756 too now.
-
06:26 AM Misc #18687 (Closed): [ANN] Upgraded bugs.ruby-lang.org to Redmine 5.0
- @jaruga Thanks. I fixed it now.
-
- Can I upload something?(Test)
-
-
- > Oh I couldn't upload the log files due to "Internal Server Error" on Redmine..
I uploaded the log files now, as the internal server error issue above was fixed.
- 03:31 PM Revision 5f0116c5 (git): * 2022-04-29 [ci skip]
-
- Previously it made object references without using write barriers,
creating GC inconsistencies.
See: http://ci.rvm.jp/results/trunk-gc-asserts@phosphorus-docker/3925529 -
- mame (Yusuke Endoh) wrote in #note-2:
> > I don't think /usr/local/lib should be in LDFLAGS by default.
> ...
Yes, I checked that. I think the weird behavior is fixed, but the commit message didn't describe the weird behavior so I don... -
- @tenderlovemaking I fixed the upload feature now. see https://bugs.ruby-lang.org/issues/18687#note-10
-
- > I don't think /usr/local/lib should be in LDFLAGS by default.
When removing what appears to be unnecessary, it is a good idea to check the reason why it was introduced. According to https://github.com/ruby/ruby/commit/67da4aebc56b1a... -
-
-
-
- https://github.com/rubygems/rubygems/commit/59449557dd
-
- Currently our tests try to detect whether `cargo` is installed or not,
and if not, set tests that need `cargo` as pending.
However, when this happens that test `setup` method is completely
skipped, meaning that the `teardown` method wil... -
-
- https://github.com/rubygems/rubygems/commit/c60ed4878c
-
- https://github.com/rubygems/rubygems/commit/06ad654120
-
- https://github.com/rubygems/rubygems/commit/fe96fb6e2ac5a8b6df5e852470d11fa854301eca
-
-
- A while ago, we fixed resolution when using old dependency endpoints to
also consider metadata dependencies, by requesting the full gemspec from
the marsahaled index, which includes this information as opposed to
these old APIs. This has... -
- https://rubyci.s3.amazonaws.com/solaris10-sunc/ruby-master/log/20220428T000004Z.fail.html.gz
```
linking static-library libruby-static.a
/bin/sh: syntax error at line 8: `(' unexpected
gmake: *** [Makefile:318: libruby-static.a] Error 2
... -
- snapshot tarball のテストに macos-12 を追加したところ、 snapshot-ruby_2_7 で failure が発生していました。
https://github.com/ruby/actions/runs/6199339063?check_suite_focus=true#step:17:138
```
1) Failure:
TestRipper::ParserEvents#test_block_variables [...