Activity
From 06/26/2021 to 07/02/2021
07/02/2021
-
06:02 PM Bug #18019 (Closed): 3.0.X fails to link on Mac OS X 10.15.7 due to linker error related to _coroutine_transfer
- I'm struggling with building ruby 3.0.X on my Mac Catalina (Intel based). Please note all 2.X versions are compiling correctly.
I've already tried to use gnugcc but getting same error:
```
▶ gcc --version
Configured with: --prefi... -
05:11 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
- This example in the original post has been fixed recently in the master branch. I bisected the fixing commit to commit:3dd3ea092acead6179033f2c95525ffc5b8bb6ff. However, as that changes constant lookup order, I'm guessing we aren't goi...
-
- I tried this on OpenBSD, and ruby 2.7 and 3.0 were faster than ruby 2.4 (all of these use libyaml 0.2.2):
```
/usr/local/bin/ruby27: 0.1 i/s
/usr/local/bin/ruby30: 0.1 i/s - 1.00x slower
/usr/local/bin/ruby24: ... -
-
03:39 PM Feature #17745: `IO#close_on_exec=` returns different value when called with `send, __send__, public_send` or not
- Is there any reason to call close_on_exec= with `send/__send__`, or to use its return value?
I would be on the side of "changing this should not hurt", but it seems other committers do not necessarily agree (I guess their point is cod... -
- * [Feature #15856] Performance of redundant `Kernel.require` is slow when many gems are activated (jeremyevans0)
* Repeated require of native library without extension is very slow.
* Repeated require of pure ruby library without e... -
- This is still a performance issue in the master branch. I think it makes sense to fix the issue by using the approach recommended by @deivid is best. In addition to being faster, is also makes the behavior for native libraries consiste...
-
12:47 PM Bug #18018: Float#floor / truncate sometimes result that is too small.
- sawa (Tsuyoshi Sawada) wrote in #note-1:
> With:
> ...
Yes, that is what I meant, thanks. -
12:17 PM Bug #18018: Float#floor / truncate sometimes result that is too small.
- With:
> g's decimal string representation has at most n digits
I think you mean:
> ...
(By the way, note here that the word "decimal" is used twice under different meanings: 1. base ten, and 2. the fractional part)
-
07:48 AM Revision 3a958347 (git): [ruby/error_highlight] Suppress SyntaxError during RubyVM::AST.of
- When the original source code is erb, RubyVM::AST.of does not work well.
https://github.com/rails/rails/issues/42678.
https://github.com/ruby/error_highlight/commit/b1572761a6 -
04:23 AM Revision e105d93b (git): Fix default prompt mode in doc/irb/irb.rd.ja
-
01:50 AM Bug #17583 (Closed): Segfault on large stack(RUBY_THREAD_VM_STACK_SIZE)
- Applied in changeset commit:git|8ebb5e23ebc5f1675e3479b9a29f124dc458226b.
----------
Keep GC disabled until VM bootstrap has done [Bug #17583] -
- Applied in changeset commit:git|8ebb5e23ebc5f1675e3479b9a29f124dc458226b.
----------
Keep GC disabled until VM bootstrap has done [Bug #17583] -
- 12:36 AM Revision 1862d961 (git): Ignore dead threads in `coroutine_join`.
-
- commit:5ada23ac1265a1da5d7ef82e1c71f14c40dddc26 changed case statements to use a `===` with a call cache, instead of using the `checkmatch` VM instruction. In my benchmarking on master, I'm only seeing about 1-3% difference with the rev...
07/01/2021
-
```ruby
291.4.floor(1) # => 291.4 (ok)
291.4.floor(2) # => 291.39 (not ok)
291.4.floor(3) # => 291.4 (ok)
291.4.floor(4) # => 291.4 (ok)
291.4.floor(5) # => 291.39999 (not ok)
291.4.floor(6) # => 291.4 (ok)
```
`g = f.floor(n...-
-
- @ko1 has rewritten the debug library (https://github.com/ruby/debug). I've checked that the rewrite fixes this issue. You can also try using the 1.0.0 beta gem. Note that you need to add `require 'debug/run'` to the file use the `rdbg...
- 09:47 PM Revision b8da141d (git): * 2021-07-02 [ci skip]
-
09:47 PM Revision e8933fda (git): Remove gdbm/dbm related code from CI
- The related extensions have been removed.
-
- This issue has been fixed in the master branch. I bisected the fixing commit to commit:39a2ba5cc559900c30c3143da32446c2f20a7484. This issue exists in Ruby 3.0 but not in Ruby 2.7 or 2.6, so if possible, this should be backported to 3.0.
-
- Thanks for the PR @jeremyevans0, looks pretty good.
On the other hand, I'd like to revise what I wrote and suggest that `transform_keys` remain untouched. It's the only one of these methods (with `to_h{...}`) that changes the keys so ha... -
- I've submitted a pull request that builds on @kachick's PR and fixes the remaining cases found by @marcandre: https://github.com/ruby/ruby/pull/4616
-
- nobu (Nobuyoshi Nakada) wrote in #note-9:
> Does this work?
> ...
Since it worked for me, I rebased this tree on master and submitted a pull request for it: https://github.com/ruby/ruby/pull/4617 -
- usa (Usaku NAKAMURA) wrote in #note-5:
> About 2.7, to make raise `ArgumentError` (or other exception) is not acceptable because it's **stable* branch.
> ...
I sent a pull request to disable the timeout option: https://github.com/ruby/... -
- vo.x (Vit Ondruch) wrote in #note-5:
> I am sure that the behavior changed and I'd like to better understand why.
The behavior changed to non-blocking by default in order to support the fiber scheduler. Changing it back to blocking ... -
- @meliborn Can you test with Ruby 3.0.1 and see if it fixes this issue?
-
02:51 PM Feature #16978: Ruby should not use realpath for __FILE__
- This issue seems also somewhat related to another I opened a while ago: #17593
-
01:13 AM Feature #16978: Ruby should not use realpath for __FILE__
- byroot (Jean Boussier) wrote in #note-17:
> The "entrypoint" script could behave differently, but maybe that would be confusing.
I think that would be acceptable. After all the "entrypoint" script already behaves differently; it's the o... -
09:28 AM Misc #18017 (Assigned): Broken links from Revision e86c1f6f to changed files
-
08:18 AM Misc #18017 (Closed): Broken links from Revision e86c1f6f to changed files
- All the links at the bottom of
https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/e86c1f6fc53433ef5c82ed2b7a4cc9a12c153e4c
(to the changed files and diffs) produce "404
The entry or revision was not found in the ... -
- In ISO-2022-JP, the bytes use to code are the same as those for "<>".
This adds regression tests to make sure that these bytes, when representing
湿, are NOT escaped with encode("ISO-2022-JP, xml: :text) or similar.
These are additi... -
-
-
03:41 AM Feature #18015 (Closed): Replace copy coroutine with pthread implementation.
- Merged.
-
- This was fixed upstream just after the release of 3.0: https://github.com/ruby/fiddle/commit/28ee5b16086f77e1f079853bff2ee1cb527cb69c. These changes have already been applied to the master branch. Possibly commit:8758b07b1e4fd636dffb4b4...
06/30/2021
-
- I've submitted a pull request to prevent loading the same realpath multiple times: https://github.com/ruby/ruby/pull/4615
- 11:23 PM Revision 1467328e (git): More general matrix "configure" parameter, add `--with-coroutine=pthread`.
- 11:23 PM Revision 42130a64 (git): Replace copy coroutine with pthread implementation.
-
- 08:16 PM Revision 8ee24840 (git): [ruby/irb] Update ls.rb without requiring Set, because Set is one of standard libraries
- https://github.com/ruby/irb/commit/7092ad2ab5
- 08:12 PM Revision 518d3938 (git): * 2021-07-01 [ci skip]
-
08:12 PM Revision 4a3df352 (git): Use stride passed into os_obj_of_i
-
-
02:26 PM Feature #17992: Upstreaming the htmlentities gem into CGI#.(un)escape_html
- I'm reasonably convinced that augmenting the existing `unescapeHTML` API is off the table, for performance reasons.
I plan to add this under a new `(de|en)code_html_entities` name.
It could be parameterized just like HTMLEntities, ... -
- Sorry, forgot to give a link to a human-readable table of html5 entities: https://html.spec.whatwg.org/multipage/named-characters.html#named-character-references.
-
- It is difficult to make this complete without overdoing it because there are many different kinds of entity sets. The htmlentities gem distinguishes three (html4, xhtml1, and expanded). Both html4 and xhtml1 come in at around 250 entitie...
-
- Eregon (Benoit Daloze) wrote in #note-12:
> and if possible one that does not involve twice the number of heredocs than needed.
It is intentional to indent inside here-docs and separate interpolation-enabled and -disabled parts.
-
12:06 PM Revision acbddbe6 (git): [ruby/irb] Rescue a specific error
- Rescuing StandardError is prone to bugs caused by a typo or obsoleted methods.
https://github.com/ruby/irb/commit/eb5260fcd5 -
11:55 AM Revision e8c2b03e (git): [ruby/irb] Fix error on `ls object_cant_define_singleton`
- such as `ls 42`, `ls :sym` and so on
https://github.com/ruby/irb/commit/b1d436a853 -
-
- https://github.com/ruby/error_highlight/commit/2dca1446c9
-
-
06:36 AM Feature #18015: Replace copy coroutine with pthread implementation.
- +1
-
- This is currently blocking <https://bugs.ruby-lang.org/issues/18005>. Pull request: <https://github.com/ruby/ruby/pull/4606>.
-
- The copy coroutine is unique in that it uses a private stack area. It is also tricky to implement as it uses setjmp/longjmp to update the stack & instruction pointer. Because of this, pointers to stack allocated data are only valid while...
-
06:03 AM Bug #18016 (Closed): fiddle\types.rb typealias maybe wrong
- in ...\lib\ruby\3.0.0\fiddle\types.rb
module Fiddle
module Win32Types
def included(m) # :nodoc:
m.module_eval{
# ...
typealias "HANDLE", "uintptr_t"
# ...
typealias "HINSTANCE", "unsi... -
-
-
- https://github.com/ruby/error_highlight/commit/8d483c251e
-
- https://github.com/ruby/error_highlight/commit/acb2046a82
-
- https://github.com/ruby/error_highlight/commit/f40a1de20e
-
- https://github.com/ruby/error_highlight/commit/e0c90c72c3
-
-
01:58 AM Bug #17887 (Closed): Missed constant lookup after prepend
- Applied in changeset commit:git|3dd3ea092acead6179033f2c95525ffc5b8bb6ff.
----------
Use Module#ancestors order in recursive constant lookup
Before this commit, const_get with inherit=true and constant lookup
expressions searched the a... -
-
- Before this commit, const_get with inherit=true and constant lookup
expressions searched the ancestors of the starting point in an order
different from `starting_point.ancestors`.
Items in the ancestry list introduced through prepend we... -
- Applied in changeset commit:git|8118d435d000adec3023a0ff509baa11cc73fabb.
----------
rb_warn_deprecated_to_remove_at [Feature #17432]
At compilation time with RUBY_DEBUG enabled, check if the removal
version has been reached. - 01:47 AM Revision dcd1eedb (git): * 2021-06-30 [ci skip]
-
-
-
-
- At compilation time with RUBY_DEBUG enabled, check if the removal
version has been reached.
06/29/2021
-
- # GitHub PR: https://github.com/ruby/ruby/pull/4613
When a Ractor is removed, the freelist in the Ractor cache is not returned to the GC, leaving the freelist permanently lost.
The following script demonstrates the issue. It iterat... -
-
- I've merged my PR https://github.com/ruby/ruby/pull/4586, created a new repository https://github.com/ruby/error_highlight
, and released a new gem https://rubygems.org/gems/error_highlight.
I will monitor the CI, but please let me k... -
- Eregon (Benoit Daloze) wrote in #note-3:
> IMHO in Ruby 3+ it should return `[[:rest, :*], [:keyrest, :**], [:block, :&]]`.
> ...
I think methods that use `ruby2_keywords`, either explicitly or implicitly through argument forwarding, s... -
- IMHO in Ruby 3+ it should return `[[:rest, :*], [:keyrest, :**], [:block, :&]]`.
The fact that it uses `ruby2_keywords` internally is an implementation detail that I don't think needs to leak into Method#parameters. -
06:09 AM Bug #18011: `Method#parameters` is incorrect for forwarded arguments
- jeremyevans0 (Jeremy Evans) wrote in #note-1:
> Forwarded arguments is implemented as `(*args, &block)` with `ruby2_keywords`, not as `(*args, **kwargs, &block)`. If you add `def wrapper4(*r, &b) = wrapped(*r, &b),` to `methods` and the... -
- Forwarded arguments is implemented as `(*args, &block)` with `ruby2_keywords`, not as `(*args, **kwargs, &block)`. If you add `def wrapper4(*r, &b) = wrapped(*r, &b),` to `methods` and then `ruby2_keywords :wrapper4` after `methods`, you...
-
- When asking a method about its parameters, forwarded arguments say they are a rest and a block (`wrapper1` in the example below).
However, when we use that signature, it raises an ArgumentError (`wrapper2` in the example below).
When I... -
- This hack should be removed after the minitest side is updated.
https://github.com/seattlerb/minitest/pull/880 -
-
- ```
$ ./local/bin/ruby -e '1.time {}'
-e:1:in `<main>': undefined method `time' for 1:Integer (NoMethodError)
1.time {}
^^^^^
Did you mean? times
```
https://bugs.ruby-lang.org/issues/17930 -
- When running btest there is a crash when compiled with
RGENGC_CHECK_MODE=4. The crash happens because `during_gc` is not
turned off before `gc_marks_check` is called, causing the marking to
happen on the main mark stack instead of mark s... -
12:05 PM Bug #18013: Unexpected results when mxiing negated character classes and case-folding
- duerst (Martin Dürst) wrote in #note-2:
> Just a question: What's the purpose of nested character classes?
They are useful in combination with the set intersection operator `&&`. They let you, e.g., exclude characters from some chara... -
- Just a question: What's the purpose of nested character classes?
I didn't even know that there was such a thing as nested character classes.
Depending on the purpose of nested character classes, the right way to handle things may d... -
- This is a simpler reproducer.
```
irb(main):003:0> /[^a]/i.match("a")
=> nil
irb(main):004:0> /[[^a]]/i.match("a")
=> #<MatchData "a">
``` -
- ```
irb(main):001:0> /[^a-c]/i.match("A")
=> nil
irb(main):002:0> /[[^a-c]]/i.match("A")
=> #<MatchData "A">
```
The two regular expressions above match different strings, because the character classes denote different sets of ch... - 11:54 AM Revision 5e75280c (git): Add basic test for updated IO wait functions.
-
- Some Unicode characters case-fold to strings of multiple code points, e.g. the ligature `\ufb00` can match the string `ff`.
```
irb(main):001:0> /\A[\ufb00]\z/i.match("\ufb00")
=> #<MatchData "ff">
irb(main):002:0> /\A[\ufb00]\z/i.m... -
- > Unfortunately, if __FILE__ uses realpath, unless you also change the behavior of $0
The "entrypoint" script could behave differently, but maybe that would be confusing. -
- Make description more readable.
-
- ... instead of exact matching. I'm now creating a built-in gem that
modifies Exception's error message, so the expectation value is changed.
IMO, it is good to check that did_you_mean suggestion is NOT added in
the uncorrectable case.
... -
- Previously, did_you_mean used `msg.end_with?(suggestion)` to check if
its suggestion is already added.
I'm now creating a gem that also modifies Exception's message. This
breaks did_you_mean's duplication check.
This change makes the ch... -
- Previously, DidYouMean::Correctable#original_message did
`method(:to_s).super_method.call` to call the original to_s method by
skipping Correctable#to_s.
I'm now creating a gem that prepends another to_s method to NameError,
which confu... -
- https://github.com/ruby/did_you_mean/commit/fbe5aaaae8
- 06:49 AM Revision 8356d9e3 (git): Start v1.6.0 development
- https://github.com/ruby/did_you_mean/commit/3f69171813
-
06/28/2021
-
- Applied in changeset commit:git|d795f494a89e0d9498dfedc54b8a98acc2bc4d7b.
----------
Avoid `free(3)`ing invalid pointer
Fixes [Bug #17794] -
- 09:06 PM Revision 983c9ad3 (git): * 2021-06-29 [ci skip]
-
- Fixes [Bug #17794]
-
- vo.x (Vit Ondruch) wrote in #note-13:
> Dan0042 (Daniel DeLorme) wrote in #note-12:
> ...
It's not difficult to make `__FILE__` use `realpath`:
```diff
@@ -10307,6 +10307,14 @@ numparam_nested_p(struct parser_params *p)
retur... -
- @alanwu came up with a much simpler fix for this issue, so I closed my pull request in favor of his. @nobu, could you please review his pull request: https://github.com/ruby/ruby/pull/4585 ?
-
-
-
-
- I tested this with RubyInstaller-head on Windows and the problem appears to have been resolved. Even without an empty `:search` option, ruby raises an exception almost immediately. As commit:9edc162583a4f685332239f6249745ad9b518cbe has...
-
- gdbm was removed in commit:edcc29dcff1b269b7748ab83adf21b2f3f97ebff
-
-
- This appears to be fixed as of Ruby 2.1. I was able to recreate the issue in 2.0, but not in 2.1. I also tested the latest RubyInstaller-head, and the problem is still fixed.
-
- This issue appears to have been fixed, probably in Ruby 3.0. Using the latest RubyInstaller-head:
```
D:\zz-können2>D:\zz-können2\Ruby31-x64\bin\ruby.exe -v --disable-gems -e "p $:.first.encoding, $:.first; require 'uri'"
ruby 3.1.... -
- I didn't have the core dump and this issue only happens very rarely. I just caught it again today and this time I have the core dump. I forwarded it to @tenderlovemaking.
-
- ```
irb(main):001:0> /ff/i.match("\ufb00")
=> #<MatchData "ff">
irb(main):002:0> /[f]f/i.match("\ufb00")
=> #<MatchData "ff">
irb(main):003:0> /f[f]/i.match("\ufb00")
=> nil
irb(main):004:0> /[f][f]/i.match("\ufb00")
=> nil
irb(ma... -
- This is a follow up to [issue 4044](https://bugs.ruby-lang.org/issues/4044). Its fix (https://github.com/k-takata/Onigmo/issues/4) handled the cases that were reported in the original issue, but there are other cases, which were omitted ...
-
- Reduce duplications
* ID caluculations of the same name
* checks against the same name
* registration to the root module hash - 03:10 AM Revision ac8c674a (git): * 2021-06-28 [ci skip]
-
- @matz Thank you for your comment! Then, I'll pick up `error_highlight`. I will update and then merge my PR later.
-
02:27 AM Feature #17930: Add column information into error backtrace
- The `pretty` from `pretty print` strongly suggests beautifying indentation, which the proposed feature doesn't provide.
So I vote for `highlight` or `emphasize`.
Matz.
-
06/27/2021
-
- I read the source code of rustc. https://github.com/rust-lang/rust/tree/master/compiler/rustc_errors
The feature name seems to be "rustc_errors", which is not helpful for my proposal to decide the gem name, but I found some inspiring ... -
- Okay thanks. As far as I take a glance at the references that you showed, the word seems to be mainly used for a "cause". However, the underline in my proposal is not necessarily a cause, so I'm unsure whether it is more appropriate.
... -
- duerst (Martin Dürst) wrote in #note-25:
> If all of pretty/emphasis/highlight are problematic, what's your suggestion?
I already gave suggestions.
mame (Yusuke Endoh) wrote in #note-26:
> ...
I had English in mind. The link https://eo... -
- @duerst It sounds similar to prettyprint which is an existing built-in gem. As far as I know, there is no grammatical rules about a gem name. I don't find any consistent rule when I see prettyprint, power_assert, did_you_mean, debug, etc...
-
- sawa (Tsuyoshi Sawada) wrote in #note-24:
> To my understanding, the word "prettify" means and has been used to add cosmetics to the output, like adding line breaks and indenting or adding colors. The words "emphasis" and "highlight" ar... -
- To my understanding, the word "prettify" means and has been used to add cosmetics to the output, like adding line breaks and indenting or adding colors. The words "emphasis" and "highlight" are in a similar vein. The functionality in que...
-
- mame (Yusuke Endoh) wrote in #note-22:
> Thank you for suggestions about the name. For the record, @pocke and @naruse like "pretty_error". I'll bring this to the next dev-meeting and ask @matz to pick up.
I'm not convinced about "pre... -
-
-
- Moved the check just after `rb_yield`.
And I found that `each_codepoint` also had a similar bug.
@wyhaines Could you add a spec for the method? -
- Applied in changeset commit:git|13939d61b4b69bd109c5f41303c79868d639fa44.
----------
Check if closed after each yield [Bug #17661] -
- +1. While we aim to obviate `keyword_init` in [Feature #16806], unless we also intend to deprecate the option (for now we don't), we'd need to have the check to correctly write a deserializer of Structs.
-
01:56 AM Feature #18008 (Closed): `keyword_init?` method for Struct
- I'd like to know whether my struct was initialized with `keyword_init: true` or not.
This information is useful when writing a deserializer (attached an example below).
```ruby
S1 = Struct.new(:a, :b, keyword_init: true)
S2 = Struc... -
-
- https://github.com/ruby/irb/pull/249 actually slowed down how `code` is
concatenated. The original way of creating `code` is faster.
[before]
user system total real
2.420137 0.005364 2.425501 ( 2.426264)
[after... -
- https://github.com/ruby/irb/commit/2b79e9ad21
06/26/2021
-
-
-
- Applied in changeset commit:git|e86c1f6fc53433ef5c82ed2b7a4cc9a12c153e4c.
----------
Work around issue transcoding issue with non-ASCII compatible encodings and xml escaping
When using a non-ASCII compatible source and destination enco... -
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> It looks like this issue occurs when using both multibyte source and destination encoding. If either the source or destination encoding is not multibyte, the issue doesn't occur:
> ...... - 07:32 PM Revision b1428b27 (git): * 2021-06-27 [ci skip]
-
- When using a non-ASCII compatible source and destination encoding
and xml escaping (the :xml option to String#encode), the resulting
string was broken, as it used the correct non-ASCII compatible
encoding, but contained data that was ASC... -
-