Activity
From 03/18/2021 to 03/24/2021
03/24/2021
-
11:58 PM Feature #12125: Proposal: Shorthand operator for Object#method
- Since the proposed feature was reverted in #16275, maybe this issue should be re-opened to continue discussion and "re-introduce with a big picture".
And I'd like add another perspective:
```
upcased = somehash.each_pair.map{|key,... -
10:09 PM Feature #17743: Show argument types in backtrace
- p8 (Petrik de Heus) wrote in #note-3:
> ```
> ...
What about keyword arguments that could have been supplied in any order? What about the block argument, if it was `nil` or not?
> Maybe for Boolean values showing true and false.
... -
08:39 PM Feature #17743: Show argument types in backtrace
- Eregon (Benoit Daloze) wrote in #note-2:
> How would your format when the method takes multiple arguments?
```
from hi.rb:2:in `say_hi' called with NilClass, Numeric, String
```
> ...
Values could possibly generate a lot of outp... -
07:54 PM Feature #17743: Show argument types in backtrace
- How would your format when the method takes multiple arguments?
Should we show the value or just the class?
I think in general this can be useful, but at the same time it's not nearly as useful as a debugger,
and it can be a signifi... -
- Given the following Ruby program:
``` ruby
def say_hi(person)
puts message(person)
end
def message(person)
"hi: #{person.name}"
end
say_hi(nil)
```
It would be helpful if the backtrace contained the types of the argum... -
09:02 PM Feature #17745: `IO#close_on_exec=` returns different value when called with `send, __send__, public_send` or not
- I also think the "returns nil" example should be removed simply.
-
- The PR looks good to me.
As you may know `recv.foo= value` always return `value`, no matter what the `foo=` method returns.
So in general the return value of assignment methods might differ and is probably best to be ignored. -
04:22 PM Feature #17745 (Closed): `IO#close_on_exec=` returns different value when called with `send, __send__, public_send` or not
- ```console
$ ruby -v -e 'p(STDIN.close_on_exec = 42)'
ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-darwin20]
42
```
```console
$ ruby -v -e 'p(STDIN.__send__ :close_on_exec=, 42)'
ruby 3.0.0p0 (2020-12-25 revision 95aff... -
06:31 PM Revision b25361f7 (git): Change heap walking to be safe for object allocation
-
06:15 PM Bug #17746 (Closed): Backport f9f13a4f6d8be706b17efc089c28f7bc617ef549 to Ruby 3.0
- This is necessary fix a bug in Kernel#caller missing frames, introduced with the fix for #17581. This should be backported to Ruby 3.0 before Ruby 3.0.1, otherwise one of the Rails tests will break.
-
06:15 PM Revision f9f13a4f (git): Ensure that caller respects the start argument
- Previously, if there were ignored frames (iseq without pc), we could
go beyond the requested start frame. This has two changes:
1) Ensure that we don't look beyond the start frame by using
last_cfp = RUBY_VM_PREVIOUS_CONTROL_FRAME(last... -
05:22 PM Feature #17524: resolv: add some more characters in IPv6 link local zone id
- I just faced this issue where `cni-podman0` including `-` is used as string matching with `Resolv::IPv6::Regex_CompressedHexLinkLocal`.
```
$ ruby -rsocket -e 'p Socket.ip_address_list[8]'
#<Addrinfo: fe80::9856:24ff:fe1b:f759%cni-p... - 03:20 PM Revision 91ab024d (git): * 2021-03-25 [ci skip]
-
03:20 PM Revision 2c3ac0fe (git): Update bundled_gems
-
02:35 PM Bug #17581: Ruby 3.0 backtrace sometimes returns empty array
- @jeremyevans0 indeed that fixes the issue. Thanks a lot!
-
- @byroot https://github.com/ruby/ruby/pull/4237 hasn't been merged yet, I'm guessing that may fix your example.
-
- @jeremyevans I'm not sure this was properly fixed:
```ruby
def label
p caller.first
end
def label_caller
label
end
p RUBY_VERSION
puts 'raw call'
label_caller
puts 'call from group_by'
[1].group_by { label_caller }
... -
02:29 PM Feature #17682: String#casecmp performance improvement
- bump.
I'll be happy to make any suggested changes to the PR.
I hope `casecmp` performance is important enough to deserve consideration.
-
-
-
02:11 PM Feature #17744: Accumulate `Enumerable#tally` results
- ~~Is there an issue using `merge`?~~
I retract my question, this change sounds simple enough -
- A [feature request] at [DevelopersMeeting20200317Japan]:
> * ko1: want to accumulate `Enumerable#tally` results
> ...
[DevelopersMeeting20200317Japan]: https://hackmd.io/nNo0Sb3nRCmQpIwR8XvusA#Other-topics-3
[feature request]: https:/... -
- nobu (Nobuyoshi Nakada) wrote in #note-3:
> I think there was a proposal for a similar concept, "rest keywords including all keywords", but can't find it now.
I believe you're talking about #15049. In #16253 there was also brief talk of... -
- This seems similar to the following fixed issue: https://bugs.ruby-lang.org/issues/17728
-
- a.out format is considered extinct nowadays.
-
10:25 AM Bug #17742: Random.rand gets wrong after using Ractor and requiring benchmark
- I think that it is fixed by 3acc81d9.
```
$ cat test.rb
10.times do
r = 100.times.map { Ractor.new{ Ractor.yield(receive.inspect) } }
r.each{|x| x.send(rand) }
s = r.map{|x| x.take }.min_by(&:size)
puts s
if s.size < 1... -
- > It is possible that this issue has already been fixed
I think so too. I compiled the `ruby_3_0` branch (what will later be 3.0.1) and can't reproduce there. However I can repro with `3.0.0-p0`. -
02:41 AM Bug #17742: Random.rand gets wrong after using Ractor and requiring benchmark
- I cannot reproduce this with a recent development version (3.1.0dev) on Git. It is possible that this issue has already been fixed, although I cannot point out exactly when it was fixed.
FWIW, I can reproduce this with Ruby 3.0.0p0, a... -
07:39 AM Feature #17685 (Feedback): Marshal format for out of band buffer objects
-
-
06:43 AM Revision 89caf51d (git): [ruby/reline] Suppress crashing when completer_{quote,word_break}_characters is empty
- https://github.com/ruby/reline/commit/c6f1164942
-
- https://github.com/ruby/reline/commit/1f469de90c
-
- https://github.com/ruby/reline/commit/da90c094a1
-
- https://github.com/ruby/reline/commit/43ac03c624
-
- https://github.com/ruby/actions/runs/2175399707?check_suite_focus=true
```
Errno::EACCES: Permission denied @ dir_s_mkdir - /home/runner/.config/irb
``` -
- https://github.com/ruby/irb/commit/1c61178b4c
-
- https://github.com/ruby/irb/commit/d9f8abc17e
-
-
03/23/2021
-
08:59 PM Bug #17742 (Closed): Random.rand gets wrong after using Ractor and requiring benchmark
- Dear All,
I use Ruby v3.0.0 on Ubuntu 18.04 x64 compiled from source the recommended way and when I run the following code:
require "benchmark"; r = []; 3.times.map{ r << Ractor.new{ p receive } }; r.map{|x| x.send(rand) }; rand
... - 08:10 PM Revision 061edf6b (git): * 2021-03-24 [ci skip]
-
08:10 PM Revision 417c648f (git): Free iv index table
- IV index tables weren't being freed. This program would leak memory:
```ruby
loop do
k = Class.new do
def initialize
@a = 1
@b = 1
@c = 1
@d = 1
@e = 1
@f = 1
@g = 1
end
end
k.new... - 07:52 PM Revision d3779ab3 (git): * 2021-03-24 [ci skip]
-
07:52 PM Revision 2efda212 (git): Merge RubyGems-3.2.15 and Bundler-2.2.15 (#4311)
-
-
- > I'm afraid that this can be happen in earlier than 3.0 too.
Hum. `rb_enc_interned_str` was introduced in 3.0.
Unless you think other string functions are vulnerable to the same issue? -
-
-
03:20 AM Revision 81d52978 (git): test/zlib/test_zlib.rb: stop a failure on armv7l
- The platform defines a constant File::TMPFILE, but it seems unavailable
(maybe depending on the file system?).
http://rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20210322T171707Z.fail.html.gz
This change adds some rescue cluases... -
- ... of test_many_fibers_with_threads because the test seems to take
about 180 sec. on Solaris. This change extends the limit to 300 sec on
Solaris.
BTW, 180 sec. is too long for other normal environments, so this reverts
Related to 6ab7d... -
- As far as I remember, I've heard that libobjc needs to be linked against the executable file instead of dynamically loaded modules for startup routines.
I'm not sure if still it is true though.
03/22/2021
-
- I missed that the link was only in the pull-request description but not in the commit log.
I'm afraid that this can be happen in earlier than 3.0 too. -
- @nobu thanks for merging https://github.com/ruby/ruby/pull/4290
Do you think it should be backported to 3.0?
Either way this ticket can now be closed. -
- Get rid of warnings in the parallel test.
```
unknown command: "Switch to inspect mode."
``` -
10:42 PM Feature #17730: Ruby on macOS transitively links to ~150 dylibs
- rickmark (Rick Mark) wrote in #note-9:
> naruse (Yui NARUSE) wrote in #note-7:
> ...
Ruby also has UTF-8-MAC, but HFS+/APFS's one is sometimes updated.
We first used our own encoding table for the usage, but finally we switched to use... -
07:50 PM Feature #17730: Ruby on macOS transitively links to ~150 dylibs
- rickmark (Rick Mark) wrote in #note-8:
> nobu (Nobuyoshi Nakada) wrote in #note-5:
> ...
Nevermind - I just recompiled ruby from head. Looks like the linking is correct now. Must have been Foundation brining in Security causing my co... -
- naruse (Yui NARUSE) wrote in #note-7:
> duerst (Martin Dürst) wrote in #note-6:
> ...
Yep - the normalization is called `UTF-8-MAC` on libicu. This implies we can use other code to do this. Also since CF is opensource we could just b... -
- nobu (Nobuyoshi Nakada) wrote in #note-5:
> The Security framework is linked only when it is available but CommonRandom is not.
> ...
From compiling recently it looks like `Security.framework` is always linked (see the static linkage r... -
- duerst (Martin Dürst) wrote in #note-6:
> rickmark (Rick Mark) wrote:
> ...
Why it uses `CFStringNormalize(m, kCFStringNormalizationFormC);` is because it needs to just the same conversion as HFS+/APFS, which is different from standard... -
- As a convenance to extension developers Ruby on macOS always links to libobjc. This could be better handled with a native ObjC extension so that one could `require 'objc'` to add this to the process.
The extension would link to libob... - 04:30 PM Revision c1497080 (git): * 2021-03-23 [ci skip]
-
- 02:32 PM Revision 816a1d97 (git): coroutine mac m1 update.
- using proper link register and frame pointer which equal x30/x29.
- 02:32 PM Revision 35d30c6a (git): vm dump display return address in the abscence of X30 in Mac ARM64.
- 01:51 PM Revision 5e16c3a1 (git): solaris/illumos build fix.
-
- If called with an autoloaded encoding that was not yet
initialized, `rb_enc_interned_str` would crash with
a NULL pointer exception.
See: https://github.com/ruby/ruby/pull/4119#issuecomment-800189841 -
-
-
-
03/21/2021
- 03:20 PM Revision db0ad483 (git): * 2021-03-22 [ci skip]
-
- Means the platform with the actual CPU info on universal binary.
The CPU in "arch" is fixed as "universal" to refer the header and
library paths. -
10:16 AM Feature #17730: Ruby on macOS transitively links to ~150 dylibs
- rickmark (Rick Mark) wrote:
> Further CoreFoundation is only used for one call in the entire codebase of `CFStringNormalize(m, kCFStringNormalizationFormC);` - if we can replace this, Ruby could work with only `libSystem` and `libgmp`... -
-
07:01 AM Revision 94254117 (git): [ruby/irb] Have some right padding
- instead of filling out an entire line
https://github.com/ruby/irb/commit/6ac8f45f5f -
- e.g. http://rubyci.s3.amazonaws.com/centos8/ruby-master/log/20210321T063003Z.fail.html.gz
https://github.com/ruby/irb/commit/ddb3472ba2 -
- cols.size was calling Integer#size, which returns 8.
Fixing a bug of https://github.com/ruby/irb/pull/209
https://github.com/ruby/irb/commit/c93ae4be71 -
- https://github.com/ruby/irb/commit/6115754623
-
06:14 AM Feature #17411 (Closed): Allow expressions in pattern matching
- Applied in changeset commit:git|21863470d965b8cc299b1f82417c70d5d26f8ab2.
----------
Pattern matching pin operator against expression [Feature #17411]
This commit is based on the patch by @nobu. -
- This commit is based on the patch by @nobu.
-
05:43 AM Revision c761586b (git): I gave up tentatively to support autoconf 2.70 in ruby_2_7 and remove failing build on GitHub Actions MinGW
- 05:27 AM Revision 338d7ec9 (git): * 2021-03-21 [ci skip]
-
- This reverts commit cfd1a17292ae37db4d09c1452a4a84e7fd58e7cf.
-
- Update for autoconf 2.70
---
configure.ac | 232 +++++++++++++++++------------------
tool/m4/ruby_check_builtin_setjmp.m4 | 8 +-
tool/m4/ruby_check_printf_prefix.m4 | 9 +-
... -
- https://github.com/ruby/irb/commit/bc822e4aac
-
- https://github.com/ruby/irb/commit/19b6c20604
-
- Thank you user:hsbt, I've sent an email with my information.
-
- @peterzhu2118
Can you provide the your information about https://bugs.ruby-lang.org/projects/ruby/wiki/CommitterHowto#What-to-do-for-registering-you-as-a-committer ? -
- Close https://github.com/ruby/ruby/pull/4298
-
03/20/2021
-
- Duplicate with https://bugs.ruby-lang.org/issues/17622
-
10:37 PM Bug #17740: Segmentation Fault on const_get when running `srb init` (sorbet gem)
- Apparently it's fixed in https://github.com/ruby/ruby/pull/4175
-
- It's from an ActiveAdmin gem.
Also removed Bootsnap and it didn't fix it. -
- Added a puts debugging, and I get:
```
puts "CONSTANT #{constant.inspect} CONST_GET NAME #{name.inspect}"
(other constants)
...
CONSTANT InheritedResources CONST_GET NAME "BaseHelper"
``` -
- Here is the full logs of the segfault: https://gist.github.com/dorianmariefr/c414a7c2d48671be12fbf0fe6769882b
The issue I raised on the sorbet gem: https://github.com/sorbet/sorbet/issues/4104 -
09:57 PM Revision 54bfa057 (git): Add ins_methods_type_i function
-
- Is there a usecase for this?
-
07:37 PM Bug #17739: Array#sort! changes the order even if the receiver raises FrozenError in given block
- I think the point of `#sort!` is that it sorts in-place - so not creating a copy. If we want to be able to restore the unsorted array after an exception happens half-way through sorting, we'd need to create a copy to either swap back in ...
-
- I think this is a similar issue of https://bugs.ruby-lang.org/issues/17736
```ruby
array = [1, 2, 3, 4, 5]
begin
array.sort! do |a, b|
array.freeze if a == 3
1
end
rescue => err
p err #=> #<FrozenError: can't mod... -
- I believe so, yes.
-
- After https://bugs.ruby-lang.org/issues/15920 and https://github.com/ruby/ruby/commit/f53d7e4bfd604be6f8131c5460c29f4af16da117, `ENV.freeze` raises TypeError.
But we can still freeze ENV as below.
```ruby
Kernel.instance_method(:fre... - 03:23 PM Revision 2d66f8e0 (git): * 2021-03-21 [ci skip]
-
-
-
-
-
-
- refs:
* https://bugs.ruby-lang.org/issues/17736
* https://github.com/ruby/ruby/pull/4296
This commit aims to cover following methods
* Hash#select!
* Hash#filter!
* Hash#keep_if
* Hash#reject!
* Hash#delete_if
I think these are not a... -
- https://github.com/ruby/irb/commit/89bcf107be
-
- Applied in changeset commit:git|e019dd24df4ed7063ad80d4c2e4070141793f598.
----------
Ensure the receiver is modifiable before shrinking [Bug #17736]
* Ensure the receiver is modifiable before shinking [Bug #17736]
* Assert the receive... -
- When I interested around https://bugs.ruby-lang.org/issues/17735, I found following behaviors.
```ruby
array = [1, 2, 3, 42]
array.select! do
array.freeze
false
end
p array #=> []
```
```ruby
array = [1, 2, 3, 42, 2, 3]... -
- * Ensure the receiver is modifiable before shinking [Bug #17736]
* Assert the receivers are not modified -
-
- These are just a bug, not a spec.
```ruby
ruby_version_is ""..."2.5.1" do
it "partially modifies the contents if we broke from the block" do
@hash.transform_keys! do |v|
break if v == :c
v.succ
... -
- ```ruby
hash = {a: 1, b: 2, c: 3}
hash.transform_values!(){ raise } rescue
p hash #=> {:a=>1, :b=>2, :c=>3}
```
```ruby
hash = {a: 1, b: 2, c: 3}
hash.transform_keys!(){ raise } rescue
p hash #=> {}
```
Is this an intention... -
- ```ruby
p [].permutation(1) #=> #<Enumerator: []:permutation(1)>
p [].permutation(1, 3) #=> #<Enumerator: []:permutation(1, 3)>
p [].permutation(1, 3).to_a #=> `permutation': wrong number of arguments (given 2, expected 0..1) (Argumen... -
- Add another missing cast
---
iseq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) -
-
- ruby_2_7 364c8595884808315aaec9605bf2423963ed81c0 merged revision(s) a85ed626f18d1014d09fb37eb0a703976c3d2b53.
-
- ruby_2_7 ec779aa56f4d6df465e721818d73d0d48fdf03f2 merged revision(s) f748b911c9157a0bb86f38280ddfba72a55049b6.
-
- ruby_2_7 6e962f02b266c3a6c47e50cf2e9ab7b1db25e515 merged revision(s) 58660e943488778563b9e41005a601e9660ce21f.
-
- Fix Enumerable#inject with high negative fixnums [Bug #17731]
---
enum.c | 2 +-
test/ruby/test_enum.rb | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-) -
- Fix infinite loop at illegal sequence [Bug #17729]
As mblen returns -1 on failure, skip the first byte and try the
succeeding bytes in that case.
Close https://github.com/ruby/ruby/pull/4281
---
... -
- Skip refined method when exporting methods with changed visibility
Previously, attempting to change the visibility of a method in a
singleton class for a class/module that is prepended to and refined
would raise ... -
- I reopen this ticket since the pull request (https://github.com/ruby/ruby/pull/3717) was not merged yet.
-
- Fix the failing test with XDG_CONFIG_HOME
---
test/irb/test_init.rb | 4 ++++
1 file changed, 4 insertions(+) -
- ruby_2_7 755a349a3a66f5731995296fe3bb7d2b1712167f merged revision(s) 4bff8e84232594ecb9914e2a8437b7c40a63b799.
-
- Ensure that the head of the vacancy list is correctly inserted into
the linked list.
See <https://bugs.ruby-lang.org/issues/16814> for more details.
---
cont.c | 1 +
1 file changed, 1 insertion(+) -
- MEMO: Though there should be some preceding changesets, I gave up to find it for the time being.
-
- Another example:
```ruby
'' != nil
module Blah
def == other
'blah blah'
end
end
String.prepend(Blah)
p 'a' == 'b' # => false
```
It seems that `rb_vm_check_redefinition_opt_method` is not working correctly in the... -
- ruby_2_7 82bce422ba9e131e62b528854dea69a6e8cc0c04 merged revision(s) 254bed302752a401b5fcc3b6c65a9c93711d91d6,fad3023e94c45e7f03478732f7641b6f39ba9d12,3156fb0f2c3ebf8229f392c8502c08fe165ab181.
-
- Renamed `nurat_sub` compliant with `rb_rational_plus`
---
internal/rational.h | 1 +
rational.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
Fix ArithmeticSequence#last ... -
- ruby_2_7 82d72f14e7071218f3fd710f770d1ba31390f027 merged revision(s) ebb96fa8808317ad53a4977bff26cf755d68077e.
-
- ruby_2_7 a85982553935b81de02eb8cca9476df5d4442fd8 merged revision(s) 276f6a225d18561cbe5282b798cb4e416c66079f,95bef7b69a6fb42687a6200b338060be307259f5.
-
- ruby_2_7 d84cc717020be1da7d89b6bda02d1427f9593968 merged revision(s) 15e23312f6abcbf1afc6fbbf7917a57a0637f680.
-
- Fix errors when XDG_CONFIG_HOME points to non-writable directory
`$HOME/.config` is not writable on CI
because I think tests should not corrupt user's data.
And GitHub Actions CI sets `XDG_CONFIG_HOME`
s... -
- Rework the order of operations to avoid stack smashing.
---
coroutine/copy/Context.c | 59 ++++++++++++++++++++++++++++++++----------------
1 file changed, 40 insertions(+), 19 deletions(-) -
- Don't double fractional seconds when passing timezone object to
Time.new
I found that fractional seconds were doubled when using the timezone
feature of Time in Sequel's named_timezones extension (which uses
... -
- MEMO: 369cfabd5936ccb522f8e95e0f9cc65b59ea4039 seems depend on the preceding changeset 0b81a484f3453082d28a48968a063fd907daa5b5.
0b81a484f3453082d28a48968a063fd907daa5b5 is one of the series fixes about initialization of RBasic::flags. -
- Fix singleton class cloning
Before this commit, `clone` gave different results depending on whether the original object
had an attached singleton class or not.
Consider the following setup:
```
c... -
- ruby_2_7 6ef46f71c743507a0e2ae0eef14dce0539b0ff52 merged revision(s) 511b55bcefc81c036294dc9a544d14bd342acd3b.
-
- Enable arm64 optimizations that exist for power/x86 (#3393)
* Enable unaligned accesses on arm64
64-bit Arm platforms support unaligned accesses.
Running the string benchmarks this change improves performance
... -
- ruby_2_7 c98aa2db60f43e839d7a82897c22b5ceecbed417 merged revision(s) c60aaed1856b2b6f90de0992c34771830019e021.
-
- ruby_2_7 ba6f0879448ebc80c7a595c369c59b6d8dfbdf3e merged revision(s) abe2e7de4d1f2d5861d7c9ab9c7e778f2ee1dcd2.
-
- ruby_2_7 ef1ed1b53afdff80cb217d77f3fbcbe7906c729e merged revision(s) c15cddd1d515c5bd8dfe8fb2725e3f723aec63b8.
-
- Allow Dir.home to work for non-login procs when $HOME not set
Allow the 'Dir.home' method to reliably locate the user's home directory when
all three of the following are true at the same time:
1. Ruby is ru... -
04:50 AM Misc #17733: Add peterzhu2118 as a committer
- I agree. Go ahead.
Matz.
-
- Don't require sub-word atomics
On some architectures (like RISC-V) sub-word atomics are only available
when linking against -latomic, but the configure script doesn't do that,
causing the atomic checks to fail an... -
- Fix Method#super_method for aliased methods
Previously, Method#super_method looked at the called_id to
determine the method id to use, but that isn't correct for
aliased methods, because the super target depends ... -
- ruby_2_7 30942fc4d89a04792e9eba7d3c4e5009c54e81da merged revision(s) 2a83650b0fd25719fb6c03bfec7bd895734d3ceb.
-
- ruby_2_7 9994860dcb56697fad1799128d1493adc06b23c7 merged revision(s) 2a6bfd22468343003463e0cbf91953a01b0dbba5,3ac28de5414c81a0da8c8ec969ea74db5a0f1b0f.
-
- ruby_2_7 70c3a195f39763dccdf9367d0c9b7e815431a41a merged revision(s) 9682db065158da5fa4ec8a3bc267da45b429b92c.
-
- ruby_2_7 70c3a195f39763dccdf9367d0c9b7e815431a41a merged revision(s) 9682db065158da5fa4ec8a3bc267da45b429b92c.
-
- Remove sender/message_id pair after response received in resolv
Once a response for a given DNS request has been received (which
requires a matching message id), the [sender, message_id] pair
should be removed fr... -
- Properly convert time_t [Bug #17645]
---
thread_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Explicitly cast __s64 to time_t [Bug #17645]
A workaround of shorten-64-to-32 error ... -
- I believe 20a8425aa0f9a947e72b06cbd3a2afe9674dd18f is not need to be backported into ruby_2_7, since the test test_any_hash_fixable passed without the patch to hash.c.
-
- Destroy VM-wise locks before freeing [Bug #15852]
---
thread.c | 7 -------
vm.c | 2 ++
2 files changed, 2 insertions(+), 7 deletions(-) -
- # The next dev meeting
**Date: 2021/04/16 13:00-17:00**
Place/Sign-up/Agenda/Log: https://github.com/ruby/dev-meeting-log/blob/master/DevelopersMeeting20210416Japan.md
- Dev meeting *IS NOT* a decision-making place. All decisions ... -
-
03/19/2021
-
- Thanks to @wanabe's insight that this issue is related to the scope of the rescue catch entry, I came up with a pull request that avoids the issues @wanabe identified in his patch: https://github.com/ruby/ruby/pull/4291. Instead of tryi...
-
- The Security framework is linked only when it is available but CommonRandom is not.
It is the case that the minimum required macOS version is 10.7(Lion)..10.9(Mavericks).
I'm not sure whether other sources are available on these old ve... -
- Looks like we applied the Foundation -> CoreFoundation patch.
What about the Security framework? It's the source of the worst dependencies like Metal, CoreML, etc...
(I know my patch proposal moves HEAD to macOS 10.10 or later, but th... -
07:41 AM Feature #17730 (Closed): Ruby on macOS transitively links to ~150 dylibs - Applied in changeset commit:git|dc7044eb48f475e5ac34e994e89115052574c451.
----------
Remove unneeded dependencies on macOS [Feature #17730] -
- https://github.com/ruby/irb/commit/ecc82336b7
-
- Hi,
I'd like to recommend we add @peterzhu2118 as a committer. Peter has been helping with bugs in GC (specifically bugs we found) as well as ObjectSpace issues and improvements. I have been reviewing Peter's work and I think he wou... - 06:05 PM Revision 2b0e5872 (git): * 2021-03-20 [ci skip]
-
-
- https://github.com/ruby/irb/commit/9587ba13b5
-
- Reported by @yahonda in https://github.com/ruby/ruby/pull/4119#issuecomment-800189841
### The bug
`rb_enc_interned_str` doesn't properly handle autoloaded encodings that are not yet loaded:
```
[BUG] Segmentation fault at 0x000... -
- 06:27 AM Revision dc7044eb (git): Remove unneeded dependencies on macOS [Feature #17730]
-
-
- akr (Akira Tanaka) wrote in #note-5:
> nobu changed it from LONG2NUM to ULONG2NUM at
> ...
Thanks.
The other changes were for counts (always positive) and most were considered as integers. In the `inject` case, the values can be any f... - 04:22 AM Bug #17731 (Closed): Integer downflow with inject/reduce
- Applied in changeset commit:git|a85ed626f18d1014d09fb37eb0a703976c3d2b53.
----------
Fix Enumerable#inject with high negative fixnums [Bug #17731] -
03:38 AM Bug #17731: Integer downflow with inject/reduce
- marcandre (Marc-Andre Lafortune) wrote in #note-3:
> Right, there's a `ULONG2NUM` that seem to assume the subtotal is always positive...
> ...
nobu changed it from LONG2NUM to ULONG2NUM at
https://github.com/ruby/ruby/commit/6bb70c11b... -
- Removing the letter 'U' fixes it...
https://github.com/ruby/ruby/pull/4288 -
- Right, there's a `ULONG2NUM` that seem to assume the subtotal is always positive...
I'll make a PR for this -
01:05 AM Bug #17731: Integer downflow with inject/reduce
- more interesting samples:
```ruby
[-2305843009213693953,-2305843009213693953,-2305843009213693953].inject(:+)
#=> 11529215046068469757
[-2305843009213693953,-2305843009213693953,-2305843009213693953].inject(&:+)
#=> -6917529027641... -
01:01 AM Bug #17731: Integer downflow with inject/reduce
- Some more interesting samples:
``` ruby
3.0.0 :001 > [0,-2305843009213693953,-2305843009213693953].inject(:+)
=> 13835058055282163710
3.0.0 :002 > [-2305843009213693953,-2305843009213693953].inject(:+)
=> -4611686018427387906
3... -
- Test case:
[-2305843009213693953,-2305843009213693953,-2305843009213693953].inject(:+)
or
([-2**61-1] * 3).inject(:+)
Expected Result:
-6917529027641081859
Actual Result:
11529215046068469757
Some clues:
* Downflow seems n... - 04:21 AM Revision a85ed626 (git): Fix Enumerable#inject with high negative fixnums [Bug #17731]
-
- Emscripten provides "emscripten_scan_stack" to get the beginning and end
pointers of the stack for conservative GC.
Also, "emscripten_scan_registers" allows the GC to mark local variables
in WASM. -
-
- Seems like it confuses "make ruby" for emscripten.
03/18/2021
-
- `-lobjc` has been intentionally linked to link startup code with Objective-C support, by the request for extension libraries written in it.
-
- By using `-framework Security` and `-framework Foundation` Ruby 3 pulls in about 150 dylibs when compiled for macOS
By using CoreCrypto / CoreFoundation I was able to reduce this to ~50. This greatly reduces Ruby's surface area and d... -
- Applied in changeset commit:git|f748b911c9157a0bb86f38280ddfba72a55049b6.
----------
Fix infinite loop at illegal sequence [Bug #17729]
As mblen returns -1 on failure, skip the first byte and try the
succeeding bytes in that case.
Clo... -
- https://github.com/ruby/ruby/pull/4281
> `ruby.c` sets up the interpreter `$LOAD_PATH` by parsing a path
> ...
> ``` -
- As mblen returns -1 on failure, skip the first byte and try the
succeeding bytes in that case.
Close https://github.com/ruby/ruby/pull/4281 -
-
07:47 PM Misc #17720: Cirrus CI to check non-x86_64 architecture cases by own machines
- Hello there,
I'm founder of Cirrus CI and will be happy to answer any of your questions and help you in any capacity.
Cirrus persistent workers are implemented via Cirrus CLI[1] which is written in Go so we can support any target t... - 07:03 PM Revision dae71be2 (git): * 2021-03-19 [ci skip]
-
07:03 PM Revision b9908ea6 (git): Make a few functions static
-
- The crash report doesn't provide a C-level backtrace of the crashed thread. There are quite a few external C extensions in use, any of which could possibly cause this null pointer dereference. Unfortunately, unless you can provide a re...
-
10:57 AM Bug #17728 (Closed): [BUG] Segmentation fault at 0x0000000000000000
- Hi guys, getting segment fault from time to time. Sorry, don't know the exact reproducing steps. Attached crash reports.
```
Started POST "/graphql" for 127.0.0.1 at 2021-03-18 13:49:07 +0300
/Users/den/.rvm/gems/ruby-3.0.0@RestaAPI... -
- That looks like an error of `rbs` actually, cc @soutaro
-
- @matz agreed to change the return value of Mutex#sleep at the last developer meeting. However, that breaks a Mutex_m test: https://github.com/ruby/ruby/pull/4256/checks?check_run_id=2135513377#step:15:1295
So the Mutex_m test needs t... -
- I think this is a nice solution: https://github.com/ruby/irb/pull/206
- 11:35 AM Bug #16996 (Closed): Hash should avoid doing unnecessary rehash
- Applied in changeset commit:git|d094c3ef046aba0bb99fd08bcbc72ff87216e736.
----------
Avoid rehashing in Hash#select/reject [Bug #16996] - 11:34 AM Revision 0ef2923c (git): Avoid rehashing in Hash#replace/dup/initialize_copy [Bug #16996]
- 11:34 AM Revision d094c3ef (git): Avoid rehashing in Hash#select/reject [Bug #16996]
-
- https://github.com/ruby/actions/runs/2137935523?check_suite_focus=true#step:9:562
```
1) Error:
TestIRB::TestHistory#test_history_concurrent_use:
Errno::EACCES: Permission denied @ dir_s_mkdir - /home/runner/.config/irb
/home/runne... -
- `$HOME/.config` is not writable on CI
because I think tests should not corrupt user's data.
And GitHub Actions CI sets `XDG_CONFIG_HOME`
since `Version: 20210309.1`.
https://github.com/ruby/actions/runs/2130811016?check_suite_focus=tru... -
- FWIW,
```ruby
# bug17725-test.rb
eval <<EOS
# encoding: ascii-8bit
MY_STRING = ''
EOS
MY_STRING + ''
String.prepend(Module.new)
class String
def + other
'blah blah'
end
end
p 'a' + 'b'
```
gives
```
$ ruby...