Activity
From 02/21/2021 to 02/27/2021
02/27/2021
-
11:07 PM Feature #17638: Support backtracing with the libbacktrace library
- The patch attached here is to be applied after the main patch and the patch in #note-1, and is for an experiment of backtracing on Cygwin. To make it work correctly, the use of `sigaltstack(2)` has to be disabled, and thus this is not fo...
-
- The patch attached here presents an alternative way of using libbacktrace, in which the return addresses are retrieved by `backtrace(3)` and passed to the libbacktrace functions `backtrace_syminfo` and `backtrace_pcinfo`. This patch has ...
-
06:58 PM Feature #17660: Expose information about which basic methods have been redefined
- Eregon (Benoit Daloze) wrote in #note-2:
> It sounds useful, +1 from me.
> ...
This sound good to me. I wasn't very happy with the name 😄
> Putting it under `RubyVM` increases the issue that `RubyVM` is becoming less and less CRuby-... -
06:52 PM Feature #17660: Expose information about which basic methods have been redefined
- Oh, IIUC, knowing if a particular method (basic or not) has been redefined is available in pure Ruby, but not the information about which methods are "basic" methods (for any given Ruby version).
-
04:36 PM Feature #17660: Expose information about which basic methods have been redefined
- @marcandre the information about redefined basic methods is not available to Ruby or C extensions AFAIK (since it is some kind of VM implementation detail).
I guess your reply reinforces my point that we should clarify this is only ab... -
- I don't object (actually I needed that method for tests in `backports` gem), but I wonder why a C method is preferable to a pure Ruby gem?
-
- It sounds useful, +1 from me.
I think we should clarify in the name that only redefined basic methods are reported, and not all redefined methods.
How about `redefined_basic_methods`?
Putting it under `RubyVM` increases the issue th... -
- I forgot to attach the patch, so here it is 😄
-
- I would like to tell if code is redefining methods that can impact
MRI's optimizations. This commit exposes which basic methods have been
redefined. For example:
```ruby
class Integer
def +(x); x ** self; end
end
p RubyVM.... -
- In the suggested pattern, the here document seems not highlighted nor auto-indented by Emacs Ruby Mode. Would you please also suggest the configuration of Emacs Ruby Mode for the suggested pattern?
-
- This heredoc pattern
```ruby
assert_ruby_status([], "#{<<-"begin;"}\n#{<<-'end;'}", bug)
begin;
exit("1" == Thread.start(1, &:to_s).value)
end;
```
completely breaks syntax highlighting in at least:
* GitHub: ... -
05:23 PM Feature #17663 (Open): Enumerator#with, an alternative to Enumerator#with_object
- **Enumerator#with** yields each element along with the arguments
``` ruby
class Enumerator
def with(*options)
return to_enum(:with, *options) unless defined? yield
each do |entry|
yield entry, *options
end
... - 04:42 PM Revision 5c907975 (git): * 2021-02-28 [ci skip]
-
-
- * [Feature #15752] A dedicated module for experimental features (eregon)
* I'd like to finish this discussion and then we can close it.
* matz said "we need to rewrite our programs when the feature graduated from the experimental s... -
- * [Misc #17662] The heredoc pattern used in tests does not syntax highlight correctly in many editors (eregon)
* Can we use something else in tests? -
-
08:54 AM Bug #17643: Ruby 3 embedded - no GC methods?
- Just following up. nobu any thoughts? I don't see any way of working around this currently when embedding Ruby.
-
06:01 AM Bug #17504: Allow UTC offset without colons per ISO-8601
- ruby_2_7 commit:190ffd8761bec206582095028e5752ae5ccd7587 merged revision(s) commit:f4be7a510eebbe6507ba41d138d7d252f4a68e90,commit:9441f3f97087a4325ee80911859d37da41fa5050.
-
-
- Added tests for Time#getlocal with UTC offset
---
test/ruby/test_time.rb | 8 ++++++++
1 file changed, 8 insertions(+)
Allow UTC offset without colons per ISO-8601 [Bug #17504]
---
tes... -
- Probably `'s|http://||'` to the reproducer?
-
- As reported here: https://twitter.com/asterite/status/1363487990203506689 when iterating through a file's contents with #each_byte, if the filehandle is closed inside of the block yielded to by #each byte, this condition is not detected,...
-
- A minor mod to the patch in #note-13 (due to an issue similar to Bug #17645):
```
--- a/addr2line.c
+++ b/addr2line.c
@@ -1463,7 +1463,7 @@
}
break;
case DW_RLE_base_add... -
- It seems that the `addr` argument for Cygwin's `munmap(2)` must be aligned to 64KB boundaries. A patch is attached to conform to this.
02/26/2021
-
11:07 PM Bug #4405 (Closed): WIN32OLE & Threads incompatible
- From my testing, this was fixed between Ruby 1.9.3 and Ruby 2.0, printing WIN32OLE object instead of raising an exception. It still works on Ruby 3.0, so I think this can be closed.
-
- I tried the example code in Ruby 2.6, Ruby 2.7, and Ruby 3.0. on Windows 10, and got the expected output each time (Internet Explorer opened), OK output on console. If you think this is still an issue with a supported version of Ruby an...
-
- I cannot reproduce this bug on Windows 10 using Ruby 1.9.3, Ruby 2.0, Ruby 2.1, or Ruby 3.0. Windows 7 is now out of support. If you think this is still an issue with a supported version of Ruby and Windows, please reopen.
-
- As Ruby 3.0 uses UTF-8 for ARGV, this is fixed.
With modified example:
```ruby
puts "Encoding of argument is reported as #{ARGV[0].encoding} and as #{ARGV[0].valid_encoding? ? "valid" : "invalid"}."
puts "Let us inspect the a-til... -
- As of Ruby 3.0, ARGV values are in UTF-8 encoding by default on Windows.
-
- As of Ruby 3.0, ENV values are now UTF-8 encoded on Windows.
-
- This definitely isn't a bug, and I don't think it's worth breaking backwards compatibility for this consistency, so I'm going to reject this. If you would still like the change made, please submit a pull request to https://github.com/ru...
-
- As of Ruby 3.0, I think this is fixed:
```
$ irb30
irb(main):001:0" x = "#{x\"}"
irb(main):002:0"
irb(main):003:0" }
irb(main):004:0" "
Traceback (most recent call last):
3: from /usr/local/bin/irb30:23:in `<main>'
... -
09:51 PM Revision dbea0be1 (git): [ruby/irb] Update help message for next context-mode of 4
- While here, fixing tab/space issues in help message, and sync
rdoc for IRB class to match the help message.
https://github.com/ruby/irb/commit/ef8e3901cc -
-
- This was fixed in Ruby 3.0, with the change of the default irb context mode from 3 to 4.
-
-
- fd0 (Daisuke Fujimura) wrote in #note-2:
> In case of `make btest`, test_massign.rb and test_thread.rb succeeded.
> ...
I think that defeats the purpose of the test. The test is specifically to test with the smallest possible machine... -
-
- This behavior seems to have been fixed after the release of Ruby 3.0. I'm guessing this fix has already been backported and will make Ruby 3.0.1, but @aycabta could probably confirm that.
-
-
-
- This fix was merged at commit:a74df67244199d1fd1f7a20b49dd5a096d2a13a2.
-
06:23 PM Bug #17659 (Closed): Ractor: can't call io/wait methods
- It seems that I can use IO.select inside a ractor, but not call IO.wait_writable, which seems odd.
```ruby
require "io/wait"
ractors = []
1.times do
ractors << Ractor.new do
$stdout.wait_writable(2) # this fails
# but ... -
- 05:59 PM Revision 3d8e373a (git): * 2021-02-27 [ci skip]
-
- This lets us cast a Fiddle::Function to a block, allowing is to write
things like:
```ruby
f = Fiddle::Function.new(@libc['strcpy'], [TYPE_VOIDP, TYPE_VOIDP], TYPE_VOIDP)
define_method :strcpy, &f
``` -
-
10:04 AM Bug #17658: DNS resolution failure with multiple named resolvers
- Fixing commit is below.
#12838 states that the problem is intermittent and due to duplicate responses. That's not what I have observed: I can consistently reproduce the problem. Can this one-line change + test please be back-ported to... -
- I tested ruby 3.0.0 and it works fine so I guess something got fixed:
```ruby
Resolv::DNS.new({nameserver: ['dns.google', 'one.one.one.one']}).getresources('example.com', Resolv::DNS::Resource::IN::A)
=> [#<Resolv::DNS::Resource::I... -
- ## Description
I created a `Resolv::DNS` resolver with two nameservers described using their domain names. Calling `#getresources` on this for an `A` or `NS` (and possibly other resource types) of domain `example.com` returns an empty... -
11:48 AM Bug #17657 (Rejected): Starting from ruby 2.3.0, LoadLibraryExA called in extension won't use PATH or current directory to find library and/or it's dependencies
-
11:13 AM Bug #17657: Starting from ruby 2.3.0, LoadLibraryExA called in extension won't use PATH or current directory to find library and/or it's dependencies
- Well, it turns out I did miss one thing
https://github.com/oneclick/rubyinstaller2/wiki/For-gem-developers#-dll-loading
Sorry, please close this issue. -
05:43 AM Bug #16842: `inspect` prints the UTF-8 character U+0085 (NEXT LINE) verbatim even though it is not printable
- Why U+0085 is categorized as `Print` in Ruby is historically Oniguruma treats as that.
https://moriyoshi.hatenablog.com/entry/20090307/1236410006
I'm neutral about the change, but I want the change should have detailed comment or lin... - 01:32 AM Revision 5c31a4b1 (git): * 2021-02-26 [ci skip]
-
01:32 AM Revision 46825a74 (git): Backport lib/reline, and lib/irb for 3.0.1 3rd (#4228)
- * [ruby/irb] Suppress error when File::ALT_SEPARATOR is nil
https://github.com/ruby/irb/commit/96accf3b95
* [ruby/irb] Suppress colorize on Windows tests
https://github.com/ruby/irb/commit/5be9354cf9
* [ruby/irb] The command "irb_inf... -
- Changes made for this issue seem to break the Cygwin builds (for both i686 and x86_64). A backtrace for `miniruby` (without any options) from GDB:
```
Thread 1 received signal SIGSEGV, Segmentation fault.
heap_page_allocate (objspace=... -
- This reverts commit a9920e7782f225b97e173a88640fe9e116b9964f.
02/25/2021
-
- Behavior here seems to be dependent on the encoding:
```
$ LC_ALL=C ruby -e "p 0x85.chr(Encoding::UTF_8).inspect.b"
"\"\\u0085\""
$ LC_ALL=en_US.UTF-8 ruby -e "p 0x85.chr(Encoding::UTF_8).inspect.b"
"\"\xC2\x85\""
```
I've s... -
- The original pull request was closed, but I committed a similar fix: https://github.com/ruby/net-ftp/pull/6
-
- @usa It looks like this hasn't yet been fixed in Ruby 2.6. Is it possible to fix this in Ruby 2.6 before Ruby 2.6 goes into security maintenance mode?
-
-
- Ruby 3.0 uses UTF-8 for ENV values on Windows by default, even if the code page is not UTF-8. So I think this and #16623 can be closed.
-
- A (revised) patch is attached to avoid segfaults with GCC's DWARF 5.
In summary, there are three changes:
(1) correct the interpretation of `DW_LNS_advance_pc` statements when the minimum instruction length is not equal to 1 (which... -
- https://github.com/ruby/reline/commit/462f971bd3
-
-
- I'm on windows 10 pro. The sample code runs successfully on ruby up to 2.2.5.
On newer versions I get "cannot load such file". The fallowing documentation lists PATH environment variable as one of the search paths, that are used to loc... - 07:02 PM Revision 04154b65 (git): * 2021-02-26 [ci skip]
-
07:01 PM Revision a9920e77 (git): Add tests for bug 17652
-
-
-
- I've merged the patch in the pull request after adding a test for it: https://github.com/ruby/cgi/pull/4
-
-
- Can you please test with the master branch to see if this issue has been resolved? If it still is present in the master branch, please try to develop a minimal self-contained reproducible example.
-
07:48 AM Bug #17655: Experiencing Repeated Segmentation Faults Using Puma with Ruby 3.0.0
- This reminds me #17536
-
- https://github.com/ruby/irb/commit/ab9852ccc5
-
07:26 AM Revision 294c244a (git): rb_random_int: ended before it begins
- It existed since f3d022543ef2afde3d53e7f6b3028eafe39d0ef4 until
96760236079b15674a6322a2ca41b1528b51afbd. No official releases included
the actual function. The declaration shall be deleted. -
07:10 AM Bug #17653 (Closed): SEGFAULT in ossl_ssl_read_internal
- vo.x (Vit Ondruch) wrote:
> ~~~
> ...
This sounds like the bug in Random fixed in master a while ago: https://github.com/ruby/ruby/commit/265c0022390e3dcd4ff692fc77d29b94e652c877
I'm attaching the commit for backporting to 3.0 since... -
- I added a pull request to fix this: https://github.com/ruby/ruby/pull/4223
02/24/2021
-
- The following is an example of C backtrace output on aarch64-linux, where `sig_do_nothing` is shown in spite of segfault:
```
-- C level backtrace information -------------------------------------------
/var/tmp/build.debug/aarch64.cl... -
10:53 PM Bug #17655: Experiencing Repeated Segmentation Faults Using Puma with Ruby 3.0.0
- This looks like the method which caused the seg fault on line 317
``` ruby
# ~/.rvm/gems/ruby-3.0.0/gems/actionpack-6.1.2.1/lib/action_dispatch/routing/route_set.rb
--316 def define_url_helper(mod, name, helper, url_str... -
- Rails -v 6.1.2.1
-
- Issue occurred with Puma and Ruby 3.0.0. I've attached the text scrollback from Puma, it's quite long.
-
- It seems this breaks tests on Solaris, so I'm reverting it until we
figure out the right fix.
http://rubyci.s3.amazonaws.com/solaris11-sunc/ruby-master/log/20210224T210007Z.fail.html.gz - 08:25 PM Revision f3c8e477 (git): * 2021-02-25 [ci skip]
-
-
-
-
06:37 PM Bug #17486: Build fails on darwin due to libtool being removed
- charlesbjohnson (Charles Johnson) wrote in #note-8:
> nobu (Nobuyoshi Nakada) wrote in #note-7:
> ...
Good news is that I was able to build 3.0.0. The culprit appeared to be that I'm using the GNU `coreutils` and related packages (ie. ... -
- nobu (Nobuyoshi Nakada) wrote in #note-7:
> Could you show mkmf.log file for a failed extension?
Here's what I have for `ext/bigdecimal/mkmf.log`: https://gist.github.com/charlesbjohnson/1b280cd5fe041824de68dd04bc6fafe1 -
- This has been accepted 🎉
Follow-up question: could we introduce this change in 3.0.x line? Otherwise we have to wait until 3.1 and many developers might resort to the `const_set` hack in the meantime... -
- ruby-doc.org is not an official Ruby site. They may need to update their version of rdoc, as this is related to a bug that was fixed in 2018. Both of these show up correctly on the official Ruby documentation site:
https://docs.ruby-... -
02:04 PM Bug #17654 (Third Party's Issue): doc: trailing comments
- Several doc pages show bits that should clearly not be there. For instance :
In https://ruby-doc.org/stdlib-3.0.0/libdoc/csv/rdoc/CSV.html you can read
```
frozen_string_literal: true
frozen_string_literal: true
```
In h... -
- I should also mention, that the failure typically happens [here](https://github.com/excon/excon/blob/master/tests/test_helper.rb#L94):
~~~
tests('response.body').returns("5000000") do
response = connection.request(:method => :post... -
- Trying to run [excon] test suite agains Ruby 3.0, it mysteriously [fails] from time to time. Digging deeper and executing the [Rack] server on background with debug option, I started to observer this error:
~~~
... snip ...
/usr/s... -
11:01 AM Revision 09f284c0 (git): Update bundled_gems
02/23/2021
-
11:51 PM Bug #17556: ruby 2.7.2 ::YAML.dump ArgumentError: invalid value for Integer(): "20210101_"
- Hello, when will this fix be available in the ruby 2.7 release branch?
-
10:49 PM Bug #17394: TCPServer is not thread safe on win32
- I've prepared backports for `ruby_3_0` and `ruby_2_7` on github, but `ruby_2_6` is not using github, so i am going to attach it here.
-
- Fix merged at commit:0d76636117c99921ac7c43293ba7962d22e72fbd .
-
-
04:10 PM Feature #17651: CSV::Row pattern matching
- Apologies this can be closed, I've opened an issue on the csv repository.
-
- I'd like to be able to use pattern matching with CSV parsing.
I've added the PR here: https://github.com/ruby/ruby/pull/4215. -
-
-
- # GitHub PR: ~~https://github.com/ruby/ruby/pull/4221~~ https://github.com/ruby/ruby/pull/4227
# Issue
GC compaction will crash on some pages due to a failing `mprotect` call. According to the `mprotect` documentation:
> POSIX s... -
-
- It looks like this was fixed in a different way by commit:3a888398a661d7dc3cbcc21b8983809905b07adb .
-
- @hsbt Does this error occur without `-j` (e.g. without JIT support)? Is it possible to provide a self contained example?
-
07:09 PM Revision 9d8c66fd (git): rb_fiber_terminate never returns
- 07:02 PM Revision 75fbea91 (git): * 2021-02-24 [ci skip]
-
- 19cc24b34b0490b7c2779eec521fe0089e05f183 and fixups.
-
05:14 PM Feature #13303: String#any? as !String#empty?
- Related to #17330 -> `non(&:empty?)`
-
- As ruby_set_debug_option() is called before ruby_sysinit(),
CRITICAL_SECTIONs are not initialized yet. -
- I don't think mixing Hash and Set is good at all. They have fundamentally different APIs.
-
-
-
-
- The main issue might be resolved by the following commit to GCC:
https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=25403c416e5f12d681d1fc45a8789d19ab40297f
(see also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84521#c29)
IMHO, the use ... -
-
-
07:46 AM Revision b956efdc (git): Drop obsoleted ci skip checks
- https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/
-
- Now that GitHub Actions always skips any job if [ci skip] is given
regardless of our CI config, we cannot merge such PRs like https://github.com/ruby/ruby/pull/4211
unless you're an admin.
https://github.blog/changelog/2021-02-08-github-... -
-
01:48 AM Revision 09c74a17 (git): [DOC] Fix copy+paste mistake [ci skip]
- It was introduced in commit 089b7a84606925e885fe91050483a352735aa91e .
-
12:23 AM Bug #17619: if false foo=42; end creates a foo local variable set to nil
- josh.cheek (Josh Cheek) wrote in #note-9:
> It's intentional. Eg what if you set the same variable in both branches? Then it would be clearer that you are expecting the variable to be visible outside the scope of the conditional.
> ...
I...
02/22/2021
-
- marcandre (Marc-Andre Lafortune) wrote in #note-31:
> I'm sorry, I am completely confused by this discussion, I can't make sense of it.
> ...
THIS.
Sets are in no way related to Hashes. The fact that they are/can be *implemented* a... -
- I submitted a pull request that should fix this: https://github.com/ruby/ruby/pull/4213
-
- mame (Yusuke Endoh) wrote in #note-9:
> I expect that `ary + set` return a Set, not an Array, unless it raises an exception.
> ...
I found implicit conversions of values in K&R to be an abomination BEFORE I became aware of the many, ma... -
10:58 PM Bug #17590 (Closed): `M.prepend M` has hidden side effect
- Applied in changeset commit:git|58e82206057f2a1644b69ac3631016009ae48590.
----------
Check for cyclic prepend before making origin
It's important to only make the origin when the prepend goes
through, as the precense of the origin info... - 10:58 PM Revision 7d4a3ac0 (git): * 2021-02-23 [ci skip]
-
- It's important to only make the origin when the prepend goes
through, as the precense of the origin informs whether to do an
origin backfill.
This plus 2d877327e fix [Bug #17590]. -
- Added fix https://github.com/ruby/ruby/pull/4212
-
- PR merged at commit:3ee4fa9491d0b2b5fb40deea8e93e797924de789.
-
-
- It's commit:69ec3f70fab0c1c537c68fb135cc315181b1d750, and had been reverted already soon.
-
- There is no feedback over the 1year.
-
10:56 AM Bug #17599: [BUG] try to mark T_NONE object when object allocation tracing is enabled
- Ok, so @tenderlove identified https://github.com/ruby/ruby/commit/100e464bee46ae71ef048ed85a9bdd012935a3f7 as the second commit that need to be backported to fix this issue.
-
- As final path name includes the namespace prefix, so expand room
for it in path name buffer. -
- I am sure that the behavior changed and I'd like to better understand why. Unfortunately, the analysis is beyond my knowledge. Changing Childprocess implementation might be the right solution after all, but not without understanding the ...
-
06:11 AM Feature #13303: String#any? as !String#empty?
- "#any?" is preferred, since the same method name is harder to forget and less confusing.
If the Array, Hash and String will have new methods, i propose "#having?" as the new method name.
-
-
03:19 AM Revision a7dda449 (git): [ruby/reline] fix Reline::Windows.getconsolemode buffer
- use double quotes to properly convert the \000 escape sequence.
https://github.com/ruby/reline/commit/236dfe5683 -
- rb_cData is deprecated and the characteristic alloc_func was already
removed in ruby-3.0. So this updates the recommendation accordingly.
It also adds fdbm_alloc() in order to show the allocation process
and to gives TypedData_Make_Stru... -
- Japanese reference manual mentions treatment `"\0"`.
(for example: https://docs.ruby-lang.org/ja/latest/method/String/i/strip.html )
If this will backport to released versions, it affects version branching in Japanese reference manua... -
12:15 AM Feature #16428: Add Array#uniq?, Enumerable#uniq?
- I was just going to post this suggestion, but saw that it was already here.
`uniq?` could be helpful, for example, where you are loading objects from an external source (e.g. from JSON or YAML), and you need to verify that the objects...
02/21/2021
- 09:33 PM Revision 431f531b (git): * 2021-02-22 [ci skip]
-
09:33 PM Revision 3ee4fa94 (git): Send :fiber_switch event for almost every fiber_switch (#4207)
- With this patch, TracePoint receives a `:fiber_switch` event for
_almost_ every fiber switch. Previously, it would not be sent when an
exception was going to be raised. Now the event should only be blockable
by an interrupt (including `... -
- I revisited this issue, and probably found another workaround: to add `volatile` qualifier to the `ec` argument of the functions `rb_ec_tag_jump` and `vm_exec`, as in the attached patch. I have no idea exactly what it means, and I don't ...
-
05:34 PM Bug #17649: `defined?` invokes method once for each syntactic element around it
- The reason seems to be because the generated iseq doesn't cache the intermediate calculations:
```sh
$ ruby -e 'puts RubyVM::InstructionSequence.new("defined? a.b.c.d.e.f").disasm'
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(1,... -
- I should have clarified my expectation: On the ones that call `defined?` I expected the number of calls to be 1 less than the ones that don't call `defined?`
-
- Honestly, I was surprised `defined?` works with expressions at all. I wouldn't object to this feature being removed, it leads to strange situations where it invokes methods, like below, and silently returns wrong results, if any of the m...
-
- It seems to me the `:fiber_switch` event should be raised for *every* fiber switch, unless there's some very important reason not to, e.g. maybe it makes sense to skip the event when a fiber terminates with a fatal error. In addition to...
-
- This workaround seems not necessary. Compilers seem very much aware of this situation. So please reject it. Sorry for the confusion.
-
- With RubyInstaller's I got the following result in the Command Prompt of Windows 10:
```
C:\Ruby30-x64\bin>irb
irb(main):001:0> Dir.pwd
=> "C:/Ruby30-x64/bin"
irb(main):002:0> File.exist?("C:/Ruby30-x64")
=> true
irb(main):003:0> ... -
- It's intentional. Eg what if you set the same variable in both branches? Then it would be clearer that you are expecting the variable to be visible outside the scope of the conditional.
Contrived code example:
```ruby
if eligible?...