Activity
From 12/28/2020 to 01/03/2021
01/03/2021
-
10:45 PM Feature #17496: Add constant Math::TAU
- > you just need to comment on https://bugs.ruby-lang.org/issues/17480 then, copying the format of the other comments.
Thanks. Done.
> ...
As with ``PI``, the Newtonian view of reality had an entrenched pedagogical, professional, cultur... -
08:05 PM Bug #17506 (Closed): Ractor isolation broken by ThreadGroup
- Ractors currently share the ThreadGroup.
This doesn't seem very useful as there is no possible communication between the Threads of different Ractors.
It is also an isolation error:
```ruby
ThreadGroup.attr_accessor :foo
var = T... -
08:01 PM Bug #17497: Ractor performance issue
- 10 core i9. I've set up enough systems in my life (I used DOS); prefer new systems to last a while...
-
- Thanks for running this on other platforms.
From the numbers, it looks like you are running on an 8-core machine, right? If so, the "fib" and "sleep" numbers are what should be expected, but "cpu" is 3-5x slower on Ractor when it shou... -
- Using various 2021-01-03 versions of master, got the following times, a few were averaged by eye:
```
—————————— Windows 10 mingw ——————————
fib | cpu | sleep
native 41 ms | 940 ms | 220 ms
ruby 345 ms | 205 ... -
- Is there a circumstance where `Thread#group` could actually be `nil`?
The documentation says so, there seems to be source code for this, but I can find no test or RubySpec for this and I don't see anywhere in the `ThreadGroup` API tha... -
07:35 PM Feature #6362: Modular exponentiation/inverse
- As of Python 3.8, modular inverses are supported by Python's pow function, which can take a mod argument, just like Ruby's.
https://docs.python.org/3/library/functions.html#pow
I therefore propose to add this feature as
```
n.pow(-1, m... -
03:36 PM Bug #17504 (Closed): Allow UTC offset without colons per ISO-8601
- Although ISO-8601 allows UTC offset to be `+HHMM` as well as `+HH:MM`, `Time.new`, `Time#getlocal` etc reject that format as invalid.
I think this is a bug, especially as far as even `Time#inspect` uses it.
https://github.com/ruby/ru... -
- * [Feature #12607] Ruby needs an atomic integer (@shyouhei)
* dummy comment
* [Feature #17099] Remove boolean argument and warning from `Module#attr` (S_H_)
* It has been warned since 1.9.1.
* [Feature #17485] Keyword argument for ti... -
- 02:38 PM Revision 0644f466 (git): Include RUBY_EXTCONF_H if available
-
01:28 PM Feature #17490: Rename RubyVM::MJIT to RubyVM::JIT
- JIT just means "Just-in-Time", so actually to be grammatically correct I guess the release note should either refer to "MJIT" (a proper noun) or "the JIT compiler (bundled with Ruby)".
Either way, I think to make it clear in the release... -
12:15 PM Bug #17503: Typing an invalid percent string crashes irb
- https://github.com/ruby/irb/issues/162
Probably I met the same problem and I reported it as the issue. -
11:43 AM Bug #17503 (Closed): Typing an invalid percent string crashes irb
- 1. Start `irb`.
2. Try typing in `%abc`. Keep typing in alphanumeric characters if it hasn't crashed yet.
3. irb crashes with the following error message:
```
/usr/local/lib/ruby/3.0.0/reline/unicode.rb:124:in `calculate_width': un... -
- https://github.com/ruby/timeout/commit/f9a9758a41
-
08:05 AM Revision 4724bf85 (git): Avoid hanging on --jit-wait after MJIT.pause
- When a worker is stopped, nobody will JIT a method for you.
-
- First off, you may be interested in reading [Feature #16254] in case you haven't. (Note: `__intrinsitc__` was renamed to `__builtin_` first, and then renamed again to `Primitive.`)
Let me separately discuss multiple independent topics y... - 02:56 AM Revision 09ec8d68 (git): * 2021-01-03 [ci skip]
- 02:55 AM Revision a495cb2f (git): NEWS-3.0.0: backquote a few code related words. [doc]
- 02:54 AM Revision fdf35399 (git): NEWS: We have links now, and there is no changelog anymore [doc]
-
- First, let's make it clear that it is not acceptable to break backwards compatibility in such an extreme manner. The default can not change.
The caveats of `OpenStruct` have been made more explicit in 3.0 and I am still curious as to ...
01/02/2021
-
- Some features are coded in a mix of Ruby and C (e.g. ractor.rb).
External gems don't have access to this. The C-API to deal with keyword parameters is also very verbose the parsing and the engine does not know it.
Moreover, some op... -
- I get your points. Nothing is technically wrong in what you're saying, and as a committer like you it's easier to interpret MJIT.
But I mean, I assume we're not writing a release note for people like us who can just read details in NEWS... -
- > ## Release notes
> ...
Not really, I'm saying the "JIT" is just unclear, "which JIT is it?".
The 3.0.0 release notes are hard to read for me because they mix MJIT and JIT.
If we use MJIT everywhere in that note, then I think it is very... -
- Now some discussions seem to be mixed, so let's sort them out:
## RubyVM::
> I tried to document it. I don't think it's good enough, many people don't read class documentation.
If e.g., they see RubyVM::AbstractSyntaxTree in a blog ... -
03:29 PM Bug #17501 (Closed): TestNetHTTPS#test_get CI failure
- しばらく前から snapshot tarball の macos-latest で発生している `TestNetHTTPS#test_get` の failure ですが、手元の macOS Catalina 10.15.7 に homebrew で入れた `openssl@1.1: stable 1.1.1i (bottled) [keg-only]` の環境では SERVER_CERT, CA_CERT の順番を入れ替えると通るようになりました。
他の環境では... -
11:12 AM Feature #17500 (Rejected): Move RubyVM::* to ExperimentalFeatures
- I am not opposed to renaming `RubyVM` module for the reason @eregon stated. But I am strongly against renaming it to `ExperimentalFeatures` or whatever means **experimental**. Users are forced to rewrite their code when the feature becom...
-
- I had a vague original idea for this proposal, which extends the Hash class generically.
First I though about case-insensitive string hashes, it had been able by using `$=` in old days.
The special variable was removed, still there are... -
09:46 AM Feature #17330: Object#non
- I think the proposed feature would be useful, but I feel that your focus on use cases with a negative predicate is artificial. Positive predicates should have as many corresponding use cases. And since negation is always one step more co...
-
- Applied in changeset commit:git|68ea7720b367fe84da601cdbc61cb0d651c3221b.
----------
NEWS: [Feature #17312] [ci skip] -
-
08:27 AM Revision b8d33df1 (git): Add Enumerable#compact and Enumerator::Lazy#compact
-
- * [Misc #0] Comment Deadline (marcandre)
* Please make comment deadline closer to meetings (1 or 2 days, not 7).
-
- * [Feature #17496] Add constant `Math::TAU` (jzakiya)
* Reconsider adding to Ruby core, as more languages have. Increased adoption|use since last consideration. It has become "time proven", https://bugs.ruby-lang.org/issues/4897#not... -
- The count of rb_alloc_tmp_buffer_with_count is the allocation size
counted in VALUE size but not in the requested element size.
Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
Co-authored-by: Koichi Sasada <ko1@atdot.net> -
- Get rid of "present but cannot be compiled" headers, on some
multi-architecture platforms. - 03:06 AM Revision a6bbba11 (git): Avoid to use __builtin_clzl in SPARC Solaris
-
- I simply can't tell which of compare-ruby and built-ruby is what.
-
02:39 AM Feature #17498 (Closed): Improve performance some Float methods
- Applied in changeset commit:git|daec5f9edcfbf98b10a4bfc1aa501c9ac2c64841.
----------
Improve performance some Float methods [Feature #17498] (#4018) -
- 01:18 AM Revision ef6ab776 (git): Add __x86_64__ guard to include x86intrin.h
-
01/01/2021
-
- > it is meant as experimental unstable MRI-specific API
I think it means only MRI-specific API, while some of it may be experimental and/or unstable. For example, RubyVM::InstructionSequence will continue to be MRI-specific, but I don... -
- Migration plan:
* In Ruby 3.1: define `ExperimentalFeatures`, add the same constants & methods as `RubyVM` under it, and deprecate the `RubyVM` constant.
User code can do `ExperimentalFeatures = RubyVM unless defined?(Experimenta... -
- `RubyVM` is a trap:
* Users will think from the name it's some official blessed API when it is meant as experimental unstable MRI-specific APIs (the complete opposite).
* CRuby developers seem to see it as an experimental module to put... -
10:34 PM Feature #17496: Add constant Math::TAU
- I also don't understand why `Math::TAU` needs to be added to Ruby, even though I am familiar with the manifesto and think it might have a merit. However, it is just a redefinition of a basic mathematical constant that doesn't bring much ...
-
10:14 PM Feature #17496: Add constant Math::TAU
- @jzakiya you just need to comment on https://bugs.ruby-lang.org/issues/17480 then, copying the format of the other comments.
-
10:12 PM Feature #17496 (Open): Add constant Math::TAU
- Personally, I don't think that anything significant has changed in the last three years this area. And the comparison of Tau vs Pi to Relativity vs Newtonian Mechanics is laughable.
However, I also don't want to be the one to stop de... -
- Well since I don't have the power to re``Open`` it, will you then see that it is?
Otherwise, this is just going around in an infinite circle, and I don't need the new year starting out like this.
Since you know what needs to be don... -
- > I request that whoever has the power to request he review this issue again now do that too.
That's done by adding to the list of issues to be considered I linked - when you have this as not rejected you can add to there. -
- OK, well then I request this issue be reclassified as ``Open``, by whoever has the power to do that.
Also, as it seems Matz's last response to a similar request was over 3 years ago, I request that whoever has the power to request he ... -
- Ok well this issue is currently marked rejected. You need to convince someone to change that first. Then you need to add it to the list of issues to be considered by Matz this month https://bugs.ruby-lang.org/issues/17480.
-
- > I don't think this manifesto helps itself by conflating a serious argument with a lot of silliness and jokes. You can see how people react to it by wondering if they're being trolled.
Well, I don't see anything specific in the Manif... -
- I don't think this manifesto helps itself by conflating a serious argument with a lot of silliness and jokes. You can see how people react to it by wondering if they're being trolled.
-
- FYI.
Yesterday (the last day of 2020) before I created this issue to include ``TAU`` in ``Ruby``, literally seconds before, I opened the exact same request in ``Crystal``, as ``Ruby|Crystal`` are my two favorite languages.
After on... -
05:04 PM Feature #17496: Add constant Math::TAU
- Almost 25 years ago I started my computer career with 3D programming. Very low level to that times, but using a lot of trigonometric computations. Using PI always felt like something half done. It's strange to tell the computer it should...
-
- This is a very serious proposal, and ``TAU`` is a very serious concept - the unit turn.
As Michael Hartl raises, trying to get people to accept ``TAU`` as better than ``PI`` is more about emotional attachment to a familiar concept, th... -
- It's difficult to work out if this is a genuine proposal or a meme.
Surely Jabari is joking when they say 'you must find your own way to acceptance, because others already have'? Is this a mathematical argument or a sort of play on cu... -
- To help answer this question,
> IMO, the sufficient condition is that it appears in some major textbooks for school.
and this,
> ...
I reviewed a couple of the ``TAU`` videos by Micheal Hartl, the author of ``The TAU Manifesto``... -
- > So, I want to know how many mathematicians accept such tau. Do you know how many academic papers that uses tau as the circle constant have been published so far?
How can anyone ever empirically answer these question? And why should th... -
02:41 AM Feature #17496: Add constant Math::TAU
- At least Julia doesn't have `tau` in its core now. There is Tau.jl, but it isn't a standard library. Following Julia's stance to `tau`, we can say that it is enough by providing a gem to define `Math::TAU` for now.
I'd like to know ... -
02:14 AM Feature #17496: Add constant Math::TAU
- jzakiya (Jabari Zakiya) wrote in #note-4:
> Well, Python3 added it, so when do you (empirically?, subjectively?) establish it's become ``time-proven``?
IMO, the sufficient condition is that it appears in some major textbooks for school. - 04:03 PM Revision 830afd94 (git): [ruby/bigdecimal] Update depend
- 03:54 PM Revision c2c01475 (git): [ruby/bigdecimal] Fix test for Ruby 2.4
- Ruby 2.4 does not have RbConfig::LIMITS.
https://github.com/ruby/bigdecimal/commit/c8087523b0 - 03:54 PM Revision 448a67cd (git): [ruby/bigdecimal] Implement special conversions for 64-bit integers
- This change improves the conversion speed from small integers.
```
Comparison:
big_n9
master: 4003688.9 i/s
bigdecimal 3.0.0: 1270551.0 i/s - 3.15x slower
big_... - 03:46 PM Revision 4730efdd (git): * 2021-01-02 [ci skip]
- 03:30 PM Revision 5ee6830a (git): [ruby/bigdecimal] Fix test_limit
- Keep the default value of BigDecimal.limit by BigDecimal.save_limit
to avoid failures of the other test methods due to the unexpected limit.
https://github.com/ruby/bigdecimal/commit/bdc1cc6585 -
- dgutov (Dmitry Gutov) wrote in #note-25:
> It's not like the new syntax makes anything possible that a simple assignment does not.
It does. It is now a pattern match, not just a rightward assignment:
```ruby
{x: 1, y: 2} => {x:}
... -
03:03 PM Feature #15921: R-assign (rightward-assignment) operator
- This is not as bad as the "pipeline operator" (which didn't do what its name said), but still, why add this?
It's not like the new syntax makes anything possible that a simple assignment does not.
The "method chains" example is per... -
-
- * [Feature #17500] Move RubyVM::* to ExperimentalFeatures (eregon)
* I think this is the best solution, for everyone. Could matz and ruby-core agree to this? -
- * [Misc #17499] Documentation backporting (zverok)
* Address systematic lack of docs at docs.ruby-lang.org
* [Bug #16497] StringIO#internal_encoding is broken (more severely in 2.7) (zverok)
* Still is, as of 3.0.0
* [Feature #17407... -
- FYI, I filed #17500 regarding RubyVM.
I think `ExperimentalFeatures::JIT` would be fine if we accept that issue, and e.g. other Rubies might implement `ExperimentalFeatures::JIT.enabled?` then, which makes sense to me. -
- k0kubun (Takashi Kokubun) wrote in #note-4:
> Didn't you clarify it by yourself at [Feature #15743]? The person who wrote the line that nobu quoted was you. You made it pretty clear that `RubyVM::MJIT` doesn't need to exist in other imp... -
- I recently noticed that the documentation created after `x.y` release (even 1 day after) never reflected at `docs.ruby-lang.org/<x.y>.0/`.
In discussion [here](https://github.com/ruby/docs.ruby-lang.org/issues/111) I was educated by @... -
- hsbt (Hiroshi SHIBATA) wrote in #note-9:
> I'm not sure how embedded pure-Ruby implementation to core classes. The above request is the different request.
It's also related, if the decision was to move all of Pathname to C (due to so... -
07:34 AM Bug #17494: ruby is hanged when using activesupport + rspec + rspec-parameterized
- Looks like this behavior has been triggered by https://github.com/ruby/ruby/commit/b9007b6c548f91e88fd3f2ffa23de740431fa969
* Created one file repro named `rep17494.rb` by adding `require "rspec/autorun"`
```
require "bundler/inli... -
- Improve performance some Float methods(write in Ruby)
benchmark:
```yml
prelude: |
flo = 4.2
benchmark:
to_f: |
flo.to_f
abs: |
flo.abs
magnitude: |
flo.magnitude
-@: |
-flo
zero?: |
flo... -
- Applied in changeset commit:git|ab32e98f984318f1074c6e39b8f2f04266a1224b.
----------
Added AST assertions for method definition arguments [Bug #17495] -
-
-
- Problem
===
Arguments information is missing for endless method without parens.
For example:
```ruby
# ok
pp RubyVM::AbstractSyntaxTree.parse(<<~RUBY).children[2]
def x() = 42
RUBY
# => (DEFN@1:0-1:12
# mid: :x
# body:
# ...
12/31/2020
-
10:55 PM Revision 3d7f7180 (git): Remove unused file
-
- From that post 3 years ago.
> For the time being, use math-tau gem.
> ...
Well, Python3 added it, so when do you (empirically?, subjectively?) establish it's become ``time-proven``?
How many other language adoptions does it take (oh bt... -
- Relevant context is probably Matz's reason for rejection and criteria for reconsidering.
https://bugs.ruby-lang.org/issues/4897#note-41 -
- Well, I guess this regresses to a philosophical|religious issue, it's obviously not technical. :-(
But how can adding ``TAU`` in anyway hurt Ruby?
A short list of languages I know of which now include ``TAU``:
D
C# (.NET)
F#
Nim
Zig
Ru... -
- jzakiya (Jabari Zakiya) wrote:
> Excuse me if this has been brought up before.
It has been brought up before, by you in #13694, which was itself a duplicate of #4897. I'm rejecting this as a duplicate. However, if you think circumst... -
- Excuse me if this has been brought up before.
This is a simple proposal to add the math constant ``Math::TAU`` = 2*``Math::PI``.
See: https://tauday.com/
``TAU`` has been included in a growing number of languages (Rust, Python3,... -
- There's a strange performance issue with Ractor (at least on MacOS, didn't run on other OS).
I ran a benchmark doing 3 different types of work:
* "fib": method calls (naive fibonacci calculation)
* "cpu": `(0...1000).inject(:+)`
* ... -
Problem
===
Arguments information is missing for endless method without parens.
For example:
```ruby
# ok
pp RubyVM::AbstractSyntaxTree.parse(<<~RUBY).children[2]
def x() = 42
RUBY
# => (DEFN@1:0-1:12
# mid: :x
# ...- 03:58 PM Revision 48cf548b (git): * 2021-01-01 [ci skip]
-
-
02:18 PM Bug #17491: `./configure' unsuccessful on Android NDK cross-build
- Thanks for the comment.
A patch is attached to solve the problem. -
- Currently, Ruby does not support Android officially. A patch is welcome.
I'm experimentally maintaining a CI on Android/Termux (http://rubyci.s3.amazonaws.com/android29-x86_64/ruby-master/recent.html), and it is only a test environmen... -
11:47 AM Bug #17494 (Closed): ruby is hanged when using activesupport + rspec + rspec-parameterized
- # Example code
## Gemfile
```ruby
# frozen_string_literal: true
source "https://rubygems.org"
git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
gem "activesupport", "6.1.0"
gem "rspec", "3.10.0"
gem "rspe... -
09:34 AM Revision d0693391 (git): merge revision(s) ed549f80b645aafd62376f65c3a27b66bafa2a38,eff0c5bf2ad47d10a440c5211be5eddb3bbf4028,f6b6a7ad345c50eeb3f7206ceabdf41ba94b7d85,5b48686691c2443d8d7113e593494c4d9302da0e,2af4c1fc5b19fc96203c2d7e917e689510d3527e,c9213aa864fb8527388679c21f1ea8ce129e2f1a,224f29c8e92094af10bc666c474b81a3545d6adf:
- spec/ruby/core/process/clock_getres_spec.rb: skip on Android
in the same way as FreeBSD and OpenBSD.
I guess that the spec makes too strong assumption.
Try to avoid random failures on clock_getres_spec.rb
... -
09:22 AM Feature #17473: Make Pathname to embedded class of Ruby
- hsbt (Hiroshi SHIBATA) wrote in #note-9:
> I'm not sure how embedded pure-Ruby implementation to core classes. The above request is the different request.
I support making Pathname part of core Ruby. It's an extremely convenient li... -
12:01 AM Feature #17473: Make Pathname to embedded class of Ruby
- >Then, we could share more of Pathname between Ruby implementations, and avoid maintaining both a Ruby and C version.
I'm not sure how embedded pure-Ruby implementation to core classes. The above request is the different request. -
-
-
-
-
- I'm +1 to rename it.
-
- > If we'd consider RubyVM is CRuby-specific, then it seems fine.
> ...
Didn't you clarify it by yourself at [Feature #15743]? The person who wrote the line that nobu quoted was you. You made it pretty clear that `RubyVM::MJIT` doesn't ne... -
- ruby_2_7 5cbba4d6005a03914fc47e7a65ae5b6ef76c8e29 merged revision(s) 1ca9facab6c85264168b4c0a18c24f489cabcc9f.
-
- Add monitor to document files
-
- ruby_2_7 9eff912943a71745087ea4ae892774e33bd2e8ca merged revision(s) 8b0dc77a621ded75f72486c33f55404ce73f00d7.
-
- configure.ac: Bump the size of sigaltstack
The RubyVM uses C macro defines to feature detect whether
`backtrace(2)` support is available, and if so it includes C level backtraces
when the RubyVM itself crashes.
... -
- ruby_2_7 16930b254b4e5397759d6b42845b495041b71321 merged revision(s) be9dbe1c3eb4bb4cab0bdc42a91ef425bb1eaddd.
-
- Fix pthread_setname_np arguments on NetBSD
The previous attempt to fix this in
b87df1bf243074edb2e6cc8a24bc00df81cebf3c reversed the argument
order instead of just fixing the quote escaping.
From Takahir... -
- Thank you for ping me. I backported f8b4340f into ruby_2_7 at 27fca66207f2c35f2f44f6a7cbbe6fd153546082.
-
06:30 AM Bug #17493 (Closed): Calling Reline::Unicode.calculate_width appears to lock up when called from emacs or if output is redirected
- In https://github.com/ruby/reline/pull/224 there is a test program
```
require "reline"
p Reline::Unicode.calculate_width("√")
```
as a test case for bug #17405. This program hangs when called from an emacs shell.
The prob... -
- Implements [Feature #16378]
-
-
-
- Use $GITHUB_ENV instead of set-env
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ -
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> Hello, I cannot reproduce this on any of `ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux]` compiled using {clang-{3,4,5,6,7,8,9,10,11,12),gcc-{4,5,6,7,8,9,10}} on my Linux box. ... -
- Applied in changeset commit:git|20a8425aa0f9a947e72b06cbd3a2afe9674dd18f.
----------
Make any hash values fixable [Bug #17488]
As hnum is an unsigned st_index_t, the result of RSHIFT may not be
in the fixable range.
Co-authored-by: Ne... -
-
- Get rid of duplicate attributes, which may be warned or ignored
except for the first. -
- As hnum is an unsigned st_index_t, the result of RSHIFT may not be
in the fixable range.
Co-authored-by: NeoCat <neocat@neocat.jp> -
- Sorry not to have checked back recently. The patch mentioned above works great for me.
I doubt if this is required now but here it is:
irb(main):001:0> irb_info
=>
Ruby version: 2.7.2
IRB version: irb 1.2.6 (2020-09-14)
InputMeth...
12/30/2020
-
- When using the debugger, as in ruby -r debug, it seems that breakpoints sometimes are honoured and sometimes not. It turns out that it matters how the program is invoked.
For example, when debugging test.rb,
if invoked as
ruby -... -
11:46 PM Bug #17486: Build fails on darwin due to libtool being removed
- I tried the following on a Macbook Pro with Catalina and the error was still present.
```
$ sudo rm -rf /Library/Developer/CommandLineTools
$ xcode-select --install
$ sudo xcode-select -s /Library/Developer/CommandLineTools
```
-
- FYI: https://github.com/rbenv/ruby-build/issues/1505#issuecomment-752274233
-
11:28 PM Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
- Thanks for the followup on this issue. However, was the fix ever released?
I can still reproduce this issue on the following ruby versions, using the grpc gem at version 1.34.0:
```
$ ruby -v
ruby 2.6.6p146 (2020-03-31 revision 6... -
- Eregon (Benoit Daloze) wrote in #note-2:
> If we'd consider RubyVM is CRuby-specific, then it seems fine.
Yes.
commit:39a43d9cd09f
```
/*
* Document-class: RubyVM
*
* The RubyVM module only exists on MRI. +RubyVM+ is... -
- If we'd consider RubyVM is CRuby-specific, then it seems fine.
However, that's rather unclear, and then the question is what should other Ruby implementations should do `RubyVM::MJIT` and its methods?
(other Ruby implementations might ... -
- ## Background
These days it's sometimes said that CRuby may add another lightweight JIT. Leaving `RubyVM::MJIT` under such a situation might imply `RubyVM::MJIT` will not impact the future JIT, but I think `MJIT.pause`/`MJIT.resume` sho... -
09:24 PM Bug #17488: Regression in Ruby 3: Hash#key? is non-deterministic when argument uses DelegateClass
- I have confirmed this too in `ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux]` built with `gcc (Debian 8.3.0-6) 8.3.0`.
And also confirmed that this PR fixes the issue:
https://github.com/ruby/ruby/pull/4014 -
- On my mac pro (High Sierra) too:
```
$ clang --version
Apple LLVM version 10.0.0 (clang-1000.11.45.2)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Volumes/Media/Applications/Xcode.app/Contents/Developer/To... -
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> Also I want to know your `clang --version`.
```
$ clang --version
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: ... -
03:42 PM Bug #17488 (Feedback): Regression in Ruby 3: Hash#key? is non-deterministic when argument uses DelegateClass
- Hello, I cannot reproduce this on any of `ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux]` compiled using {clang-{3,4,5,6,7,8,9,10,11,12),gcc-{4,5,6,7,8,9,10}} on my Linux box. Maybe an XCode glitch I suspect?
I have jus... -
-
06:46 PM Feature #17475: Implement arguments forwarding for blocks
- Found it, duplicate of rejected #16605. Sorry for the noise, can be closed/rejected.
-
- We have no such command as `getprop` in our Android NDK cross-build environment, and so `./configure` says
```
checking whether it is Android... yes
checking for Android API version... ./configure: line 9108: getprop: command not foun... - 05:19 PM Revision b2030d4d (git): * 2020-12-31 [ci skip]
- 05:05 PM Revision a8014dae (git): [ruby/bigdecimal] Refactor object allocation
- https://github.com/ruby/bigdecimal/commit/271cebe567
- 05:04 PM Revision 4569e465 (git): [ruby/bigdecimal] Remove ToValue
- https://github.com/ruby/bigdecimal/commit/97e9feeebd
-
- shyouhei (Shyouhei Urabe) wrote in #note-7:
> JFYI pathname was born as a pure-ruby library, then was eventually translated into C (in commit:4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf). Don't know the reason behind that move though. @a... -
- JFYI pathname was born as a pure-ruby library, then was eventually translated into C (in commit:4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf). Don't know the reason behind that move though. @akr do you remember?
-
- * DECLARE_DEPRECATED_FEATURE with RBIMPL_ATTR_DEPRECATED_SINCE
* DECLARE_DEPRECATED_INTERNAL_FEATURE with RBIMPL_ATTR_INTERNAL
And moved function declarations outside both. -
07:42 AM Feature #17316: On memoization
- IMO there should be an operator in the language directly to keep it more dry.
```ruby
def my_method # current implementation
return @cache if defined? @cache
@cache = some_heavy_calculation
end
def my_new_method
@cac... -
- `mjit_valid_class_serial_p` has no longer been used since b9007b6c548.
- 06:25 AM Revision 11b8bb99 (git): Minor grammar fix in String#chomp documentation
-
- for random hangs like:
http://ci.rvm.jp/results/trunk-mjit-wait@phosphorus-docker/3302796
http://ci.rvm.jp/results/trunk-mjit-wait@phosphorus-docker/3302188
http://ci.rvm.jp/results/trunk-mjit-wait@phosphorus-docker/3301293 -
- * [Feature #16806] `Struct#initialize` accepts keyword arguments too by default (k0kubun)
* Is there any update on kwargs since [the last discussion](https://github.com/ruby/dev-meeting-log/blob/master/DevelopersMeeting20200514Japan.md... -
- for failures like:
http://ci.rvm.jp/logfiles/brlog.trunk-mjit-wait.20201229-130509
http://ci.rvm.jp/logfiles/brlog.trunk-mjit-wait.20201229-165132
http://ci.rvm.jp/logfiles/brlog.trunk-mjit-wait.20201228-015519
12/29/2020
-
08:49 PM Feature #16746: Endless method definition
- I haven't seen it mentioned in the comments so I just wanted to point out that the regular method-definition syntax doesn't require semicolons, and is very close to this experiment, given the parentheses are mandatory:
``` ruby
def fib(... -
- I believe that `HashWithIndifferentAccess` is one of the very false ideas in Rails -- and that as of today, it is a more or less common understanding in the community.
The distinction of Symbol (as a controlled internal name) and Str... - 03:46 PM Revision c550b75c (git): * 2020-12-30 [ci skip]
-
03:23 PM Feature #17471: send_if method for improved conditional chaining
- osyo (manga osyo) wrote in #note-1:
```ruby
puts number.tap { break _1 * 2 if _1 > 5 }.send(:-, 1)
puts %w(Merry Christmas).tap { break _1.map(&:upcase) if answer == 'y' }.join(' ')
```
Hello and thanks for sharing this Ruby idiom... - 03:22 PM Revision 8d93c1e7 (git): [ruby/bigdecimal] Remove VP_EXCEPTION_MEMORY
- It is no longer used due to the previous commit.
https://github.com/ruby/bigdecimal/commit/7d463f802b - 03:22 PM Revision 086f3f18 (git): [ruby/bigdecimal] Remove needless pointer checks
- xmalloc and xrealloc return non-NULL pointers or raise memory error.
https://github.com/ruby/bigdecimal/commit/507f0a6a64 -
- For some external reasons, e.g. Bison 3.5.91, some commits need to
be applied retroactively in order to pass builds. -
- At b958e2add835d62c0a62edaf9a23ecbbd70a3635
-
09:12 AM Bug #17477: Ractor and pp incompatibility
- marcandre (Marc-Andre Lafortune) wrote in #note-4:
> I wrote a similar opinion to Martin Dürst's in #17420. I propose that we comment there (simply because the issue is older and more general)
Thanks, I wasn't aware of #17420. Should... -
- 08:46 AM Revision 47a1f5ff (git): [ruby/bigdecimal] Define bool, true, and false for old Ruby
- https://github.com/ruby/bigdecimal/commit/a6d3bd2d44
- 08:46 AM Revision 29d012c9 (git): [ruby/bigdecimal] Alloc wrapper object before VpAlloc
- Calling TypedData_Wrap_Struct after VpAlloc may cause memory leak.
This commit reverts d11b78f9c420f39ee800b9feed4839cd28f4ff5c.
https://github.com/ruby/bigdecimal/commit/2c5a288caf - 08:46 AM Revision 13b520d5 (git): [ruby/bigdecimal] Refactor to extract VpCheckException
- https://github.com/ruby/bigdecimal/commit/6fd171308b
-
-
-
-
- Just forgotten in https://github.com/ruby/irb/commit/a5804c3560bb1de3ea8e40002635bff87f6a2825
https://github.com/ruby/irb/commit/e42e548793 -
- This is to prevent a yellow-mixed output for ActiveSupport::TimeWithZone.
Follows up https://github.com/ruby/irb/pull/159 and https://github.com/ruby/ruby/pull/3967.
https://github.com/ruby/irb/commit/a5804c3560bb1de3ea8e40002635bff87f... -
07:07 AM Revision 9b7ceb67 (git): irb: add more syntax errors colorizing support (#3967)
-
-
- https://github.com/ruby/irb/commit/7723ade899
-
- https://github.com/ruby/irb/commit/b4df0fd8b2
-
- https://github.com/ruby/irb/commit/dffcdb5269
-
06:56 AM Feature #17187: Add connect_timeout to TCPSocket
- @PhobosK
Many thanks for reporting the issue!
I merged your patch. -
- The patch is provided by PhobosK (Phobos Kappa).
This should be backported to Ruby 3.0.
[Feature #17187] -
- Seems commit:9e6e39c3512f7a962c44dc3729c98a0f8be90341 by bisect.
- 04:09 AM Revision f8555cad (git): * 2020-12-29 [ci skip]
- 03:56 AM Revision 512e0889 (git): [ruby/bigdecimal] Refactor to decompose VpNewVarArg into small functions
- https://github.com/ruby/bigdecimal/commit/7504871c48
-
-
- I've heard that similar error used to occur in earlier versions too,
and `sudo xcode-select -s /Library/Developer/CommandLineTools` may fix it. - 03:54 AM Revision d11b78f9 (git): [ruby/bigdecimal] Reduce needless object allocation in f_BigDecimal
- https://github.com/ruby/bigdecimal/commit/5c808eeabb
12/28/2020
-
- Thank you for confirming. I will close this as the issue appears to have already been fixed.
-
10:12 PM Bug #17487: rb_gc segfaults on ARM64 platforms
- I cannot reproduce with 2.6.6 or 2.7.2, using those the call to rb_gc doesn't cause a segfault.
-
- Both Ruby 2.0 and 2.3 are out of support. Can you reproduce this on Ruby 2.6, 2.7, or 3.0?
-
- I have a ruby native extension, and I see a segfault when calling rb_gc, so far I have seen this happening on arm64 platforms both rhel7 arm64 using ruby 2.0 and debian stretch arm64 using ruby 2.3
```
(gdb) bt
#0 0x0000ffffbe2251b... -
- (coming to this bug from https://bugs.ruby-lang.org/issues/17477)
I think it's fine to force `require` to be called only from the main thread/ractor, at least for now. I can imagine that would simplify a lot of things.
I'd like to ... -
- That sounds like a good way to fix it.
marcandre (Marc-Andre Lafortune) wrote in #note-3:
> the main thread could spin a private thread to do the needed `require`.
Whatever code is loaded by require can check `Thread.current`, so ... -
- I agree that it would be best to make require work everywhere, but always be executed in the main Reactor. That would just be part of the semantics of require (comment moved from #17477).
-
- I was able to boil it down to this script:
```ruby
require 'bundler/inline'
gemfile do
source 'https://rubygems.org'
gem "sinatra", "~> 2.1"
end
require 'sinatra'
class App < Sinatra::Base
get '/' do
200
en... -
- Bug requires more than 8 keys (as in the example)
-
- I didn't run a git bisect, but this was the case already in `ruby 3.0.0preview1`
-
08:52 PM Bug #17488 (Closed): Regression in Ruby 3: Hash#key? is non-deterministic when argument uses DelegateClass
- Upon upgrading a library to run on Ruby 3.0, I have observed that `Hash#key?` has non-deterministic behavior when the argument uses `DelegateClass`. This non-deterministic behavior was not present in Ruby 2.7.
Reproducing this is slig... -
- mame (Yusuke Endoh) wrote in #note-8:
> ktsj (Kazuki Tsujimoto) wrote in #note-7:
> ...
We also already have all theses issues/possibilities (including modifying local variables on the fly):
```ruby
var = 42
proc = ->(obj) { var =... -
- ktsj (Kazuki Tsujimoto) wrote in #note-7:
> If there were a obvious reason, I'd like to know that.
I can think of three reasons.
* (1) This feature makes an exhaustive check impossible (like a guard), which is not related to Ruby'... -
04:18 PM Feature #17411: Allow expressions in pattern matching
- I am basically positive.
(I've had the same idea. :) https://speakerdeck.com/k_tsj/pattern-matching-new-feature-in-ruby-2-dot-7?slide=64)
But I've been a little concerned most of languages which have pattern matching don't support su... -
- The following commit is causing builds in master and for the recently released Ruby 3.0.0 to fail on darwin. This was tested on macOS Mojave using the most recent XCode and Mojave patches. The error reported is as follows:
```
compil... -
- Your example:
```
def m(i)
$("foo#{i}")
end
```
**_would not_** work because it doesn't evaluate at parse-time to a constant value. It requires a runtime parameter ``i``, thus it can't evaluate to a constant value/object it c... -
- > Agree but... can a JIT optimize `Set["x","y","z"].include?(v)` so that the Set is only allocated once?
Absolutely it could - TruffleRuby will today already optimise `['x', 'y', 'z'].include?('y')` to be `true` and it doesn't allocat... -
04:48 PM Feature #17474: Interpreting constants at compile time
- Eregon (Benoit Daloze) wrote in #note-13:
> Doesn't `private_constant` (no arguments) work? (if not, sounds worth adding)
No it doesn't work; "warning: private_constant with no argument is just ignored"
Being able to set the default... -
- marcandre (Marc-Andre Lafortune) wrote in #note-9:
> Moreover, constants would ideally use `private_constant`, making the resulting code very verbose.
Doesn't `private_constant` (no arguments) work? (if not, sounds worth adding)
I... -
- Regarding "once" syntax, I've had an idea to use `BEGIN`.
```ruby
BEGIN {/#{1+2}/} #equivalent /#{1+2}/o
BEGIN {Set["x","y","z"]}.include?(v)
BEGIN {(10**6 ... 10**7)}.include?(range)
```
I haven't considere... -
- Some time ago I thought of basically the same idea, but in the end decided that constants were the appropriate way to handle this, so I didn't make it a proposal.
But the cases presented by Marc-Andre are remarkably compelling. It's ... -
04:42 PM Bug #15857: <=> の右辺が <=> を実装していない場合の振る舞い
- In doing a bit of maintenance work for the ruby-units gem this issue came up. I think there may be some additional methods that now need to be generated in the C code. See the following example.
```
c = Complex(1,0)
c <=> 1 # => 0
... -
02:53 PM Feature #17187: Add connect_timeout to TCPSocket
- You forgot to add the new parameter *connect_timeout* to the return statement of the function **socks_init** in sockssocket.c.
Thus the now available official sources of Ruby 3.0.0 cannot compile when sockets are enabled giving the erro... -
02:47 PM Feature #17479: Enable to get "--backtrace-limit" value by "$-B"
- I am making a library that makes error messages easier to read. Therefore, instead of using `Exception#full_message`, I need to analyze the Exception and output the error message myself.
For example, suppose I have a script like this:... -
- It works perfectly for me. Did you `gem install pry-byebug`?
-
01:41 PM Bug #17484 (Closed): pry & byebug gems not working properly with Ruby 3.0.0
- When I try to use pry with version 3, it won't allow me. For example when I type in the command next in the terminal, an error message says: "can't escape from eval with next". When using byebug's command step, version 3 I get an error ...
-
- Currently, `Time.at` and `Time.now` accept a timezone as a keyword argument, but not `Time.new`.
This means minor arguments cannot be omitted for `Time.new`.
```ruby
Time.new(2021, 1, 1, 0, 0, 0, "+09:00") #=> ok: 2021-01-01 00:00:0... -
- I thought about FileUtils too, but it's required lazily for these two methods.
So I think it might be fine to move only Pathname to core, and accept that `Pathname#{mkpath,rmtree}` `require`s `fileutils` when used.
I think having par... -
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> Isn't Pathname dependent on FileUtils though?
Yes. It uses only `FileUtils.mkpath` and `rm_r`. Rubygems also uses them, so @hsbt is preparing to propose making a very limited set of FileUt... -
- Agreed it should be in 2.7 (well, I've said since the beginning of this issue :D).
Right now, I consider `...` non-existing because it's almost never usable due to the restrictions in 2.7. - 12:26 PM Revision 06b44f81 (git): [ruby/bigdecimal] [Doc] Fix the document of BigDecimal()
- [ci-skip]
https://github.com/ruby/bigdecimal/commit/905d0345ec - 12:16 PM Revision 80d9e457 (git): [ruby/bigdecimal] Reduce conditional branch count in VpNewVarArg
- https://github.com/ruby/bigdecimal/commit/741fb3e00f
-
- naruse (Yui NARUSE) wrote in #note-11:
> I think it will not fast.
Before we start considering performance trade-offs,
do we even have a benchmark where time spent in HashWithIndifferentAccess is significant for a Rails app? -
11:24 AM Feature #17472: HashWithIndifferentAccess like Hash extension
- byroot (Jean Boussier) wrote in #note-10:
> > A feature to implement Rails's ActiveSupport::HashWithIndifferentAccess
> ...
I think it will not fast. -
11:22 AM Feature #17472: HashWithIndifferentAccess like Hash extension
- > A feature to implement Rails's ActiveSupport::HashWithIndifferentAccess
Would it be possible to have a "hook" akin to `convert_key`?
e.g. something like:
```
hash = {}
hash.coerce_key = ->(key) { key.is_a?(Symbol) ? key.name... -
- My intention is
* A feature to implement Rails's ActiveSupport::HashWithIndifferentAccess, not providing HashWithIndifferentAccess itself.
* the key of internal hash should be symbol though ActiveSupport::HashWithIndifferentAccess uses... -
-
-
- Dan0042 (Daniel DeLorme) wrote in #note-16:
> naruse (Yui NARUSE) wrote in #note-15:
> ...
Both `Timeout.timeout` and `deadline` is not the essential problem of this topic. The topic this ticket handles is "getaddrinfo is not interruptab... -
- https://github.com/ruby/drb/commit/61c49af71b
-
- https://github.com/ruby/pp/commit/272d4befeb
-
- https://github.com/ruby/pp/commit/e92228964b
-
- I wrote a similar opinion to Martin Dürst's in #17420. I propose that we comment there (simply because the issue is older and more general)
-
- My preference would be to make `require` work everywhere, but always be executed in the main Reactor. That would just be part of the semantics of `require`.
-
-
-
-
- In short, it is unavoidable.
Currently, an array is internally represented as consecutive memory area. Adding new elements into the middle of an array requires reallocation of the array, which takes O(n). Therefore, calling Array#inse...