Activity
From 09/05/2020 to 09/11/2020
09/11/2020
-
11:35 PM Revision 777d5367 (git): [ruby/reline] Support for word movement escape sequences in iTerm2
- https://github.com/ruby/reline/commit/187235f88c
-
- https://github.com/ruby/reline/commit/9c9ba0eff3
-
- https://github.com/ruby/reline/commit/9b932df544
-
- https://github.com/ruby/reline/commit/3e2f55c3e0
-
- When the cursor is at the end of the line and erases characters after the
cursor, some terminals delete the character at the cursor position.
https://github.com/ruby/reline/commit/e96ec97b02 -
- The nil means there is nothing in the buffer in some systems. Incidentally,
Errno::EIO is raised if the I/O is closed.
https://github.com/ruby/reline/commit/c698634e74 -
11:35 PM Revision a840ef85 (git): [ruby/reline] not clear scrollback buffer
- https://github.com/ruby/reline/commit/ba800f1461
-
- https://github.com/ruby/reline/commit/2c5ee54cb3
-
- https://github.com/ruby/reline/commit/2d32604c9e
- 11:31 PM Revision ae5d97ca (git): * 2020-09-12 [ci skip]
-
11:29 PM Revision 6042b743 (git): Promote time.rb to default gems
-
11:20 PM Bug #12780: BigDecimal#round returns different types depending on argument
- matz (Yukihiro Matsumoto) wrote in #note-9:
> `#round` with the argument less than 1 (`n < 1`) should return `Integer` value.
I've submitted a pull request that implements this: https://github.com/ruby/bigdecimal/pull/170
-
-
- This is still in issue in the master branch. The underlying problem is resolv does not remove the `[sender, message_id]` pair once a response has been received. I have submitted a pull request to fix this issue: https://github.com/ruby...
-
- I tried with `ruby 2.6.3p62 (2019-04-16 revision 67580) [i386-mingw32]` and `ruby 1.9.3p551 (2014-11-13) [i386-mingw32]` and was able to call a function without an argument:
```ruby
require 'Win32API'
getch = Win32API.new("C:\\Windo... -
- I've added a pull request to zlib to document this difference in #gets behavior: https://github.com/ruby/zlib/pull/18
-
- This is expected and documented behavior since https://github.com/ruby/openssl/commit/9435c8b3cab02a78375cb43e122e4cfc7eee79b9, where `key.group` returns a new group, and modifying that group does not affect the key.
-
- `sprintf` has been documented that the prefix is only added on non-zero since commit:67151cd7af01f97524f0a14cf5abd9567f856155 in 2008, so this isn't a bug, but a feature request. Adding the prefix even on zero seems more reasonable to m...
-
-
-
-
-
-
10:22 AM Feature #13719: [PATCH] net/http: allow existing socket arg for Net::HTTP.start
- Any news on this?
I was just trying to use the rest-client gem to connect to a unix domain socket, which isn't possible since the underlying net/http component does not accept unix domain URLs.
Since offering rest-apis on unix-dom... -
05:36 AM Feature #17140: Merge Enumerable#grep(_v) with Enumerable#select/reject
- I made `select` parts.
https://github.com/nobu/ruby/pull/new/feature/17140-enum_select -
05:34 AM Revision f0ddbd50 (git): Let String#slice! return nil (#3533)
- Returns `nil` instead of an empty string when non-integer number is given (to make it 2.7 compatible).
-
- Since 6f3e8df133c7785ff6bb6f18d1faec81fefb3999 in 2014.
-
02:02 AM Revision 406559a2 (git): Add missing break
- pointed out by Coverity Scan
-
-
09/10/2020
-
-
-
- This patch appears to change a general behavior of `require` even when extension libraries are not involved. For example, it changes the behavior of this code:
```ruby
Dir.mkdir('a')
Dir.mkdir('b')
File.write('a/c.rb', '$a = 1')
... -
09:34 PM Feature #16794: Rightward operators
- For symmetry, we also have `<<-` for heredocs "take this input for..."
It might make sense to think of `->>` as "give this output to..." -
08:02 PM Bug #17164 (Closed): Threads can ignore kill/interrupt/abort
- Threads can opt-out of requests to shut down the thread, including 'thr.kill' and the interrupt that happens when a main thread shuts down. When the interrupt happens, 'ensure' clauses will run in the thread's stack. If one of these clau...
-
-
- I tried updating this patch for the current master branch, but it breaks `test_reopen_inherit`:
```
1) Failure:
TestIO#test_reopen_inherit [/ruby/test/ruby/test_io.rb:2385]:
<"outerr"> expected but was
<"">.
```
@nobu, do yo... -
03:51 PM Bug #14015: Enumerable & Hash yielding arity
- Looks like this was resolved for `map` specifically in #13391 (https://github.com/ruby/ruby/commit/1f67a3900fbd45482ed36ad3b148b321307c1576)
Here are other steps to reveal the inconsistency:
```ruby
hash = { a: "my", b: "en" }
... - 03:49 PM Revision 440ab313 (git): * 2020-09-11 [ci skip]
-
03:48 PM Revision ef22af4d (git): If the GC runs before the Mutex's are initialised then we get a crash in pthread_mutex_lock.
- It is possible for GC to run during initialisation due to objects being allocated
-
01:52 PM Feature #16150: Add a way to request a frozen string from to_s
- Honestly now that `Symbol#name` is exposed, it's very easy to simply replace `to_s` with `Symbol.alias_method(:to_s, :name)`.
-
10:24 AM Feature #16150: Add a way to request a frozen string from to_s
- matz (Yukihiro Matsumoto) wrote in #note-68:
> I admit `Symbol#name` that returns a frozen string from a symbol. This can be a building block of the proposal.
> ...
For what it's worth, I agree with the above suggestion to try making a... -
- I opened a PR with a patch for this: https://github.com/ruby/ruby/pull/3530
-
-
-
-
-
09:44 AM Revision ea78960e (git): sync callable_method_entry()
- callable_method_entry() read/write method table structures so that
this function should be synchronized between Ractors. -
07:34 AM Feature #17140: Merge Enumerable#grep(_v) with Enumerable#select/reject
- Enhancing `select` and `reject` seems a good idea.
Matz.
09/09/2020
-
07:45 PM Revision 475c8701 (git): Make SecureRandom support Ractor
- SecureRandom lazily defines `get_random`. Accessing the mutex to define
the `get_random` method is not supported inside a Ractor. This commit
defines `gen_random` when `securerandom` is required and makes it
suppore Ractor (as well as ... -
- The two main optimization are:
- buffer writes for improved performance
- avoid formatting functions when possible
```
| |compare-ruby|built-ruby|
|:------------------|-----------:|---------:|
|dump_all_string ... -
- > The only complicating factor is json has a dependency on ostruct. JSON::GenericObject inherits from OpenStruct
It is of very questionable usefulness though, so it could probably be deprecated at the same time, or make lazy loaded an... -
03:39 PM Bug #15409: OpenStruct error when attribute is called 'method'
- jeremyevans0 (Jeremy Evans) wrote in #note-10:
> marcandre (Marc-Andre Lafortune) wrote in #note-9:
> ...
Thanks for the quick review 👍. I'll wait a few days and commit if there are no other comments.
> I would like to move ostruct... -
- Hanmac (Hans Mackowiak) wrote in #note-11:
> i have seen ruby making problems when using `method_missing` without `respond_to_missing` so it might cause problems there
The PR doesn't change `respond_to?`. The `respond_to_missing` wa... -
07:24 AM Bug #15409: OpenStruct error when attribute is called 'method'
- marcandre (Marc-Andre Lafortune) wrote in #note-9:
> I opened a PR that resolves this: https://github.com/ruby/ostruct/pull/15
> ...
i have seen ruby making problems when using `method_missing` without `respond_to_missing` so it might c... -
- marcandre (Marc-Andre Lafortune) wrote in #note-9:
> I opened a PR that resolves this: https://github.com/ruby/ostruct/pull/15
I reviewed the PR and the changes look good to me.
In regards to OpenStruct in general, I agree with @m... - 03:05 PM Revision 76c7146a (git): * 2020-09-10 [ci skip]
-
- This is useful to see what a block of code allocated, e.g.
```
GC.start
GC.disable
ObjectSpace.trace_object_allocations do
# run some code
end
gc_gen = GC.count
allocations = ObjectSpace.dump_all(output: :file, since: gc_gen)
GC.enabl... -
01:47 PM Revision 3590f082 (git): spec/ruby/core/file/utime_spec.rb: far future timestamp may be trancated
- Under some Ext4 filesystem settings, a timestamp is limited up to
0x37fffffff (2446-05-10).
https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps
> Therefore, timestamps should not overflow until May 2446.
Actually t... -
-
- Start with https://github.com/ruby/ruby/commit/fa21985a7a2f8f52a8bd82bd12a724e9dca74934
to https://github.com/ruby/ruby/commit/d7492a0be885ea9f2b9f71e3e95582f9a859c439 -
11:15 AM Revision 6997109f (git): [ruby/tempfile] Revert Tempfile.open unlinking the file
- Document difference in behavior between Tempfile.open and
Tempfile.create.
https://github.com/ruby/tempfile/commit/426d6f887f -
09:06 AM Bug #17162: Dir['**/*'] : stack smashing detected when listing big amount of directories
- Here's a repository with 2 scripts that might help debugging.
- one to create a lot of directories & sub-directories
- another to clear newly created directories
https://gitlab.com/kawsay/ruby-bug-17162
Sadly I haven't got a ... -
03:04 AM Feature #17163 (Open): Rename `begin`
- `Range#begin` is a getter method; it returns a value, and does not have a side effect, or does any calculation. Nevertheless, "begin" is a verb, so there is a mismatch. I would rather expect a noun.
It has a counterpart `Range#end`, a...
09/08/2020
-
- I opened a PR that resolves this: https://github.com/ruby/ostruct/pull/15
Note that using a field called `:method` has never worked with `OpenStruct` before; only private methods could be overridden.
The PR does a few things:
- re... -
09:41 PM Feature #17039: Remove Time#succ
- I gave it a try: https://github.com/ruby/ruby/pull/3525
-
-
- One possible approach to avoiding the stack smash is to limit the recursion allowed during directory globbing. Here's a simple approach that does that: https://github.com/jeremyevans/ruby/commit/29edc847b991bb59185b15c16988bc8004299c16
... -
- When I try to recursively list directories, the instructions returns an error "*** stack smashing detected ***" / "[BUG] Illegal instruction".
Error only happens when I try to list a big amount of directories.
Specificity:
* irb
... - 04:23 PM Revision 96f2b2e0 (git): * 2020-09-09 [ci skip]
-
04:22 PM Revision 65ab2385 (git): Use size_t for MJIT's max_ivar_index
- iseq_inline_iv_cache_entry's index is also size_t.
%"PRIuSIZE" seems to print warnings against st_index_t in some environments. -
-
-
10:56 AM Misc #17138: DevelopersMeeting20200925Japan
- * [Feature #14394] Class.descendants (fatkodima)
* Introduces `Module#descendants` method as a native way to track `Class`/`Module` descendants, instead of inefficient hack like crawling `ObjectSpace` or tracking descendants via `inher... -
03:35 AM Misc #17138: DevelopersMeeting20200925Japan
- * [Feature #17134] Add resolv_timeout to TCPSocket (glass)
* It introduces `resolve_timeout` similar to `Socket.tcp`. Can I merge it?
* After merging it, I will work on `connect_timeout` as well.
* [Feature #15628] init_inetsock_i... -
- Because macOS 11.0(Big Sur) was removed libc and libm from `/usr/lib`.
- 01:31 AM Revision 4530bea8 (git): * 2020-09-08 [ci skip]
-
- Pointed out by Coverity Scan
```
** CID 1466646: Control flow issues (MISSING_BREAK)
/ext/-test-/random/loop.c: 63 in loop_get_bytes()
```
09/07/2020
-
06:48 PM Bug #17160: Wrong exception backtrace
- I thought there will be some magic and yes, it is confusing, because I'd expect the `rescue` exception to be the rule. Also, if the `WebConsole::Evaluator#eval` was named differently, it would be probably more obvious. Appreciate your e...
-
- It is confusing, but I think there is nothing wrong. There are two points.
The first point is that the location for a method written in C is represented by its caller's location.
This is an example: `Integer#times` is implemented in... -
- Looking at web-console test results [1], there is following error reported:
~~~
WebConsole::EvaluatorTest#test_Evaluator_callers_are_cleaned_up_of_unneeded_backtraces [/home/travis/build/rails/web-console/test/web_console/evaluator_t... -
02:38 PM Bug #17161 (Closed): [BUG] object allocation during garbage collection phase
- Hi, I frequently get this error in development or production, at any time. I cannot find a sequence of actions to reproduce it, it just happens.
I have no knowledge to solve it, but I can help if you have questions.
Thanks a lot!
Fre... -
01:05 PM Bug #17152: Missing TracePoint return event for String#unpack
- This behavior is fixed(alredy backported).
ref: https://bugs.ruby-lang.org/issues/17149
ref: https://github.com/ruby/ruby/commit/3fef159f81fad6ffb9af5b60f4c8ec867fdb2391 -
12:13 PM Revision 27707617 (git): Run a TracePoint test in an insolated process
- to prevent a random failure like
http://ci.rvm.jp/results/trunk-random2@phosphorus-docker/3024287 - 12:07 PM Revision 2b5b9e12 (git): * 2020-09-07 [ci skip]
-
- A test worker process may already be enabling TracePoint, which results
in changing the insn name in this test.
http://ci.rvm.jp/results/trunk-random0@phosphorus-docker/3022750 -
- To enclose the initialization of Random::Base part.
-
- Added `WITH_REAL` versions to `RB_RANDOM_INTERFACE` macros. Also
these macros including "without real" versions no longer contain
the terminator (semicolon and comma). -
-
-
- * random.c: separate abstract rb_random_t and rb_random_mt_t for
Mersenne Twister implementation.
* include/ruby/random.h: the interface for extensions of Random
class.
* DLL imported symbol reference is not constant on Windows.
*... -
- * random.c (InitVM_Random): introduce abstract super class
Random::Base. -
10:02 AM Revision 19917d45 (git): .github: try GitHub Container Registry
- It is natural for a CI running on GitHub to use GitHub's facility.
See also https://github.blog/2020-09-01-introducing-github-container-registry/ -
- Yes, I mean most of case (2) can be replaced with `eval` and proposed changes.
-
- Just a comment. In general,
```ruby
i = 0
define_method("foo#{i}"){ i }
```
and
```ruby
i = 0
eval("def foo#{i} #{i}; end")
```
behave differently. The former returns the current value of `i` in the closure, the latter embed the val... -
- Ractor prohibits use of non-isolated `Proc`s.
Non-isolated example is here:
```ruby
s = "foo"
pr = Proc.new{ p s }
```
This Proc `pr` can not be shared among ractors because outer variable `s` can contain an unshareable objec... -
- Applied in changeset commit:git|0dbf6e46fb88a1c8c48ce5f67ac881a77de76526.
----------
[Feature #17157] removed -T command line option - 04:29 AM Revision 17a27060 (git): * 2020-09-07 [ci skip]
-
04:12 AM Feature #17148: stdbuf(1) support
- なるほど、そんなやり方が……。
それだと stdbuf の有無など環境の差異を気にしなくて良さそうですね。 -
01:41 AM Feature #17147: New method to get frozen strings from String objects
- Thank you for the beedbacks! I missed considering about `String#-@` method. It looks worth to try, so I'll evaluate that option on the workload of msgpack-ruby (and Fluentd possibly).
09/06/2020
-
07:29 PM Bug #17158 (Closed): Ractor Segfault when using shell and puts
- Here is my example repo:
https://github.com/schneems/ractor_shell_bug_reproduction
This is the commit of Ruby I'm using:
```shell
$ git log
commit de30450d91a8dda9dd415512ba5a1709704cae12 (HEAD -> master, origin/master, origin... -
-
- > Not also sure if String#-@ saves the OP’s situation, though
`String#-@` doesn't as it's too late (the string was allocated already). But exposing `rb_fstring()` would, at in some specific use cases it could drastically reduce alloca... -
- Hi, cfis (Charlie Savage) .
you expected `return` like this?
```
47435362097880:112480.769196 line # bug.rb: 5
47435362097880:112480.769280 c-call Integer#times bug.rb: 5
47435362097880:112480.769290 line # bu... -
- Warning says that it will be removed in Ruby 3.0.
```
% ruby -T1 -e ''
ruby: warning: ruby -T will be removed in Ruby 3.0
``` - 10:11 AM Revision b22b3f03 (git): Increase timeout for GitHub Actions.
-
-
- A backtrace object in an exception had never supported marshalling
correctly: `Marshal.load(Marshal.dump(exc)).backtrace_locations` dumped
core.
An Exception object has two hidden instance varibles for backtrace data:
one is "bt", which... - 03:37 AM Revision c12b2703 (git): Add `RB_` prefix for size_t to number conversion.
-
- ruby_2_7 dd4e51d84e01d9c60458dfe19a0b4d4e05b55140 merged revision(s) ff5e66034006a875125581114cce19d46843b32a.
-
- Added `NODE_SPECIAL_EXCESSIVE_COMMA` info to `ARGS` of
`RubyVM::AbstractSyntaxTree`. -
- ruby_2_7 3fef159f81fad6ffb9af5b60f4c8ec867fdb2391 merged revision(s) 3e02cd518fbe4d91c2aca7fbc3c5aafa387d3cb7.
-
- Trace :return of builtin methods
using opt_invokebuiltin_delegate_leave insn.
Since Ruby 2.7, :return of methods using builtin have not been traced properly. -
01:59 AM Feature #17156 (Open): Refinements per directory tree
- One of the main use case for refinements is to enable extensions to core classes for a given codebase (app or gem) without impacting the other codebases. Let's call it sandboxed monkey-patching. Note that you usually want this for an ent...
-
- ruby_2_7 e778de2c82478dda930cfc8d795ed4e0e60ea775 merged revision(s) 11963da9e8e98821860fbb0c0f2adc118860c814.
-
- I have just found that the similar testcase was added in https://bugs.ruby-lang.org/issues/16603 and backporting git|11963da9e8e98821860fbb0c0f2adc118860c814 fixes this issue.
-
- Okey, I will add a test for this case into master and backport it to ruby_2_7 with your patch.
Thanks. -
- ruby_2_7 e778de2c82478dda930cfc8d795ed4e0e60ea775 merged revision(s) 11963da9e8e98821860fbb0c0f2adc118860c814.
-
- Check type of empty keyword [Bug #16603]
Co-authored-by: Yusuke Endoh <mame@ruby-lang.org> -
- Austin Ziegler wrote on mailing list:
> If we don’t change the behaviour, could we at least modify the documentation for `Tempfile.open` to recommend most people use `Tempfile.create`, since I don’t think that I’ve ever used it and reac...
09/05/2020
- 07:58 PM Revision 40c06e6f (git): Fixed some typos in ractor.md (#3522)
-
- nagachika (Tomoyuki Chikanaga) wrote in #note-2:
> Hi Jeremy,
> ...
The program doesn't crash in master, so I assume the fix isn't needed in master. It's possible there is a better fix for 2.7 that fixes the problem at a higher level ... -
- Hi Jeremy,
The code around the patch you show is exactly same in master and ruby_2_7 branches.
Isn't the patch necessary for master branch? - 04:59 PM Revision dfefe0e0 (git): * 2020-09-06 [ci skip]
-
-
-
-
02:05 PM Feature #17155 (Open): Add a Diggable mixin
- Ruby 2.3 introduced the ```#dig``` method as a general way to access elements in deep structures. Initially it was implemented only for ```Array``` and ```Hash```. In the meanwhile also the classes ```Struct```, ```OpenStruct``` and ```S...
-
01:18 PM Misc #17154: Update Pathname Documentation to Clarify Expected Behavior
- Oh, and I would be happy to submit the necessary patches if this if a feature that will be accepted.
-
- I would like to suggest adding a sentence to the documentation for [Pathname](https://ruby-doc.org/stdlib-2.7.1/libdoc/pathname/rdoc/Pathname.html) to make clear the unusual behavior of `Pathname#+` when an absolute path is included in t...
-
- https://github.com/ruby/ruby/pull/3521
-
11:49 AM Feature #16461: Proc#using
- I think it would be good to get @headius' feedback on this.
I'd also like to take another detailed look (I won't be able before 14 September though). -
11:05 AM Feature #16461: Proc#using
- Disclaimer: I'm a big fan of refinements; they make Ruby more expressive (or chaotic 😉) and allow developers to be more creative.
shugo (Shugo Maeda) wrote in #note-5:
> I admit that the behavior is complex, but DSL users need not
>... -
- Thank you jeremy for your investigation.
I reverted the commit at 2c9dd060ab487a96e391793bd782cef6fd471b83 according to your recommendation. thanks! -
- ruby_2_7 2c9dd060ab487a96e391793bd782cef6fd471b83.
-
-
- [Backport #16771]
This reverts commit 0d24fb774d84d4a99454ce10fd343da00049a588. -
- 08:21 AM Revision 72757fb5 (git): Fix typo in ractor.md
-
06:31 AM Feature #16786: Light-weight scheduler for improved concurrency.
- Thanks @matz, I'll consider your feedback, and we can make some changes after the next PR is finished.
-
-
-
01:09 AM Feature #17153: Add Enumerable#compact_map
- Oops! I didn't notice that. Thank you for letting me know. Please close this.
sawa (Tsuyoshi Sawada) wrote in #note-1:
> Hi Ito-san,
> ...
-
- Hi Ito-san,
This is a duplicate of https://bugs.ruby-lang.org/issues/5663 and https://bugs.ruby-lang.org/issues/15323, and has been realized as `Enumerable#filter_map` since Ruby 2.7.0.
```ruby
[1, 2, 3, 4, 5].filter_map { |n| n * 10 i... -
- Beacause, if file can be separeted when number of cases implemented by builtin code in future, readability for code will be good.(I think so)
Currently, amount of code does not increase to much, but I thought it would be good to consi... -
- Why do they need to be separate files?
-
- Not also sure if String#-@ saves the OP’s situation, though. The method dedups string contents but has nothing to do with GC pressures.
Can you test if String#-@ works?