Activity
From 08/04/2020 to 08/10/2020
08/10/2020
-
11:51 PM Bug #16695: Stack consistency error when using the return value
- Maybe there are some potential issues.
```
$ ruby -v -e 'RubyVM::InstructionSequence.compile("def f; return 1 unless true or any; end", peephole_optimization: false).eval'
ruby 2.8.0dev (2020-08-02T03:05:19Z wanabe/master ac69849e49) ... -
11:44 PM Bug #17106 (Closed): Build ruby 2.6.6 from git source
-
01:29 PM Bug #17106: Build ruby 2.6.6 from git source
- mame (Yusuke Endoh) wrote in #note-1:
> Hi,
> ...
Thanks, i'll wait backport. -
07:47 PM Revision d43e99b7 (git): Add Method Documentation Guide (#3399)
- This documents how methods for core classes and classes in the
standard library should be documented.
Co-authored-by: Eric Hodel <drbrain@segment7.net> -
06:51 PM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
- > However in my view what defines a literal, is the use of a specific syntax, so ""
There is only one reason for freezing literals, to be able to intern them and reduce allocation. In fact the feature is poorly named, after the conseq... -
04:47 PM Feature #17016: Enumerable#accumulate
- nobu (Nobuyoshi Nakada) wrote in #note-30:
> I found a word [traject], means to transport, transmit, or transpose.
> ...
That's an interesting word that I don't know. It looks like it's archaic, so I don't think that it has much meanin... - 04:33 PM Revision 404bff56 (git): * 2020-08-11 [ci skip]
-
04:33 PM Revision c303e21d (git): Enhanced RDoc for Array (#3400)
- Methods:
drop
drop_while
any?
all?
none?
one? -
02:51 PM Bug #17110: String.tr unexpected behaviour with backslash
- Yusuke Endoh, thanks for clearing it up.
-
08:18 AM Bug #17110: String.tr unexpected behaviour with backslash
- ```
p "\\/".tr("/\\\\", "\\\\/") #=> "/\\"
```
Unfortunately it is complicated, but `\` is an escape character of string literal as well as an escape character of `String#tr` format, so it is unavoidable. -
- Is there no way to do change all backslashes to forward slashes and forward slashes to backslashes in the same tr command?
``` ruby
# Should result in "/\\" but instead results in "\\/" (unchanged)
"\\/".tr("\//","\\/")
```
-
- See the document.
> The backslash character `\` can be used to escape `^` or `-` and is otherwise ignored unless it appears at the end of a range or the end of the from_str or to_str:
https://docs.ruby-lang.org/en/2.7.0/String.html#met... -
- ``` ruby
"\\".tr("\\","A") works great, with "\\" becoming "A"
"\\".tr("\\C","AB") should also output "A" but instead outputs "\\"
```
-
- `"\\".tr("\\","A")` works great, with `"\\"` becoming `"A"`.
`"\\".tr("\\C","AB")` should also output `"A"`, but instead outputs `"\\"`. -
01:28 PM Feature #17109 (Rejected): Eliminate the performance impact of operands' order in array's | and &
-
- [set.rb](https://github.com/ruby/ruby/blob/master/lib/set.rb) has this optimization for `intersection` and IMHO `Set` should be used explicitly if you expect high-performance Set operations.
-
12:27 PM Feature #17109: Eliminate the performance impact of operands' order in array's | and &
- > > The order is preserved from the original array.
My bad, I missed the comment. In this case, I think the optimisation is not worth a change in the spec. -
- I like the idea very much, but very unfortunately, the document of `Array#&` says:
> The order is preserved from the original array.
https://docs.ruby-lang.org/en/2.7.0/Array.html#method-i-26
Personally I agree with you that thi... -
08:12 AM Feature #17109: Eliminate the performance impact of operands' order in array's | and &
- I mean these operations essentially perform Set union and intersection, am I correct? Then the order of the operands doesn't affect the outcome.
-
11:55 AM Bug #17112 (Closed): Resolv.getaddress fails with IPv6 link-local addresses
- I noticed that I cannot resolve any link-local IPv6 address using `Resolv.getaddress`. For example calling `Resolv.getaddress('fe80::eca4:7b00:ecc5:206c%8')` fails with `Resolv::ResolvError`
Resolving any IPv4 address succeedes, as well... -
10:46 AM Revision 0ca6b973 (git): Removed non-ASCII code to suppress warnings by localized compilers
-
- Encoding of C-sources can not be determined, and non-ASCII code
are often warned by localized compilers. -
- `key` is not used outside this assertion.
-
- Calls with a constant argument should be optimized away.
-
- From #7 actually the checks would be needed in both cases, because one could save the value of `Thread.current.local` and pass it to another `Thread`.
So either `.local` API seems fine to me, but if it's `Fiber.current.local` then `Fi... -
- One consideration: `Fiber.current` is not available until `require "fiber"`.
So an API based on `Fiber.current` doesn't seem nice while `require "fiber"` is needed (will be NoMethodError + confusion if not required).
I think it would... - 07:36 AM Revision 9260b0ae (git): * 2020-08-10 [ci skip]
-
-
-
04:09 AM Feature #17111 (Assigned): Improve performance of Net::HTTPHeader#set_form by 40%
- ## diff
```diff
diff --git a/lib/net/http/header.rb b/lib/net/http/header.rb
index a8901e7..3f1a008 100644
--- a/lib/net/http/header.rb
+++ b/lib/net/http/header.rb
@@ -475,9 +475,8 @@ def set_form(params, enctype='application/x-...
08/09/2020
-
10:51 PM Feature #17109: Eliminate the performance impact of operands' order in array's | and &
- `a & b` returns different result from `b & a`. `a | b` returns different result from `b | a`. You cannot substitute one with another.
Furthermore, your idea is implementation-dependent.
It does not make sense at all. -
- When I do intersection (`a & b`) or union (`a | b`), usually the array in one position is more likely longer than the one in the other position. I always try to remember in what order I should write `a` and` b` for the best performance. ...
-
- * [Bug #17105] A single `return` can return to two different places in a proc inside a lambda inside a method (eregon)
* Is current implementation correct? Should it not be a `LocalJumpError` if the surrounding lambda is no longer on ... -
08:19 AM Misc #17041: DevelopersMeeting20200831Japan
- * [Feature #13381] Expose rb_fstring and its family to C extensions
* It's only missing a decision on the names. Could this be discussed again? -
10:41 AM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
- +1 to @eregon ’s interpretation. Current behaviour is at least very cryptic.
-
10:02 AM Bug #17108: error: initialization of ‘long unsigned int’ from ‘void *’ makes integer from pointer without a cast
- tested with latest RUBY -> same warning=error
-
- It seems that the "OPTIMIZATION" macro for "rb_funcall" causes something bad.
```
|| CC rubymsgque_la-misc_ruby.lo
|| .../misc_ruby.c: In function ‘rubymsgque_OtCheckCallable’:
.../misc_ruby.c|430 col 18| error: initializat...
08/08/2020
-
11:11 PM Feature #8215 (Closed): Support accessing Fiber-locals and backtraces for a Fiber
- It looks like we can implement `Fiber#backtrace`:
https://bugs.ruby-lang.org/issues/16815
and in addition we should continue the discussion about Fiber locals:
https://bugs.ruby-lang.org/issues/13893 -
- Also discussed here:
https://bugs.ruby-lang.org/issues/8215 -
08:35 PM Bug #11628: Net::SMTPServerBusy is not behaving according to documentation
- Checkout this - https://www.smtpservers.co/blog/free-smtp-servers/
-
- @ioquatix Two reasons I've heard from projects using `RubyVM::AbstractSyntaxTree` are: built-in (not an extra dependency), and performance.
But "built-in (not an extra dependency)" also means only works on CRuby 2.6+, and some versions ... -
- I was using `RubyVM::AbstractSyntaxTree` but moved to `parser` gem. I cannot see any reason to use `RubyVM::AbstractSyntaxTree` unless you are concerned about some specific details of the current implementation's parser.
-
- The choice of characters used for quoting is irrelevant to such problem, which will not be solved unless the method name is represented escaped such as in string inspection form.
I do not think it is right to parse the error message. ... -
- See #13589
-
- In Ruby exception backtrace (and other places), the method name uses a quoting style of a backtick followed by a text/name followed by an apostrophy.
```
in `<main>'
```
The quoting style is not safe, as in, it cannot be relied u... -
01:29 AM Feature #16461 (Assigned): Proc#using
- shugo (Shugo Maeda) wrote in #note-5:
> > I think that could be a good rule, all `Proc#using` must happen `before Proc#call` for a given block.
> ...
Sorry for the delay.
I've fixed the CRuby implementation:
https://github.com/shug...
08/07/2020
- 05:08 PM Revision b4b702dd (git): * 2020-08-08 [ci skip]
-
-
-
- Right, every object cached at parse time must be deeply immutable, I would think that was an oversight.
-
06:12 AM Feature #15504: Freeze all Range objects
- I got an issue on Ractor.
```ruby
def test
(1..2)
end
r1 = test
Ractor.new do
r2 = test
end.take
```
* compiler cached Range `(1..2)` because they begin and end are frozen literals. The test method returns a cached same range obj... -
11:17 AM Bug #17013: `RubyVM::AbstractSyntaxTree.parse("struct.field += foo")` has no operator
- ruby_2_7 e9e4f8430a62f56a4e62dd728f4498ee4c300c12 merged revision(s) 8e189df32cacef4b21e357a590d349330532baf5.
-
- Add operator info to `OP_ASGN2` of `RubyVM::AbstractSyntaxTree`.
-
- Hi,
I think you are using bison that is newer than the latest version at Ruby 2.6 release.
I guess @nobu has already fixed the issue in ruby master, so we need to backport something. -
- Hello!
I tried to build ruby 2.6.6 from git source, but get an error.
My Dockerfile:
```
FROM archlinux:20200705
RUN pacman -Sy vim curl git ruby --noconfirm && \
pacman -S --needed base-devel libffi libyaml openssl zlib --... -
- - When NDEBUG is defined that shall be honoured.
- When RUBY_DEBUG is defined that shall be honoured.
- When both are defined and they conflict, warnings shall be rendered.
- When nothing is specified, nothing shall happen. -
- * Revert "mswin build - install src zlib files after checkout"
This reverts commit b6175c9e4fe25b978252d8998fe791d65d998fc5.
* Revert "mswin build - install src zlib files"
This reverts commit bf758ef8b4e2895bf71a611a7ab2a4f236e260ea. -
12:27 AM Feature #16495: Inconsistent quotes in error messages
- Some terminals don't highlight text inside different quotes (for example, Iterm2, Terminal on Mac).
So you're going to double-click, copy; but have to highlight text manually.
08/06/2020
-
- IMHO it should be a LocalJumpError. The Proc should return to the lambda, that's syntactically the closest scope it should return to.
Since it's not possible to return to it (the lambda is no longer on stack), it should be a LocalJumpError. -
07:09 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
- I think the behavior makes sense to some extent, because the proc is within 2 nested contexts. Since the proc is within the lambda context, calling it in the lambda returns from the lambda. And since the proc is _also_ within the method ...
-
02:43 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
- Hans I don't think anyone is debating the basic idea of what return in a proc or lambda does - I think we're talking about the edge-case for a proc in a return in the example above, which isn't explained by the text you have.
-
02:34 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
- i think this is by design:
https://www.rubyguides.com/2016/02/ruby-procs-and-lambdas/
> A lambda will return normally, like a regular method.
> ...
> Procs return from the current method, while lambdas return from the lambda itself. -
- I should also note some of these semantics might significantly harm the performance of Ruby.
CRuby seems to walk the stack on every `return`.
On others VMs there need to be some extra logic to find if the frame to return to is still on... -
- A single `return` in the source code might return to 2 different lexical places.
That seems wrong to me, as AFAIK all other control flow language constructs always jump to a single place.
```ruby
def m(call_proc)
r = -> {
# ... - 03:17 PM Revision 429efce4 (git): * 2020-08-07 [ci skip]
-
03:16 PM Revision fcdda2f8 (git): Add more debug info to test_verify
- http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3111684
-
- for example:
http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3111251
http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3109195 -
- > I'd argue "a#{2}c" is not a string literal ("a2c" is a string literal).
I understand your point of view. However in my view what defines a literal, is the use of a specific syntax, so `""` in this case.
Same for hashes or arrays,... -
- byroot (Jean Boussier) wrote in #note-8:
> Because I understand the consistency argument. "All string literals are frozen" is much easier to wrap your head around than "All string literals are frozen except the ones that are interpolated... -
- > If you want to get a mutable string from an interpolated literal +"_#{method1}_", 2 allocation will be done instead of 1
Maybe the parser could understand `+"#{}"` and avoid that second allocation? The same way it understand `"".fre... -
- +1
A while ago I opened ticket #16047 about the same thing.
Seems a lot of people don't like the current behavior so much. -
- * [Feature #17104] Do not freeze interpolated strings when using frozen-string-literal (eregon)
* It seems many people agree there is no point to freeze interpolated strings.
* Interpolated strings are not "simple literals" (just lik... -
- I've directly heard "not-yet-implemented" from @ko1. Sorry for noise.
-
- Question: What is "immutable"?
I've tried the following code, but the implementation raises a NameError "can not access non-sharable objects in constant A by non-main Ractors".
```
A = {}
A.freeze
Hash.freeze
Object.freeze
s... -
02:56 AM Feature #16513 (Closed): TracePoint#inspect to return "... file:line" instead of "...@file:line"
- Applied in changeset commit:git|1819652578e8f9fe3606f7a716ec4e427fc55f0a.
----------
[Feature #16513] TracePoint#inspect returns "... file:line" (#3391)
* Fix debug documents to match Thread#to_s change (Feature #16412 ticket)
* Trace... - 02:56 AM Revision 18196525 (git): [Feature #16513] TracePoint#inspect returns "... file:line" (#3391)
- * Fix debug documents to match Thread#to_s change (Feature #16412 ticket)
* TracePoint#inspect returns "... file:line" (Feature #16513)
* Guard older version of Ruby in Tracepoint inspection tests
* Focus on current thread only when r...
08/05/2020
- 11:36 PM Revision bbbec4b8 (git): Apply timeout-scale to test_thr_kill.
-
09:26 PM Feature #17104 (Open): Do not freeze interpolated strings when using frozen-string-literal
- We can treat this as a feature request. I changed it from Misc to Feature and modified the Subject to be the feature you are requesting as opposed to a question. The issue for the next developer meeting is at https://bugs.ruby-lang.org...
-
- Can't we just treat this as I feature request? The reasons are, it will reduce allocations, be more logical, less surprising and produce simpler code (when a mutable string is needed and you don't want extra allocations)
-
- FWIW I'd be +1 to make interpolated Strings non-frozen.
It's BTW still the behavior in TruffleRuby to this day, since it seems to cause no incompatibility and is convenient for writing the core library with Ruby code. -
- If you would like the behavior changed, you should file a feature request for it, and add it to the agenda of a future developer meeting.
-
- If you want to get a mutable string from an interpolated literal `+"_#{method1}_"`, 2 allocation will be done instead of 1, if it weren't pointlessly frozen.
In this case a feature designed to reduce allocations is producing more allo... -
- Other people have felt the same way, including me (see https://bugs.ruby-lang.org/issues/11473#note-7 and https://bugs.ruby-lang.org/issues/8976#note-67). However, @matz decided during the November 2015 developer meeting that they should...
-
- I think the point of frozen string literals is to avoid needless allocations. Interpolated strings are allocated each time, so freezing them appears pointless.
```rb
#frozen_string_literal: true
def foo(str)
"#{str}"
end
f... - 07:58 PM Revision 77cfd2e0 (git): * 2020-08-06 [ci skip]
-
- * Enhanced documentation for Array#repeated_combination
* Enhanced documentation for Array#repeated_combination -
- * Enhanced documentation for Array#repeated_permutation
* Enhanced documentation for Array#repeated_permutation -
-
- I created a patch for this ticket here: https://github.com/ruby/ruby/pull/3391.
-
08:01 AM Bug #17025: `Time#ceil` does not work like `Rational#ceil` or `Float#ceil`
- Thank you for fixing this Jeremy.
08/04/2020
-
- ko1 (Koichi Sasada) wrote in #note-5:
> BTW, there is some inconsistent by variable types:
I think that does not matter much, it's about consistency between what "state" of modules/classes can be accessed.
I do not mind much about class... -
- Eregon (Benoit Daloze) wrote in #note-2:
> * I think we need to introduce `#deep_freeze` to make it easy to create deeply-immutable objects conveniently and efficiently.
> ...
Do we need both? It seems an "optimised deep copy that ret... -
- Thank you for trying Ractor.
ibylich (Ilya Bylich) wrote in #note-4:
> 1. Multiple ractors use a single shared objectspace, right? If so, is it ok that objects can be shared using ObjectSpace? I'm talking about something like this:
... -
- Thank you for your question.
Eregon (Benoit Daloze) wrote in #note-2:
> * Reactor#recv/Channel#recv => Reactor#receive/Channel#receive. I don't think libc-like abbreviations should be used. Let's use actual words.
I want to ask Ma... - 11:05 PM Revision c8704328 (git): * 2020-08-05 [ci skip]
-
11:04 PM Revision 9db5d63e (git): [DOC] Use oracle url instead of sun url
- [ci skip]
-
07:57 PM Bug #14607: Fix use of the rb_profile_frames start parameter
- The original patch has a merge conflict. However, I have opened a pull request with the fix for this issue (https://github.com/ruby/ruby/pull/2713) that has been rebased to resolve the merge conflict.
-
03:36 PM Bug #17101: YAML.load_file: Massive slowdown under Ruby 2.7 vs. Ruby 2.4
- I run this program on Windows 10 64-bit. Very very slow: I wait more than 10 minutes, then I press Ctrl-Break. Now I install Ruby 2.6, then the program runs as fast as Ruby 2.4.
-
- I tried this benchmark in several ruby's(Ubuntu18.04 in WSL2. using `rbenv`).
```yaml
prelude: |
require 'yaml'
benchmark:
load_file: YAML.load_file('qlnv_h_h.yaml')
loop_count: 1
```
And, result.
```bash
sh@MyComputer:~/rubyde... -
- * [Feature #17103] Add a :since option to `ObjectSpace.dump_all` (byroot)
* On large heap, `dump_all` can take over a minute and generate huge (6+GiB) files.
* `since: 42`, means only objects matching `generation && generation >= 42`... -
- Patch: https://github.com/ruby/ruby/pull/3368
This is useful for seeing what a block of code allocated, e.g.
```ruby
GC.start
GC.disable
gc_gen = GC.count
ObjectSpace.trace_object_allocations do
# run some code
end
allocat... -
- I added a regression test using `assert_separately`.
-
- tenderlovemaking (Aaron Patterson) wrote in #note-16:
> I guess I need to read the Sequel implementation. It seems possible to design a system that is no overhead in the no-plugin case that also uses regular instance variables. In fac... -
- Matz said: "good to have, but current proposed syntax are not acceptable. If there is good syntax, I can consider to accept."
-
- FYI: [Type-profiler](https://github.com/mame/ruby-type-profiler), which I'm developing for an experimental type inference tool for Ruby 3 types, heavily depends upon `RubyVM::InstructionSequence` because it performs static analysis on M...
-
12:01 AM Revision e8edc34f (git): Remove unused struct member
- I accidentally added this in 35ba2783fe6b3316a6bbc6f00bf975ad7185d6e0,
and it's making the size of RVALUE be too big. I'm sorry! orz